From: Johannes Berg <johannes@sipsolutions.net>
To: Kieran Frewen <kieran.frewen@morsemicro.com>
Cc: linux-wireless@vger.kernel.org, quic_jjohnson@quicinc.com
Subject: Re: [PATCH v3 07/12] mac80211: S1G capabilities information element in probe request
Date: Tue, 06 Sep 2022 11:47:22 +0200 [thread overview]
Message-ID: <4184a31465de442c3f8a66f06aa4c59e77e4c237.camel@sipsolutions.net> (raw)
In-Reply-To: <20220906044812.7609-8-kieran.frewen@morsemicro.com>
Feels like somewhere in this patch you should consider the size of the
new element?
> /* channel management */
> bool ieee80211_chandef_ht_oper(const struct ieee80211_ht_operation *ht_oper,
> diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> index 53826c663723..78e8c286011e 100644
> --- a/net/mac80211/util.c
> +++ b/net/mac80211/util.c
> @@ -1857,6 +1857,12 @@ static int ieee80211_build_preq_ies_band(struct ieee80211_sub_if_data *sdata,
> rate_flags = ieee80211_chandef_rate_flags(chandef);
> shift = ieee80211_chandef_get_shift(chandef);
>
> + /* For direct mac80211 scan (probe request), add S1G IE and consider its override bits */
> + if (band == NL80211_BAND_S1GHZ) {
> + pos = ieee80211_ie_build_s1g_cap(pos, &sband->s1g_cap);
> + goto done;
> + }
>
Though off the top of my head I'm not really sure how it works for the
other bits.
johannes
next prev parent reply other threads:[~2022-09-06 9:47 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 4:48 [PATCH v3 00/12] Additional Support for 802.11ah (S1G) Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 01/12] cfg80211: regulatory: extend regulatory support for S1G Kieran Frewen
2022-09-06 9:36 ` Johannes Berg
2022-09-21 22:10 ` Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 02/12] mac80211: update TIM for S1G specification changes Kieran Frewen
2022-09-06 9:38 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 03/12] mac80211: S1G beacon/short beacon support Kieran Frewen
2022-09-06 9:40 ` Johannes Berg
2022-09-06 9:43 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 04/12] nl80211: support setting S1G short beacon period Kieran Frewen
2022-09-06 9:42 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 05/12] nl80211: support advertising S1G capabilities Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 06/12] mac80211: support ieee80211_ext format Kieran Frewen
2022-09-06 9:45 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 07/12] mac80211: S1G capabilities information element in probe request Kieran Frewen
2022-09-06 9:47 ` Johannes Berg [this message]
2022-09-06 4:48 ` [PATCH v3 08/12] cfg80211: S1G rate flags Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 09/12] nl80211: support advertising S1G rate information Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 10/12] mac80211: support S1G rate encoding Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 11/12] cfg80211: support for calculating S1G bitrates Kieran Frewen
2022-09-06 9:51 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 12/12] mac80211_hwsim: support for S1G rate information Kieran Frewen
2022-11-07 20:09 ` [PATCH v3 00/12] Additional Support for 802.11ah (S1G) Kieran Frewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4184a31465de442c3f8a66f06aa4c59e77e4c237.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kieran.frewen@morsemicro.com \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox