From: Johannes Berg <johannes@sipsolutions.net>
To: Kieran Frewen <kieran.frewen@morsemicro.com>
Cc: linux-wireless@vger.kernel.org, quic_jjohnson@quicinc.com
Subject: Re: [PATCH v3 04/12] nl80211: support setting S1G short beacon period
Date: Tue, 06 Sep 2022 11:42:32 +0200 [thread overview]
Message-ID: <df1eda8a2e788800f71e77af60d3ae899a6d3d5d.camel@sipsolutions.net> (raw)
In-Reply-To: <20220906044812.7609-5-kieran.frewen@morsemicro.com>
On Tue, 2022-09-06 at 16:48 +1200, Kieran Frewen wrote:
>
> @@ -805,6 +805,7 @@ static const struct nla_policy nl80211_policy[NUM_NL80211_ATTR] = {
> [NL80211_ATTR_MLD_ADDR] = NLA_POLICY_EXACT_LEN(ETH_ALEN),
> [NL80211_ATTR_MLO_SUPPORT] = { .type = NLA_FLAG },
> [NL80211_ATTR_MAX_NUM_AKM_SUITES] = { .type = NLA_REJECT },
> + [NL80211_ATTR_SHORT_BEACON_PERIOD] = { .type = NLA_U16 },
You probably want _some_ kind of range validation here, like "don't set
it to zero" at least?
> + if (info->attrs[NL80211_ATTR_SHORT_BEACON_PERIOD])
> + params->short_beacon_period =
> + nla_get_u32(info->attrs[NL80211_ATTR_SHORT_BEACON_PERIOD]);
>
And maybe it should be < the long beacon period?
Actually the mac80211 code makes it sound like what you really should
have is a "long beacon period" or something, so that every N beacons you
send a long one?
Or are these really completely independent? It feels like probably the
intention would be to have a (short) beacon period, and then every N
beacons you send a long one?
johannes
next prev parent reply other threads:[~2022-09-06 9:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 4:48 [PATCH v3 00/12] Additional Support for 802.11ah (S1G) Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 01/12] cfg80211: regulatory: extend regulatory support for S1G Kieran Frewen
2022-09-06 9:36 ` Johannes Berg
2022-09-21 22:10 ` Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 02/12] mac80211: update TIM for S1G specification changes Kieran Frewen
2022-09-06 9:38 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 03/12] mac80211: S1G beacon/short beacon support Kieran Frewen
2022-09-06 9:40 ` Johannes Berg
2022-09-06 9:43 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 04/12] nl80211: support setting S1G short beacon period Kieran Frewen
2022-09-06 9:42 ` Johannes Berg [this message]
2022-09-06 4:48 ` [PATCH v3 05/12] nl80211: support advertising S1G capabilities Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 06/12] mac80211: support ieee80211_ext format Kieran Frewen
2022-09-06 9:45 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 07/12] mac80211: S1G capabilities information element in probe request Kieran Frewen
2022-09-06 9:47 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 08/12] cfg80211: S1G rate flags Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 09/12] nl80211: support advertising S1G rate information Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 10/12] mac80211: support S1G rate encoding Kieran Frewen
2022-09-06 4:48 ` [PATCH v3 11/12] cfg80211: support for calculating S1G bitrates Kieran Frewen
2022-09-06 9:51 ` Johannes Berg
2022-09-06 4:48 ` [PATCH v3 12/12] mac80211_hwsim: support for S1G rate information Kieran Frewen
2022-11-07 20:09 ` [PATCH v3 00/12] Additional Support for 802.11ah (S1G) Kieran Frewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df1eda8a2e788800f71e77af60d3ae899a6d3d5d.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=kieran.frewen@morsemicro.com \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox