* [PATCH 2/2] wil6210: add HW write-back option in TX descriptor
@ 2013-06-20 12:45 Kirshenbaum Erez
2013-06-20 14:00 ` Vladimir Kondratiev
0 siblings, 1 reply; 3+ messages in thread
From: Kirshenbaum Erez @ 2013-06-20 12:45 UTC (permalink / raw)
To: qca_vkondrat; +Cc: linux-wireless, Kirshenbaum Erez
Map BIT 9 in TX DMA DWARD 0 as HW write back option.
We must turn on this option in the last TX descriptor,
this is required for old HW compatability.
This option indicate to HW that WB is required for this descriptor.
Signed-off-by: Kirshenbaum Erez <erezk@wilocity.com>
---
drivers/net/wireless/ath/wil6210/txrx.c | 2 +-
drivers/net/wireless/ath/wil6210/txrx.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
index b79ba10..c3e763c 100644
--- a/drivers/net/wireless/ath/wil6210/txrx.c
+++ b/drivers/net/wireless/ath/wil6210/txrx.c
@@ -709,7 +709,7 @@ static int wil_tx_vring(struct wil6210_priv *wil, struct vring *vring,
}
/* for the last seg only */
d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_CMD_EOP_POS);
- d->dma.d0 |= BIT(9); /* BUG: undocumented bit */
+ d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_CMD_MARK_WB_POS);
d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_CMD_DMA_IT_POS);
*_d = *d;
diff --git a/drivers/net/wireless/ath/wil6210/txrx.h b/drivers/net/wireless/ath/wil6210/txrx.h
index 23c0781..859aea6 100644
--- a/drivers/net/wireless/ath/wil6210/txrx.h
+++ b/drivers/net/wireless/ath/wil6210/txrx.h
@@ -201,6 +201,10 @@ struct vring_tx_mac {
#define DMA_CFG_DESC_TX_0_CMD_EOP_LEN 1
#define DMA_CFG_DESC_TX_0_CMD_EOP_MSK 0x100
+#define DMA_CFG_DESC_TX_0_CMD_MARK_WB_POS 9
+#define DMA_CFG_DESC_TX_0_CMD_MARK_WB_LEN 1
+#define DMA_CFG_DESC_TX_0_CMD_MARK_WB_MSK 0x200
+
#define DMA_CFG_DESC_TX_0_CMD_DMA_IT_POS 10
#define DMA_CFG_DESC_TX_0_CMD_DMA_IT_LEN 1
#define DMA_CFG_DESC_TX_0_CMD_DMA_IT_MSK 0x400
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2] wil6210: add HW write-back option in TX descriptor
2013-06-20 12:45 [PATCH 2/2] wil6210: add HW write-back option in TX descriptor Kirshenbaum Erez
@ 2013-06-20 14:00 ` Vladimir Kondratiev
0 siblings, 0 replies; 3+ messages in thread
From: Vladimir Kondratiev @ 2013-06-20 14:00 UTC (permalink / raw)
To: Kirshenbaum Erez; +Cc: linux-wireless
On Thursday, June 20, 2013 03:45:40 PM Kirshenbaum Erez wrote:
> Map BIT 9 in TX DMA DWARD 0 as HW write back option.
> We must turn on this option in the last TX descriptor,
> this is required for old HW compatability.
> This option indicate to HW that WB is required for this descriptor.
>
> Signed-off-by: Kirshenbaum Erez <erezk@wilocity.com>
Here is my
Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
Thanks for this.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] wil6210: add HW write-back option in TX descriptor
2013-06-23 9:59 [PATCH 0/2] wil6210: Tx path improvements Vladimir Kondratiev
@ 2013-06-23 9:59 ` Vladimir Kondratiev
0 siblings, 0 replies; 3+ messages in thread
From: Vladimir Kondratiev @ 2013-06-23 9:59 UTC (permalink / raw)
To: John W . Linville
Cc: Kirshenbaum Erez, Johannes Berg, linux-wireless,
Luis R . Rodriguez, Vladimir Kondratiev, Jouni Malinen
From: Kirshenbaum Erez <erezk@wilocity.com>
Map BIT 9 in TX DMA DWARD 0 as HW write back option.
We must turn on this option in the last TX descriptor,
this is required for old HW compatability.
This option indicate to HW that WB is required for this descriptor.
Signed-off-by: Kirshenbaum Erez <erezk@wilocity.com>
Signed-off-by: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
---
drivers/net/wireless/ath/wil6210/txrx.c | 2 +-
drivers/net/wireless/ath/wil6210/txrx.h | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wil6210/txrx.c b/drivers/net/wireless/ath/wil6210/txrx.c
index 73d6c2d..d240b24 100644
--- a/drivers/net/wireless/ath/wil6210/txrx.c
+++ b/drivers/net/wireless/ath/wil6210/txrx.c
@@ -708,7 +708,7 @@ static int wil_tx_vring(struct wil6210_priv *wil, struct vring *vring,
}
/* for the last seg only */
d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_CMD_EOP_POS);
- d->dma.d0 |= BIT(9); /* BUG: undocumented bit */
+ d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_CMD_MARK_WB_POS);
d->dma.d0 |= BIT(DMA_CFG_DESC_TX_0_CMD_DMA_IT_POS);
*_d = *d;
diff --git a/drivers/net/wireless/ath/wil6210/txrx.h b/drivers/net/wireless/ath/wil6210/txrx.h
index 23c0781..859aea6 100644
--- a/drivers/net/wireless/ath/wil6210/txrx.h
+++ b/drivers/net/wireless/ath/wil6210/txrx.h
@@ -201,6 +201,10 @@ struct vring_tx_mac {
#define DMA_CFG_DESC_TX_0_CMD_EOP_LEN 1
#define DMA_CFG_DESC_TX_0_CMD_EOP_MSK 0x100
+#define DMA_CFG_DESC_TX_0_CMD_MARK_WB_POS 9
+#define DMA_CFG_DESC_TX_0_CMD_MARK_WB_LEN 1
+#define DMA_CFG_DESC_TX_0_CMD_MARK_WB_MSK 0x200
+
#define DMA_CFG_DESC_TX_0_CMD_DMA_IT_POS 10
#define DMA_CFG_DESC_TX_0_CMD_DMA_IT_LEN 1
#define DMA_CFG_DESC_TX_0_CMD_DMA_IT_MSK 0x400
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-23 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-20 12:45 [PATCH 2/2] wil6210: add HW write-back option in TX descriptor Kirshenbaum Erez
2013-06-20 14:00 ` Vladimir Kondratiev
-- strict thread matches above, loose matches on Subject: below --
2013-06-23 9:59 [PATCH 0/2] wil6210: Tx path improvements Vladimir Kondratiev
2013-06-23 9:59 ` [PATCH 2/2] wil6210: add HW write-back option in TX descriptor Vladimir Kondratiev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox