From: Johannes Berg <johannes@sipsolutions.net>
To: Pablo Martin-Gomez <pmartin-gomez@freebox.fr>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH 1/7] wifi: nl80211: remove EHT IE size validation
Date: Fri, 10 Apr 2026 22:25:20 +0200 [thread overview]
Message-ID: <4573490cc064212381ff88dcc9d891c77e7a94eb.camel@sipsolutions.net> (raw)
In-Reply-To: <20260410190354.394742-2-pmartin-gomez@freebox.fr> (sfid-20260410_210401_795150_2EF97458)
On Fri, 2026-04-10 at 21:03 +0200, Pablo Martin-Gomez wrote:
> Remove ieee802_eht_capa_size_ok() calls from the middle of nl80211
> packet processing paths. There is no reason why EHT Capabilities elem
> size should be checked here while HE & UHR are not.
That's not right: NL80211_ATTR_HE_CAPABILITY and
NL80211_ATTR_UHR_CAPABILITY have policy validation functions. It's just
that NL80211_ATTR_EHT_CAPABILITY doesn't, because it cannot, because it
depends on the HE capability (validating EHT requires access to HE data,
and policy validation functions can't do that.)
johannes
next prev parent reply other threads:[~2026-04-10 20:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-10 19:03 [RFC PATCH 0/7] Do not read band-dependent reserved bits Pablo Martin-Gomez
2026-04-10 19:03 ` [RFC PATCH 1/7] wifi: nl80211: remove EHT IE size validation Pablo Martin-Gomez
2026-04-10 20:25 ` Johannes Berg [this message]
2026-04-10 19:03 ` [RFC PATCH 2/7] wifi: make EHT capa size check not read reserved bits Pablo Martin-Gomez
2026-04-10 20:35 ` Johannes Berg
2026-04-10 19:03 ` [RFC PATCH 3/7] wifi: make HE " Pablo Martin-Gomez
2026-04-10 19:03 ` [RFC PATCH 4/7] wifi: do not read band-dependent " Pablo Martin-Gomez
2026-04-10 19:03 ` [RFC PATCH 5/7] wifi: ath11k: " Pablo Martin-Gomez
2026-04-10 19:03 ` [RFC PATCH 6/7] wifi: ath12k: " Pablo Martin-Gomez
2026-04-10 19:03 ` [RFC PATCH 7/7] wifi: mt76: " Pablo Martin-Gomez
2026-04-15 22:38 ` [RFC PATCH 0/7] Do " Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4573490cc064212381ff88dcc9d891c77e7a94eb.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pmartin-gomez@freebox.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox