Re: [RFC PATCH 0/7] Do not read band-dependent reserved bits

[Jeff Johnson <jeff.johnson@oss.qualcomm.com>]

On 4/10/2026 12:03 PM, Pablo Martin-Gomez wrote:
> This series is a recyclying and extension of a previous attempt [1] to 
> not read reserved bits depending on the current band for HE/EHT STAs.
> 
> Convention (section 9.2.2 of 802.11-2024) states that reserved bits
> should be set to 0 (unless stated otherwise) and not to be read. Some
> STAs do not respect the convention in transmission and the kernel do not
> respect the convention in reception. The practical effect can be a
> really low throughtput between a MT7927 Windows STA and a ath12k Linux AP.
> 
> I've been quite drastic and added a check of the current band before
> read a bit that might be reserved whatever it's from an IE that was
> received or an IE will be sent. I also removed checks where they didn't
> make much sense and the current band was complicated/impossible to
> retrieve. That is why I'm positing this as a RFC.
> 
> [1]: https://lore.kernel.org/linux-wireless/20250120114551.1542812-1-pmartin-gomez@freebox.fr/
> 
> 
> Pablo Martin-Gomez (7):
>   wifi: nl80211: remove EHT IE size validation
>   wifi: make EHT capa size check not read reserved bits
>   wifi: make HE capa size check not read reserved bits
>   wifi: do not read band-dependent reserved bits
>   wifi: ath11k: do not read band-dependent reserved bits
>   wifi: ath12k: do not read band-dependent reserved bits
>   wifi: mt76: do not read band-dependent reserved bits
> 
>  drivers/net/wireless/ath/ath11k/mac.c         | 11 +--
>  drivers/net/wireless/ath/ath12k/mac.c         | 35 +++++----
>  .../net/wireless/mediatek/mt76/mt7996/mcu.c   | 16 ++--
>  include/linux/ieee80211-eht.h                 | 58 +++++++++------
>  include/linux/ieee80211-he.h                  | 21 +++---
>  net/mac80211/debugfs_sta.c                    |  7 +-
>  net/mac80211/eht.c                            |  3 +-
>  net/mac80211/he.c                             | 73 ++++++++++---------
>  net/mac80211/mlme.c                           |  7 +-
>  net/mac80211/util.c                           | 12 +--
>  net/mac80211/vht.c                            |  2 +-
>  net/wireless/nl80211.c                        | 31 +++-----
>  12 files changed, 149 insertions(+), 127 deletions(-)
> 

Please use scripts/get_maintainer.pl to identify all necessary recipients for
your patches. Or start using 'b4' which does all the work for you. You are
modifying drivers without including the per-driver mailing lists and maintainers.

/jeff