Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Jiri Slaby <jirislaby@gmail.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-wireless@vger.kernel.org
Subject: Re: Ath5k panic fix
Date: Mon, 03 Sep 2007 20:55:09 +0200	[thread overview]
Message-ID: <46DC588D.40305@gmail.com> (raw)
In-Reply-To: <m3ejhfvbp3.fsf@maximus.localdomain>

Krzysztof Halasa napsal(a):
> Ath5k panics on ath_open() because sc->pdev is never set, fixed.
> 
> Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>

Acked-by: Jiri Slaby <jirislaby@gmail.com>

I wonder how it is possible that the driver works here.

> --- a/drivers/net/wireless/ath5k_base.c
> +++ b/drivers/net/wireless/ath5k_base.c
> @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
>  	hw->max_rssi = 127; /* FIXME: get a real value for this. */
>  	sc = hw->priv;
>  	sc->hw = hw;
> +	sc->pdev = pdev;
>  
>  	/*
>  	 * Mark the device as detached to avoid processing
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

thanks,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz

       reply	other threads:[~2007-09-03 18:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <m3ejhfvbp3.fsf@maximus.localdomain>
2007-09-03 18:55 ` Jiri Slaby [this message]
2007-09-03 20:53   ` Ath5k panic fix Nick Kossifidis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46DC588D.40305@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=khc@pm.waw.pl \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox