Re: Ath5k panic fix

Re: Ath5k panic fix

[Jiri Slaby]

Krzysztof Halasa napsal(a):
> Ath5k panics on ath_open() because sc->pdev is never set, fixed.
> 
> Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>

Acked-by: Jiri Slaby <jirislaby@gmail.com>

I wonder how it is possible that the driver works here.

> --- a/drivers/net/wireless/ath5k_base.c
> +++ b/drivers/net/wireless/ath5k_base.c
> @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
>  	hw->max_rssi = 127; /* FIXME: get a real value for this. */
>  	sc = hw->priv;
>  	sc->hw = hw;
> +	sc->pdev = pdev;
>  
>  	/*
>  	 * Mark the device as detached to avoid processing
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

thanks,
-- 
http://www.fi.muni.cz/~xslaby/            Jiri Slaby
faculty of informatics, masaryk university, brno, cz

Re: Ath5k panic fix

[Nick Kossifidis]

2007/9/3, Jiri Slaby <jirislaby@gmail.com>:
> Krzysztof Halasa napsal(a):
> > Ath5k panics on ath_open() because sc->pdev is never set, fixed.
> >
> > Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
>
> Acked-by: Jiri Slaby <jirislaby@gmail.com>
>
> I wonder how it is possible that the driver works here.
>
> > --- a/drivers/net/wireless/ath5k_base.c
> > +++ b/drivers/net/wireless/ath5k_base.c
> > @@ -2295,6 +2295,7 @@ static int __devinit ath_pci_probe(struct pci_dev *pdev,
> >       hw->max_rssi = 127; /* FIXME: get a real value for this. */
> >       sc = hw->priv;
> >       sc->hw = hw;
> > +     sc->pdev = pdev;
> >
> >       /*
> >        * Mark the device as detached to avoid processing
> > -
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/
> >
>
> thanks,

I've already fixed this on r2698 ;-)
http://madwifi.org/changeset/2698

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick