From: Johannes Berg <johannes@sipsolutions.net>
To: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>,
ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org,
Ganesh Kariganuru Mahabalesh <quic_gkarigan@quicinc.com>
Subject: Re: [PATCH wireless-next] wifi: mac80211: Report parent AP BSS parameters for AP_VLAN
Date: Fri, 04 Sep 2026 12:38:10 +0200 [thread overview]
Message-ID: <47c4ba195ae49552538ea65f4f13de7d3dced266.camel@sipsolutions.net> (raw)
In-Reply-To: <20260820052426.3177309-1-aaradhana.sahu@oss.qualcomm.com>
On Thu, 2026-08-20 at 10:54 +0530, Aaradhana Sahu wrote:
>
> +struct ieee80211_bss_conf *
> +ieee80211_get_sdata_bss_conf(struct ieee80211_sub_if_data *sdata, int link_id)
not sure I think this function is all that useful, but
> +{
> + struct ieee80211_sub_if_data *bss_sdata = sdata;
> +
> + lockdep_assert_wiphy(sdata->local->hw.wiphy);
> +
> + if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
> + if (!sdata->bss)
> + return NULL;
> +
> + bss_sdata = get_bss_sdata(sdata);
> + }
at the very least that part is pointless, and should just be a
get_bss_sdata() call?
or are you saying you somehow found a VLAN existing with sdata->bss
being NULL?
johannes
next prev parent reply other threads:[~2026-09-04 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-20 5:24 [PATCH wireless-next] wifi: mac80211: Report parent AP BSS parameters for AP_VLAN Aaradhana Sahu
2026-09-04 10:38 ` Johannes Berg [this message]
2026-09-07 4:59 ` Aaradhana Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47c4ba195ae49552538ea65f4f13de7d3dced266.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=aaradhana.sahu@oss.qualcomm.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_gkarigan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox