Re: [PATCH wireless-next] wifi: mac80211: Report parent AP BSS parameters for AP_VLAN

[Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>]

On 9/4/2026 4:08 PM, Johannes Berg wrote:
> On Thu, 2026-08-20 at 10:54 +0530, Aaradhana Sahu wrote:
>>
>> +struct ieee80211_bss_conf *
>> +ieee80211_get_sdata_bss_conf(struct ieee80211_sub_if_data *sdata, int link_id)
> 
> not sure I think this function is all that useful, but
> 

Thanks for the review. Since both sta_set_link_sinfo() and sta_set_sinfo() use this helper,
I introduced it to avoid duplicating the BSS configuration lookup logic in both callers.
I can remove it if you prefer.

>> +{
>> +	struct ieee80211_sub_if_data *bss_sdata = sdata;
>> +
>> +	lockdep_assert_wiphy(sdata->local->hw.wiphy);
>> +
>> +	if (sdata->vif.type == NL80211_IFTYPE_AP_VLAN) {
>> +		if (!sdata->bss)
>> +			return NULL;
>> +
>> +		bss_sdata = get_bss_sdata(sdata);
>> +	}
> 
> at the very least that part is pointless, and should just be a
> get_bss_sdata() call?
> 
> or are you saying you somehow found a VLAN existing with sdata->bss
> being NULL?
> 
> johannes

Yes, you are right. The sdata->bss NULL check is unnecessary here.
I will remove it and send the next version.