From: Johannes Berg <johannes@sipsolutions.net>
To: Lachlan Hodges <lachlan.hodges@morsemicro.com>
Cc: linux-wireless@vger.kernel.org, arien.judge@morsemicro.com
Subject: Re: [PATCH wireless-next v2] wifi: cfg80211: init S1G properly when creating chandef
Date: Wed, 11 Mar 2026 12:07:26 +0100 [thread overview]
Message-ID: <493973048da8c2c0b80a33abb98540acb4e6c200.camel@sipsolutions.net> (raw)
In-Reply-To: <b725c0be05df1a9595c177aada4cc148bf555448.camel@sipsolutions.net>
On Wed, 2026-03-11 at 11:56 +0100, Johannes Berg wrote:
>
> +++ b/net/wireless/chan.c
> @@ -29,9 +29,10 @@ void cfg80211_chandef_create(struct cfg80211_chan_def *chandef,
>
> *chandef = (struct cfg80211_chan_def) {
> .chan = chan,
> - .freq1_offset = chan->freq_offset,
> };
>
> + WARN_ON(chan->band == NL80211_BAND_S1GHZ);
>
Hm, no, I guess that really should only allow 2.4, 5 and 6 GHz.
johannes
next prev parent reply other threads:[~2026-03-11 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 6:43 [PATCH wireless-next v2] wifi: cfg80211: init S1G properly when creating chandef Lachlan Hodges
2026-03-11 9:55 ` Johannes Berg
2026-03-11 10:21 ` Lachlan Hodges
2026-03-11 10:56 ` Johannes Berg
2026-03-11 11:07 ` Johannes Berg [this message]
2026-03-11 11:48 ` Lachlan Hodges
2026-03-11 11:55 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=493973048da8c2c0b80a33abb98540acb4e6c200.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arien.judge@morsemicro.com \
--cc=lachlan.hodges@morsemicro.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox