Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Lachlan Hodges <lachlan.hodges@morsemicro.com>
Cc: linux-wireless@vger.kernel.org, arien.judge@morsemicro.com
Subject: Re: [PATCH wireless-next v2] wifi: cfg80211: init S1G properly when creating chandef
Date: Wed, 11 Mar 2026 10:55:46 +0100	[thread overview]
Message-ID: <791eaf8ab04dcbe01e2d71612d162f71c61e573a.camel@sipsolutions.net> (raw)
In-Reply-To: <20260311064339.524758-1-lachlan.hodges@morsemicro.com> (sfid-20260311_074401_065972_89BA6CE0)

On Wed, 2026-03-11 at 17:43 +1100, Lachlan Hodges wrote:
> When creating a chandef, the initial width is determined by the
> chan_type argument leading to a default width of 20/20_NOHT/40 which
> does not make sense for S1G channels. Fix this by ensuring we default
> S1G chandefs to a width of 1MHz.
> 
> Signed-off-by: Lachlan Hodges <lachlan.hodges@morsemicro.com>
> ---
> v1 -> v2:
> 
> - Remove the mac80211-based wording in the commit message and keep it
>   simple.

Thanks :)

Now with more tea and all that, do we really want it to completely
ignore the width? Should that be documented? Almost feels like it should
WARN if you use it wrong, with an S1G channel but a regular width, and
mac80211 should be fixed?

johannes

  reply	other threads:[~2026-03-11  9:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-11  6:43 [PATCH wireless-next v2] wifi: cfg80211: init S1G properly when creating chandef Lachlan Hodges
2026-03-11  9:55 ` Johannes Berg [this message]
2026-03-11 10:21   ` Lachlan Hodges
2026-03-11 10:56     ` Johannes Berg
2026-03-11 11:07       ` Johannes Berg
2026-03-11 11:48       ` Lachlan Hodges
2026-03-11 11:55         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=791eaf8ab04dcbe01e2d71612d162f71c61e573a.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arien.judge@morsemicro.com \
    --cc=lachlan.hodges@morsemicro.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox