* [PATCH] mac80211: Fix probe request filtering in IBSS mode
@ 2010-02-04 21:34 Benoit Papillault
2010-02-04 23:54 ` Luis R. Rodriguez
0 siblings, 1 reply; 5+ messages in thread
From: Benoit Papillault @ 2010-02-04 21:34 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Benoit Papillault
We only reply to probe request if either the requested SSID is the
broadcast SSID or if the requested SSID matches our own SSID. This
latter case was not properly handled since we were replying to different
SSID with the same length as our own SSID.
Signed-off-by: Benoit Papillault <benoit.papillault@free.fr>
---
net/mac80211/ibss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index 86bd2a0..e905c45 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -714,7 +714,7 @@ static void ieee80211_rx_mgmt_probe_req(struct ieee80211_sub_if_data *sdata,
}
if (pos[1] != 0 &&
(pos[1] != ifibss->ssid_len ||
- !memcmp(pos + 2, ifibss->ssid, ifibss->ssid_len))) {
+ memcmp(pos + 2, ifibss->ssid, ifibss->ssid_len))) {
/* Ignore ProbeReq for foreign SSID */
return;
}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mac80211: Fix probe request filtering in IBSS mode
2010-02-04 21:34 [PATCH] mac80211: Fix probe request filtering in IBSS mode Benoit Papillault
@ 2010-02-04 23:54 ` Luis R. Rodriguez
2010-02-05 0:11 ` Benoit PAPILLAULT
0 siblings, 1 reply; 5+ messages in thread
From: Luis R. Rodriguez @ 2010-02-04 23:54 UTC (permalink / raw)
To: Benoit Papillault; +Cc: johannes, linux-wireless
On Thu, Feb 4, 2010 at 1:34 PM, Benoit Papillault
<benoit.papillault@free.fr> wrote:
> We only reply to probe request if either the requested SSID is the
> broadcast SSID or if the requested SSID matches our own SSID. This
> latter case was not properly handled since we were replying to different
> SSID with the same length as our own SSID.
>
> Signed-off-by: Benoit Papillault <benoit.papillault@free.fr>
Cc: stable@kernel.org it seems?
Luis
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mac80211: Fix probe request filtering in IBSS mode
2010-02-04 23:54 ` Luis R. Rodriguez
@ 2010-02-05 0:11 ` Benoit PAPILLAULT
2010-02-05 0:13 ` Luis R. Rodriguez
0 siblings, 1 reply; 5+ messages in thread
From: Benoit PAPILLAULT @ 2010-02-05 0:11 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: johannes, linux-wireless
Luis R. Rodriguez a écrit :
> On Thu, Feb 4, 2010 at 1:34 PM, Benoit Papillault
> <benoit.papillault@free.fr> wrote:
>
>> We only reply to probe request if either the requested SSID is the
>> broadcast SSID or if the requested SSID matches our own SSID. This
>> latter case was not properly handled since we were replying to different
>> SSID with the same length as our own SSID.
>>
>> Signed-off-by: Benoit Papillault <benoit.papillault@free.fr>
>>
>
> Cc: stable@kernel.org it seems?
>
> Luis
>
Indeed! Do I need to resend?
Benoit
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mac80211: Fix probe request filtering in IBSS mode
2010-02-05 0:11 ` Benoit PAPILLAULT
@ 2010-02-05 0:13 ` Luis R. Rodriguez
0 siblings, 0 replies; 5+ messages in thread
From: Luis R. Rodriguez @ 2010-02-05 0:13 UTC (permalink / raw)
To: Benoit PAPILLAULT; +Cc: johannes, linux-wireless
On Thu, Feb 4, 2010 at 4:11 PM, Benoit PAPILLAULT
<benoit.papillault@free.fr> wrote:
> Luis R. Rodriguez a écrit :
>>
>> On Thu, Feb 4, 2010 at 1:34 PM, Benoit Papillault
>> <benoit.papillault@free.fr> wrote:
>>
>>>
>>> We only reply to probe request if either the requested SSID is the
>>> broadcast SSID or if the requested SSID matches our own SSID. This
>>> latter case was not properly handled since we were replying to different
>>> SSID with the same length as our own SSID.
>>>
>>> Signed-off-by: Benoit Papillault <benoit.papillault@free.fr>
>>>
>>
>> Cc: stable@kernel.org it seems?
>>
>> Luis
>>
>
> Indeed! Do I need to resend?
Its easy to resend so just go ahead.
Luis
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] mac80211: Fix probe request filtering in IBSS mode
@ 2010-02-05 0:21 Benoit Papillault
0 siblings, 0 replies; 5+ messages in thread
From: Benoit Papillault @ 2010-02-05 0:21 UTC (permalink / raw)
To: johannes; +Cc: linux-wireless, Benoit Papillault, stable
We only reply to probe request if either the requested SSID is the
broadcast SSID or if the requested SSID matches our own SSID. This
latter case was not properly handled since we were replying to different
SSID with the same length as our own SSID.
Signed-off-by: Benoit Papillault <benoit.papillault@free.fr>
Cc: stable@kernel.org
---
net/mac80211/ibss.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index 86bd2a0..e905c45 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -714,7 +714,7 @@ static void ieee80211_rx_mgmt_probe_req(struct ieee80211_sub_if_data *sdata,
}
if (pos[1] != 0 &&
(pos[1] != ifibss->ssid_len ||
- !memcmp(pos + 2, ifibss->ssid, ifibss->ssid_len))) {
+ memcmp(pos + 2, ifibss->ssid, ifibss->ssid_len))) {
/* Ignore ProbeReq for foreign SSID */
return;
}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-02-05 0:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-04 21:34 [PATCH] mac80211: Fix probe request filtering in IBSS mode Benoit Papillault
2010-02-04 23:54 ` Luis R. Rodriguez
2010-02-05 0:11 ` Benoit PAPILLAULT
2010-02-05 0:13 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2010-02-05 0:21 Benoit Papillault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox