* [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode
@ 2010-06-19 13:29 Larry Finger
2010-06-19 14:01 ` Michael Büsch
0 siblings, 1 reply; 2+ messages in thread
From: Larry Finger @ 2010-06-19 13:29 UTC (permalink / raw)
To: John W Linville, Michael Buesch; +Cc: b43-dev, linux-wireless
The message following fatal DMA errors fails to indicate properly that the
driver has switched to PIO mode.
Signed-off-by: Larry Finger <Larry.Finger@wfinger.net>
---
Index: wireless-testing/drivers/net/wireless/b43/main.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/main.c
+++ wireless-testing/drivers/net/wireless/b43/main.c
@@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
dma_reason[2], dma_reason[3],
dma_reason[4], dma_reason[5]);
b43err(dev->wl, "This device does not support DMA "
- "on your system. Please use PIO instead.\n");
+ "on your system. It will now be switched to PIO.\n");
/* Fall back to PIO transfers if we get fatal DMA errors! */
dev->use_pio = 1;
b43_controller_restart(dev, "DMA error");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode
2010-06-19 13:29 [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode Larry Finger
@ 2010-06-19 14:01 ` Michael Büsch
0 siblings, 0 replies; 2+ messages in thread
From: Michael Büsch @ 2010-06-19 14:01 UTC (permalink / raw)
To: Larry Finger; +Cc: John W Linville, b43-dev, linux-wireless
On 06/19/2010 03:29 PM, Larry Finger wrote:
> The message following fatal DMA errors fails to indicate properly that the
> driver has switched to PIO mode.
>
> Signed-off-by: Larry Finger<Larry.Finger@wfinger.net>
> ---
>
> Index: wireless-testing/drivers/net/wireless/b43/main.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/b43/main.c
> +++ wireless-testing/drivers/net/wireless/b43/main.c
> @@ -1804,7 +1804,7 @@ static void b43_do_interrupt_thread(stru
> dma_reason[2], dma_reason[3],
> dma_reason[4], dma_reason[5]);
> b43err(dev->wl, "This device does not support DMA "
> - "on your system. Please use PIO instead.\n");
> + "on your system. It will now be switched to PIO.\n");
> /* Fall back to PIO transfers if we get fatal DMA errors! */
> dev->use_pio = 1;
> b43_controller_restart(dev, "DMA error");
>
Ack.
But what's the current status of the debugging of the PCI-core code
w.r.t DMA?
--
Greetings Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-06-19 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-19 13:29 [PATCH] b43: Clarify logged message after fatal DMA error and switch to PIO mode Larry Finger
2010-06-19 14:01 ` Michael Büsch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox