From: Johannes Berg <johannes@sipsolutions.net>
To: Suraj P Kizhakkethil <suraj.kizhakkethil@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org,
Sriram R <quic_srirrama@quicinc.com>,
Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
Subject: Re: [PATCH wireless-next 2/2] wifi: mac80211: set addr2/addr3 to link address for NULL packets to non-MLO stations
Date: Thu, 08 Jan 2026 13:20:52 +0100 [thread overview]
Message-ID: <557aea3a06c79c2d2e04649e43b48e0733d26347.camel@sipsolutions.net> (raw)
In-Reply-To: <20251127140555.472327-3-suraj.kizhakkethil@oss.qualcomm.com>
On Thu, 2025-11-27 at 19:35 +0530, Suraj P Kizhakkethil wrote:
>
> - if (ieee80211_vif_is_mld(&sdata->vif))
> - info->control.flags |= IEEE80211_TX_CTRL_MLO_LINK_UNSPEC;
> + if (ieee80211_vif_is_mld(&sdata->vif)) {
> + if (sta->sta.mlo)
> + info->control.flags |=
> + IEEE80211_TX_CTRL_MLO_LINK_UNSPEC;
> + else
> + info->control.flags |=
> + u32_encode_bits(link_id,
> + IEEE80211_TX_CTRL_MLO_LINK);
> + }
This whole conditional logic is now pretty messy, and we (and the
compiler, for warnings) have to track that link_id is actually
initialized on all paths, which seems unlikely to always go right ...
I think you should set link_id = IEEE80211_LINK_UNSPECIFIED or the link
according to the logic earlier, and then just always u32_encode_bits()
unconditionally.
next prev parent reply other threads:[~2026-01-08 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 14:05 [PATCH wireless-next 0/2] wifi: mac80211: Fix issues related to sending NULL packets to probe stations Suraj P Kizhakkethil
2025-11-27 14:05 ` [PATCH wireless-next 1/2] wifi: mac80211: set band information for NULL packets only for non-MLO stations Suraj P Kizhakkethil
2026-01-08 12:19 ` Johannes Berg
2026-02-14 7:36 ` Suraj P Kizhakkethil
2025-11-27 14:05 ` [PATCH wireless-next 2/2] wifi: mac80211: set addr2/addr3 to link address for NULL packets to " Suraj P Kizhakkethil
2026-01-08 12:20 ` Johannes Berg [this message]
2026-02-14 7:37 ` Suraj P Kizhakkethil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557aea3a06c79c2d2e04649e43b48e0733d26347.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_srirrama@quicinc.com \
--cc=rameshkumar.sundaram@oss.qualcomm.com \
--cc=suraj.kizhakkethil@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox