From: Suraj P Kizhakkethil <suraj.kizhakkethil@oss.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless-next 1/2] wifi: mac80211: set band information for NULL packets only for non-MLO stations
Date: Sat, 14 Feb 2026 13:06:10 +0530 [thread overview]
Message-ID: <92638760-553a-47cf-8d7e-e020c82c35fd@oss.qualcomm.com> (raw)
In-Reply-To: <67b8cc599e923433eec6c8baff72583c47a53cfd.camel@sipsolutions.net>
On 08-Jan-26 5:49 PM, Johannes Berg wrote:
> Technically "AP MLD" ;)
Sure, Johannes. I have updated and sent out the next version.
>
> But I was more wondering about the use of "MLD connections", which seems
> odd to me (vs. "MLO connections")? Connections between MLDs? MLD is an
> entity, MLO is the mode of operation?
>
>> + if (ieee80211_vif_is_mld(&sdata->vif))
>> + info->control.flags |= IEEE80211_TX_CTRL_MLO_LINK_UNSPEC;
> I don't see why it should be set conditionally, it should be ignored
> anyway by non-MLO drivers? Or maybe if you'd want it zero for t hose
> then do that explicitly?
>
> I'm really commenting here because it gets messy in the next patch, see
> also there.
>
> johannes
Thanks for the reply, Johannes. I have made the changes and sent out the
next version. Sorry for the delayed response.
next prev parent reply other threads:[~2026-02-14 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 14:05 [PATCH wireless-next 0/2] wifi: mac80211: Fix issues related to sending NULL packets to probe stations Suraj P Kizhakkethil
2025-11-27 14:05 ` [PATCH wireless-next 1/2] wifi: mac80211: set band information for NULL packets only for non-MLO stations Suraj P Kizhakkethil
2026-01-08 12:19 ` Johannes Berg
2026-02-14 7:36 ` Suraj P Kizhakkethil [this message]
2025-11-27 14:05 ` [PATCH wireless-next 2/2] wifi: mac80211: set addr2/addr3 to link address for NULL packets to " Suraj P Kizhakkethil
2026-01-08 12:20 ` Johannes Berg
2026-02-14 7:37 ` Suraj P Kizhakkethil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92638760-553a-47cf-8d7e-e020c82c35fd@oss.qualcomm.com \
--to=suraj.kizhakkethil@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox