[BISECTED] brcmfmac issue since 4.3.0-rc3

[BISECTED] brcmfmac issue since 4.3.0-rc3

[Carlo Caione]

Hi Hante,
I'm having an issue with my BCM43340 SDIO WiFi card on the Asus X205TA
laptop and the latest firmware taken from the linux-firmware git repo
with the correct nvram file in place. I bisected the issue back to
commit 2b76acd "brcmfmac: Rework p2p attach, use single method for p2p
dev creation." (bad commit).

The problem is not always reproducible. I'd say it happens once every
ten reboots. What I see is that the kernel panics at boot immediately
after I see:

brcmfmac: brcmf_sdio_drivestrengthinit: No SDIO Drive strength init
done for chip 43340 rev 2 pmurev 20
brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
brcmfmac: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52
brcmfmac: brcmf_bus_start: failed: -52
brcmfmac: brcmf_sdio_firmware_callback: dongle is not responding
brcmfmac: brcmf_sdio_dpc: failed backplane access over SDIO, halting operation
brcmfmac: brcmf_sdio_dpc: failed backplane access over SDIO, halting operation

With a messy trace similar to
https://gist.github.com/carlocaione/06d17124a2589f3d4108

Any idea what's going on?

Thanks

-- 
Carlo Caione

Re: [BISECTED] brcmfmac issue since 4.3.0-rc3

[Arend van Spriel]

On 24-12-15 18:23, Carlo Caione wrote:
> Hi Hante,
> I'm having an issue with my BCM43340 SDIO WiFi card on the Asus X205TA
> laptop and the latest firmware taken from the linux-firmware git repo
> with the correct nvram file in place. I bisected the issue back to
> commit 2b76acd "brcmfmac: Rework p2p attach, use single method for p2p
> dev creation." (bad commit).
> 
> The problem is not always reproducible. I'd say it happens once every
> ten reboots. What I see is that the kernel panics at boot immediately
> after I see:
> 
> brcmfmac: brcmf_sdio_drivestrengthinit: No SDIO Drive strength init
> done for chip 43340 rev 2 pmurev 20
> brcmfmac: brcmf_sdio_bus_rxctl: resumed on timeout
> brcmfmac: brcmf_c_preinit_dcmds: Retreiving cur_etheraddr failed, -52
> brcmfmac: brcmf_bus_start: failed: -52
> brcmfmac: brcmf_sdio_firmware_callback: dongle is not responding
> brcmfmac: brcmf_sdio_dpc: failed backplane access over SDIO, halting operation
> brcmfmac: brcmf_sdio_dpc: failed backplane access over SDIO, halting operation

Hi Carlo,

This smells like a firmware crash. Upon the brcmf_bus_start failure we
bail out on the probe. I suspect in the error path there is an issue
introduced (or exposed) by the mentioned patch. Did not look further
into it as the family is giving me the angry look during the holidays ;-)

Regards,
Arend

> With a messy trace similar to
> https://gist.github.com/carlocaione/06d17124a2589f3d4108
> 
> Any idea what's going on?
> 
> Thanks
> 

Re: [BISECTED] brcmfmac issue since 4.3.0-rc3

[Carlo Caione]

On Fri, Dec 25, 2015 at 10:54 AM, Arend van Spriel <aspriel@gmail.com> wrote:
> Hi Carlo,
>
> This smells like a firmware crash. Upon the brcmf_bus_start failure we
> bail out on the probe. I suspect in the error path there is an issue
> introduced (or exposed) by the mentioned patch. Did not look further
> into it as the family is giving me the angry look during the holidays ;-)

Hi Arend,
Thank you for the quick reply, this can definitely wait ;-)
Happy holidays and happy new year!

-- 
Carlo Caione

RE: [BISECTED] brcmfmac issue since 4.3.0-rc3

[Hante Meuleman]

SGkgQ2FybG8NCg0KVGhlIGV4cGVjdGlvbiB3YXMgbGlrZWx5IGZpeGVkIHdpdGggYSBwYXRjaCB3
aXRoIHRoZSB0aXRsZToNCg0KYnJjbWZtYWM6IEZpeCBkb3VibGUgZnJlZSBvbiBleGNlcHRpb24g
YXQgbW9kdWxlIGxvYWQuDQoNClRoZSBjaGFuZ2UgeW91IGZvdW5kIHdoaWNoIGlzIGNhdXNpbmcg
YSBjcmFzaCBjYXVzZWQgYSBkb3VibGUgZnJlZS4gDQoNCkl0IHdvbid0IGZpeCB0aGUgZmlybXdh
cmUgY3Jhc2gsIGJ1dCBpdCB3aWxsIGZpeCB0aGUgc3lzdGVtIGNyYXNoIG9uIGZhaWx1cmUuDQoN
ClJlZ2FyZHMsDQpIYW50ZQ0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogY2Fy
bG8uY2Fpb25lQGdtYWlsLmNvbSBbbWFpbHRvOmNhcmxvLmNhaW9uZUBnbWFpbC5jb21dIE9uIEJl
aGFsZiBPZiBDYXJsbyBDYWlvbmUNClNlbnQ6IEZyaWRheSwgRGVjZW1iZXIgMjUsIDIwMTUgMTE6
MTYgQU0NClRvOiBBcmVuZCB2YW4gU3ByaWVsDQpDYzogQ2FybG8gQ2Fpb25lOyBIYW50ZSBNZXVs
ZW1hbjsgQXJlbmQgVmFuIFNwcmllbDsga3ZhbG9AY29kZWF1cm9yYS5vcmc7IGxpbnV4LXdpcmVs
ZXNzQHZnZXIua2VybmVsLm9yZw0KU3ViamVjdDogUmU6IFtCSVNFQ1RFRF0gYnJjbWZtYWMgaXNz
dWUgc2luY2UgNC4zLjAtcmMzDQoNCk9uIEZyaSwgRGVjIDI1LCAyMDE1IGF0IDEwOjU0IEFNLCBB
cmVuZCB2YW4gU3ByaWVsIDxhc3ByaWVsQGdtYWlsLmNvbT4gd3JvdGU6DQo+IEhpIENhcmxvLA0K
Pg0KPiBUaGlzIHNtZWxscyBsaWtlIGEgZmlybXdhcmUgY3Jhc2guIFVwb24gdGhlIGJyY21mX2J1
c19zdGFydCBmYWlsdXJlIHdlDQo+IGJhaWwgb3V0IG9uIHRoZSBwcm9iZS4gSSBzdXNwZWN0IGlu
IHRoZSBlcnJvciBwYXRoIHRoZXJlIGlzIGFuIGlzc3VlDQo+IGludHJvZHVjZWQgKG9yIGV4cG9z
ZWQpIGJ5IHRoZSBtZW50aW9uZWQgcGF0Y2guIERpZCBub3QgbG9vayBmdXJ0aGVyDQo+IGludG8g
aXQgYXMgdGhlIGZhbWlseSBpcyBnaXZpbmcgbWUgdGhlIGFuZ3J5IGxvb2sgZHVyaW5nIHRoZSBo
b2xpZGF5cyA7LSkNCg0KSGkgQXJlbmQsDQpUaGFuayB5b3UgZm9yIHRoZSBxdWljayByZXBseSwg
dGhpcyBjYW4gZGVmaW5pdGVseSB3YWl0IDstKQ0KSGFwcHkgaG9saWRheXMgYW5kIGhhcHB5IG5l
dyB5ZWFyIQ0KDQotLSANCkNhcmxvIENhaW9uZQ0KDQo=