From: Sebastian Gottschall <s.gottschall@dd-wrt.com>
To: bpothuno@qti.qualcomm.com, ath10k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable
Date: Wed, 29 Nov 2017 03:57:31 +0100 [thread overview]
Message-ID: <5ec76365-7ca2-15bd-0bcc-9cc19b9f3b27@dd-wrt.com> (raw)
In-Reply-To: <1511863650-9419-1-git-send-email-bpothuno@qti.qualcomm.com>
did you notice that Marvell 88W8964 based clients will crash 10.4-3.5.3
firmwares? (tested with 9984 and 10.4-3.5.3-00038)
client device was a linksys wrt3200acm running dd-wrt for testing
Am 28.11.2017 um 11:07 schrieb bpothuno@qti.qualcomm.com:
> From: Balaji Pothunoori <bpothuno@qti.qualcomm.com>
>
> Data packets are not sent by STA in case of STA joined to
> non QOS AP (WMM disabled AP). This is happening because of STA
> is sending data packets to firmware from host with qos enabled
> along with non qos queue value(TID = 16).
> Due to qos enabled, firmware is discarding the packet.
>
> This patch fixes this issue by updating the qos based on station
> WME capability field if WMM is disabled in AP.
>
> This patch is required by 10.4 family chipsets like
> QCA4019/QCA9888/QCA9884/QCA99X0.
> Firmware Versoin : 10.4-3.5.1-00018.
>
> For 10.2.4 family chipsets QCA988X/QCA9887 and QCA6174 this patch
> has no effect.
>
> Signed-off-by: Balaji Pothunoori <bpothuno@qti.qualcomm.com>
> ---
> drivers/net/wireless/ath/ath10k/mac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
> index 0a947ee..2616b99 100644
> --- a/drivers/net/wireless/ath/ath10k/mac.c
> +++ b/drivers/net/wireless/ath/ath10k/mac.c
> @@ -2563,7 +2563,7 @@ static void ath10k_peer_assoc_h_qos(struct ath10k *ar,
> }
> break;
> case WMI_VDEV_TYPE_STA:
> - if (vif->bss_conf.qos)
> + if (sta->wme)
> arg->peer_flags |= arvif->ar->wmi.peer_flags->qos;
> break;
> case WMI_VDEV_TYPE_IBSS:
--
Mit freundlichen Grüssen / Regards
Sebastian Gottschall / CTO
NewMedia-NET GmbH - DD-WRT
Firmensitz: Stubenwaldallee 21a, 64625 Bensheim
Registergericht: Amtsgericht Darmstadt, HRB 25473
Geschäftsführer: Peter Steinhäuser, Christian Scheele
http://www.dd-wrt.com
email: s.gottschall@dd-wrt.com
Tel.: +496251-582650 / Fax: +496251-5826565
next prev parent reply other threads:[~2017-11-29 2:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 10:07 [PATCH] ath10k: handling qos at STA side based on AP WMM enable/disable bpothuno
2017-11-29 2:57 ` Sebastian Gottschall [this message]
2017-11-29 6:58 ` Balaji Pothunoori
2017-11-29 8:33 ` Sebastian Gottschall
2017-11-29 10:12 ` Balaji Pothunoori
2017-11-29 13:38 ` Sebastian Gottschall
2017-11-30 5:24 ` Balaji Pothunoori
2017-12-14 15:19 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ec76365-7ca2-15bd-0bcc-9cc19b9f3b27@dd-wrt.com \
--to=s.gottschall@dd-wrt.com \
--cc=ath10k@lists.infradead.org \
--cc=bpothuno@qti.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox