* [PATCH v2] iwlwifi: dvm: add missing cleaup for on error path
@ 2026-04-01 3:05 Haoxiang Li
2026-04-02 6:10 ` Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Haoxiang Li @ 2026-04-01 3:05 UTC (permalink / raw)
To: miriam.rachel.korenblit, johannes.berg
Cc: linux-wireless, linux-kernel, Haoxiang Li
In iwlagn_tx_agg_start(), call iwlagn_dealloc_agg_txq()
to clear bit on error path.
Signed-off-by: Haoxiang Li <lihaoxiang@isrc.iscas.ac.cn>
---
Changes in v2:
- remove an unnecessary error handling. Thanks, Miriam!
---
drivers/net/wireless/intel/iwlwifi/dvm/tx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
index a7806776a51e..1a0167f67c7b 100644
--- a/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
+++ b/drivers/net/wireless/intel/iwlwifi/dvm/tx.c
@@ -604,8 +604,10 @@ int iwlagn_tx_agg_start(struct iwl_priv *priv, struct ieee80211_vif *vif,
}
ret = iwl_sta_tx_modify_enable_tid(priv, sta_id, tid);
- if (ret)
+ if (ret) {
+ iwlagn_dealloc_agg_txq(priv, txq_id);
return ret;
+ }
spin_lock_bh(&priv->sta_lock);
tid_data = &priv->tid_data[sta_id][tid];
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-07 10:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-01 3:05 [PATCH v2] iwlwifi: dvm: add missing cleaup for on error path Haoxiang Li
2026-04-02 6:10 ` Markus Elfring
2026-04-07 10:50 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox