From: Kavita Kavita <kavita.kavita@oss.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless-next 3/3] wifi: mac80211_hwsim: Advertise support for IEEE 802.1X authentication protocol
Date: Thu, 26 Feb 2026 22:28:47 +0530 [thread overview]
Message-ID: <67e9955a-1287-4467-9b52-be89144effbc@oss.qualcomm.com> (raw)
In-Reply-To: <916b0969c559f1faeba94bdef792da646b9b0c21.camel@sipsolutions.net>
On 2/26/2026 10:20 PM, Johannes Berg wrote:
> On Thu, 2026-02-26 at 22:19 +0530, Kavita Kavita wrote:
>>
>> Sorry, I missed one case earlier. EPPKE mandates (Re)Association frame
>> encryption support, so we should only advertise EPPKE when the driver indicates
>> support for (Re)Association frame encryption in mac80211.
>
> Oh, OK, but we could also check that in mac80211, in register_hw(), I
> think?
For EPPKE, I will handle it like this:
@@ -1598,6 +1598,15 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
local->sband_allocated |= BIT(band);
}
+ /*
+ * mac80211 supports EPPKE, if the driver supports (Re)Association
+ * frame encryption
+ */
+ if (wiphy_ext_feature_isset(local->hw.wiphy,
+ NL80211_EXT_FEATURE_ASSOC_FRAME_ENCRYPTION))
+ wiphy_ext_feature_set(local->hw.wiphy,
+ NL80211_EXT_FEATURE_EPPKE);
For IEEE 802.1X Authentication, I am thinking to advertise its support directly
from mac80211, in ieee80211_alloc_hw_nm, without checking for (Re)Association encryption
support from the driver.
>
>
> johannes
next prev parent reply other threads:[~2026-02-26 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 6:54 [PATCH wireless-next 0/3] wifi: cfg80211/mac80211: Add support for IEEE 802.1X Authentication Protocol Kavita Kavita
2026-02-26 6:54 ` [PATCH wireless-next 1/3] wifi: cfg80211: add " Kavita Kavita
2026-02-26 6:54 ` [PATCH wireless-next 2/3] wifi: mac80211: Add support for IEEE 802.1X authentication protocol in non-AP STA mode Kavita Kavita
2026-02-26 6:54 ` [PATCH wireless-next 3/3] wifi: mac80211_hwsim: Advertise support for IEEE 802.1X authentication protocol Kavita Kavita
2026-02-26 8:36 ` Johannes Berg
2026-02-26 13:50 ` Kavita Kavita
2026-02-26 13:53 ` Johannes Berg
2026-02-26 14:07 ` Kavita Kavita
2026-02-26 16:49 ` Kavita Kavita
2026-02-26 16:50 ` Johannes Berg
2026-02-26 16:58 ` Kavita Kavita [this message]
2026-02-26 17:09 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67e9955a-1287-4467-9b52-be89144effbc@oss.qualcomm.com \
--to=kavita.kavita@oss.qualcomm.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox