Re: [PATCH wireless-next 3/3] wifi: mac80211_hwsim: Advertise support for IEEE 802.1X authentication protocol

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2026-02-26 at 22:28 +0530, Kavita Kavita wrote:
> 
> On 2/26/2026 10:20 PM, Johannes Berg wrote:
> > On Thu, 2026-02-26 at 22:19 +0530, Kavita Kavita wrote:
> > > 
> > > Sorry, I missed one case earlier. EPPKE mandates (Re)Association frame
> > > encryption support, so we should only advertise EPPKE when the driver indicates
> > > support for (Re)Association frame encryption in mac80211.
> > 
> > Oh, OK, but we could also check that in mac80211, in register_hw(), I
> > think?
> 
> For EPPKE, I will handle it like this:
> 
> @@ -1598,6 +1598,15 @@ int ieee80211_register_hw(struct ieee80211_hw *hw)
>                 local->sband_allocated |= BIT(band);
>         }
>  
> +       /*
> +        * mac80211 supports EPPKE, if the driver supports (Re)Association
> +        * frame encryption
> +        */
> +       if (wiphy_ext_feature_isset(local->hw.wiphy,
> +                                   NL80211_EXT_FEATURE_ASSOC_FRAME_ENCRYPTION))
> +               wiphy_ext_feature_set(local->hw.wiphy,
> +                                     NL80211_EXT_FEATURE_EPPKE);
> 
> For IEEE 802.1X Authentication, I am thinking to advertise its support directly
> from mac80211, in ieee80211_alloc_hw_nm, without checking for (Re)Association encryption
> support from the driver.
> 

Both Makes sense, thanks!

johannes