public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pablo Martin-Gomez <pmartin-gomez@freebox.fr>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 3/3] wifi: Transition/Padding delay subfields are for both EMLSR and EMLMR
Date: Tue, 07 Apr 2026 16:00:39 +0200	[thread overview]
Message-ID: <6900294c6c10fb7336e8ca6c7217e970db2cc3a1.camel@sipsolutions.net> (raw)
In-Reply-To: <20260327201135.905852-4-pmartin-gomez@freebox.fr> (sfid-20260327_211203_859894_9243403A)

On Fri, 2026-03-27 at 21:11 +0100, Pablo Martin-Gomez wrote:
> -#define IEEE80211_EML_CAP_EMLSR_TRANSITION_DELAY	0x0070
> +#define IEEE80211_EML_CAP_EMLSR_EMLMR_TRANSITION_DELAY	0x0070
>  #define  IEEE80211_EML_CAP_EMLSR_TRANSITION_DELAY_0US		0
>  #define  IEEE80211_EML_CAP_EMLSR_TRANSITION_DELAY_16US		1
>  #define  IEEE80211_EML_CAP_EMLSR_TRANSITION_DELAY_32US		2

I think this is confusing. You have the "EMLSR_EMLMR_" prefix in the
definition for the mask, but not in the values, but also the prefix
itself gets very long, not sure what to do about that. Maybe just
..._EML_TRANSITION_DELAY even if it doesn't match the spec completely.

And then another thing - I was going to apply the other two patches, but
really then looked at my git log and saw that no, really, the subjects
are stating a spec thing rather than describing a change, so please fix
that too.

johannes

  reply	other threads:[~2026-04-07 14:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 20:11 [PATCH 0/3] EML Capabilities compliance changes Pablo Martin-Gomez
2026-03-27 20:11 ` [PATCH 1/3] wifi: Transition Timeout of 128TUs is not defined Pablo Martin-Gomez
2026-03-27 20:11 ` [PATCH 2/3] wifi: EMLMR Delay subfield has been removed Pablo Martin-Gomez
2026-03-27 20:11 ` [PATCH 3/3] wifi: Transition/Padding delay subfields are for both EMLSR and EMLMR Pablo Martin-Gomez
2026-04-07 14:00   ` Johannes Berg [this message]
2026-04-07 15:47     ` Pablo MARTIN-GOMEZ
2026-04-08 12:07       ` Johannes Berg
2026-04-09  9:04         ` Pablo MARTIN-GOMEZ
2026-04-09 13:14           ` Johannes Berg
2026-04-07  9:00 ` [PATCH 0/3] EML Capabilities compliance changes Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6900294c6c10fb7336e8ca6c7217e970db2cc3a1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pmartin-gomez@freebox.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox