From: Johannes Berg <johannes@sipsolutions.net>
To: Julius Bairaktaris <julius@bairaktaris.de>
Cc: linux-wireless@vger.kernel.org, toke@toke.dk
Subject: Re: [PATCH] wifi: mac80211: scale the airtime queue limit by the station's weight
Date: Fri, 04 Sep 2026 11:49:58 +0200 [thread overview]
Message-ID: <6d033c71732e8ad2df4abcde1d38d89e2536609f.camel@sipsolutions.net> (raw)
In-Reply-To: <CAC1t37JMHWHNfEfK4+2uMj59+rkQATftmohmxnYM63crYGWysw@mail.gmail.com> (sfid-20260904_114736_899943_815E331D)
On Fri, 2026-09-04 at 09:46 +0000, Julius Bairaktaris wrote:
> Hi Johannes,
>
> > airtime weight is already used to select when the queues are serviced,
> > so why should it be used for the queue depth?
>
> While I used AI to help me write the change, my understanding of it is
> that on ath11k the order does not matter.
ath11k doesn't appear to use ieee80211_next_txq(), so it doesn't get
this and then AQL doesn't really work, I guess?
But for a driver that *does* use it, I believe this change is wrong.
johannes
next prev parent reply other threads:[~2026-09-04 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 14:24 [PATCH] wifi: mac80211: scale the airtime queue limit by the station's weight Julius Bairaktaris
2026-09-04 9:21 ` Johannes Berg
2026-09-04 9:46 ` Julius Bairaktaris
2026-09-04 9:49 ` Johannes Berg [this message]
2026-09-04 10:02 ` Julius Bairaktaris
2026-09-04 10:07 ` Johannes Berg
2026-09-04 10:35 ` Julius Bairaktaris
2026-09-04 11:46 ` Toke Høiland-Jørgensen
2026-09-08 13:52 ` Julius Bairaktaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d033c71732e8ad2df4abcde1d38d89e2536609f.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=julius@bairaktaris.de \
--cc=linux-wireless@vger.kernel.org \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox