Re: [PATCH] wifi: mac80211: scale the airtime queue limit by the station's weight

[Johannes Berg <johannes@sipsolutions.net>]

On Fri, 2026-09-04 at 10:02 +0000, Julius Bairaktaris wrote:
> > ath11k doesn't appear to use ieee80211_next_txq(), so it doesn't get
> > this and then AQL doesn't really work, I guess?
> 
> ath11k is using the generic handler
> 
>     drivers/net/wireless/ath/ath11k/mac.c:
>         .wake_tx_queue                  = ieee80211_handle_wake_tx_queue,
> 
> which runs the ieee80211_next_txq() loop itself.

Oops, my bad.

> What is missing is
> the AQL feature bit and the airtime reporting, which my series on
> ath-next adds. The numbers in this patch were taken with that series
> applied, so AQL and the DRR were both active when the weight did
> nothing.
> 
> > But for a driver that *does* use it, I believe this change is wrong.
> 
> I agree with that. It would have to be gated so that drivers like
> ath9k don't get it.

Now I'm confused - I was thinking it'd be wrong _only_ for ath9k etc.,
but you just corrected me and said that ieee80211_next_txq() is called
anyway, so then wouldn't it also be wrong on ath11k? Or not wrong on
all?

> There is also the possibility of dropping this change and letting
> ath11k pass the weight to the firmware's own ATF, for which the WMI
> commands are already in wmi.h but unused. I haven't tested this yet,
> it's just a theory, but mac80211 would stay untouched. What do you
> think?

No idea, sorry.

johannes