From: Arend Van Spriel <arend.vanspriel@broadcom.com>
To: Baoyou Xie <baoyou.xie@linaro.org>,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, arnd@linaro.org,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH v2] fix:brcmfmac: add missing header dependencies
Date: Mon, 29 Aug 2016 09:59:46 +0200 [thread overview]
Message-ID: <6e8b16f5-b4c7-39eb-dad4-d7fb3c08667f@broadcom.com> (raw)
In-Reply-To: <1472278103-28320-1-git-send-email-baoyou.xie@linaro.org>
On 27-8-2016 8:08, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-
> prototypes]
>
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies
Thanks for this fix, but please remove the 'fix:' prefix in the subject
as it just noise.
Regards,
Arend
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> index a10f35c..fe67559 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> @@ -19,6 +19,7 @@
> #ifndef __CHECKER__
> #define CREATE_TRACE_POINTS
> #include "tracepoint.h"
> +#include "debug.h"
>
> void __brcmf_err(const char *func, const char *fmt, ...)
> {
>
prev parent reply other threads:[~2016-08-29 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 6:08 [PATCH v2] fix:brcmfmac: add missing header dependencies Baoyou Xie
2016-08-29 7:59 ` Arend Van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e8b16f5-b4c7-39eb-dad4-d7fb3c08667f@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox