* [PATCH v2] fix:brcmfmac: add missing header dependencies
@ 2016-08-27 6:08 Baoyou Xie
2016-08-29 7:59 ` Arend Van Spriel
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-08-27 6:08 UTC (permalink / raw)
To: franky.lin, hante.meuleman, kvalo
Cc: baoyou.xie, linux-wireless, brcm80211-dev-list.pdl, netdev,
linux-kernel, arnd, xie.baoyou
We get 1 warning when biuld kernel with W=1:
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-
prototypes]
In fact, this function is declared in brcmfmac/debug.h, so this patch
add missing header dependencies
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
index a10f35c..fe67559 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
@@ -19,6 +19,7 @@
#ifndef __CHECKER__
#define CREATE_TRACE_POINTS
#include "tracepoint.h"
+#include "debug.h"
void __brcmf_err(const char *func, const char *fmt, ...)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] fix:brcmfmac: add missing header dependencies
2016-08-27 6:08 [PATCH v2] fix:brcmfmac: add missing header dependencies Baoyou Xie
@ 2016-08-29 7:59 ` Arend Van Spriel
0 siblings, 0 replies; 2+ messages in thread
From: Arend Van Spriel @ 2016-08-29 7:59 UTC (permalink / raw)
To: Baoyou Xie, franky.lin, hante.meuleman, kvalo
Cc: linux-wireless, brcm80211-dev-list.pdl, netdev, linux-kernel,
arnd, xie.baoyou
On 27-8-2016 8:08, Baoyou Xie wrote:
> We get 1 warning when biuld kernel with W=1:
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6: warning: no previous prototype for '__brcmf_err' [-Wmissing-
> prototypes]
>
> In fact, this function is declared in brcmfmac/debug.h, so this patch
> add missing header dependencies
Thanks for this fix, but please remove the 'fix:' prefix in the subject
as it just noise.
Regards,
Arend
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> index a10f35c..fe67559 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c
> @@ -19,6 +19,7 @@
> #ifndef __CHECKER__
> #define CREATE_TRACE_POINTS
> #include "tracepoint.h"
> +#include "debug.h"
>
> void __brcmf_err(const char *func, const char *fmt, ...)
> {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-29 7:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-27 6:08 [PATCH v2] fix:brcmfmac: add missing header dependencies Baoyou Xie
2016-08-29 7:59 ` Arend Van Spriel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox