Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 2/2] wifi: mac80211: Assign tx-stats to the proper link.
Date: Thu, 07 Nov 2024 15:43:18 +0100	[thread overview]
Message-ID: <73b1eb45e666aff20cf1debfdee1b60b44b82b46.camel@sipsolutions.net> (raw)
In-Reply-To: <20241009164904.3906438-2-greearb@candelatech.com>

On Wed, 2024-10-09 at 09:49 -0700, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
> 
> For drivers that can report the tx link-id, account tx
> stats against that link.  If we cannot determine tx link,
> then use deflink.

I was hoping Miri would look at the other patch ... but now that I
consider it again, this should probably come with some documentation
updates? Right now, it only says:

 * @IEEE80211_TX_CTRL_MLO_LINK: If not @IEEE80211_LINK_UNSPECIFIED, this
 *      frame should be transmitted on the specific link. This really is
 *      only relevant for frames that do not have data present, and is
 *      also not used for 802.3 format frames. Note that even if the frame
 *      is on a specific link, address translation might still apply if
 *      it's intended for an MLD.

and actually it's in the _control_ section of the TX info, so it's not
generally even preserved over to the _status_ section.

So rather than reusing this, we probably just need to introduce a new
_status_ field for it. And probably make it link_id+1 so 0 means no
value (this works because link ID 15 is invalid).

johannes

  reply	other threads:[~2024-11-07 14:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 16:49 [PATCH v3 1/2] wifi: iwlwifi: Report link-id for transmitted frames greearb
2024-10-09 16:49 ` [PATCH v3 2/2] wifi: mac80211: Assign tx-stats to the proper link greearb
2024-11-07 14:43   ` Johannes Berg [this message]
2024-11-07 15:51     ` Ben Greear
2024-11-07 16:03       ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73b1eb45e666aff20cf1debfdee1b60b44b82b46.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=greearb@candelatech.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox