Re: [PATCH v3 2/2] wifi: mac80211: Assign tx-stats to the proper link.

[Ben Greear <greearb@candelatech.com>]

On 11/7/24 06:43, Johannes Berg wrote:
> On Wed, 2024-10-09 at 09:49 -0700, greearb@candelatech.com wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> For drivers that can report the tx link-id, account tx
>> stats against that link.  If we cannot determine tx link,
>> then use deflink.
> 
> I was hoping Miri would look at the other patch ... but now that I
> consider it again, this should probably come with some documentation
> updates? Right now, it only says:
> 
>   * @IEEE80211_TX_CTRL_MLO_LINK: If not @IEEE80211_LINK_UNSPECIFIED, this
>   *      frame should be transmitted on the specific link. This really is
>   *      only relevant for frames that do not have data present, and is
>   *      also not used for 802.3 format frames. Note that even if the frame
>   *      is on a specific link, address translation might still apply if
>   *      it's intended for an MLD.
> 
> and actually it's in the _control_ section of the TX info, so it's not
> generally even preserved over to the _status_ section.
> 
> So rather than reusing this, we probably just need to introduce a new
> _status_ field for it. And probably make it link_id+1 so 0 means no
> value (this works because link ID 15 is invalid).

Where would you like this new field added?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com