Re: RX rate is wrong in 5.10? (bisected to: mac80211: receive and process S1G beacons)

Re: RX rate is wrong in 5.10? (bisected to: mac80211: receive and process S1G beacons)

[Ben Greear]

On 1/4/21 8:18 AM, Ben Greear wrote:
> Hello,
> 
> I noticed that RX rate is always 6Mbps when I use -ct firmware and -ct driver in
> 5.10, and on stock 5.10.0 driver and stock firmware, rx-rate does not show up at
> all in 'iw dev wlan1 station dump'.
> 
> I'm using 9984 NIC...
> 
> Anyone else see this?

After a bisect, the first bad commit shows this:

commit 09a740ce352e1a1d16b9984115514ba9a4f4704b (refs/bisect/bad)
Author: Thomas Pedersen <thomas@adapt-ip.com>
Date:   Mon Sep 21 19:28:14 2020 -0700

     mac80211: receive and process S1G beacons

     S1G beacons are 802.11 Extension Frames, so the fixed
     header part differs from regular beacons.

     Add a handler to process S1G beacons and abstract out the
     fetching of BSSID and element start locations in the
     beacon body handler.

     Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
     Link: https://lore.kernel.org/r/20200922022818.15855-14-thomas@adapt-ip.com
     [don't rename, small coding style cleanups]
     Signed-off-by: Johannes Berg <johannes.berg@intel.com>

 From a glance through the diff, I'm at a loss as to why it causes the symptom.  I manually
double-checked the bisect, an it appears correct.

What I see is that in the commit before this, I see a useful rx rate (1.3Gbps for instance)
in 'iw dev wlan1 station dump', but in this bad commit, both show 6Mbps rate.  (Tx rate
in ath10k is probably broken for other reasons, so I only bisected the rx side issue.)

I'm using ath10k 9984 radio with firmware 10.4-3.9.0.2-00070 in station mode.

AP is an ath11k Hawkeye...

I'm using a 1Mbps UDP packet 'download' stream to make sure I'm seeing rates for data frames
and not just management frames.

Any idea what might be the issue?

Thanks,
Ben

Re: RX rate is wrong in 5.10? (bisected to: mac80211: receive and process S1G beacons)

[Thomas Pedersen]

Hi Ben,

On 2021-01-04 16:18, Ben Greear wrote:
> On 1/4/21 8:18 AM, Ben Greear wrote:
>> Hello,
>> 
>> I noticed that RX rate is always 6Mbps when I use -ct firmware and -ct 
>> driver in
>> 5.10, and on stock 5.10.0 driver and stock firmware, rx-rate does not 
>> show up at
>> all in 'iw dev wlan1 station dump'.
>> 
>> I'm using 9984 NIC...
>> 
>> Anyone else see this?
> 
> After a bisect, the first bad commit shows this:
> 
> commit 09a740ce352e1a1d16b9984115514ba9a4f4704b (refs/bisect/bad)
> Author: Thomas Pedersen <thomas@adapt-ip.com>
> Date:   Mon Sep 21 19:28:14 2020 -0700
> 
>     mac80211: receive and process S1G beacons
> 
>     S1G beacons are 802.11 Extension Frames, so the fixed
>     header part differs from regular beacons.
> 
>     Add a handler to process S1G beacons and abstract out the
>     fetching of BSSID and element start locations in the
>     beacon body handler.
> 
>     Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
>     Link: 
> https://lore.kernel.org/r/20200922022818.15855-14-thomas@adapt-ip.com
>     [don't rename, small coding style cleanups]
>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> 
> From a glance through the diff, I'm at a loss as to why it causes the
> symptom.  I manually
> double-checked the bisect, an it appears correct.
> 
> What I see is that in the commit before this, I see a useful rx rate
> (1.3Gbps for instance)
> in 'iw dev wlan1 station dump', but in this bad commit, both show
> 6Mbps rate.  (Tx rate
> in ath10k is probably broken for other reasons, so I only bisected the
> rx side issue.)
> 
> I'm using ath10k 9984 radio with firmware 10.4-3.9.0.2-00070 in station 
> mode.
> 
> AP is an ath11k Hawkeye...
> 
> I'm using a 1Mbps UDP packet 'download' stream to make sure I'm seeing
> rates for data frames
> and not just management frames.

Sorry about that.

> Any idea what might be the issue?

It may be fixed by 
https://patchwork.kernel.org/project/linux-wireless/patch/1607483189-3891-1-git-send-email-wgong@codeaurora.org/

-- 
thomas

Re: RX rate is wrong in 5.10? (bisected to: mac80211: receive and process S1G beacons)

[Ben Greear]

On 1/4/21 4:25 PM, Thomas Pedersen wrote:
> Hi Ben,
> 
> On 2021-01-04 16:18, Ben Greear wrote:
>> On 1/4/21 8:18 AM, Ben Greear wrote:
>>> Hello,
>>>
>>> I noticed that RX rate is always 6Mbps when I use -ct firmware and -ct driver in
>>> 5.10, and on stock 5.10.0 driver and stock firmware, rx-rate does not show up at
>>> all in 'iw dev wlan1 station dump'.
>>>
>>> I'm using 9984 NIC...
>>>
>>> Anyone else see this?
>>
>> After a bisect, the first bad commit shows this:
>>
>> commit 09a740ce352e1a1d16b9984115514ba9a4f4704b (refs/bisect/bad)
>> Author: Thomas Pedersen <thomas@adapt-ip.com>
>> Date:   Mon Sep 21 19:28:14 2020 -0700
>>
>>     mac80211: receive and process S1G beacons
>>
>>     S1G beacons are 802.11 Extension Frames, so the fixed
>>     header part differs from regular beacons.
>>
>>     Add a handler to process S1G beacons and abstract out the
>>     fetching of BSSID and element start locations in the
>>     beacon body handler.
>>
>>     Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
>>     Link: https://lore.kernel.org/r/20200922022818.15855-14-thomas@adapt-ip.com
>>     [don't rename, small coding style cleanups]
>>     Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>>
>> From a glance through the diff, I'm at a loss as to why it causes the
>> symptom.  I manually
>> double-checked the bisect, an it appears correct.
>>
>> What I see is that in the commit before this, I see a useful rx rate
>> (1.3Gbps for instance)
>> in 'iw dev wlan1 station dump', but in this bad commit, both show
>> 6Mbps rate.  (Tx rate
>> in ath10k is probably broken for other reasons, so I only bisected the
>> rx side issue.)
>>
>> I'm using ath10k 9984 radio with firmware 10.4-3.9.0.2-00070 in station mode.
>>
>> AP is an ath11k Hawkeye...
>>
>> I'm using a 1Mbps UDP packet 'download' stream to make sure I'm seeing
>> rates for data frames
>> and not just management frames.
> 
> Sorry about that.
> 
>> Any idea what might be the issue?
> 
> It may be fixed by https://patchwork.kernel.org/project/linux-wireless/patch/1607483189-3891-1-git-send-email-wgong@codeaurora.org/

Yes, that fixes it.  Looks like it is already in 5.10.4 stable, so I'll upgrade to that.

Thanks for the quick hint.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com