* [PATCH rtw-next v11 0/3] wifi: rtw88: channel switch in AP mode
@ 2026-11-16 7:19 Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Mehmet Fide @ 2026-11-16 7:19 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel,
mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
An rtw88 AP cannot change its channel: the driver does not announce
channel switch support, so hostapd's CHAN_SWITCH is refused and the
only way is to tear the AP down. The series fixes the beacon download
the reserved page build makes twice, counts a switch down on top of
the firmware's beacon page, and times the countdown downloads from the
TBTT so that every count goes out on the air.
v11 was tested on rtw-next with the mac80211 patch [1] on top, on a
kernel with PROVE_LOCKING, DEBUG_ATOMIC_SLEEP, kmemleak and KFENCE, on
an RTL8821CU (two adapters), an RTL8822BU, an RTL8822CU (USB) and an
RTL8822CE (PCIe) with hostapd as AP, in both bands, the beacons
sniffed from a second machine. No lockdep or sleep-in-atomic report
came from the series:
- switches with counts 2, 5 and 10 and a station attached: every count
went out in 148 of 150 switches, one count is missing in the capture
of the other two, and the station stayed associated
- 240 more switches with a count of 2 on the RTL8822CE, the RTL8822CU
and the two RTL8821CU: the CSA beacon went out in all of them; the
station re-associated after four, all on an RTL8821CU on 2.4 GHz
- 200 more with counts 5 and 10 on the two RTL8821CU on 2.4 GHz and 60
with counts 50 and 100 on all adapters: the station stayed
associated in all. Of the 4380 beacons of the long countdowns 21
are missing in the capture, as many as without a countdown
- IBSS switches with counts 2, 5 and 10: every count in 75 of 75 on
5 GHz and in 55 of 75 on 2.4 GHz; 60 more with counts 50 and 100
ended on the new channel. No count was skipped, one was sent twice
- hostapd stopped and started and the driver unbound and bound, each
during a countdown, on every adapter in both bands: the AP came
back. One unbind hit the "Have pending ack frames!" WARN of
mac80211, which is there without the series
- a firmware crash during a countdown on the RTL8822CE: the countdown
goes on from the count that was on the air, the AP switches and a
switch after it completes. The crash from debugfs starts no
recovery on the USB chips
- a station interface associated first and an AP started next to it on
the RTL8822CE and the RTL8822CU: mac80211 cannot finalize a switch
of the AP alone and stops it at the end of the countdown. The
reserved page then holds the frames of the station only and the
station stays associated, in 9 of 9 runs
- scans during a countdown, from an IBSS interface of every adapter in
both bands and from the station interface next to the AP: each one
is refused with -EBUSY, a scan before and after the countdown works
- an IBSS left during its countdown and joined again, with [1]: the
countdown work is idle, a scan and a new switch work
In IBSS a countdown leaves more beacons off the air where the channel
is busy; the count goes on after each of them. With 20 s with and
without a countdown taking turns on one channel, the beacons that no
sniffer heard are, on 5 GHz, 1.9 % and 3.5 % of the countdown of an
RTL8821CU and the RTL8822BU against 0.3 % and 0.2 % without one, and
none on the RTL8822C; on 2.4 GHz 6.6 to 12.1 % against 2.7 to 7.2 % on
the five adapters. An AP shows no such difference. The cause is the
beacon function, which rtw_fw_write_data_rsvd_page() switches off for
the download: left on for the count steps, the difference is gone on
5 GHz, but one RTL8821CU AP then lost its station in 6 of 110
switches with counts 5 and 10 on 2.4 GHz, and in none of 100 without
the change, so the series leaves the download as it is. The TSF
stands still for the download as well, 2.8 ms on the USB chips and
0.3 ms on the RTL8822CE, so the beacons of a countdown are about
105 ms apart on USB.
Not run for v11: Windows stations and the build that delays the
downloads. The WoWLAN paths are built but not run: after a suspend
the PCIe card of the test board is inaccessible and the USB adapters
are probed again. Without the series as well, an IBSS interface stops
beaconing after a scan. Patch 1 is unchanged since v6.
v11:
- 2/3: the channel_switch_beacon op is gone, the BSS_CHANGED_BEACON
path starts every countdown (Luka)
- 2/3: rtw_fw_csa_start() does nothing on a device that is not
running
- 2/3: only the countdown work advances the count. The beacon of the
reserved page is fetched as a template while a switch is announced,
so the replay after a firmware recovery and the page of the WoWLAN
firmware repeat the count that is on the air
- 2/3: an AP that stops in its countdown downloads the reserved page
again if a station interface stays behind; the downloads the
countdown held back were lost for it
- 3/3: the first download shares the branch of a late one, and the
comment says what the branch catches (Luka)
- the beacon interval that stays at 100 TU on the air is fixed by a
separate patch (Luka)
- rebased on rtw-next
v10:
- 2/3: rtw_core_stop() clears csa_vif and cancels the countdown work
again once it has the mutex back, for a switch started while the
mutex was dropped (Luka)
- 3/3: the first count is downloaded by the countdown work, 10 ms
after the next TBTT, and no longer when mac80211 changes the beacon.
My reply on v9 said v10 only drops the back-off; that is not enough
on the RTL8822CE, where a TBTT shortly before the download sends no
beacon and the next one stays out too, so a count of 2 went out
without a CSA beacon (Luka). The switch completes up to one beacon
interval later. Ping-Ke's Acked-by and Luka's Reviewed-by are
dropped for the changed code
- rebased on rtw-next
v9:
- 2/3: the countdown starts again after a WoWLAN resume that worked,
which mac80211 follows with no replay (Luka); Ping-Ke's Acked-by is
dropped for the new code
- 3/3: Acked-by from Ping-Ke on v8, Reviewed-by from Luka
- an IBSS left during its countdown and joined again kept csa_active;
that is mac80211's, fixed by a separate patch [1] (Luka)
v8:
- 2/3: Acked-by from Ping-Ke
- 3/3: the TSF read retries once instead of looping, rtw_fw_csa_queue()
reads the TSF once also on start, the port 0 comment is gone, empty
lines where asked (Ping-Ke)
v7:
- new patch 3: the countdown downloads are timed from the TSF, 10 ms
after each TBTT, so a download that runs late by less than a beacon
interval still reaches the firmware before the next beacon; one
later than that is followed by its successor at once. Ping-Ke's
question on v6: with the absolute due time a late download and its
successor could land in one beacon period and leave a count out of
the air
- patch 3 takes a TBTT within the margin before the start as the one
that sent the countdown template: a TBTT between the template
download and the first TSF read made the stations see one count
twice
- patch 2 keeps csa_vif until the beacon after the switch: a TIM
update before it fetched one beacon past count 1 and hit the WARN
in ieee80211_beacon_update_cntdwn()
- rebased on rtw-next
v6:
- the wiphy work patch of v5 is gone: the countdown work is an
ieee80211 delayed work and csa_vif is driver state, both under the
driver mutex, so rtw88 takes no wiphy lock anywhere (Ping-Ke)
- rtw_core_stop() cancels the countdown work and clears csa_vif, which
covers the IPS path and the firmware recovery; the wiphy_lock() in
the recovery work is gone (Ping-Ke)
- the BSS_CHANGED_BEACON path says why it starts the countdown, the
replay after a hardware restart, and stops it when the beacon comes
back without a switch announced (Ping-Ke)
- the downloads are paced from the first one with an absolute due
time. Queued after each download, they drifted by about 10 ms per
beacon interval on the ordered mac80211 workqueue; on a count of 50
the AP switched half a second after its station had, and the
station re-associated
v5:
- 2/3 is new: update_beacon_work becomes a wiphy work, so that it can
look at the channel switch state under the wiphy lock; it checks
RTW_FLAG_RUNNING instead of being cancelled in rtw_core_stop(), which
runs without the wiphy lock on the IPS path (Ping-Ke); reverted in v6
- 3/3: rtw_fw_csa_active/start/stop() assert the wiphy lock (Ping-Ke);
reverted in v6, they assert the driver mutex
- 3/3: hw_scan() takes the mutex with guard() (Ping-Ke)
- 3/3: a comment on the association download names the STA+AP
combination it skips the download for (Ping-Ke)
- the whole set ran on a PROVE_LOCKING kernel without a lockdep report:
switches with counts 1 to 100, hostapd stopped and restarted during
a countdown, scans during a countdown, a firmware crash during a
countdown, three stop/idle/start cycles, IBSS, 50 switches with a
station attached, and on the RTL8822CU a station interface
associating while the AP interface counted down
v4:
- 1/2: Reviewed-by from Luka
- 2/2: the countdown work is back in the device, initialised once,
with csa_vif naming the interface; no interface iteration and no
lookup through the reserved page any more (Ping-Ke)
- 2/2: the countdown is cancelled before a firmware recovery restarts
the hardware, instead of guarding the work with flags (Ping-Ke)
- 2/2: the page download on association skips a running countdown,
like the TIM update and the PG backup (Luka)
- 2/2: the scan refusal comes before the scan offload test, so that
firmware without scan offload does not fall back to a software scan
during a countdown (Luka)
v3:
- 1/2: the beacon out-pointer is initialised in the caller (Luka)
- 2/2: the countdown work lives in the interface, remove_interface
cancels it unconditionally, the queue wrapper and the comments are
gone (Ping-Ke)
- 2/2: the TIM update and the PG backup on set_key skip the page
download while a switch is announced; every beacon fetch advances
the countdown (Luka)
- 2/2: the commit message names the refused hardware scan (Ping-Ke)
v2:
- 2/2: a hardware scan is refused while a switch is announced
- the rtw89 mention is gone from the cover
[1] https://lore.kernel.org/linux-wireless/20261025193615.1123718-1-mehmet.fide@gmail.com/
Mehmet Fide (3):
wifi: rtw88: download the beacon the reserved page was built with
wifi: rtw88: support channel switch in AP mode
wifi: rtw88: time the countdown downloads from the TBTT
drivers/net/wireless/realtek/rtw88/fw.c | 157 ++++++++++++++++--
drivers/net/wireless/realtek/rtw88/fw.h | 4 +
drivers/net/wireless/realtek/rtw88/mac80211.c | 56 ++++++-
drivers/net/wireless/realtek/rtw88/main.c | 9 +-
drivers/net/wireless/realtek/rtw88/main.h | 3 +
drivers/net/wireless/realtek/rtw88/reg.h | 1 +
6 files changed, 205 insertions(+), 25 deletions(-)
base-commit: 61a5eb87b2d9b4d5e353780b781cf691f39ba9e1
--
2.56.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH rtw-next v11 1/3] wifi: rtw88: download the beacon the reserved page was built with
2026-11-16 7:19 [PATCH rtw-next v11 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
@ 2026-11-16 7:19 ` Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2 siblings, 0 replies; 6+ messages in thread
From: Mehmet Fide @ 2026-11-16 7:19 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel,
mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
rtw_fw_download_rsvd_page() downloads the beacon twice: once as part of
the reserved page and once more on its own, so that the firmware ends up
with a TX descriptor that describes the beacon rather than the whole
page. The second download fetched a new beacon from mac80211 instead of
downloading the one the page already holds.
Besides the extra work, every beacon fetch advances the DTIM count and,
while a channel switch is announced, the CSA countdown; doing it twice
per update lets a countdown that starts at 2 reach 0, which mac80211
warns about. Hand the beacon skb out of the page build and download
that. The hw scan, which downloads the beacon without a page build,
keeps fetching its own.
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
---
Notes:
Changes in v11:
- none, rebased on rtw-next
Changes in v10:
- none, rebased on rtw-next
Changes in v9:
- none
Changes in v8:
- none
Changes in v7:
- none, rebased on rtw-next
Changes in v6:
- none
Changes in v5:
- none
Changes in v4:
- none, rebased on rtw-next
Changes in v3:
- the beacon out-pointer is initialised in the caller
drivers/net/wireless/realtek/rtw88/fw.c | 34 +++++++++++++++----------
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 945fedcd375b..3cd17a3bb494 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -1622,7 +1622,8 @@ static int __rtw_build_rsvd_page_from_vifs(struct rtw_dev *rtwdev)
return 0;
}
-static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size)
+static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size,
+ struct sk_buff **beacon)
{
const struct rtw_chip_info *chip = rtwdev->chip;
struct ieee80211_hw *hw = rtwdev->hw;
@@ -1702,13 +1703,15 @@ static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size)
list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, build_list) {
rtw_rsvd_page_list_to_buf(rtwdev, page_size, page_margin,
page, buf, rsvd_pkt);
- if (page == 0)
+ if (page == 0) {
page += rtw_len_to_page(rsvd_pkt->skb->len +
tx_desc_sz, page_size);
- else
+ /* the caller downloads it once more on its own */
+ *beacon = rsvd_pkt->skb;
+ } else {
page += rtw_len_to_page(rsvd_pkt->skb->len, page_size);
-
- kfree_skb(rsvd_pkt->skb);
+ kfree_skb(rsvd_pkt->skb);
+ }
rsvd_pkt->skb = NULL;
}
@@ -1723,11 +1726,12 @@ static u8 *rtw_build_rsvd_page(struct rtw_dev *rtwdev, u32 *size)
return NULL;
}
-static int rtw_download_beacon(struct rtw_dev *rtwdev)
+/* the beacon the page was built with, or a fresh one for the hw scan */
+static int rtw_download_beacon(struct rtw_dev *rtwdev, struct sk_buff *beacon)
{
struct ieee80211_hw *hw = rtwdev->hw;
struct rtw_rsvd_page *rsvd_pkt;
- struct sk_buff *skb;
+ struct sk_buff *skb = beacon;
int ret = 0;
rsvd_pkt = list_first_entry_or_null(&rtwdev->rsvd_page_list,
@@ -1744,7 +1748,8 @@ static int rtw_download_beacon(struct rtw_dev *rtwdev)
return -EINVAL;
}
- skb = rtw_get_rsvd_page_skb(hw, rsvd_pkt);
+ if (!skb)
+ skb = rtw_get_rsvd_page_skb(hw, rsvd_pkt);
if (!skb) {
rtw_err(rtwdev, "failed to get beacon skb\n");
return -ENOMEM;
@@ -1754,18 +1759,20 @@ static int rtw_download_beacon(struct rtw_dev *rtwdev)
if (ret)
rtw_err(rtwdev, "failed to download drv rsvd page\n");
- dev_kfree_skb(skb);
+ if (!beacon)
+ dev_kfree_skb(skb);
return ret;
}
int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev)
{
- u8 *buf;
+ struct sk_buff *beacon = NULL;
u32 size;
+ u8 *buf;
int ret;
- buf = rtw_build_rsvd_page(rtwdev, &size);
+ buf = rtw_build_rsvd_page(rtwdev, &size, &beacon);
if (!buf) {
rtw_err(rtwdev, "failed to build rsvd page pkt\n");
return -ENOMEM;
@@ -1782,13 +1789,14 @@ int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev)
* the beacon again to replace the TX desc header, and we will get
* a correct tx_desc for the beacon in the rsvd page.
*/
- ret = rtw_download_beacon(rtwdev);
+ ret = rtw_download_beacon(rtwdev, beacon);
if (ret) {
rtw_err(rtwdev, "failed to download beacon\n");
goto free;
}
free:
+ dev_kfree_skb(beacon);
kfree(buf);
return ret;
@@ -2345,7 +2353,7 @@ int rtw_hw_scan_offload(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
rtw_fw_set_scan_offload(rtwdev, &cs_option, rtwvif, &chan_list);
out:
if (rtwdev->ap_active) {
- ret = rtw_download_beacon(rtwdev);
+ ret = rtw_download_beacon(rtwdev, NULL);
if (ret)
rtw_err(rtwdev, "HW scan download beacon failed\n");
}
--
2.56.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-16 7:19 [PATCH rtw-next v11 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
@ 2026-11-16 7:19 ` Mehmet Fide
2026-11-16 14:24 ` Luka Gejak
2026-11-16 7:19 ` [PATCH rtw-next v11 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2 siblings, 1 reply; 6+ messages in thread
From: Mehmet Fide @ 2026-11-16 7:19 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel,
mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
hostapd's CHAN_SWITCH is refused because the driver does not announce
channel switch support, so an rtw88 AP can only change its channel by
being torn down and started again.
Declare WIPHY_FLAG_HAS_CHANNEL_SWITCH and start the countdown when
BSS_CHANGED_BEACON brings a beacon with CSA: the firmware repeats the
beacon held in the first reserved page, so while a switch is announced
the page is downloaded again every beacon interval to advance the
countdown, and ieee80211_csa_finish() is called once it completes. IBSS
shares the page and the work.
The work is a delayed work of the device and csa_vif names the
interface, both under the driver mutex. The countdown is cancelled when
the AP stops, when the interface goes away, on WoWLAN suspend and in
rtw_core_stop(), and is not started while the device is stopped; the
BSS_CHANGED_BEACON replay after a hardware restart resumes it, and so
does the driver after a WoWLAN resume, which mac80211 follows with no
replay.
Only the work advances the count: while a switch is announced the
beacon of the page is fetched as a template, which leaves the count as
it is, and the work steps it before each of its downloads. A download
for another reason, the replay after a hardware restart or the page of
the WoWLAN firmware, then repeats the count that is on the air. The
TIM update, the PG backup and the download on association are left to
the work during a countdown, its next download carries their changes.
An AP that stops in its countdown downloads the page once more if a
station interface stays behind. A scan is refused: it would take the
AP off the channel its stations count down to.
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 95 ++++++++++++++++++-
drivers/net/wireless/realtek/rtw88/fw.h | 4 +
drivers/net/wireless/realtek/rtw88/mac80211.c | 49 ++++++++--
drivers/net/wireless/realtek/rtw88/main.c | 9 +-
drivers/net/wireless/realtek/rtw88/main.h | 3 +
5 files changed, 150 insertions(+), 10 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 3cd17a3bb494..6968b608c54f 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -1229,6 +1229,7 @@ static struct sk_buff *rtw_get_rsvd_page_skb(struct ieee80211_hw *hw,
struct ieee80211_vif *vif;
struct rtw_vif *rtwvif;
struct sk_buff *skb_new;
+ struct ieee80211_mutable_offsets offs = {};
struct cfg80211_ssid *ssid;
u16 tim_offset = 0;
@@ -1249,7 +1250,15 @@ static struct sk_buff *rtw_get_rsvd_page_skb(struct ieee80211_hw *hw,
switch (rsvd_pkt->type) {
case RSVD_BEACON:
- skb_new = ieee80211_beacon_get_tim(hw, vif, &tim_offset, NULL, 0);
+ /* only the countdown work advances the count */
+ if (vif->bss_conf.csa_active) {
+ skb_new = ieee80211_beacon_get_template(hw, vif, &offs,
+ 0);
+ tim_offset = offs.tim_offset;
+ } else {
+ skb_new = ieee80211_beacon_get_tim(hw, vif, &tim_offset,
+ NULL, 0);
+ }
rsvd_pkt->tim_offset = tim_offset;
break;
case RSVD_PS_POLL:
@@ -1802,14 +1811,94 @@ int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev)
return ret;
}
+bool rtw_fw_csa_active(struct rtw_dev *rtwdev)
+{
+ lockdep_assert_held(&rtwdev->mutex);
+
+ return !!rtwdev->csa_vif;
+}
+
+/* paced from the first download: a late one does not delay the next */
+static void rtw_fw_csa_queue(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
+{
+ u32 interval = ieee80211_tu_to_usec(vif->bss_conf.beacon_int);
+ s64 delay;
+
+ rtwdev->csa_due = ktime_add_us(rtwdev->csa_due, interval);
+ delay = ktime_us_delta(rtwdev->csa_due, ktime_get());
+ ieee80211_queue_delayed_work(rtwdev->hw, &rtwdev->csa_beacon_work,
+ usecs_to_jiffies(max(delay, 0)));
+}
+
+void rtw_fw_csa_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
+{
+ lockdep_assert_held(&rtwdev->mutex);
+
+ if (rtwdev->csa_vif == vif ||
+ !test_bit(RTW_FLAG_RUNNING, rtwdev->flags))
+ return;
+
+ rtwdev->csa_vif = vif;
+ rtwdev->csa_due = ktime_get();
+ rtw_fw_csa_queue(rtwdev, vif);
+}
+
+bool rtw_fw_csa_stop(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
+{
+ lockdep_assert_held(&rtwdev->mutex);
+
+ if (!vif || rtwdev->csa_vif != vif)
+ return false;
+
+ rtwdev->csa_vif = NULL;
+ cancel_delayed_work(&rtwdev->csa_beacon_work);
+
+ return true;
+}
+
void rtw_fw_update_beacon_work(struct work_struct *work)
{
struct rtw_dev *rtwdev = container_of(work, struct rtw_dev,
update_beacon_work);
mutex_lock(&rtwdev->mutex);
- rtw_fw_download_rsvd_page(rtwdev);
- rtw_send_rsvd_page_h2c(rtwdev);
+
+ /* the countdown's next download carries the TIM */
+ if (!rtw_fw_csa_active(rtwdev)) {
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
+
+ mutex_unlock(&rtwdev->mutex);
+}
+
+void rtw_fw_csa_beacon_work(struct work_struct *work)
+{
+ struct rtw_dev *rtwdev = container_of(work, struct rtw_dev,
+ csa_beacon_work.work);
+ struct ieee80211_vif *vif;
+
+ mutex_lock(&rtwdev->mutex);
+
+ vif = rtwdev->csa_vif;
+ if (!vif)
+ goto out;
+
+ if (!vif->bss_conf.csa_active) {
+ rtwdev->csa_vif = NULL;
+ goto out;
+ }
+
+ if (!ieee80211_beacon_cntdwn_is_complete(vif, 0)) {
+ ieee80211_beacon_update_cntdwn(vif, 0);
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ rtw_fw_csa_queue(rtwdev, vif);
+ } else {
+ ieee80211_csa_finish(vif, 0);
+ }
+
+out:
mutex_unlock(&rtwdev->mutex);
}
diff --git a/drivers/net/wireless/realtek/rtw88/fw.h b/drivers/net/wireless/realtek/rtw88/fw.h
index 48ad9ceab6ea..40686a7e47d4 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.h
+++ b/drivers/net/wireless/realtek/rtw88/fw.h
@@ -863,7 +863,11 @@ void rtw_add_rsvd_page_pno(struct rtw_dev *rtwdev,
void rtw_add_rsvd_page_sta(struct rtw_dev *rtwdev,
struct rtw_vif *rtwvif);
int rtw_fw_download_rsvd_page(struct rtw_dev *rtwdev);
+bool rtw_fw_csa_active(struct rtw_dev *rtwdev);
+void rtw_fw_csa_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif);
+bool rtw_fw_csa_stop(struct rtw_dev *rtwdev, struct ieee80211_vif *vif);
void rtw_fw_update_beacon_work(struct work_struct *work);
+void rtw_fw_csa_beacon_work(struct work_struct *work);
void rtw_send_rsvd_page_h2c(struct rtw_dev *rtwdev);
int rtw_dump_drv_rsvd_page(struct rtw_dev *rtwdev,
u32 offset, u32 size, u32 *buf);
diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
index 5e40cf06a9e3..4bf47116ac73 100644
--- a/drivers/net/wireless/realtek/rtw88/mac80211.c
+++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
@@ -237,6 +237,8 @@ static void rtw_ops_remove_interface(struct ieee80211_hw *hw,
mutex_lock(&rtwdev->mutex);
+ rtw_fw_csa_stop(rtwdev, vif);
+
rtw_leave_lps_deep(rtwdev);
rtw_txq_cleanup(rtwdev, vif->txq);
@@ -395,8 +397,11 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
if (vif->cfg.assoc) {
rtw_coex_connect_notify(rtwdev, COEX_ASSOCIATE_FINISH);
- rtw_fw_download_rsvd_page(rtwdev);
- rtw_send_rsvd_page_h2c(rtwdev);
+ /* a station associating while the AP counts down */
+ if (!rtw_fw_csa_active(rtwdev)) {
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
rtw_fw_default_port(rtwdev, rtwvif);
rtw_coex_media_status_notify(rtwdev, vif->cfg.assoc);
if (rtw_bf_support)
@@ -438,6 +443,14 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
rtw_set_dtim_period(rtwdev, conf->dtim_period);
rtw_fw_download_rsvd_page(rtwdev);
rtw_send_rsvd_page_h2c(rtwdev);
+ /*
+ * A beacon with CSA starts the countdown, also when a restart
+ * replays it. A beacon without CSA ends it.
+ */
+ if (conf->csa_active)
+ rtw_fw_csa_start(rtwdev, vif);
+ else
+ rtw_fw_csa_stop(rtwdev, vif);
}
if (changed & BSS_CHANGED_BEACON_ENABLED) {
@@ -488,13 +501,20 @@ static void rtw_ops_stop_ap(struct ieee80211_hw *hw,
struct ieee80211_bss_conf *link_conf)
{
struct rtw_dev *rtwdev = hw->priv;
+ bool csa;
mutex_lock(&rtwdev->mutex);
+ csa = rtw_fw_csa_stop(rtwdev, vif);
rtw_write32_clr(rtwdev, REG_TCR, BIT_TCR_UPDATE_HGQMD);
rtw_write16(rtwdev, REG_ATIMWND, ATIMWND_DEFAULT);
rtwdev->ap_active = false;
- if (!rtw_core_check_sta_active(rtwdev))
+ if (!rtw_core_check_sta_active(rtwdev)) {
rtw_clear_op_chan(rtwdev);
+ } else if (csa) {
+ /* what the countdown held back */
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
mutex_unlock(&rtwdev->mutex);
}
@@ -626,7 +646,8 @@ static int rtw_ops_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
}
/* download new cam settings for PG to backup */
- if (rtw_get_lps_deep_mode(rtwdev) == LPS_DEEP_MODE_PG)
+ if (rtw_get_lps_deep_mode(rtwdev) == LPS_DEEP_MODE_PG &&
+ !rtw_fw_csa_active(rtwdev))
rtw_fw_download_rsvd_page(rtwdev);
out:
@@ -846,6 +867,7 @@ static int rtw_ops_suspend(struct ieee80211_hw *hw,
int ret;
mutex_lock(&rtwdev->mutex);
+ rtw_fw_csa_stop(rtwdev, rtwdev->csa_vif);
ret = rtw_wow_suspend(rtwdev, wowlan);
if (ret)
rtw_err(rtwdev, "failed to suspend for wow %d\n", ret);
@@ -854,6 +876,15 @@ static int rtw_ops_suspend(struct ieee80211_hw *hw,
return ret ? 1 : 0;
}
+static void rtw_ops_csa_resume_iter(void *data, struct ieee80211_vif *vif)
+{
+ struct rtw_dev *rtwdev = data;
+
+ if ((vif->type == NL80211_IFTYPE_AP ||
+ vif->type == NL80211_IFTYPE_ADHOC) && vif->bss_conf.csa_active)
+ rtw_fw_csa_start(rtwdev, vif);
+}
+
static int rtw_ops_resume(struct ieee80211_hw *hw)
{
struct rtw_dev *rtwdev = hw->priv;
@@ -863,6 +894,8 @@ static int rtw_ops_resume(struct ieee80211_hw *hw)
ret = rtw_wow_resume(rtwdev);
if (ret)
rtw_err(rtwdev, "failed to resume for wow %d\n", ret);
+ else
+ rtw_iterate_vifs(rtwdev, rtw_ops_csa_resume_iter, rtwdev);
mutex_unlock(&rtwdev->mutex);
return ret ? 1 : 0;
@@ -893,20 +926,24 @@ static int rtw_ops_hw_scan(struct ieee80211_hw *hw, struct ieee80211_vif *vif,
struct rtw_dev *rtwdev = hw->priv;
int ret;
+ guard(mutex)(&rtwdev->mutex);
+
+ /* a scan takes the AP off the channel its stations count down to */
+ if (rtw_fw_csa_active(rtwdev))
+ return -EBUSY;
+
if (!rtw_fw_feature_check(&rtwdev->fw, FW_FEATURE_SCAN_OFFLOAD))
return 1;
if (test_bit(RTW_FLAG_SCANNING, rtwdev->flags))
return -EBUSY;
- mutex_lock(&rtwdev->mutex);
rtw_hw_scan_start(rtwdev, vif, req);
ret = rtw_hw_scan_offload(rtwdev, vif, true);
if (ret) {
rtw_hw_scan_abort(rtwdev);
rtw_err(rtwdev, "HW scan failed with status: %d\n", ret);
}
- mutex_unlock(&rtwdev->mutex);
return ret;
}
diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
index f7708ad17b6f..4d9837b07ebf 100644
--- a/drivers/net/wireless/realtek/rtw88/main.c
+++ b/drivers/net/wireless/realtek/rtw88/main.c
@@ -1548,11 +1548,13 @@ void rtw_core_stop(struct rtw_dev *rtwdev)
clear_bit(RTW_FLAG_RUNNING, rtwdev->flags);
clear_bit(RTW_FLAG_FW_RUNNING, rtwdev->flags);
+ rtwdev->csa_vif = NULL;
mutex_unlock(&rtwdev->mutex);
cancel_work_sync(&rtwdev->c2h_work);
cancel_work_sync(&rtwdev->update_beacon_work);
+ cancel_delayed_work_sync(&rtwdev->csa_beacon_work);
cancel_delayed_work_sync(&rtwdev->watch_dog_work);
cancel_delayed_work_sync(&coex->bt_relink_work);
cancel_delayed_work_sync(&coex->bt_reenable_work);
@@ -1565,6 +1567,9 @@ void rtw_core_stop(struct rtw_dev *rtwdev)
mutex_lock(&rtwdev->mutex);
+ rtwdev->csa_vif = NULL;
+ cancel_delayed_work(&rtwdev->csa_beacon_work);
+
rtwdev->chip->ops->power_off(rtwdev);
}
@@ -2168,6 +2173,7 @@ int rtw_core_init(struct rtw_dev *rtwdev)
INIT_WORK(&rtwdev->ips_work, rtw_ips_work);
INIT_WORK(&rtwdev->fw_recovery_work, rtw_fw_recovery_work);
INIT_WORK(&rtwdev->update_beacon_work, rtw_fw_update_beacon_work);
+ INIT_DELAYED_WORK(&rtwdev->csa_beacon_work, rtw_fw_csa_beacon_work);
INIT_WORK(&rtwdev->ba_work, rtw_txq_ba_work);
skb_queue_head_init(&rtwdev->c2h_queue);
skb_queue_head_init(&rtwdev->coex.queue);
@@ -2291,7 +2297,8 @@ int rtw_register_hw(struct rtw_dev *rtwdev, struct ieee80211_hw *hw)
hw->wiphy->available_antennas_rx = hal->antenna_rx;
hw->wiphy->flags |= WIPHY_FLAG_SUPPORTS_TDLS |
- WIPHY_FLAG_TDLS_EXTERNAL_SETUP;
+ WIPHY_FLAG_TDLS_EXTERNAL_SETUP |
+ WIPHY_FLAG_HAS_CHANNEL_SWITCH;
hw->wiphy->features |= NL80211_FEATURE_SCAN_RANDOM_MAC_ADDR;
hw->wiphy->max_scan_ssids = RTW_SCAN_MAX_SSIDS;
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index 6ecbeb4ffe4b..5d18841a705f 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -2094,6 +2094,9 @@ struct rtw_dev {
struct work_struct ips_work;
struct work_struct fw_recovery_work;
struct work_struct update_beacon_work;
+ struct delayed_work csa_beacon_work;
+ struct ieee80211_vif *csa_vif;
+ ktime_t csa_due;
/* used to protect txqs list */
spinlock_t txq_lock;
--
2.56.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH rtw-next v11 3/3] wifi: rtw88: time the countdown downloads from the TBTT
2026-11-16 7:19 [PATCH rtw-next v11 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
@ 2026-11-16 7:19 ` Mehmet Fide
2026-11-16 14:26 ` Luka Gejak
2 siblings, 1 reply; 6+ messages in thread
From: Mehmet Fide @ 2026-11-16 7:19 UTC (permalink / raw)
To: Ping-Ke Shih
Cc: Luka Gejak, Bitterblue Smith, linux-wireless, linux-kernel,
mehmet.fide
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
The countdown downloads are queued one beacon interval apart, with no
relation to the TBTT. A download that runs late past the next TBTT
leaves a count out of the air.
Queue each download 10 ms after the next TBTT, read from the TSF, so it
may run late by almost a beacon interval; a later one is followed by
the next at once. A download that ran more than a beacon interval late
restarts the schedule from the next TBTT.
The first count is downloaded the same way, not when mac80211 changes
the beacon: a download close to a TBTT keeps beacons off the air. On an
RTL8821CU and an RTL8822CU a TBTT during the download sent no beacon or
the old one. On an RTL8822CE a TBTT up to about 100 us before the
download sent none and the next beacon stayed out too, and with a count
of 2 no CSA beacon went out. The switch completes up to one beacon
interval later. The replay after a hardware restart still downloads at
once.
The USB chips raise no TBTT interrupt, so the TSF register is read. The
beaconing interface is always on port 0: rtw_core_port_switch() moves
an AP there, an IBSS runs alone.
Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
---
drivers/net/wireless/realtek/rtw88/fw.c | 42 +++++++++++++++----
drivers/net/wireless/realtek/rtw88/mac80211.c | 7 +++-
drivers/net/wireless/realtek/rtw88/main.h | 2 +-
drivers/net/wireless/realtek/rtw88/reg.h | 1 +
4 files changed, 42 insertions(+), 10 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
index 6968b608c54f..2b5d6268e7f9 100644
--- a/drivers/net/wireless/realtek/rtw88/fw.c
+++ b/drivers/net/wireless/realtek/rtw88/fw.c
@@ -3,6 +3,7 @@
*/
#include <linux/iopoll.h>
+#include <linux/math64.h>
#include "main.h"
#include "coex.h"
@@ -1818,14 +1819,41 @@ bool rtw_fw_csa_active(struct rtw_dev *rtwdev)
return !!rtwdev->csa_vif;
}
-/* paced from the first download: a late one does not delay the next */
-static void rtw_fw_csa_queue(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
+#define RTW_CSA_TBTT_MARGIN_US 10000
+
+static u64 rtw_fw_read_tsf(struct rtw_dev *rtwdev)
+{
+ u32 hi, lo, tmp;
+
+ hi = rtw_read32(rtwdev, REG_TSFTR + 4);
+ lo = rtw_read32(rtwdev, REG_TSFTR);
+ tmp = rtw_read32(rtwdev, REG_TSFTR + 4);
+ if (tmp != hi) {
+ hi = tmp;
+ lo = rtw_read32(rtwdev, REG_TSFTR);
+ }
+
+ return ((u64)hi << 32) | lo;
+}
+
+static void rtw_fw_csa_queue(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
+ bool start)
{
u32 interval = ieee80211_tu_to_usec(vif->bss_conf.beacon_int);
+ u64 tsf = rtw_fw_read_tsf(rtwdev);
s64 delay;
+ u32 rem;
+
+ rtwdev->csa_tbtt += interval;
+ delay = rtwdev->csa_tbtt + RTW_CSA_TBTT_MARGIN_US - tsf;
+ if (start || delay > interval + RTW_CSA_TBTT_MARGIN_US ||
+ delay < -(s64)interval) {
+ /* at the start, or the download ran too late: the next TBTT */
+ div_u64_rem(tsf, interval, &rem);
+ rtwdev->csa_tbtt = tsf - rem + interval;
+ delay = rtwdev->csa_tbtt + RTW_CSA_TBTT_MARGIN_US - tsf;
+ }
- rtwdev->csa_due = ktime_add_us(rtwdev->csa_due, interval);
- delay = ktime_us_delta(rtwdev->csa_due, ktime_get());
ieee80211_queue_delayed_work(rtwdev->hw, &rtwdev->csa_beacon_work,
usecs_to_jiffies(max(delay, 0)));
}
@@ -1839,8 +1867,8 @@ void rtw_fw_csa_start(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
return;
rtwdev->csa_vif = vif;
- rtwdev->csa_due = ktime_get();
- rtw_fw_csa_queue(rtwdev, vif);
+
+ rtw_fw_csa_queue(rtwdev, vif, true);
}
bool rtw_fw_csa_stop(struct rtw_dev *rtwdev, struct ieee80211_vif *vif)
@@ -1893,7 +1921,7 @@ void rtw_fw_csa_beacon_work(struct work_struct *work)
ieee80211_beacon_update_cntdwn(vif, 0);
rtw_fw_download_rsvd_page(rtwdev);
rtw_send_rsvd_page_h2c(rtwdev);
- rtw_fw_csa_queue(rtwdev, vif);
+ rtw_fw_csa_queue(rtwdev, vif, false);
} else {
ieee80211_csa_finish(vif, 0);
}
diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
index 4bf47116ac73..b88fc420058f 100644
--- a/drivers/net/wireless/realtek/rtw88/mac80211.c
+++ b/drivers/net/wireless/realtek/rtw88/mac80211.c
@@ -441,8 +441,11 @@ static void rtw_ops_bss_info_changed(struct ieee80211_hw *hw,
if (changed & BSS_CHANGED_BEACON) {
rtw_set_dtim_period(rtwdev, conf->dtim_period);
- rtw_fw_download_rsvd_page(rtwdev);
- rtw_send_rsvd_page_h2c(rtwdev);
+ /* the countdown downloads its beacons after a TBTT */
+ if (!conf->csa_active || changed & BSS_CHANGED_BEACON_ENABLED) {
+ rtw_fw_download_rsvd_page(rtwdev);
+ rtw_send_rsvd_page_h2c(rtwdev);
+ }
/*
* A beacon with CSA starts the countdown, also when a restart
* replays it. A beacon without CSA ends it.
diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index 5d18841a705f..466992b85c43 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -2096,7 +2096,7 @@ struct rtw_dev {
struct work_struct update_beacon_work;
struct delayed_work csa_beacon_work;
struct ieee80211_vif *csa_vif;
- ktime_t csa_due;
+ u64 csa_tbtt;
/* used to protect txqs list */
spinlock_t txq_lock;
diff --git a/drivers/net/wireless/realtek/rtw88/reg.h b/drivers/net/wireless/realtek/rtw88/reg.h
index afcdb66fdb9a..3ff4ae0885ef 100644
--- a/drivers/net/wireless/realtek/rtw88/reg.h
+++ b/drivers/net/wireless/realtek/rtw88/reg.h
@@ -506,6 +506,7 @@
#define REG_USTIME_TSF 0x055C
#define REG_BCN_MAX_ERR 0x055D
#define REG_RXTSF_OFFSET_CCK 0x055E
+#define REG_TSFTR 0x0560
#define REG_MISC_CTRL 0x0577
#define BIT_EN_FREE_CNT BIT(3)
#define BIT_DIS_SECOND_CCA (BIT(0) | BIT(1))
--
2.56.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode
2026-11-16 7:19 ` [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
@ 2026-11-16 14:24 ` Luka Gejak
0 siblings, 0 replies; 6+ messages in thread
From: Luka Gejak @ 2026-11-16 14:24 UTC (permalink / raw)
To: Mehmet Fide, Ping-Ke Shih
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
Hi Mehmet,
Thanks for the v11. Three comments below.
On November 16, 2026 8:19:51 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
> diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
[ ... ]
> + if (!ieee80211_beacon_cntdwn_is_complete(vif, 0)) {
> + ieee80211_beacon_update_cntdwn(vif, 0);
> + rtw_fw_download_rsvd_page(rtwdev);
> + rtw_send_rsvd_page_h2c(rtwdev);
> + rtw_fw_csa_queue(rtwdev, vif);
> + } else {
> + ieee80211_csa_finish(vif, 0);
> + }
As far as I can see, the template fetch writes the new count into
mac80211's beacon before the transfer can fail. If the allocation in
rtw_tx_write_data_rsvd_page_get() fails at count 1, the next work still
finds the countdown complete. With patch 3 and count 2, this can finish
the switch without any CSA beacon going out.
Could a failed download keep that count pending for a retry before
allowing completion?
[ ... ]
> diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c
[ ... ]
> + csa = rtw_fw_csa_stop(rtwdev, vif);
[ ... ]
> + } else if (csa) {
> + /* what the countdown held back */
> + rtw_fw_download_rsvd_page(rtwdev);
> + rtw_send_rsvd_page_h2c(rtwdev);
> + }
I think ieee80211_stop_ap() can clear csa_active and the countdown work
can then clear csa_vif before stop_ap gets the driver mutex.
rtw_fw_csa_stop() returns false, so this refresh is skipped even with a
station left running. Any deferred station PG backup or association
download is then lost.
Maybe the refresh should not depend on csa_vif still being set? The
wiphy lock does not exclude the countdown work.
[ ... ]
> + else
> + rtw_iterate_vifs(rtwdev, rtw_ops_csa_resume_iter, rtwdev);
rtw_iterate_vifs() silently skips a vif if its GFP_ATOMIC entry
allocation fails. With an AP counting down next to an associated station
on the 8822C, skipping the AP leaves csa_active set and the work
cancelled. Resume returns 0, so mac80211 sends no beacon replay and the
countdown stays stuck. TIM downloads fetch a template and do not advance
it either.
Could the AP be found without allocating an entry?
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH rtw-next v11 3/3] wifi: rtw88: time the countdown downloads from the TBTT
2026-11-16 7:19 ` [PATCH rtw-next v11 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
@ 2026-11-16 14:26 ` Luka Gejak
0 siblings, 0 replies; 6+ messages in thread
From: Luka Gejak @ 2026-11-16 14:26 UTC (permalink / raw)
To: Mehmet Fide, Ping-Ke Shih
Cc: Bitterblue Smith, linux-wireless, linux-kernel, mehmet.fide
Hi Mehmet,
Thanks for the v11. One comment below.
On November 16, 2026 8:19:52 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
> diff --git a/drivers/net/wireless/realtek/rtw88/fw.c b/drivers/net/wireless/realtek/rtw88/fw.c
[ ... ]
> + rtwdev->csa_tbtt += interval;
> + delay = rtwdev->csa_tbtt + RTW_CSA_TBTT_MARGIN_US - tsf;
> + if (start || delay > interval + RTW_CSA_TBTT_MARGIN_US ||
> + delay < -(s64)interval) {
> + /* at the start, or the download ran too late: the next TBTT */
> + div_u64_rem(tsf, interval, &rem);
> + rtwdev->csa_tbtt = tsf - rem + interval;
> + delay = rtwdev->csa_tbtt + RTW_CSA_TBTT_MARGIN_US - tsf;
> + }
[ ... ]
> ieee80211_queue_delayed_work(rtwdev->hw, &rtwdev->csa_beacon_work,
> usecs_to_jiffies(max(delay, 0)));
Could the first count still be replaced before it goes out if the first
work runs late? With patch 3 that work is also the first download of a
CSA beacon.
For example, with a 100 TU interval and a count of 2:
first work due: TSF 112400
first download done: TSF 224800
csa_tbtt after +=: TSF 204800
delay: -10000 us
next TBTT: TSF 307200
The delay is not below -102400, so this queues the next work immediately.
The download just installed count 1, and that work can call
ieee80211_csa_finish() before the next TBTT. So if I read it right, no
CSA beacon has gone out at all, even though the download succeeded.
I understand skipping an intermediate count when a download runs late,
but with a count of 2 there is no earlier CSA beacon for the station to
follow. Could the next step wait for a TBTT that can send the first
download, including when the first work has missed its scheduled one?
Best regards,
Luka Gejak
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-16 14:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 7:19 [PATCH rtw-next v11 0/3] wifi: rtw88: channel switch in AP mode Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 1/3] wifi: rtw88: download the beacon the reserved page was built with Mehmet Fide
2026-11-16 7:19 ` [PATCH rtw-next v11 2/3] wifi: rtw88: support channel switch in AP mode Mehmet Fide
2026-11-16 14:24 ` Luka Gejak
2026-11-16 7:19 ` [PATCH rtw-next v11 3/3] wifi: rtw88: time the countdown downloads from the TBTT Mehmet Fide
2026-11-16 14:26 ` Luka Gejak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox