Linux wireless drivers development
 help / color / mirror / Atom feed
From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wil6210: Replace %pK with %p
Date: Sat, 17 Oct 2026 09:04:00 -0700	[thread overview]
Message-ID: <8444a9b6-b197-4b64-9afa-d3741c2a85e2@oss.qualcomm.com> (raw)
In-Reply-To: <20260918201145.kQDy1UrD@linutronix.de>

On 9/18/2026 1:11 PM, Sebastian Andrzej Siewior wrote:

commit subject is missing "wifi: " prefix

> Commit 71338aa7d050c ("net: convert %p usage to %pK") which is from
> 2011 and changed the %p annotation for pointer to %pK. Back then the
> default behaviour for %p was to print the pointer. The %pK modifier was
> introduced to able to control the behaviour of specific pointer values
> without changing the behaviour of %p for everyone. It was dedicated to
> avoid leaking pointers via /proc.
> 
> Things changed over time. The default behaviour for %p is now to print a
> hash pointer which does not leak the address but allows to correlate if
> two pointers are equal. I intend to remove %pK from the library.
> 
> Replace %pK with %pK in order to retain the pointer output for

s/with %pK/with %p/

> debugging.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> v1…v2: https://lore.kernel.org/all/20260918105632.pDhc9gIB@linutronix.de/
>   - Keep existing %p, just replace %pK.
> 
>  drivers/net/wireless/ath/wil6210/debugfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
> index e06e45323272c..79f5785697081 100644
> --- a/drivers/net/wireless/ath/wil6210/debugfs.c
> +++ b/drivers/net/wireless/ath/wil6210/debugfs.c
> @@ -200,7 +200,7 @@ static void wil_print_sring(struct seq_file *s, struct wil6210_priv *wil,
>  	seq_printf(s, "Status Ring %s [ %d ] = {\n",
>  		   sring->is_rx ? "RX" : "TX", sring_idx);
>  	seq_printf(s, "  pa     = %pad\n", &sring->pa);
> -	seq_printf(s, "  va     = 0x%pK\n", sring->va);
> +	seq_printf(s, "  va     = 0x%p\n", sring->va);
>  	seq_printf(s, "  size   = %d\n", sring->size);
>  	seq_printf(s, "  elem_size   = %zu\n", sring->elem_size);
>  	seq_printf(s, "  swhead = %d\n", sring->swhead);

No need to repost to address the nits -- I'll fix them in 'pending'

  reply	other threads:[~2026-10-17 16:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-18 10:56 [PATCH] wil6210: Remove %pK and %p Sebastian Andrzej Siewior
2026-09-18 15:25 ` Jeff Johnson
2026-09-18 16:58   ` Sebastian Andrzej Siewior
2026-09-18 20:11   ` [PATCH v2] wil6210: Replace %pK with %p Sebastian Andrzej Siewior
2026-10-17 16:04     ` Jeff Johnson [this message]
2026-10-19  6:51       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8444a9b6-b197-4b64-9afa-d3741c2a85e2@oss.qualcomm.com \
    --to=jeff.johnson@oss.qualcomm.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox