From: Kalle Valo <kvalo@codeaurora.org>
To: Wright Feng <wright.feng@cypress.com>
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
chi-hsien.lin@cypress.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 2/3] brcmfmac: make firmware eap_restrict a module parameter
Date: Sun, 22 Mar 2020 16:29:31 +0200 [thread overview]
Message-ID: <871rpkcvjo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <9683e5c3-5f68-5632-e1cf-c31e51379673@cypress.com> (Wright Feng's message of "Fri, 20 Mar 2020 16:06:11 +0800")
Wright Feng <wright.feng@cypress.com> writes:
> Arend Van Spriel 於 3/19/2020 4:28 PM 寫道:
>> On 3/19/2020 8:53 AM, Wright Feng wrote:
>>> When eap_restrict is enabled, firmware will toss non-802.1x frames from
>>> tx/rx data path if station not yet authorized.
>>> Internal firmware eap_restrict is disabled by default. This patch makes
>>> it possible to enable firmware eap_restrict by specifying
>>> eap_restrict=1 as module parameter.
>>
>> What is the reason for not having this toss behavior as default?
>> Don't see much reason for having the module parameter.
>
> The eap_restrict feature in most of firmwares are disabled as default,
> and refer to our experience, using eap_restrict increases roam time
> for associations in some cases.
What are these these cases exactly?
> So what we do in this patch is not changing the default firmware
> behavior but still give users a way to enable eap_resrtict feature.
You should have mentioned this (ie. answer the "Why?" part) in the
commit log in the first place.
But I don't like adding module parameters unless with really good
reasons. And in this case there's no proper documentation when and how a
user should use the module parameter so this is nowhere near a proper
justifiction.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-03-22 14:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 7:53 [PATCH 0/3] Add AP isolate support and two modules parameters Wright Feng
2020-03-19 7:53 ` [PATCH 1/3] brcmfmac: support AP isolate Wright Feng
2020-03-19 8:48 ` Arend Van Spriel
2020-03-20 8:04 ` Wright Feng
2020-03-19 7:53 ` [PATCH 2/3] brcmfmac: make firmware eap_restrict a module parameter Wright Feng
2020-03-19 8:28 ` Arend Van Spriel
2020-03-20 8:06 ` Wright Feng
2020-03-22 14:29 ` Kalle Valo [this message]
2020-03-19 7:53 ` [PATCH 3/3] brcmfmac: make setting SDIO workqueue WQ_HIGHPRI " Wright Feng
2020-03-19 8:55 ` Arend Van Spriel
2020-03-20 8:08 ` Wright Feng
2020-03-20 8:18 ` Arend Van Spriel
2020-03-20 9:01 ` Wright Feng
2020-03-24 18:23 ` Tejun Heo
2020-03-25 4:29 ` Wright Feng
2020-03-25 14:08 ` Tejun Heo
2020-03-25 14:53 ` Arend Van Spriel
2020-03-25 15:06 ` Wright Feng
2020-03-25 15:12 ` Tejun Heo
2020-03-27 9:14 ` Wright Feng
2020-04-03 14:59 ` Tejun Heo
2020-03-25 15:10 ` Tejun Heo
2020-03-22 14:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rpkcvjo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox