Linux wireless drivers development
 help / color / mirror / Atom feed
From: Wright Feng <wright.feng@cypress.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>,
	Tejun Heo <tj@kernel.org>
Cc: franky.lin@broadcom.com, hante.meuleman@broadcom.com,
	kvalo@codeaurora.org, chi-hsien.lin@cypress.com,
	linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 3/3] brcmfmac: make setting SDIO workqueue WQ_HIGHPRI a module parameter
Date: Wed, 25 Mar 2020 23:06:33 +0800	[thread overview]
Message-ID: <c1192351-6f72-6f82-bb2b-9f91266d8aab@cypress.com> (raw)
In-Reply-To: <171122f50d8.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com>



Arend Van Spriel 於 3/25/2020 10:53 PM 寫道:
> On March 25, 2020 3:08:18 PM Tejun Heo <tj@kernel.org> wrote:
> 
>> On Wed, Mar 25, 2020 at 12:29:44PM +0800, Wright Feng wrote:
>>> If that's incorrect, would you please give me a hint how to set
>>> __WQ_ORDERED(internal use flag) and WQ_HIGHPRI flags at the same time?
>>
>> Wouldn't alloc_ordered_workqueue(NAME, WQ_HIGHPRI, ...) do what you want?
> 
> That was my initial suggestion. Can WQ_HIGHPRI be used together with 
> WQ_MEMRECLAIM?
> 
> Regards,
> Arend
I was trying do that, but the comment of alloc_oredered_workqueue shows 
that only WQ_FREEZABLE and WQ_MEM_RECLAIM are meaningful, so...

I will measure the throughput with "alloc_ordered_workqueue(NAME, 
WQ_HIGHPRI, ...)" to see if WQ_HIGHPRI works with 
alloc_ordered_workqueue. Thanks for the suggestion.

---
/**
  * alloc_ordered_workqueue - allocate an ordered workqueue
  * @fmt: printf format for the name of the workqueue
  * @flags: WQ_* flags (only WQ_FREEZABLE and WQ_MEM_RECLAIM are meaningful)
  * @args...: args for @fmt
  *
...
  */
---

Regards,
Wright

  reply	other threads:[~2020-03-25 15:06 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-19  7:53 [PATCH 0/3] Add AP isolate support and two modules parameters Wright Feng
2020-03-19  7:53 ` [PATCH 1/3] brcmfmac: support AP isolate Wright Feng
2020-03-19  8:48   ` Arend Van Spriel
2020-03-20  8:04     ` Wright Feng
2020-03-19  7:53 ` [PATCH 2/3] brcmfmac: make firmware eap_restrict a module parameter Wright Feng
2020-03-19  8:28   ` Arend Van Spriel
2020-03-20  8:06     ` Wright Feng
2020-03-22 14:29       ` Kalle Valo
2020-03-19  7:53 ` [PATCH 3/3] brcmfmac: make setting SDIO workqueue WQ_HIGHPRI " Wright Feng
2020-03-19  8:55   ` Arend Van Spriel
2020-03-20  8:08     ` Wright Feng
2020-03-20  8:18       ` Arend Van Spriel
2020-03-20  9:01         ` Wright Feng
2020-03-24 18:23       ` Tejun Heo
2020-03-25  4:29         ` Wright Feng
2020-03-25 14:08           ` Tejun Heo
2020-03-25 14:53             ` Arend Van Spriel
2020-03-25 15:06               ` Wright Feng [this message]
2020-03-25 15:12                 ` Tejun Heo
2020-03-27  9:14                   ` Wright Feng
2020-04-03 14:59                     ` Tejun Heo
2020-03-25 15:10               ` Tejun Heo
2020-03-22 14:32   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1192351-6f72-6f82-bb2b-9f91266d8aab@cypress.com \
    --to=wright.feng@cypress.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=chi-hsien.lin@cypress.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox