From: Kalle Valo <kvalo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Ajay.Kathat@microchip.com, alexis.lothore@bootlin.com,
linux-wireless@vger.kernel.org, claudiu.beznea@tuxon.dev
Subject: Re: [PATCH] wifi: wilc1000: Keep slot powered on during suspend/resume
Date: Thu, 29 Aug 2024 19:32:02 +0300 [thread overview]
Message-ID: <874j73e1dp.fsf@kernel.org> (raw)
In-Reply-To: <12b79e2b-08ca-4ba0-8abb-6f1d0be65b3c@denx.de> (Marek Vasut's message of "Thu, 29 Aug 2024 17:38:12 +0200")
Marek Vasut <marex@denx.de> writes:
> Since this driver does not reload the firmware into the card on
> resume, the card has to be kept powered on during suspend/resume
> cycle. The card can NOT be powered off during suspend/resume cycle,
> otherwise the firmware is lost.
>
> Without this flag, the card may be powered off during suspend/resume
> cycle. It possibly does not happen on the Atmel controller, but it
> does on the STM32MP15xx ARM MMCI one.
>
> Now, since the card does consume about the same amount of power
> whether it is powered OFF or whether it is powered ON but suspended, I
> opt for the later option -- keep the card powered ON, suspend it, and
> that's what this patch does. This also allows us to support WoWlan
> then.
Are you also taking into account hibernation? During hibernation the
device will be powered off. I can't remember the details right now but
wanted to mention this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-08-29 16:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 18:37 [PATCH] wifi: wilc1000: Keep slot powered on during suspend/resume Marek Vasut
2024-08-27 9:53 ` Alexis Lothoré
2024-08-27 15:20 ` Marek Vasut
2024-08-28 7:42 ` Alexis Lothoré
2024-08-29 1:45 ` Ajay.Kathat
2024-08-29 2:45 ` Marek Vasut
2024-08-29 5:51 ` Ajay.Kathat
2024-08-29 15:38 ` Marek Vasut
2024-08-29 16:32 ` Kalle Valo [this message]
2024-08-29 22:23 ` Marek Vasut
2024-09-02 16:32 ` Kalle Valo
2024-09-02 16:43 ` Marek Vasut
2024-09-05 7:27 ` Kalle Valo
2024-09-06 18:23 ` Marek Vasut
2024-08-31 5:22 ` Ajay.Kathat
2024-08-31 21:18 ` Marek Vasut
2024-09-04 17:09 ` Ajay.Kathat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874j73e1dp.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Ajay.Kathat@microchip.com \
--cc=alexis.lothore@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox