Re: [PATCH] wifi: wilc1000: Keep slot powered on during suspend/resume

[Kalle Valo <kvalo@kernel.org>]

Marek Vasut <marex@denx.de> writes:

> On 8/29/24 6:32 PM, Kalle Valo wrote:
>> Marek Vasut <marex@denx.de> writes:
>> 
>>> Since this driver does not reload the firmware into the card on
>>> resume, the card has to be kept powered on during suspend/resume
>>> cycle. The card can NOT be powered off during suspend/resume cycle,
>>> otherwise the firmware is lost.
>>>
>>> Without this flag, the card may be powered off during suspend/resume
>>> cycle. It possibly does not happen on the Atmel controller, but it
>>> does on the STM32MP15xx ARM MMCI one.
>>>
>>> Now, since the card does consume about the same amount of power
>>> whether it is powered OFF or whether it is powered ON but suspended, I
>>> opt for the later option -- keep the card powered ON, suspend it, and
>>> that's what this patch does. This also allows us to support WoWlan
>>> then.
>> Are you also taking into account hibernation? During hibernation the
>> device will be powered off. I can't remember the details right now but
>> wanted to mention this.
>
> I don't think I am. Isn't hibernation actually a full shutdown, so the
> hardware does get reinitialized ?

I don't know how it works exactly nor what you exactly mean with
reinitalized. But at least with ath11k hibernation didn't work when it
left the firmware running during suspend.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html