* [PATCH] wlcore: fix return value of wlcore_event_fw_logger
@ 2016-01-18 9:35 Guy Mishol
2016-01-21 13:52 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Guy Mishol @ 2016-01-18 9:35 UTC (permalink / raw)
To: linux-wireless; +Cc: Guy Mishol
The function can return negative values in case of error.
Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio")
Signed-off-by: Guy Mishol <guym@ti.com>
---
drivers/net/wireless/ti/wlcore/event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/ti/wlcore/event.c
index c964054..4b59f67 100644
--- a/drivers/net/wireless/ti/wlcore/event.c
+++ b/drivers/net/wireless/ti/wlcore/event.c
@@ -38,7 +38,7 @@
int wlcore_event_fw_logger(struct wl1271 *wl)
{
- u32 ret;
+ int ret;
struct fw_logger_information fw_log;
u8 *buffer;
u32 internal_fw_addrbase = WL18XX_DATA_RAM_BASE_ADDRESS;
--
2.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] wlcore: fix return value of wlcore_event_fw_logger 2016-01-18 9:35 [PATCH] wlcore: fix return value of wlcore_event_fw_logger Guy Mishol @ 2016-01-21 13:52 ` Kalle Valo 2016-01-21 13:54 ` Mishol, Guy 0 siblings, 1 reply; 3+ messages in thread From: Kalle Valo @ 2016-01-21 13:52 UTC (permalink / raw) To: Guy Mishol; +Cc: linux-wireless Guy Mishol <guym@ti.com> writes: > The function can return negative values in case of error. > Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") > > Signed-off-by: Guy Mishol <guym@ti.com> Andrzej already submitted identical patch: https://patchwork.kernel.org/patch/7977461/ So I'm dropping this. -- Kalle Valo ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wlcore: fix return value of wlcore_event_fw_logger 2016-01-21 13:52 ` Kalle Valo @ 2016-01-21 13:54 ` Mishol, Guy 0 siblings, 0 replies; 3+ messages in thread From: Mishol, Guy @ 2016-01-21 13:54 UTC (permalink / raw) To: Kalle Valo; +Cc: linux-wireless@vger.kernel.org Cool. Thanks! Sent from my iPhone > On Jan 21, 2016, at 15:52, Kalle Valo <kvalo@codeaurora.org> wrote: > > Guy Mishol <guym@ti.com> writes: > >> The function can return negative values in case of error. >> Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") >> >> Signed-off-by: Guy Mishol <guym@ti.com> > > Andrzej already submitted identical patch: > > https://patchwork.kernel.org/patch/7977461/ > > So I'm dropping this. > > -- > Kalle Valo ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-21 13:54 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-18 9:35 [PATCH] wlcore: fix return value of wlcore_event_fw_logger Guy Mishol 2016-01-21 13:52 ` Kalle Valo 2016-01-21 13:54 ` Mishol, Guy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox