Re: [PATCH 5/5] ath6kl: fix crash when interface is closed but scan is ongoing

[Kalle Valo <kvalo@adurom.com>]

Dan Carpenter <error27@gmail.com> writes:

> On Mon, Jun 13, 2011 at 10:52:33AM +0300, Kalle Valo wrote:
>> Dan Carpenter <error27@gmail.com> writes:
>> 
>> > On Thu, Jun 09, 2011 at 04:23:36PM +0300, Kalle Valo wrote:
>> >> I only combined the pending ath6kl patches, I did not edit them.
>> >> Vasanth sent patch 4 few days earlier and that's why you see the
>> >> change here. But if greg wants, I can drop patch 4 and resend the
>> >> series.
>> >
>> > Part of the problem is that patch doesn't add the check for NULL
>> > consistently throughout the function.  There is a place where a NULL
>> > deref could still be triggered later on.  Let's just drop it instead
>> > of fixing it.
>> 
>> Agreed.
>> 
>> But I see that Greg applied the patch 4 already. So I just drop patch
>> 4 from my patchset and resend patch 5 as is (ie. removing the
>> unnecessary null check).
>
> Yep.  It really should go the 3.0 kernel along with [PATCH 3/5]
> ath6kl: cache firmware.

Thanks, I'll mention this in the cover letter. I'll also change the
order of patches so that the most important patches are first.

Thanks for all the review and help.

-- 
Kalle Valo