Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@adurom.com>
To: Dan Carpenter <error27@gmail.com>
Cc: gregkh@suse.de, devel@linuxdriverproject.org,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5/5] ath6kl: fix crash when interface is closed but scan is ongoing
Date: Thu, 09 Jun 2011 16:23:36 +0300	[thread overview]
Message-ID: <87sjrj6svb.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20110608201458.GD4069@shale.localdomain> (Dan Carpenter's message of "Wed\, 8 Jun 2011 23\:14\:58 +0300")

Dan Carpenter <error27@gmail.com> writes:

> On Wed, Jun 08, 2011 at 11:03:32PM +0300, Dan Carpenter wrote:
>> On Wed, Jun 08, 2011 at 02:55:01PM +0300, Kalle Valo wrote:
>> > -        /* Translate data to cfg80211 mgmt format */
>> > -	if (ar->arWmi)
>>             ^^^^^^^^^
>> 	You removed this check on purpose?  Is this only NULL when
>> 	the scan is canceled?
>
> Grr...  That's the check that was just added in [PATCH 4/4] of this
> exact same series!  Seriously?  Why are we submitting known wrong
> patches???

I only combined the pending ath6kl patches, I did not edit them.
Vasanth sent patch 4 few days earlier and that's why you see the
change here. But if greg wants, I can drop patch 4 and resend the
series.

But now that you mention this, I realise that my sob line is missing
from patch 4 as well.

-- 
Kalle Valo

  reply	other threads:[~2011-06-09 13:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 11:54 [PATCH 0/5] ath6kl: staging fixes Kalle Valo
2011-06-08 11:54 ` [PATCH 1/5] ath6kl: export firmware version to user space Kalle Valo
2011-06-08 11:54 ` [PATCH 2/5] ath6kl: testmode support Kalle Valo
2011-06-08 19:46   ` Dan Carpenter
2011-06-09 13:02     ` Kalle Valo
2011-06-08 11:54 ` [PATCH 3/5] ath6kl: cache firmware Kalle Valo
2011-06-08 19:44   ` Dan Carpenter
2011-06-09 13:14     ` Kalle Valo
2011-06-09 15:42       ` Dan Carpenter
2011-06-09 20:46         ` Dan Carpenter
2011-06-13  7:49         ` Kalle Valo
2011-06-08 11:54 ` [PATCH 4/5] ath6kl: Fix a kernel panic furing suspend/resume Kalle Valo
2011-06-08 11:55 ` [PATCH 5/5] ath6kl: fix crash when interface is closed but scan is ongoing Kalle Valo
2011-06-08 20:03   ` Dan Carpenter
2011-06-08 20:14     ` Dan Carpenter
2011-06-09 13:23       ` Kalle Valo [this message]
2011-06-09 15:24         ` Dan Carpenter
2011-06-13  7:52           ` Kalle Valo
2011-06-13  7:55             ` Dan Carpenter
2011-06-13  8:03               ` Kalle Valo
2011-06-13  8:18                 ` Dan Carpenter
2011-06-13  8:21                   ` Kalle Valo
2011-06-09 13:19     ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjrj6svb.fsf@purkki.adurom.net \
    --to=kvalo@adurom.com \
    --cc=devel@linuxdriverproject.org \
    --cc=error27@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox