* [PATCH] [trivial] nl80211: fix typos in comments
@ 2012-05-07 9:21 Zefir Kurtisi
2012-05-07 9:35 ` Kalle Valo
0 siblings, 1 reply; 5+ messages in thread
From: Zefir Kurtisi @ 2012-05-07 9:21 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Zefir Kurtisi
Signed-off-by: Zefir Kurtisi <zefir.kurtisi@neratec.com>
---
include/linux/nl80211.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
index 2540e86..f296a64 100644
--- a/include/linux/nl80211.h
+++ b/include/linux/nl80211.h
@@ -1994,9 +1994,9 @@ enum nl80211_reg_rule_flags {
* enum nl80211_dfs_regions - regulatory DFS regions
*
* @NL80211_DFS_UNSET: Country has no DFS master region specified
- * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
- * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
- * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
+ * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
+ * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
+ * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
*/
enum nl80211_dfs_regions {
NL80211_DFS_UNSET = 0,
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] [trivial] nl80211: fix typos in comments
2012-05-07 9:21 [PATCH] [trivial] nl80211: fix typos in comments Zefir Kurtisi
@ 2012-05-07 9:35 ` Kalle Valo
2012-05-07 9:41 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2012-05-07 9:35 UTC (permalink / raw)
To: Zefir Kurtisi; +Cc: linville, linux-wireless
Zefir Kurtisi <zefir.kurtisi@neratec.com> writes:
> - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
> - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
> - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
> + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
> + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
> + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
Are there any user space applications which use these enums? If there are,
this change will break them which is bad (tm).
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [trivial] nl80211: fix typos in comments
2012-05-07 9:35 ` Kalle Valo
@ 2012-05-07 9:41 ` Johannes Berg
2012-05-07 9:45 ` Zefir Kurtisi
2012-05-07 9:46 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Johannes Berg @ 2012-05-07 9:41 UTC (permalink / raw)
To: Kalle Valo; +Cc: Zefir Kurtisi, linville, linux-wireless
On Mon, 2012-05-07 at 12:35 +0300, Kalle Valo wrote:
> Zefir Kurtisi <zefir.kurtisi@neratec.com> writes:
>
> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
> > - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
> > + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
> > + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
> > + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
>
> Are there any user space applications which use these enums? If there are,
> this change will break them which is bad (tm).
No, it actually just fixes kernel-doc .. the constant names are spelled
wrong in the comment.
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [trivial] nl80211: fix typos in comments
2012-05-07 9:41 ` Johannes Berg
@ 2012-05-07 9:45 ` Zefir Kurtisi
2012-05-07 9:46 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Zefir Kurtisi @ 2012-05-07 9:45 UTC (permalink / raw)
To: Johannes Berg; +Cc: Kalle Valo, linville, linux-wireless
On 05/07/2012 11:41 AM, Johannes Berg wrote:
> On Mon, 2012-05-07 at 12:35 +0300, Kalle Valo wrote:
>> Zefir Kurtisi <zefir.kurtisi@neratec.com> writes:
>>
>>> - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
>>> - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
>>> - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
>>> + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
>>> + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
>>> + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
>>
>> Are there any user space applications which use these enums? If there are,
>> this change will break them which is bad (tm).
>
> No, it actually just fixes kernel-doc .. the constant names are spelled
> wrong in the comment.
>
> johannes
>
Yep, 'trivial' since only C&P typos fixed. Or is there a better tag for
non functional modifications (comments, indentation, etc.)?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] [trivial] nl80211: fix typos in comments
2012-05-07 9:41 ` Johannes Berg
2012-05-07 9:45 ` Zefir Kurtisi
@ 2012-05-07 9:46 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2012-05-07 9:46 UTC (permalink / raw)
To: Johannes Berg; +Cc: Zefir Kurtisi, linville, linux-wireless
Johannes Berg <johannes@sipsolutions.net> writes:
> On Mon, 2012-05-07 at 12:35 +0300, Kalle Valo wrote:
>> Zefir Kurtisi <zefir.kurtisi@neratec.com> writes:
>>
>> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
>> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
>> > - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
>> > + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
>> > + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
>> > + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
>>
>> Are there any user space applications which use these enums? If there are,
>> this change will break them which is bad (tm).
>
> No, it actually just fixes kernel-doc .. the constant names are spelled
> wrong in the comment.
Hah, I was blind again. I blame Monday morning for this ;)
Sorry for the noise.
--
Kalle Valo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-05-07 9:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-07 9:21 [PATCH] [trivial] nl80211: fix typos in comments Zefir Kurtisi
2012-05-07 9:35 ` Kalle Valo
2012-05-07 9:41 ` Johannes Berg
2012-05-07 9:45 ` Zefir Kurtisi
2012-05-07 9:46 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox