* [PATCH v4 0/3] wifi: ath12k: prepare vif and sta datastructure
@ 2024-06-17 13:16 Rameshkumar Sundaram
2024-06-17 13:16 ` [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling Rameshkumar Sundaram
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Rameshkumar Sundaram @ 2024-06-17 13:16 UTC (permalink / raw)
To: ath12k; +Cc: linux-wireless, Rameshkumar Sundaram
To prepare the driver for MLO support, split the driver vif and sta
data structure to scale for multiple links. This requires changing
the use of arvif and arsta to per link and not per hw which can now
comprise of multiple links.
Also since most configurations from mac80211 are done per link,
do refactoring of the driver functions to apply these configurations
at link level.
Add the required locking changes to synchronize the usage of these
per link objects.
---
v4:
- Extensive rebase on PATCH 1/3 on ToT as MBSSID changes are
introduced since v3.
v3:
- Rebased on ToT
v2:
- Rebased PATCH 1/3 on ToT as b0afabc4d7e0 (wifi: ath12k: add support to
handle beacon miss for WCN7850) has introduced few APIs that use
arvif.
Sriram R (3):
wifi: ath12k: prepare vif data structure for MLO handling
wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif
wifi: ath12k: prepare sta data structure for MLO handling
drivers/net/wireless/ath/ath12k/core.h | 89 ++-
drivers/net/wireless/ath/ath12k/dp.c | 21 +-
drivers/net/wireless/ath/ath12k/dp.h | 3 +-
drivers/net/wireless/ath/ath12k/dp_mon.c | 14 +-
drivers/net/wireless/ath/ath12k/dp_rx.c | 16 +-
drivers/net/wireless/ath/ath12k/dp_rx.h | 2 +-
drivers/net/wireless/ath/ath12k/dp_tx.c | 9 +-
drivers/net/wireless/ath/ath12k/dp_tx.h | 2 +-
drivers/net/wireless/ath/ath12k/mac.c | 921 +++++++++++++++--------
drivers/net/wireless/ath/ath12k/mac.h | 9 +-
drivers/net/wireless/ath/ath12k/p2p.c | 17 +-
drivers/net/wireless/ath/ath12k/p2p.h | 2 +-
drivers/net/wireless/ath/ath12k/peer.c | 7 +-
drivers/net/wireless/ath/ath12k/peer.h | 4 +-
drivers/net/wireless/ath/ath12k/wmi.c | 12 +-
15 files changed, 728 insertions(+), 400 deletions(-)
base-commit: e72048809ec7355a947415ae6836d2eb7fdcda39
--
2.34.1
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling 2024-06-17 13:16 [PATCH v4 0/3] wifi: ath12k: prepare vif and sta datastructure Rameshkumar Sundaram @ 2024-06-17 13:16 ` Rameshkumar Sundaram 2024-06-18 7:47 ` Baochen Qiang 2024-06-17 13:16 ` [PATCH v4 2/3] wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram 2 siblings, 1 reply; 11+ messages in thread From: Rameshkumar Sundaram @ 2024-06-17 13:16 UTC (permalink / raw) To: ath12k; +Cc: linux-wireless, Sriram R, Rameshkumar Sundaram From: Sriram R <quic_srirrama@quicinc.com> To prepare the driver for MLO support, split the driver vif data structure to scale for multiple links. This requires changing the use of arvif to per link and not per hw which can now comprise of multiple links. Also since most configurations from mac80211 are done per link, do refactoring of the driver functions to apply these configurations at link level. Split ath12k_vif which is the driver private of ieee80211_vif to store link specific information as ath12k_link_vif. For default use cases the ath12k vif will have a preallocated link vif called deflink which will be used by non ML and the first link vif of ML vif. With MLO Support to be added, remaining link vifs will be allocated during channel assignment where vdev create/start happens. These link vifs will be freed during interface down. Current ath12k_vif(arvif) structure +---------------+ +---------------+ +---------------+ | ieee80211_vif | | ieee80211_vif | | ieee80211_vif | | private data | | private data | | private data | | | | | | | | ath12k_vif | | ath12k_vif | | ath12k_vif | | (arvif) | | (arvif) | | (arvif) | | | | | | | | +----------+ | | +----------+ | | +----------+ | | |*ar (2GHz)| | | |*ar (5GHz)| | | |*ar (2GHz)| | | +----------+ | | +----------+ | | +----------+ | | | | | | | +---------------+ +---------------+ +---------------+ Proposed ath12k_vif(ahvif) containing ath12k_link_vif(s) (arvif) (deflink is preallocated member which is always the first link if ieee80211_vif is MLD and is the only link otherwise) +---------------------------------+ | ieee80211_vif | | private data | | | | ath12k_vif(ahvif) | | | | +-------------------------------+ | |ath12k_link_vif deflink (arvif)| | | +---------------+ | | | | *ar(2GHz) | | | +-------------------------------+ | +-------------------------------+ | | ath12k_link_vif *link (arvif)| | | +---------------+ | | | | *ar(5GHz) | | | +-------------------------------+ | +-------------------------------+ | | ath12k_link_vif *link (arvif)| | | +---------------+ | | | | *ar(6GHz) | | | +-------------------------------+ | | +---------------------------------+ To refactor existing ath12k_vif to make use of link vifs, following changes are made, 1. ath12k_vif now called by variable name ahvif stores multiple arvifs(ah12k_link_vif) and also has a back pointer to ieee80211_vif. 2. In this patch set, only deflink is used to be on par with the existing code. When MLO support is added the link id will be used to fetch the arvif. 3. For mac80211 ops which doesn't use specific link_id, the config or info is common for the vif, hence apply the config to all link vifs. The links_map in the ahvif, will be used to identify all the link vifs that are setup. 4. Change ath12k_vif_to_arvif() as ath12k_vif_to_ahvif() to fetch the hw level vif. The link vif can be fetched from ahvif->link[], or the deflink can be accessed via ahvif->deflink. API to access link vif(arvif) by passing link_id can be introduced with MLO Support. 5. The ieee80211_vif can be accessed from ahvif using ath12k_vif_to_vif() Locking: Currently modifications to members of arvif and arsta are protected by ar->conf_mutex and it stays as such. Now with these hw level structure (ahvif) being introduced, any modifications to its members and link objects (i.e., arvifs[] which are dynamically allocated) needs to be protected for writing and ah->conf_mutex is used for the same. Also, atomic contexts(say WMI events and certain mac_ops) that we currently have in driver will not(shouldn't be allowed) do any modifications but can read them and rcu_read_lock() is used for the same. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: Sriram R <quic_srirrama@quicinc.com> Co-developed-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> --- drivers/net/wireless/ath/ath12k/core.h | 69 ++- drivers/net/wireless/ath/ath12k/dp.c | 21 +- drivers/net/wireless/ath/ath12k/dp.h | 3 +- drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +- drivers/net/wireless/ath/ath12k/dp_rx.h | 2 +- drivers/net/wireless/ath/ath12k/dp_tx.c | 9 +- drivers/net/wireless/ath/ath12k/dp_tx.h | 2 +- drivers/net/wireless/ath/ath12k/mac.c | 733 ++++++++++++++++-------- drivers/net/wireless/ath/ath12k/mac.h | 9 +- drivers/net/wireless/ath/ath12k/p2p.c | 17 +- drivers/net/wireless/ath/ath12k/p2p.h | 2 +- drivers/net/wireless/ath/ath12k/peer.c | 7 +- drivers/net/wireless/ath/ath12k/peer.h | 4 +- drivers/net/wireless/ath/ath12k/wmi.c | 12 +- 14 files changed, 592 insertions(+), 300 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h index b483899ca136..d47b6413aaad 100644 --- a/drivers/net/wireless/ath/ath12k/core.h +++ b/drivers/net/wireless/ath/ath12k/core.h @@ -229,10 +229,8 @@ struct ath12k_vif_cache { u32 bss_conf_changed; }; -struct ath12k_vif { +struct ath12k_link_vif { u32 vdev_id; - enum wmi_vdev_type vdev_type; - enum wmi_vdev_subtype vdev_subtype; u32 beacon_interval; u32 dtim_period; u16 ast_hash; @@ -242,13 +240,38 @@ struct ath12k_vif { u8 search_type; struct ath12k *ar; - struct ieee80211_vif *vif; int bank_id; u8 vdev_id_check_en; struct wmi_wmm_params_all_arg wmm_params; struct list_head list; + + bool is_created; + bool is_started; + bool is_up; + u8 bssid[ETH_ALEN]; + struct cfg80211_bitrate_mask bitrate_mask; + struct delayed_work connection_loss_work; + int num_legacy_stations; + int rtscts_prot_mode; + int txpower; + bool rsnie_present; + bool wpaie_present; + struct ieee80211_chanctx_conf chanctx; + u8 vdev_stats_id; + u32 punct_bitmap; + u8 link_id; + struct ath12k_vif *ahvif; + struct ath12k_vif_cache *cache; +}; + +struct ath12k_vif { + enum wmi_vdev_type vdev_type; + enum wmi_vdev_subtype vdev_subtype; + struct ieee80211_vif *vif; + struct ath12k_hw *ah; + union { struct { u32 uapsd; @@ -266,31 +289,21 @@ struct ath12k_vif { } ap; } u; - bool is_created; - bool is_started; - bool is_up; u32 aid; - u8 bssid[ETH_ALEN]; - struct cfg80211_bitrate_mask bitrate_mask; - struct delayed_work connection_loss_work; - int num_legacy_stations; - int rtscts_prot_mode; - int txpower; - bool rsnie_present; - bool wpaie_present; - struct ieee80211_chanctx_conf chanctx; u32 key_cipher; u8 tx_encap_type; - u8 vdev_stats_id; - u32 punct_bitmap; bool ps; - struct ath12k_vif_cache *cache; + + struct ath12k_link_vif deflink; + struct ath12k_link_vif __rcu *link[IEEE80211_MLD_MAX_NUM_LINKS]; + /* indicates bitmap of link vif created in FW */ + u16 links_map; }; struct ath12k_vif_iter { u32 vdev_id; struct ath12k *ar; - struct ath12k_vif *arvif; + struct ath12k_link_vif *arvif; }; #define HAL_AST_IDX_INVALID 0xFFFF @@ -426,7 +439,7 @@ struct ath12k_wbm_tx_stats { }; struct ath12k_sta { - struct ath12k_vif *arvif; + struct ath12k_link_vif *arvif; /* the following are protected by ar->data_lock */ u32 changed; /* IEEE80211_RC_* */ @@ -543,7 +556,7 @@ struct ath12k { */ struct mutex conf_mutex; /* protects the radio specific data like debug stats, ppdu_stats_info stats, - * vdev_stop_status info, scan data, ath12k_sta info, ath12k_vif info, + * vdev_stop_status info, scan data, ath12k_sta info, ath12k_link_vif info, * channel context data, survey info, test mode data. */ spinlock_t data_lock; @@ -639,6 +652,11 @@ struct ath12k_hw { enum ath12k_hw_state state; bool regd_updated; bool use_6ghz_regd; + + /* To synchronize concurrent access of ahvif->link[] + * between mac80211 operations. + */ + struct mutex conf_mutex; u8 num_radio; /* Keep last */ @@ -995,7 +1013,7 @@ static inline struct ath12k_skb_rxcb *ATH12K_SKB_RXCB(struct sk_buff *skb) return (struct ath12k_skb_rxcb *)skb->cb; } -static inline struct ath12k_vif *ath12k_vif_to_arvif(struct ieee80211_vif *vif) +static inline struct ath12k_vif *ath12k_vif_to_ahvif(struct ieee80211_vif *vif) { return (struct ath12k_vif *)vif->drv_priv; } @@ -1005,6 +1023,11 @@ static inline struct ath12k_sta *ath12k_sta_to_arsta(struct ieee80211_sta *sta) return (struct ath12k_sta *)sta->drv_priv; } +static inline struct ieee80211_vif *ath12k_vif_to_vif(struct ath12k_vif *ahvif) +{ + return container_of((void *)ahvif, struct ieee80211_vif, drv_priv); +} + static inline struct ath12k *ath12k_ab_to_ar(struct ath12k_base *ab, int mac_id) { diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c index 61aa78d8bd8c..30aac0dd5a80 100644 --- a/drivers/net/wireless/ath/ath12k/dp.c +++ b/drivers/net/wireless/ath/ath12k/dp.c @@ -327,20 +327,22 @@ int ath12k_dp_srng_setup(struct ath12k_base *ab, struct dp_srng *ring, } static -u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, struct ath12k_vif *arvif) +u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, + struct ath12k_link_vif *arvif) { u32 bank_config = 0; + struct ath12k_vif *ahvif = arvif->ahvif; /* Only valid for raw frames with HW crypto enabled. * With SW crypto, mac80211 sets key per packet */ - if (arvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && + if (ahvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags)) bank_config |= - u32_encode_bits(ath12k_dp_tx_get_encrypt_type(arvif->key_cipher), + u32_encode_bits(ath12k_dp_tx_get_encrypt_type(ahvif->key_cipher), HAL_TX_BANK_CONFIG_ENCRYPT_TYPE); - bank_config |= u32_encode_bits(arvif->tx_encap_type, + bank_config |= u32_encode_bits(ahvif->tx_encap_type, HAL_TX_BANK_CONFIG_ENCAP_TYPE); bank_config |= u32_encode_bits(0, HAL_TX_BANK_CONFIG_SRC_BUFFER_SWAP) | u32_encode_bits(0, HAL_TX_BANK_CONFIG_LINK_META_SWAP) | @@ -355,7 +357,7 @@ u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, struct ath12k_vif HAL_TX_ADDRY_EN), HAL_TX_BANK_CONFIG_ADDRY_EN); - bank_config |= u32_encode_bits(ieee80211_vif_is_mesh(arvif->vif) ? 3 : 0, + bank_config |= u32_encode_bits(ieee80211_vif_is_mesh(ahvif->vif) ? 3 : 0, HAL_TX_BANK_CONFIG_MESH_EN) | u32_encode_bits(arvif->vdev_id_check_en, HAL_TX_BANK_CONFIG_VDEV_ID_CHECK_EN); @@ -365,7 +367,8 @@ u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, struct ath12k_vif return bank_config; } -static int ath12k_dp_tx_get_bank_profile(struct ath12k_base *ab, struct ath12k_vif *arvif, +static int ath12k_dp_tx_get_bank_profile(struct ath12k_base *ab, + struct ath12k_link_vif *arvif, struct ath12k_dp *dp) { int bank_id = DP_INVALID_BANK_ID; @@ -1099,9 +1102,9 @@ int ath12k_dp_htt_connect(struct ath12k_dp *dp) return 0; } -static void ath12k_dp_update_vdev_search(struct ath12k_vif *arvif) +static void ath12k_dp_update_vdev_search(struct ath12k_link_vif *arvif) { - switch (arvif->vdev_type) { + switch (arvif->ahvif->vdev_type) { case WMI_VDEV_TYPE_STA: /* TODO: Verify the search type and flags since ast hash * is not part of peer mapv3 @@ -1120,7 +1123,7 @@ static void ath12k_dp_update_vdev_search(struct ath12k_vif *arvif) } } -void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_vif *arvif) +void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_link_vif *arvif) { struct ath12k_base *ab = ar->ab; diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h index 742094545089..4161486e98ab 100644 --- a/drivers/net/wireless/ath/ath12k/dp.h +++ b/drivers/net/wireless/ath/ath12k/dp.h @@ -16,6 +16,7 @@ struct ath12k_base; struct ath12k_peer; struct ath12k_dp; struct ath12k_vif; +struct ath12k_link_vif; struct hal_tcl_status_ring; struct ath12k_ext_irq_grp; @@ -1810,7 +1811,7 @@ int ath12k_dp_service_srng(struct ath12k_base *ab, struct ath12k_ext_irq_grp *irq_grp, int budget); int ath12k_dp_htt_connect(struct ath12k_dp *dp); -void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_vif *arvif); +void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_link_vif *arvif); void ath12k_dp_free(struct ath12k_base *ab); int ath12k_dp_alloc(struct ath12k_base *ab); void ath12k_dp_cc_config(struct ath12k_base *ab); diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c index 54aea3c22311..781cb7af8cf0 100644 --- a/drivers/net/wireless/ath/ath12k/dp_rx.c +++ b/drivers/net/wireless/ath/ath12k/dp_rx.c @@ -1090,7 +1090,7 @@ int ath12k_dp_rx_ampdu_stop(struct ath12k *ar, return ret; } -int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_vif *arvif, +int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_link_vif *arvif, const u8 *peer_addr, enum set_key_cmd key_cmd, struct ieee80211_key_conf *key) diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.h b/drivers/net/wireless/ath/ath12k/dp_rx.h index 2ff421160181..8c1bccc4f0f0 100644 --- a/drivers/net/wireless/ath/ath12k/dp_rx.h +++ b/drivers/net/wireless/ath/ath12k/dp_rx.h @@ -88,7 +88,7 @@ int ath12k_dp_rx_ampdu_start(struct ath12k *ar, struct ieee80211_ampdu_params *params); int ath12k_dp_rx_ampdu_stop(struct ath12k *ar, struct ieee80211_ampdu_params *params); -int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_vif *arvif, +int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_link_vif *arvif, const u8 *peer_addr, enum set_key_cmd key_cmd, struct ieee80211_key_conf *key); diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c index c4cfa7cf7cb9..fb5de5c2794d 100644 --- a/drivers/net/wireless/ath/ath12k/dp_tx.c +++ b/drivers/net/wireless/ath/ath12k/dp_tx.c @@ -10,7 +10,7 @@ #include "hw.h" static enum hal_tcl_encap_type -ath12k_dp_tx_get_encap_type(struct ath12k_vif *arvif, struct sk_buff *skb) +ath12k_dp_tx_get_encap_type(struct ath12k_link_vif *arvif, struct sk_buff *skb) { struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb); struct ath12k_base *ab = arvif->ar->ab; @@ -162,7 +162,7 @@ static int ath12k_dp_prepare_htt_metadata(struct sk_buff *skb) return 0; } -int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, +int ath12k_dp_tx(struct ath12k *ar, struct ath12k_link_vif *arvif, struct sk_buff *skb) { struct ath12k_base *ab = ar->ab; @@ -176,6 +176,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, struct sk_buff *skb_ext_desc; struct hal_srng *tcl_ring; struct ieee80211_hdr *hdr = (void *)skb->data; + struct ath12k_vif *ahvif = arvif->ahvif; struct dp_tx_ring *tx_ring; u8 pool_id; u8 hal_ring_id; @@ -219,7 +220,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, ti.bank_id = arvif->bank_id; ti.meta_data_flags = arvif->tcl_metadata; - if (arvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && + if (ahvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ar->ab->dev_flags)) { if (skb_cb->flags & ATH12K_SKB_CIPHER_SET) { ti.encrypt_type = @@ -304,7 +305,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, ti.desc_id = tx_desc->desc_id; ti.data_len = skb->len; skb_cb->paddr = ti.paddr; - skb_cb->vif = arvif->vif; + skb_cb->vif = ahvif->vif; skb_cb->ar = ar; if (msdu_ext_desc) { diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.h b/drivers/net/wireless/ath/ath12k/dp_tx.h index 55ff8cc721e3..46dce23501f3 100644 --- a/drivers/net/wireless/ath/ath12k/dp_tx.h +++ b/drivers/net/wireless/ath/ath12k/dp_tx.h @@ -16,7 +16,7 @@ struct ath12k_dp_htt_wbm_tx_status { }; int ath12k_dp_tx_htt_h2t_ver_req_msg(struct ath12k_base *ab); -int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, +int ath12k_dp_tx(struct ath12k *ar, struct ath12k_link_vif *arvif, struct sk_buff *skb); void ath12k_dp_tx_completion_handler(struct ath12k_base *ab, int ring_id); diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 2259ce22cc8b..8bd8efcc1264 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -247,7 +247,7 @@ static const u32 ath12k_smps_map[] = { }; static int ath12k_start_vdev_delay(struct ath12k *ar, - struct ath12k_vif *arvif); + struct ath12k_link_vif *arvif); static void ath12k_mac_stop(struct ath12k *ar); static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif); static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif); @@ -536,18 +536,22 @@ static void ath12k_get_arvif_iter(void *data, u8 *mac, struct ieee80211_vif *vif) { struct ath12k_vif_iter *arvif_iter = data; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif = &ahvif->deflink; if (arvif->vdev_id == arvif_iter->vdev_id && arvif->ar == arvif_iter->ar) arvif_iter->arvif = arvif; } -struct ath12k_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id) +struct ath12k_link_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id) { struct ath12k_vif_iter arvif_iter = {}; u32 flags; + /* To use the arvif returned, caller must have held rcu read lock. + */ + WARN_ON(!rcu_read_lock_any_held()); arvif_iter.vdev_id = vdev_id; arvif_iter.ar = ar; @@ -564,12 +568,12 @@ struct ath12k_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id) return arvif_iter.arvif; } -struct ath12k_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, - u32 vdev_id) +struct ath12k_link_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, + u32 vdev_id) { int i; struct ath12k_pdev *pdev; - struct ath12k_vif *arvif; + struct ath12k_link_vif *arvif; for (i = 0; i < ab->num_radios; i++) { pdev = rcu_dereference(ab->pdevs_active[i]); @@ -655,7 +659,8 @@ static struct ath12k *ath12k_get_ar_by_ctx(struct ieee80211_hw *hw, static struct ath12k *ath12k_get_ar_by_vif(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif = &ahvif->deflink; struct ath12k_hw *ah = ath12k_hw_to_ah(hw); /* If there is one pdev within ah, then we return @@ -691,7 +696,7 @@ static void ath12k_pdev_caps_update(struct ath12k *ar) static int ath12k_mac_txpower_recalc(struct ath12k *ar) { struct ath12k_pdev *pdev = ar->pdev; - struct ath12k_vif *arvif; + struct ath12k_link_vif *arvif; int ret, txpower = -1; u32 param; @@ -745,7 +750,7 @@ static int ath12k_mac_txpower_recalc(struct ath12k *ar) return ret; } -static int ath12k_recalc_rtscts_prot(struct ath12k_vif *arvif) +static int ath12k_recalc_rtscts_prot(struct ath12k_link_vif *arvif) { struct ath12k *ar = arvif->ar; u32 vdev_param, rts_cts; @@ -784,7 +789,7 @@ static int ath12k_recalc_rtscts_prot(struct ath12k_vif *arvif) return ret; } -static int ath12k_mac_set_kickout(struct ath12k_vif *arvif) +static int ath12k_mac_set_kickout(struct ath12k_link_vif *arvif) { struct ath12k *ar = arvif->ar; u32 param; @@ -1147,8 +1152,9 @@ static int ath12k_mac_monitor_stop(struct ath12k *ar) return ret; } -static int ath12k_mac_vdev_stop(struct ath12k_vif *arvif) +static int ath12k_mac_vdev_stop(struct ath12k_link_vif *arvif) { + struct ath12k_vif *ahvif = arvif->ahvif; struct ath12k *ar = arvif->ar; int ret; @@ -1174,7 +1180,7 @@ static int ath12k_mac_vdev_stop(struct ath12k_vif *arvif) ar->num_started_vdevs--; ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "vdev %pM stopped, vdev_id %d\n", - arvif->vif->addr, arvif->vdev_id); + ahvif->vif->addr, arvif->vdev_id); if (test_bit(ATH12K_CAC_RUNNING, &ar->dev_flags)) { clear_bit(ATH12K_CAC_RUNNING, &ar->dev_flags); @@ -1242,7 +1248,7 @@ static int ath12k_mac_op_config(struct ieee80211_hw *hw, u32 changed) return ret; } -static int ath12k_mac_setup_bcn_p2p_ie(struct ath12k_vif *arvif, +static int ath12k_mac_setup_bcn_p2p_ie(struct ath12k_link_vif *arvif, struct sk_buff *bcn) { struct ath12k *ar = arvif->ar; @@ -1299,7 +1305,7 @@ static int ath12k_mac_remove_vendor_ie(struct sk_buff *skb, unsigned int oui, return 0; } -static void ath12k_mac_set_arvif_ies(struct ath12k_vif *arvif, struct sk_buff *bcn, +static void ath12k_mac_set_arvif_ies(struct ath12k_link_vif *arvif, struct sk_buff *bcn, u8 bssid_index, bool *nontx_profile_found) { struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)bcn->data; @@ -1391,19 +1397,22 @@ static void ath12k_mac_set_arvif_ies(struct ath12k_vif *arvif, struct sk_buff *b } } -static int ath12k_mac_setup_bcn_tmpl_ema(struct ath12k_vif *arvif) +static int ath12k_mac_setup_bcn_tmpl_ema(struct ath12k_link_vif *arvif) { - struct ieee80211_bss_conf *bss_conf = &arvif->vif->bss_conf; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_bss_conf *bss_conf = &ahvif->vif->bss_conf; struct ath12k_wmi_bcn_tmpl_ema_arg ema_args; struct ieee80211_ema_beacons *beacons; - struct ath12k_vif *tx_arvif; + struct ath12k_link_vif *tx_arvif; bool nontx_profile_found = false; + struct ath12k_vif *tx_ahvif; int ret = 0; u8 i; - tx_arvif = ath12k_vif_to_arvif(arvif->vif->mbssid_tx_vif); + tx_ahvif = ath12k_vif_to_ahvif(ahvif->vif->mbssid_tx_vif); + tx_arvif = &tx_ahvif->deflink; beacons = ieee80211_beacon_get_template_ema_list(ath12k_ar_to_hw(tx_arvif->ar), - tx_arvif->vif, 0); + tx_ahvif->vif, 0); if (!beacons || !beacons->cnt) { ath12k_warn(arvif->ar->ab, "failed to get ema beacon templates from mac80211\n"); @@ -1441,22 +1450,25 @@ static int ath12k_mac_setup_bcn_tmpl_ema(struct ath12k_vif *arvif) return ret; } -static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) +static int ath12k_mac_setup_bcn_tmpl(struct ath12k_link_vif *arvif) { - struct ath12k_vif *tx_arvif = arvif; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); + struct ath12k_link_vif *tx_arvif = arvif; struct ath12k *ar = arvif->ar; struct ath12k_base *ab = ar->ab; - struct ieee80211_vif *vif = arvif->vif; struct ieee80211_mutable_offsets offs = {}; + struct ath12k_vif *tx_ahvif = ahvif; bool nontx_profile_found = false; struct sk_buff *bcn; int ret; - if (arvif->vdev_type != WMI_VDEV_TYPE_AP) + if (ahvif->vdev_type != WMI_VDEV_TYPE_AP) return 0; if (vif->mbssid_tx_vif) { - tx_arvif = ath12k_vif_to_arvif(vif->mbssid_tx_vif); + tx_ahvif = ath12k_vif_to_ahvif(vif->mbssid_tx_vif); + tx_arvif = &tx_ahvif->deflink; if (tx_arvif != arvif && arvif->is_up) return 0; @@ -1464,7 +1476,7 @@ static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) return ath12k_mac_setup_bcn_tmpl_ema(arvif); } - bcn = ieee80211_beacon_get_template(ath12k_ar_to_hw(tx_arvif->ar), tx_arvif->vif, + bcn = ieee80211_beacon_get_template(ath12k_ar_to_hw(tx_arvif->ar), tx_ahvif->vif, &offs, 0); if (!bcn) { ath12k_warn(ab, "failed to get beacon template from mac80211\n"); @@ -1475,14 +1487,14 @@ static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) ath12k_mac_set_arvif_ies(arvif, bcn, 0, NULL); } else { ath12k_mac_set_arvif_ies(arvif, bcn, - arvif->vif->bss_conf.bssid_index, + ahvif->vif->bss_conf.bssid_index, &nontx_profile_found); if (!nontx_profile_found) ath12k_warn(ab, "nontransmitted profile not found in beacon template\n"); } - if (arvif->vif->type == NL80211_IFTYPE_AP && arvif->vif->p2p) { + if (ahvif->vif->type == NL80211_IFTYPE_AP && ahvif->vif->p2p) { ret = ath12k_mac_setup_bcn_p2p_ie(arvif, bcn); if (ret) { ath12k_warn(ab, "failed to setup P2P GO bcn ie: %d\n", @@ -1516,10 +1528,11 @@ static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) return ret; } -static void ath12k_control_beaconing(struct ath12k_vif *arvif, +static void ath12k_control_beaconing(struct ath12k_link_vif *arvif, struct ieee80211_bss_conf *info) { struct ath12k_wmi_vdev_up_params params = {}; + struct ath12k_vif *ahvif = arvif->ahvif; struct ath12k *ar = arvif->ar; int ret; @@ -1543,15 +1556,19 @@ static void ath12k_control_beaconing(struct ath12k_vif *arvif, return; } - arvif->aid = 0; + ahvif->aid = 0; ether_addr_copy(arvif->bssid, info->bssid); params.vdev_id = arvif->vdev_id; - params.aid = arvif->aid; + params.aid = ahvif->aid; params.bssid = arvif->bssid; - if (arvif->vif->mbssid_tx_vif) { - params.tx_bssid = ath12k_vif_to_arvif(arvif->vif->mbssid_tx_vif)->bssid; + if (ahvif->vif->mbssid_tx_vif) { + struct ath12k_vif *tx_ahvif = + ath12k_vif_to_ahvif(ahvif->vif->mbssid_tx_vif); + struct ath12k_link_vif *tx_arvif = &tx_ahvif->deflink; + + params.tx_bssid = tx_arvif->bssid; params.nontx_profile_idx = info->bssid_index; params.nontx_profile_cnt = 1 << info->bssid_indicator; } @@ -1572,7 +1589,8 @@ static void ath12k_mac_handle_beacon_iter(void *data, u8 *mac, { struct sk_buff *skb = data; struct ieee80211_mgmt *mgmt = (void *)skb->data; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif = &ahvif->deflink; if (vif->type != NL80211_IFTYPE_STATION) return; @@ -1595,7 +1613,8 @@ static void ath12k_mac_handle_beacon_miss_iter(void *data, u8 *mac, struct ieee80211_vif *vif) { u32 *vdev_id = data; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif = &ahvif->deflink; struct ath12k *ar = arvif->ar; struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); @@ -1626,9 +1645,9 @@ void ath12k_mac_handle_beacon_miss(struct ath12k *ar, u32 vdev_id) static void ath12k_mac_vif_sta_connection_loss_work(struct work_struct *work) { - struct ath12k_vif *arvif = container_of(work, struct ath12k_vif, - connection_loss_work.work); - struct ieee80211_vif *vif = arvif->vif; + struct ath12k_link_vif *arvif = container_of(work, struct ath12k_link_vif, + connection_loss_work.work); + struct ieee80211_vif *vif = arvif->ahvif->vif; if (!arvif->is_up) return; @@ -1641,12 +1660,15 @@ static void ath12k_peer_assoc_h_basic(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); + struct ath12k_link_vif *arvif; u32 aid; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; if (vif->type == NL80211_IFTYPE_STATION) aid = vif->cfg.aid; else @@ -1667,16 +1689,19 @@ static void ath12k_peer_assoc_h_crypto(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ieee80211_bss_conf *info = &vif->bss_conf; + struct ath12k_link_vif *arvif; struct cfg80211_chan_def def; struct cfg80211_bss *bss; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); const u8 *rsnie = NULL; const u8 *wpaie = NULL; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -1729,19 +1754,22 @@ static void ath12k_peer_assoc_h_rates(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct wmi_rate_set_arg *rateset = &arg->peer_legacy_rates; struct cfg80211_chan_def def; const struct ieee80211_supported_band *sband; const struct ieee80211_rate *rates; struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); + struct ath12k_link_vif *arvif; enum nl80211_band band; u32 ratemask; u8 rate; int i; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -1792,8 +1820,9 @@ static void ath12k_peer_assoc_h_ht(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); const struct ieee80211_sta_ht_cap *ht_cap = &sta->deflink.ht_cap; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_link_vif *arvif; struct cfg80211_chan_def def; enum nl80211_band band; const u8 *ht_mcs_mask; @@ -1801,8 +1830,10 @@ static void ath12k_peer_assoc_h_ht(struct ath12k *ar, u8 max_nss; u32 stbc; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -1953,8 +1984,9 @@ static void ath12k_peer_assoc_h_vht(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); const struct ieee80211_sta_vht_cap *vht_cap = &sta->deflink.vht_cap; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_link_vif *arvif; struct cfg80211_chan_def def; enum nl80211_band band; const u16 *vht_mcs_mask; @@ -1963,6 +1995,9 @@ static void ath12k_peer_assoc_h_vht(struct ath12k *ar, u8 max_nss, vht_mcs; int i; + lockdep_assert_held(&ahvif->ah->conf_mutex); + arvif = &ahvif->deflink; + if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -2300,9 +2335,9 @@ static void ath12k_peer_assoc_h_qos(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); - switch (arvif->vdev_type) { + switch (ahvif->vdev_type) { case WMI_VDEV_TYPE_AP: if (sta->wme) { /* TODO: Check WME vs QoS */ @@ -2332,7 +2367,7 @@ static void ath12k_peer_assoc_h_qos(struct ath12k *ar, } static int ath12k_peer_assoc_qos_ap(struct ath12k *ar, - struct ath12k_vif *arvif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta) { struct ath12k_wmi_ap_ps_arg arg; @@ -2498,13 +2533,17 @@ static void ath12k_peer_assoc_h_phymode(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); struct cfg80211_chan_def def; enum nl80211_band band; const u8 *ht_mcs_mask; const u16 *vht_mcs_mask; enum wmi_phy_mode phymode = MODE_UNKNOWN; + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; + lockdep_assert_held(&ahvif->ah->conf_mutex); + + arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -2643,13 +2682,17 @@ static void ath12k_peer_assoc_h_eht(struct ath12k *ar, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); const struct ieee80211_sta_eht_cap *eht_cap = &sta->deflink.eht_cap; const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; const struct ieee80211_eht_mcs_nss_supp_20mhz_only *bw_20; const struct ieee80211_eht_mcs_nss_supp_bw *bw; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_link_vif *arvif; u32 *rx_mcs, *tx_mcs; + lockdep_assert_held(&ahvif->ah->conf_mutex); + + arvif = &ahvif->deflink; if (!sta->deflink.he_cap.has_he || !eht_cap->has_eht) return; @@ -2749,7 +2792,7 @@ static void ath12k_peer_assoc_prepare(struct ath12k *ar, /* TODO: amsdu_disable req? */ } -static int ath12k_setup_peer_smps(struct ath12k *ar, struct ath12k_vif *arvif, +static int ath12k_setup_peer_smps(struct ath12k *ar, struct ath12k_link_vif *arvif, const u8 *addr, const struct ieee80211_sta_ht_cap *ht_cap, const struct ieee80211_he_6ghz_capa *he_6ghz_capa) @@ -2766,10 +2809,11 @@ static int ath12k_setup_peer_smps(struct ath12k *ar, struct ath12k_vif *arvif, } static void ath12k_bss_assoc(struct ath12k *ar, - struct ath12k_vif *arvif, + struct ath12k_link_vif *arvif, struct ieee80211_bss_conf *bss_conf) { - struct ieee80211_vif *vif = arvif->vif; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); struct ath12k_wmi_vdev_up_params params = {}; struct ath12k_wmi_peer_assoc_arg peer_arg; struct ieee80211_sta *ap_sta; @@ -2780,7 +2824,7 @@ static void ath12k_bss_assoc(struct ath12k *ar, lockdep_assert_held(&ar->conf_mutex); ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "mac vdev %i assoc bssid %pM aid %d\n", - arvif->vdev_id, arvif->bssid, arvif->aid); + arvif->vdev_id, arvif->bssid, ahvif->aid); rcu_read_lock(); @@ -2820,11 +2864,11 @@ static void ath12k_bss_assoc(struct ath12k *ar, WARN_ON(arvif->is_up); - arvif->aid = vif->cfg.aid; + ahvif->aid = vif->cfg.aid; ether_addr_copy(arvif->bssid, bss_conf->bssid); params.vdev_id = arvif->vdev_id; - params.aid = arvif->aid; + params.aid = ahvif->aid; params.bssid = arvif->bssid; ret = ath12k_wmi_vdev_up(ar, ¶ms); if (ret) { @@ -2865,7 +2909,7 @@ static void ath12k_bss_assoc(struct ath12k *ar, } static void ath12k_bss_disassoc(struct ath12k *ar, - struct ath12k_vif *arvif) + struct ath12k_link_vif *arvif) { int ret; @@ -2913,17 +2957,20 @@ static void ath12k_recalculate_mgmt_rate(struct ath12k *ar, struct ieee80211_vif *vif, struct cfg80211_chan_def *def) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); const struct ieee80211_supported_band *sband; + struct ath12k_link_vif *arvif; u8 basic_rate_idx; int hw_rate_code; u32 vdev_param; u16 bitrate; int ret; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; sband = hw->wiphy->bands[def->chan->band]; basic_rate_idx = ffs(vif->bss_conf.basic_rates) - 1; bitrate = sband->bitrates[basic_rate_idx].bitrate; @@ -2947,9 +2994,10 @@ static void ath12k_recalculate_mgmt_rate(struct ath12k *ar, ath12k_warn(ar->ab, "failed to set beacon tx rate %d\n", ret); } -static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, +static int ath12k_mac_fils_discovery(struct ath12k_link_vif *arvif, struct ieee80211_bss_conf *info) { + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ath12k *ar = arvif->ar; struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); struct sk_buff *tmpl; @@ -2960,7 +3008,7 @@ static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, if (info->fils_discovery.max_interval) { interval = info->fils_discovery.max_interval; - tmpl = ieee80211_get_fils_discovery_tmpl(hw, arvif->vif); + tmpl = ieee80211_get_fils_discovery_tmpl(hw, vif); if (tmpl) ret = ath12k_wmi_fils_discovery_tmpl(ar, arvif->vdev_id, tmpl); @@ -2968,8 +3016,7 @@ static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, unsol_bcast_probe_resp_enabled = 1; interval = info->unsol_bcast_probe_resp_interval; - tmpl = ieee80211_get_unsol_bcast_probe_resp_tmpl(hw, - arvif->vif); + tmpl = ieee80211_get_unsol_bcast_probe_resp_tmpl(hw, vif); if (tmpl) ret = ath12k_wmi_probe_resp_tmpl(ar, arvif->vdev_id, tmpl); @@ -2994,10 +3041,10 @@ static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, return ret; } -static void ath12k_mac_vif_setup_ps(struct ath12k_vif *arvif) +static void ath12k_mac_vif_setup_ps(struct ath12k_link_vif *arvif) { struct ath12k *ar = arvif->ar; - struct ieee80211_vif *vif = arvif->vif; + struct ieee80211_vif *vif = arvif->ahvif->vif; struct ieee80211_conf *conf = &ath12k_ar_to_hw(ar)->conf; enum wmi_sta_powersave_param param; enum wmi_sta_ps_mode psmode; @@ -3010,7 +3057,7 @@ static void ath12k_mac_vif_setup_ps(struct ath12k_vif *arvif) if (vif->type != NL80211_IFTYPE_STATION) return; - enable_ps = arvif->ps; + enable_ps = arvif->ahvif->ps; if (enable_ps) { psmode = WMI_STA_PS_MODE_ENABLED; param = WMI_STA_PS_PARAM_INACTIVITY_TIME; @@ -3042,11 +3089,12 @@ static void ath12k_mac_vif_setup_ps(struct ath12k_vif *arvif) } static void ath12k_mac_bss_info_changed(struct ath12k *ar, - struct ath12k_vif *arvif, + struct ath12k_link_vif *arvif, struct ieee80211_bss_conf *info, u64 changed) { - struct ieee80211_vif *vif = arvif->vif; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); struct ieee80211_vif_cfg *vif_cfg = &vif->cfg; struct cfg80211_chan_def def; u32 param_id, param_value; @@ -3116,10 +3164,10 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, if (changed & BSS_CHANGED_SSID && vif->type == NL80211_IFTYPE_AP) { - arvif->u.ap.ssid_len = vif->cfg.ssid_len; + ahvif->u.ap.ssid_len = vif->cfg.ssid_len; if (vif->cfg.ssid_len) - memcpy(arvif->u.ap.ssid, vif->cfg.ssid, vif->cfg.ssid_len); - arvif->u.ap.hidden_ssid = info->hidden_ssid; + memcpy(ahvif->u.ap.ssid, vif->cfg.ssid, vif->cfg.ssid_len); + ahvif->u.ap.hidden_ssid = info->hidden_ssid; } if (changed & BSS_CHANGED_BSSID && !is_zero_ether_addr(info->bssid)) @@ -3230,7 +3278,7 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, } if (changed & BSS_CHANGED_MCAST_RATE && - !ath12k_mac_vif_chan(arvif->vif, &def)) { + !ath12k_mac_vif_chan(vif, &def)) { band = def.chan->band; mcast_rate = vif->bss_conf.mcast_rate[band]; @@ -3274,7 +3322,7 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, } if (changed & BSS_CHANGED_BASIC_RATES && - !ath12k_mac_vif_chan(arvif->vif, &def)) + !ath12k_mac_vif_chan(vif, &def)) ath12k_recalculate_mgmt_rate(ar, vif, &def); if (changed & BSS_CHANGED_TWT) { @@ -3320,12 +3368,12 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, if (changed & BSS_CHANGED_PS && ar->ab->hw_params->supports_sta_ps) { - arvif->ps = vif_cfg->ps; + ahvif->ps = vif_cfg->ps; ath12k_mac_vif_setup_ps(arvif); } } -static struct ath12k_vif_cache *ath12k_arvif_get_cache(struct ath12k_vif *arvif) +static struct ath12k_vif_cache *ath12k_arvif_get_cache(struct ath12k_link_vif *arvif) { if (!arvif->cache) arvif->cache = kzalloc(sizeof(*arvif->cache), GFP_KERNEL); @@ -3333,7 +3381,7 @@ static struct ath12k_vif_cache *ath12k_arvif_get_cache(struct ath12k_vif *arvif) return arvif->cache; } -static void ath12k_arvif_put_cache(struct ath12k_vif *arvif) +static void ath12k_arvif_put_cache(struct ath12k_link_vif *arvif) { kfree(arvif->cache); arvif->cache = NULL; @@ -3344,10 +3392,17 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, struct ieee80211_bss_conf *info, u64 changed) { + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_vif_cache *cache; + struct ath12k_link_vif *arvif; + mutex_lock(&ah->conf_mutex); + /* TODO use info->link_id and fetch corresponding ahvif->link[] + * with MLO support. + */ + arvif = &ahvif->deflink; ar = ath12k_get_ar_by_vif(hw, vif); /* if the vdev is not created on a certain radio, @@ -3355,10 +3410,17 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, */ if (!ar) { + /* TODO Once link vif is fetched based on link id from + * info, avoid using the deflink above and cache the link + * configs in ahvif per link. + */ cache = ath12k_arvif_get_cache(arvif); - if (!cache) + if (!cache) { + mutex_unlock(&ah->conf_mutex); return; + } arvif->cache->bss_conf_changed |= changed; + mutex_unlock(&ah->conf_mutex); return; } @@ -3367,6 +3429,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, ath12k_mac_bss_info_changed(ar, arvif, info, changed); mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); } static struct ath12k* @@ -3575,13 +3638,17 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, { struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar, *prev_ar; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; struct cfg80211_scan_request *req = &hw_req->req; struct ath12k_wmi_scan_req_arg arg = {}; int ret; int i; bool create = true; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; + if (ah->num_radio == 1) { WARN_ON(!arvif->is_created); ar = ath12k_ah_to_ar(ah, 0); @@ -3592,9 +3659,10 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, * requested in the hw_req, select the corresponding radio */ ar = ath12k_mac_select_scan_device(hw, vif, hw_req->req.channels[0]->center_freq); - if (!ar) + if (!ar) { + mutex_unlock(&ah->conf_mutex); return -EINVAL; - + } /* If the vif is already assigned to a specific vdev of an ar, * check whether its already started, vdev which is started * are not allowed to switch to a new radio. @@ -3605,11 +3673,15 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, * always on the same band for the vif */ if (arvif->is_created) { - if (WARN_ON(!arvif->ar)) + if (WARN_ON(!arvif->ar)) { + mutex_unlock(&ah->conf_mutex); return -EINVAL; + } - if (ar != arvif->ar && arvif->is_started) + if (ar != arvif->ar && arvif->is_started) { + mutex_unlock(&ah->conf_mutex); return -EINVAL; + } if (ar != arvif->ar) { /* backup the previously used ar ptr, since the vdev delete @@ -3632,6 +3704,7 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, mutex_unlock(&ar->conf_mutex); if (ret) { ath12k_warn(ar->ab, "unable to create scan vdev %d\n", ret); + mutex_unlock(&ah->conf_mutex); return -EINVAL; } } @@ -3714,21 +3787,30 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, kfree(arg.extraie.ptr); mutex_unlock(&ar->conf_mutex); - + mutex_unlock(&ah->conf_mutex); return ret; } static void ath12k_mac_op_cancel_hw_scan(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_link_vif *arvif; struct ath12k *ar; - if (!arvif->is_created) + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; + + if (!arvif->is_created) { + mutex_unlock(&ah->conf_mutex); return; + } ar = arvif->ar; + mutex_unlock(&ah->conf_mutex); + mutex_lock(&ar->conf_mutex); ath12k_scan_abort(ar); mutex_unlock(&ar->conf_mutex); @@ -3736,7 +3818,7 @@ static void ath12k_mac_op_cancel_hw_scan(struct ieee80211_hw *hw, cancel_delayed_work_sync(&ar->scan.timeout); } -static int ath12k_install_key(struct ath12k_vif *arvif, +static int ath12k_install_key(struct ath12k_link_vif *arvif, struct ieee80211_key_conf *key, enum set_key_cmd cmd, const u8 *macaddr, u32 flags) @@ -3751,6 +3833,8 @@ static int ath12k_install_key(struct ath12k_vif *arvif, .key_flags = flags, .macaddr = macaddr, }; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); lockdep_assert_held(&arvif->ar->conf_mutex); @@ -3803,13 +3887,13 @@ static int ath12k_install_key(struct ath12k_vif *arvif, if (!wait_for_completion_timeout(&ar->install_key_done, 1 * HZ)) return -ETIMEDOUT; - if (ether_addr_equal(macaddr, arvif->vif->addr)) - arvif->key_cipher = key->cipher; + if (ether_addr_equal(macaddr, vif->addr)) + ahvif->key_cipher = key->cipher; return ar->install_key_status ? -EINVAL : 0; } -static int ath12k_clear_peer_keys(struct ath12k_vif *arvif, +static int ath12k_clear_peer_keys(struct ath12k_link_vif *arvif, const u8 *addr) { struct ath12k *ar = arvif->ar; @@ -3855,22 +3939,25 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, struct ieee80211_vif *vif, struct ieee80211_sta *sta, struct ieee80211_key_conf *key) { + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_base *ab = ar->ab; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_link_vif *arvif; struct ath12k_peer *peer; struct ath12k_sta *arsta; const u8 *peer_addr; int ret = 0; u32 flags = 0; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; if (test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags)) return 1; if (sta) peer_addr = sta->addr; - else if (arvif->vdev_type == WMI_VDEV_TYPE_STA) + else if (ahvif->vdev_type == WMI_VDEV_TYPE_STA) peer_addr = vif->bss_conf.bssid; else peer_addr = vif->addr; @@ -3966,41 +4053,60 @@ static int ath12k_mac_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, struct ieee80211_vif *vif, struct ieee80211_sta *sta, struct ieee80211_key_conf *key) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_link_vif *arvif; struct ath12k_vif_cache *cache; struct ath12k *ar; int ret; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; /* BIP needs to be done in software */ if (key->cipher == WLAN_CIPHER_SUITE_AES_CMAC || key->cipher == WLAN_CIPHER_SUITE_BIP_GMAC_128 || key->cipher == WLAN_CIPHER_SUITE_BIP_GMAC_256 || - key->cipher == WLAN_CIPHER_SUITE_BIP_CMAC_256) + key->cipher == WLAN_CIPHER_SUITE_BIP_CMAC_256) { + mutex_unlock(&ah->conf_mutex); return 1; + } - if (key->keyidx > WMI_MAX_KEY_INDEX) + if (key->keyidx > WMI_MAX_KEY_INDEX) { + mutex_unlock(&ah->conf_mutex); return -ENOSPC; + } ar = ath12k_get_ar_by_vif(hw, vif); if (!ar) { /* ar is expected to be valid when sta ptr is available */ if (sta) { WARN_ON_ONCE(1); + mutex_unlock(&ah->conf_mutex); return -EINVAL; } cache = ath12k_arvif_get_cache(arvif); - if (!cache) + if (!cache) { + mutex_unlock(&ah->conf_mutex); return -ENOSPC; + } cache->key_conf.cmd = cmd; cache->key_conf.key = key; cache->key_conf.changed = true; + mutex_unlock(&ah->conf_mutex); return 0; } + /* Note: Currently only deflink of ahvif is used here, once MLO + * support is added the allocated links (i.e ahvif->links[]) + * should be use based on link id passed from mac80211 and such link + * access needs to be protected with ah->conf_mutex. + */ + mutex_lock(&ar->conf_mutex); ret = ath12k_mac_set_key(ar, cmd, vif, sta, key); mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return ret; } @@ -4019,7 +4125,7 @@ ath12k_mac_bitrate_mask_num_vht_rates(struct ath12k *ar, } static int -ath12k_mac_set_peer_vht_fixed_rate(struct ath12k_vif *arvif, +ath12k_mac_set_peer_vht_fixed_rate(struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, const struct cfg80211_bitrate_mask *mask, enum nl80211_band band) @@ -4069,16 +4175,19 @@ static int ath12k_station_assoc(struct ath12k *ar, struct ieee80211_sta *sta, bool reassoc) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_wmi_peer_assoc_arg peer_arg; int ret; struct cfg80211_chan_def def; enum nl80211_band band; + struct ath12k_link_vif *arvif; struct cfg80211_bitrate_mask *mask; u8 num_vht_rates; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return -EPERM; @@ -4152,11 +4261,14 @@ static int ath12k_station_disassoc(struct ath12k *ar, struct ieee80211_vif *vif, struct ieee80211_sta *sta) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; int ret; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; if (!sta->wme) { arvif->num_legacy_stations--; ret = ath12k_recalc_rtscts_prot(arvif); @@ -4176,8 +4288,8 @@ static int ath12k_station_disassoc(struct ath12k *ar, static void ath12k_sta_rc_update_wk(struct work_struct *wk) { struct ath12k *ar; - struct ath12k_vif *arvif; struct ath12k_sta *arsta; + struct ath12k_link_vif *arvif; struct ieee80211_sta *sta; struct cfg80211_chan_def def; enum nl80211_band band; @@ -4188,13 +4300,15 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) const struct cfg80211_bitrate_mask *mask; struct ath12k_wmi_peer_assoc_arg peer_arg; enum wmi_phy_mode peer_phymode; + struct ieee80211_vif *vif; arsta = container_of(wk, struct ath12k_sta, update_wk); sta = container_of((void *)arsta, struct ieee80211_sta, drv_priv); arvif = arsta->arvif; + vif = ath12k_vif_to_vif(arvif->ahvif); ar = arvif->ar; - if (WARN_ON(ath12k_mac_vif_chan(arvif->vif, &def))) + if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; band = def.chan->band; @@ -4220,7 +4334,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) ath12k_mac_max_vht_nss(vht_mcs_mask))); if (changed & IEEE80211_RC_BW_CHANGED) { - ath12k_peer_assoc_h_phymode(ar, arvif->vif, sta, &peer_arg); + ath12k_peer_assoc_h_phymode(ar, vif, sta, &peer_arg); peer_phymode = peer_arg.peer_phymode; if (bw > bw_prev) { @@ -4315,7 +4429,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) * is provided in the new bitrate mask we set the * other rates using peer_assoc command. */ - ath12k_peer_assoc_prepare(ar, arvif->vif, sta, + ath12k_peer_assoc_prepare(ar, vif, sta, &peer_arg, true); err = ath12k_wmi_send_peer_assoc_cmd(ar, &peer_arg); @@ -4332,14 +4446,14 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) mutex_unlock(&ar->conf_mutex); } -static int ath12k_mac_inc_num_stations(struct ath12k_vif *arvif, +static int ath12k_mac_inc_num_stations(struct ath12k_link_vif *arvif, struct ieee80211_sta *sta) { struct ath12k *ar = arvif->ar; lockdep_assert_held(&ar->conf_mutex); - if (arvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) + if (arvif->ahvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) return 0; if (ar->num_stations >= ar->max_num_stations) @@ -4350,14 +4464,14 @@ static int ath12k_mac_inc_num_stations(struct ath12k_vif *arvif, return 0; } -static void ath12k_mac_dec_num_stations(struct ath12k_vif *arvif, +static void ath12k_mac_dec_num_stations(struct ath12k_link_vif *arvif, struct ieee80211_sta *sta) { struct ath12k *ar = arvif->ar; lockdep_assert_held(&ar->conf_mutex); - if (arvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) + if (arvif->ahvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) return; ar->num_stations--; @@ -4368,20 +4482,22 @@ static int ath12k_mac_station_add(struct ath12k *ar, struct ieee80211_sta *sta) { struct ath12k_base *ab = ar->ab; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); struct ath12k_wmi_peer_create_arg peer_param; + struct ath12k_link_vif *arvif; int ret; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; ret = ath12k_mac_inc_num_stations(arvif, sta); if (ret) { ath12k_warn(ab, "refusing to associate station: too many connected already (%d)\n", ar->max_num_stations); goto exit; } - arsta->rx_stats = kzalloc(sizeof(*arsta->rx_stats), GFP_KERNEL); if (!arsta->rx_stats) { ret = -ENOMEM; @@ -4422,7 +4538,7 @@ static int ath12k_mac_station_add(struct ath12k *ar, if (ab->hw_params->vdev_start_delay && !arvif->is_started && - arvif->vdev_type != WMI_VDEV_TYPE_AP) { + arvif->ahvif->vdev_type != WMI_VDEV_TYPE_AP) { ret = ath12k_start_vdev_delay(ar, arvif); if (ret) { ath12k_warn(ab, "failed to delay vdev start: %d\n", ret); @@ -4477,12 +4593,17 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, enum ieee80211_sta_state old_state, enum ieee80211_sta_state new_state) { + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k *ar; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); + struct ath12k_link_vif *arvif; struct ath12k_peer *peer; int ret = 0; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; + /* cancel must be done outside the mutex to avoid deadlock */ if ((old_state == IEEE80211_STA_NONE && new_state == IEEE80211_STA_NOTEXIST)) @@ -4491,9 +4612,9 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, ar = ath12k_get_ar_by_vif(hw, vif); if (!ar) { WARN_ON_ONCE(1); + mutex_unlock(&ah->conf_mutex); return -EINVAL; } - mutex_lock(&ar->conf_mutex); if (old_state == IEEE80211_STA_NOTEXIST && @@ -4508,7 +4629,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, sta->addr, arvif->vdev_id); } else if ((old_state == IEEE80211_STA_NONE && new_state == IEEE80211_STA_NOTEXIST)) { - if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { + if (ahvif->vdev_type == WMI_VDEV_TYPE_STA) { ath12k_bss_disassoc(ar, arvif); ret = ath12k_mac_vdev_stop(arvif); if (ret) @@ -4596,6 +4717,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, } mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return ret; } @@ -4606,20 +4728,28 @@ static int ath12k_mac_op_sta_set_txpwr(struct ieee80211_hw *hw, { struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; int ret; s16 txpwr; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; + if (sta->deflink.txpwr.type == NL80211_TX_POWER_AUTOMATIC) { txpwr = 0; } else { txpwr = sta->deflink.txpwr.power; - if (!txpwr) + if (!txpwr) { + mutex_unlock(&ah->conf_mutex); return -EINVAL; + } } - if (txpwr > ATH12K_TX_POWER_MAX_VAL || txpwr < ATH12K_TX_POWER_MIN_VAL) + if (txpwr > ATH12K_TX_POWER_MAX_VAL || txpwr < ATH12K_TX_POWER_MIN_VAL) { + mutex_unlock(&ah->conf_mutex); return -EINVAL; + } ar = ath12k_ah_to_ar(ah, 0); @@ -4635,6 +4765,7 @@ static int ath12k_mac_op_sta_set_txpwr(struct ieee80211_hw *hw, out: mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return ret; } @@ -4645,7 +4776,8 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, { struct ath12k *ar; struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; struct ath12k_peer *peer; u32 bw, smps; @@ -4655,11 +4787,14 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, return; } + rcu_read_lock(); + arvif = &ahvif->deflink; spin_lock_bh(&ar->ab->base_lock); peer = ath12k_peer_find(ar->ab, arvif->vdev_id, sta->addr); if (!peer) { spin_unlock_bh(&ar->ab->base_lock); + rcu_read_unlock(); ath12k_warn(ar->ab, "mac sta rc update failed to find peer %pM on vdev %i\n", sta->addr, arvif->vdev_id); return; @@ -4712,16 +4847,18 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, spin_unlock_bh(&ar->data_lock); ieee80211_queue_work(hw, &arsta->update_wk); + rcu_read_unlock(); } -static int ath12k_conf_tx_uapsd(struct ath12k_vif *arvif, +static int ath12k_conf_tx_uapsd(struct ath12k_link_vif *arvif, u16 ac, bool enable) { struct ath12k *ar = arvif->ar; + struct ath12k_vif *ahvif = arvif->ahvif; u32 value; int ret; - if (arvif->vdev_type != WMI_VDEV_TYPE_STA) + if (ahvif->vdev_type != WMI_VDEV_TYPE_STA) return 0; switch (ac) { @@ -4744,19 +4881,19 @@ static int ath12k_conf_tx_uapsd(struct ath12k_vif *arvif, } if (enable) - arvif->u.sta.uapsd |= value; + ahvif->u.sta.uapsd |= value; else - arvif->u.sta.uapsd &= ~value; + ahvif->u.sta.uapsd &= ~value; ret = ath12k_wmi_set_sta_ps_param(ar, arvif->vdev_id, WMI_STA_PS_PARAM_UAPSD, - arvif->u.sta.uapsd); + ahvif->u.sta.uapsd); if (ret) { ath12k_warn(ar->ab, "could not set uapsd params %d\n", ret); goto exit; } - if (arvif->u.sta.uapsd) + if (ahvif->u.sta.uapsd) value = WMI_STA_PS_RX_WAKE_POLICY_POLL_UAPSD; else value = WMI_STA_PS_RX_WAKE_POLICY_WAKE; @@ -4771,7 +4908,7 @@ static int ath12k_conf_tx_uapsd(struct ath12k_vif *arvif, return ret; } -static int ath12k_mac_conf_tx(struct ath12k_vif *arvif, +static int ath12k_mac_conf_tx(struct ath12k_link_vif *arvif, unsigned int link_id, u16 ac, const struct ieee80211_tx_queue_params *params) { @@ -4829,27 +4966,34 @@ static int ath12k_mac_op_conf_tx(struct ieee80211_hw *hw, unsigned int link_id, u16 ac, const struct ieee80211_tx_queue_params *params) { + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_link_vif *arvif; + struct ath12k_vif_cache *cache; struct ath12k *ar; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); - struct ath12k_vif_cache *cache = arvif->cache; int ret; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; ar = ath12k_get_ar_by_vif(hw, vif); if (!ar) { /* cache the info and apply after vdev is created */ cache = ath12k_arvif_get_cache(arvif); - if (!cache) + if (!cache) { + mutex_unlock(&ah->conf_mutex); return -ENOSPC; + } cache->tx_conf.changed = true; cache->tx_conf.ac = ac; cache->tx_conf.tx_queue_params = *params; + mutex_unlock(&ah->conf_mutex); return 0; } mutex_lock(&ar->conf_mutex); ret = ath12k_mac_conf_tx(arvif, link_id, ac, params); mutex_unlock(&ar->conf_mutex); - + mutex_unlock(&ah->conf_mutex); return ret; } @@ -4919,10 +5063,11 @@ ath12k_create_ht_cap(struct ath12k *ar, u32 ar_ht_cap, u32 rate_cap_rx_chainmask return ht_cap; } -static int ath12k_mac_set_txbf_conf(struct ath12k_vif *arvif) +static int ath12k_mac_set_txbf_conf(struct ath12k_link_vif *arvif) { u32 value = 0; struct ath12k *ar = arvif->ar; + struct ath12k_vif *ahvif = arvif->ahvif; int nsts; int sound_dim; u32 vht_cap = ar->pdev->cap.vht_cap; @@ -4950,7 +5095,7 @@ static int ath12k_mac_set_txbf_conf(struct ath12k_vif *arvif) value |= WMI_VDEV_PARAM_TXBF_SU_TX_BFER; if ((vht_cap & IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE) && - arvif->vdev_type == WMI_VDEV_TYPE_AP) + ahvif->vdev_type == WMI_VDEV_TYPE_AP) value |= WMI_VDEV_PARAM_TXBF_MU_TX_BFER; } @@ -4958,7 +5103,7 @@ static int ath12k_mac_set_txbf_conf(struct ath12k_vif *arvif) value |= WMI_VDEV_PARAM_TXBF_SU_TX_BFEE; if ((vht_cap & IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE) && - arvif->vdev_type == WMI_VDEV_TYPE_STA) + ahvif->vdev_type == WMI_VDEV_TYPE_STA) value |= WMI_VDEV_PARAM_TXBF_MU_TX_BFEE; } @@ -5619,7 +5764,7 @@ static int ath12k_mac_vif_txmgmt_idr_remove(int buf_id, void *skb, void *ctx) return 0; } -static int ath12k_mac_mgmt_tx_wmi(struct ath12k *ar, struct ath12k_vif *arvif, +static int ath12k_mac_mgmt_tx_wmi(struct ath12k *ar, struct ath12k_link_vif *arvif, struct sk_buff *skb) { struct ath12k_base *ab = ar->ab; @@ -5687,7 +5832,8 @@ static void ath12k_mgmt_over_wmi_tx_work(struct work_struct *work) { struct ath12k *ar = container_of(work, struct ath12k, wmi_mgmt_tx_work); struct ath12k_skb_cb *skb_cb; - struct ath12k_vif *arvif; + struct ath12k_vif *ahvif; + struct ath12k_link_vif *arvif; struct sk_buff *skb; int ret; @@ -5699,8 +5845,8 @@ static void ath12k_mgmt_over_wmi_tx_work(struct work_struct *work) continue; } - arvif = ath12k_vif_to_arvif(skb_cb->vif); - + ahvif = ath12k_vif_to_ahvif(skb_cb->vif); + arvif = &ahvif->deflink; if (ar->allocated_vdev_map & (1LL << arvif->vdev_id)) { ret = ath12k_mac_mgmt_tx_wmi(ar, arvif, skb); if (ret) { @@ -5755,18 +5901,18 @@ static void ath12k_mac_add_p2p_noa_ie(struct ath12k *ar, struct sk_buff *skb, bool is_prb_rsp) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); if (likely(!is_prb_rsp)) return; spin_lock_bh(&ar->data_lock); - if (arvif->u.ap.noa_data && - !pskb_expand_head(skb, 0, arvif->u.ap.noa_len, + if (ahvif->u.ap.noa_data && + !pskb_expand_head(skb, 0, ahvif->u.ap.noa_len, GFP_ATOMIC)) - skb_put_data(skb, arvif->u.ap.noa_data, - arvif->u.ap.noa_len); + skb_put_data(skb, ahvif->u.ap.noa_data, + ahvif->u.ap.noa_len); spin_unlock_bh(&ar->data_lock); } @@ -5778,7 +5924,8 @@ static void ath12k_mac_op_tx(struct ieee80211_hw *hw, struct ath12k_skb_cb *skb_cb = ATH12K_SKB_CB(skb); struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); struct ieee80211_vif *vif = info->control.vif; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif = &ahvif->deflink; struct ath12k *ar = arvif->ar; struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; struct ieee80211_key_conf *key = info->control.hw_key; @@ -6131,7 +6278,7 @@ static void ath12k_mac_op_stop(struct ieee80211_hw *hw) } static u8 -ath12k_mac_get_vdev_stats_id(struct ath12k_vif *arvif) +ath12k_mac_get_vdev_stats_id(struct ath12k_link_vif *arvif) { struct ath12k_base *ab = arvif->ar->ab; u8 vdev_stats_id = 0; @@ -6153,19 +6300,22 @@ ath12k_mac_get_vdev_stats_id(struct ath12k_vif *arvif) return vdev_stats_id; } -static int ath12k_mac_setup_vdev_params_mbssid(struct ath12k_vif *arvif, +static int ath12k_mac_setup_vdev_params_mbssid(struct ath12k_link_vif *arvif, u32 *flags, u32 *tx_vdev_id) { - struct ieee80211_vif *tx_vif = arvif->vif->mbssid_tx_vif; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *tx_vif = ahvif->vif->mbssid_tx_vif; struct ath12k *ar = arvif->ar; - struct ath12k_vif *tx_arvif; + struct ath12k_link_vif *tx_arvif; + struct ath12k_vif *tx_ahvif; if (!tx_vif) return 0; - tx_arvif = ath12k_vif_to_arvif(tx_vif); + tx_ahvif = ath12k_vif_to_ahvif(tx_vif); + tx_arvif = &tx_ahvif->deflink; - if (arvif->vif->bss_conf.nontransmitted) { + if (ahvif->vif->bss_conf.nontransmitted) { if (ar->ah->hw->wiphy != ieee80211_vif_to_wdev(tx_vif)->wiphy) return -EINVAL; @@ -6177,22 +6327,23 @@ static int ath12k_mac_setup_vdev_params_mbssid(struct ath12k_vif *arvif, return -EINVAL; } - if (arvif->vif->bss_conf.ema_ap) + if (ahvif->vif->bss_conf.ema_ap) *flags |= WMI_VDEV_MBSSID_FLAGS_EMA_MODE; return 0; } -static int ath12k_mac_setup_vdev_create_arg(struct ath12k_vif *arvif, +static int ath12k_mac_setup_vdev_create_arg(struct ath12k_link_vif *arvif, struct ath12k_wmi_vdev_create_arg *arg) { struct ath12k *ar = arvif->ar; struct ath12k_pdev *pdev = ar->pdev; + struct ath12k_vif *ahvif = arvif->ahvif; int ret; arg->if_id = arvif->vdev_id; - arg->type = arvif->vdev_type; - arg->subtype = arvif->vdev_subtype; + arg->type = ahvif->vdev_type; + arg->subtype = ahvif->vdev_subtype; arg->pdev_id = pdev->pdev_id; arg->mbssid_flags = WMI_VDEV_MBSSID_FLAGS_NON_MBSSID_AP; @@ -6259,14 +6410,15 @@ ath12k_mac_prepare_he_mode(struct ath12k_pdev *pdev, u32 viftype) } static int ath12k_set_he_mu_sounding_mode(struct ath12k *ar, - struct ath12k_vif *arvif) + struct ath12k_link_vif *arvif) { u32 param_id, param_value; struct ath12k_base *ab = ar->ab; + struct ath12k_vif *ahvif = arvif->ahvif; int ret; param_id = WMI_VDEV_PARAM_SET_HEMU_MODE; - param_value = ath12k_mac_prepare_he_mode(ar->pdev, arvif->vif->type); + param_value = ath12k_mac_prepare_he_mode(ar->pdev, ahvif->vif->type); ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id, param_id, param_value); if (ret) { @@ -6289,9 +6441,10 @@ static int ath12k_set_he_mu_sounding_mode(struct ath12k *ar, return ret; } -static void ath12k_mac_update_vif_offload(struct ath12k_vif *arvif) +static void ath12k_mac_update_vif_offload(struct ath12k_link_vif *arvif) { - struct ieee80211_vif *vif = arvif->vif; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); struct ath12k *ar = arvif->ar; struct ath12k_base *ab = ar->ab; u32 param_id, param_value; @@ -6304,14 +6457,14 @@ static void ath12k_mac_update_vif_offload(struct ath12k_vif *arvif) IEEE80211_OFFLOAD_DECAP_ENABLED); if (vif->offload_flags & IEEE80211_OFFLOAD_ENCAP_ENABLED) - arvif->tx_encap_type = ATH12K_HW_TXRX_ETHERNET; + ahvif->tx_encap_type = ATH12K_HW_TXRX_ETHERNET; else if (test_bit(ATH12K_FLAG_RAW_MODE, &ab->dev_flags)) - arvif->tx_encap_type = ATH12K_HW_TXRX_RAW; + ahvif->tx_encap_type = ATH12K_HW_TXRX_RAW; else - arvif->tx_encap_type = ATH12K_HW_TXRX_NATIVE_WIFI; + ahvif->tx_encap_type = ATH12K_HW_TXRX_NATIVE_WIFI; ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id, - param_id, arvif->tx_encap_type); + param_id, ahvif->tx_encap_type); if (ret) { ath12k_warn(ab, "failed to set vdev %d tx encap mode: %d\n", arvif->vdev_id, ret); @@ -6338,57 +6491,60 @@ static void ath12k_mac_update_vif_offload(struct ath12k_vif *arvif) static void ath12k_mac_op_update_vif_offload(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); - ath12k_mac_update_vif_offload(arvif); + ath12k_mac_update_vif_offload(&ahvif->deflink); } -static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) +int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) { struct ath12k_hw *ah = ar->ah; struct ath12k_base *ab = ar->ab; struct ieee80211_hw *hw = ah->hw; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_wmi_vdev_create_arg vdev_arg = {0}; struct ath12k_wmi_peer_create_arg peer_param; + struct ath12k_link_vif *arvif; u32 param_id, param_value; u16 nss; int i; int ret, vdev_id; + lockdep_assert_held(&ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; arvif->ar = ar; vdev_id = __ffs64(ab->free_vdev_map); arvif->vdev_id = vdev_id; - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_NONE; + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_NONE; switch (vif->type) { case NL80211_IFTYPE_UNSPECIFIED: case NL80211_IFTYPE_STATION: - arvif->vdev_type = WMI_VDEV_TYPE_STA; + ahvif->vdev_type = WMI_VDEV_TYPE_STA; if (vif->p2p) - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_CLIENT; + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_CLIENT; break; case NL80211_IFTYPE_MESH_POINT: - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_MESH_11S; + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_MESH_11S; fallthrough; case NL80211_IFTYPE_AP: - arvif->vdev_type = WMI_VDEV_TYPE_AP; + ahvif->vdev_type = WMI_VDEV_TYPE_AP; if (vif->p2p) - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_GO; + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_GO; break; case NL80211_IFTYPE_MONITOR: - arvif->vdev_type = WMI_VDEV_TYPE_MONITOR; + ahvif->vdev_type = WMI_VDEV_TYPE_MONITOR; ar->monitor_vdev_id = vdev_id; break; case NL80211_IFTYPE_P2P_DEVICE: - arvif->vdev_type = WMI_VDEV_TYPE_STA; - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_DEVICE; + ahvif->vdev_type = WMI_VDEV_TYPE_STA; + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_DEVICE; break; default: WARN_ON(1); @@ -6396,7 +6552,7 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) } ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "mac vdev create id %d type %d subtype %d map %llx\n", - arvif->vdev_id, arvif->vdev_type, arvif->vdev_subtype, + arvif->vdev_id, ahvif->vdev_type, ahvif->vdev_subtype, ab->free_vdev_map); vif->cab_queue = arvif->vdev_id % (ATH12K_HW_MAX_QUEUES - 1); @@ -6439,7 +6595,7 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) goto err_vdev_del; } - switch (arvif->vdev_type) { + switch (ahvif->vdev_type) { case WMI_VDEV_TYPE_AP: peer_param.vdev_id = arvif->vdev_id; peer_param.peer_addr = vif->addr; @@ -6515,15 +6671,19 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) } ath12k_dp_vdev_tx_attach(ar, arvif); - if (vif->type != NL80211_IFTYPE_MONITOR && ar->monitor_conf_enabled) ath12k_mac_monitor_vdev_create(ar); arvif->ar = ar; + /* TODO use appropriate link id once MLO support is added. + */ + arvif->link_id = ATH12K_DEFAULT_LINK_ID; + rcu_assign_pointer(ahvif->link[arvif->link_id], arvif); + ahvif->links_map = BIT(arvif->link_id); return ret; err_peer_del: - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { + if (ahvif->vdev_type == WMI_VDEV_TYPE_AP) { reinit_completion(&ar->peer_delete_done); ret = ath12k_wmi_send_peer_delete_cmd(ar, vif->addr, @@ -6559,16 +6719,19 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) return ret; } -static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ieee80211_vif *vif) +static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); - struct ath12k_vif_cache *cache = arvif->cache; + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_vif_cache *cache; struct ath12k_base *ab = ar->ab; - + struct ath12k_link_vif *arvif; int ret; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + arvif = &ahvif->deflink; + cache = arvif->cache; if (!cache) return; @@ -6600,12 +6763,16 @@ static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, struct ieee80211_vif *vif, struct ieee80211_chanctx_conf *ctx) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; struct ath12k_hw *ah = hw->priv; struct ath12k *ar, *prev_ar; struct ath12k_base *ab; int ret; + lockdep_assert_held(&ah->conf_mutex); + arvif = &ahvif->deflink; + if (ah->num_radio == 1) ar = ah->radio; else if (ctx) @@ -6687,12 +6854,18 @@ static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; int i; - memset(arvif, 0, sizeof(*arvif)); + mutex_lock(&ah->conf_mutex); + memset(ahvif, 0, sizeof(*ahvif)); - arvif->vif = vif; + ahvif->ah = ah; + ahvif->vif = vif; + arvif = &ahvif->deflink; + arvif->ahvif = ahvif; INIT_LIST_HEAD(&arvif->list); INIT_DELAYED_WORK(&arvif->connection_loss_work, @@ -6719,6 +6892,7 @@ static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw, * vdev needs to be created */ ath12k_mac_assign_vif_to_vdev(hw, vif, NULL); + mutex_unlock(&ah->conf_mutex); return 0; } @@ -6749,12 +6923,16 @@ static void ath12k_mac_vif_unref(struct ath12k_dp *dp, struct ieee80211_vif *vif static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_base *ab = ar->ab; + struct ath12k_link_vif *arvif; unsigned long time_left; int ret; + lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); + + arvif = &ahvif->deflink; reinit_completion(&ar->vdev_delete_done); ret = ath12k_wmi_vdev_delete(ar, arvif->vdev_id); @@ -6775,7 +6953,7 @@ static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) ar->allocated_vdev_map &= ~(1LL << arvif->vdev_id); ar->num_created_vdevs--; - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { ar->monitor_vdev_id = -1; ar->monitor_vdev_created = false; } else if (ar->monitor_vdev_created && !ar->monitor_started) { @@ -6805,6 +6983,12 @@ static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) /* TODO: recal traffic pause state based on the available vdevs */ arvif->is_created = false; arvif->ar = NULL; + if (arvif->link_id < IEEE80211_MLD_MAX_NUM_LINKS) { + rcu_assign_pointer(ahvif->link[arvif->link_id], NULL); + synchronize_rcu(); + ahvif->links_map &= ~(BIT(arvif->link_id)); + arvif->link_id = ATH12K_INVALID_LINK_ID; + } return ret; } @@ -6812,16 +6996,21 @@ static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_link_vif *arvif; struct ath12k_base *ab; struct ath12k *ar; int ret; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; if (!arvif->is_created) { /* if we cached some config but never received assign chanctx, * free the allocated cache. */ ath12k_arvif_put_cache(arvif); + mutex_unlock(&ah->conf_mutex); return; } @@ -6835,7 +7024,7 @@ static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw, ath12k_dbg(ab, ATH12K_DBG_MAC, "mac remove interface (vdev %d)\n", arvif->vdev_id); - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { + if (ahvif->vdev_type == WMI_VDEV_TYPE_AP) { ret = ath12k_peer_delete(ar, arvif->vdev_id, vif->addr); if (ret) ath12k_warn(ab, "failed to submit AP self-peer removal on vdev %d: %d\n", @@ -6845,6 +7034,7 @@ static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw, ath12k_mac_vdev_delete(ar, vif); mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); } /* FIXME: Has to be verified. */ @@ -6936,7 +7126,7 @@ static int ath12k_mac_op_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx return ret; } -static int ath12k_mac_ampdu_action(struct ath12k_vif *arvif, +static int ath12k_mac_ampdu_action(struct ath12k_link_vif *arvif, struct ieee80211_ampdu_params *params) { struct ath12k *ar = arvif->ar; @@ -6972,7 +7162,8 @@ static int ath12k_mac_op_ampdu_action(struct ieee80211_hw *hw, { struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; int ret = -EINVAL; ar = ath12k_get_ar_by_vif(hw, vif); @@ -6980,10 +7171,13 @@ static int ath12k_mac_op_ampdu_action(struct ieee80211_hw *hw, return -EINVAL; ar = ath12k_ah_to_ar(ah, 0); + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; mutex_lock(&ar->conf_mutex); ret = ath12k_mac_ampdu_action(arvif, params); mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); if (ret) ath12k_warn(ar->ab, "pdev idx %d unable to perform ampdu action %d ret %d\n", @@ -7114,7 +7308,7 @@ ath12k_mac_check_down_grade_phy_mode(struct ath12k *ar, } static int -ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, +ath12k_mac_vdev_start_restart(struct ath12k_link_vif *arvif, struct ieee80211_chanctx_conf *ctx, bool restart) { @@ -7122,7 +7316,8 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, struct ath12k_base *ab = ar->ab; struct wmi_vdev_start_req_arg arg = {}; const struct cfg80211_chan_def *chandef = &ctx->def; - int he_support = arvif->vif->bss_conf.he_support; + struct ath12k_vif *ahvif = arvif->ahvif; + int he_support = ahvif->vif->bss_conf.he_support; int ret; lockdep_assert_held(&ar->conf_mutex); @@ -7141,7 +7336,7 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, arg.mode = ath12k_mac_check_down_grade_phy_mode(ar, arg.mode, chandef->chan->band, - arvif->vif->type); + ahvif->vif->type); arg.min_power = 0; arg.max_power = chandef->chan->max_power * 2; arg.max_reg_power = chandef->chan->max_reg_power * 2; @@ -7161,10 +7356,10 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, return ret; } - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { - arg.ssid = arvif->u.ap.ssid; - arg.ssid_len = arvif->u.ap.ssid_len; - arg.hidden_ssid = arvif->u.ap.hidden_ssid; + if (ahvif->vdev_type == WMI_VDEV_TYPE_AP) { + arg.ssid = ahvif->u.ap.ssid; + arg.ssid_len = ahvif->u.ap.ssid_len; + arg.hidden_ssid = ahvif->u.ap.hidden_ssid; /* For now allow DFS for AP mode */ arg.chan_radar = !!(chandef->chan->flags & IEEE80211_CHAN_RADAR); @@ -7211,7 +7406,7 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, ar->num_started_vdevs++; ath12k_dbg(ab, ATH12K_DBG_MAC, "vdev %pM started, vdev_id %d\n", - arvif->vif->addr, arvif->vdev_id); + ahvif->vif->addr, arvif->vdev_id); /* Enable CAC Flag in the driver by checking the channel DFS cac time, * i.e dfs_cac_ms value which will be valid only for radar channels @@ -7220,7 +7415,7 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, * during CAC. */ /* TODO: Set the flag for other interface types as required */ - if (arvif->vdev_type == WMI_VDEV_TYPE_AP && + if (arvif->ahvif->vdev_type == WMI_VDEV_TYPE_AP && chandef->chan->dfs_cac_ms && chandef->chan->dfs_state == NL80211_DFS_USABLE) { set_bit(ATH12K_CAC_RUNNING, &ar->dev_flags); @@ -7237,13 +7432,13 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, return 0; } -static int ath12k_mac_vdev_start(struct ath12k_vif *arvif, +static int ath12k_mac_vdev_start(struct ath12k_link_vif *arvif, struct ieee80211_chanctx_conf *ctx) { return ath12k_mac_vdev_start_restart(arvif, ctx, false); } -static int ath12k_mac_vdev_restart(struct ath12k_vif *arvif, +static int ath12k_mac_vdev_restart(struct ath12k_link_vif *arvif, struct ieee80211_chanctx_conf *ctx) { return ath12k_mac_vdev_start_restart(arvif, ctx, true); @@ -7261,8 +7456,12 @@ static void ath12k_mac_change_chanctx_cnt_iter(void *data, u8 *mac, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_mac_change_chanctx_arg *arg = data; + struct ath12k_link_vif *arvif; + + lockdep_assert_held(&ahvif->ah->conf_mutex); + arvif = &ahvif->deflink; if (arvif->ar != arg->ar) return; @@ -7277,9 +7476,13 @@ static void ath12k_mac_change_chanctx_fill_iter(void *data, u8 *mac, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_mac_change_chanctx_arg *arg = data; struct ieee80211_chanctx_conf *ctx; + struct ath12k_link_vif *arvif; + + lockdep_assert_held(&ahvif->ah->conf_mutex); + arvif = &ahvif->deflink; if (arvif->ar != arg->ar) return; @@ -7323,13 +7526,13 @@ static u32 ath12k_mac_nlwidth_to_wmiwidth(enum nl80211_chan_width width) } static int ath12k_mac_update_peer_puncturing_width(struct ath12k *ar, - struct ath12k_vif *arvif, + struct ath12k_link_vif *arvif, struct cfg80211_chan_def def) { u32 param_id, param_value; int ret; - if (arvif->vdev_type != WMI_VDEV_TYPE_STA) + if (arvif->ahvif->vdev_type != WMI_VDEV_TYPE_STA) return 0; param_id = WMI_PEER_CHWIDTH_PUNCTURE_20MHZ_BITMAP; @@ -7355,8 +7558,9 @@ ath12k_mac_update_vif_chan(struct ath12k *ar, { struct ath12k_wmi_vdev_up_params params = {}; struct ath12k_base *ab = ar->ab; + struct ath12k_link_vif *arvif; struct ieee80211_vif *vif; - struct ath12k_vif *arvif; + struct ath12k_vif *ahvif; int ret; int i; bool monitor_vif = false; @@ -7365,7 +7569,8 @@ ath12k_mac_update_vif_chan(struct ath12k *ar, for (i = 0; i < n_vifs; i++) { vif = vifs[i].vif; - arvif = ath12k_vif_to_arvif(vif); + ahvif = ath12k_vif_to_ahvif(vif); + arvif = &ahvif->deflink; if (vif->type == NL80211_IFTYPE_MONITOR) monitor_vif = true; @@ -7415,10 +7620,14 @@ ath12k_mac_update_vif_chan(struct ath12k *ar, memset(¶ms, 0, sizeof(params)); params.vdev_id = arvif->vdev_id; - params.aid = arvif->aid; + params.aid = ahvif->aid; params.bssid = arvif->bssid; if (vif->mbssid_tx_vif) { - params.tx_bssid = ath12k_vif_to_arvif(vif->mbssid_tx_vif)->bssid; + struct ath12k_vif *ahvif = + ath12k_vif_to_ahvif(vif->mbssid_tx_vif); + struct ath12k_link_vif *arvif = &ahvif->deflink; + + params.tx_bssid = arvif->bssid; params.nontx_profile_idx = vif->bss_conf.bssid_index; params.nontx_profile_cnt = 1 << vif->bss_conf.bssid_indicator; } @@ -7481,12 +7690,16 @@ static void ath12k_mac_op_change_chanctx(struct ieee80211_hw *hw, struct ieee80211_chanctx_conf *ctx, u32 changed) { + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; struct ath12k_base *ab; + mutex_lock(&ah->conf_mutex); ar = ath12k_get_ar_by_ctx(hw, ctx); - if (!ar) + if (!ar) { + mutex_unlock(&ah->conf_mutex); return; + } ab = ar->ab; @@ -7511,13 +7724,15 @@ static void ath12k_mac_op_change_chanctx(struct ieee80211_hw *hw, unlock: mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); } static int ath12k_start_vdev_delay(struct ath12k *ar, - struct ath12k_vif *arvif) + struct ath12k_link_vif *arvif) { struct ath12k_base *ab = ar->ab; - struct ieee80211_vif *vif = arvif->vif; + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); int ret; if (WARN_ON(arvif->is_started)) @@ -7531,7 +7746,7 @@ static int ath12k_start_vdev_delay(struct ath12k *ar, return ret; } - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { ret = ath12k_monitor_vdev_up(ar, arvif->vdev_id); if (ret) { ath12k_warn(ab, "failed put monitor up: %d\n", ret); @@ -7551,17 +7766,22 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, struct ieee80211_bss_conf *link_conf, struct ieee80211_chanctx_conf *ctx) { + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; struct ath12k_base *ab; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; int ret; /* For multi radio wiphy, the vdev was not created during add_interface * create now since we have a channel ctx now to assign to a specific ar/fw */ + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; ar = ath12k_mac_assign_vif_to_vdev(hw, vif, ctx); if (!ar) { WARN_ON(1); + mutex_unlock(&ah->conf_mutex); return -EINVAL; } @@ -7577,8 +7797,8 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, /* for some targets bss peer must be created before vdev_start */ if (ab->hw_params->vdev_start_delay && - arvif->vdev_type != WMI_VDEV_TYPE_AP && - arvif->vdev_type != WMI_VDEV_TYPE_MONITOR && + ahvif->vdev_type != WMI_VDEV_TYPE_AP && + ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR && !ath12k_peer_exist_by_vdev_id(ab, arvif->vdev_id)) { memcpy(&arvif->chanctx, ctx, sizeof(*ctx)); ret = 0; @@ -7590,7 +7810,7 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, goto out; } - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { ret = ath12k_mac_monitor_start(ar); if (ret) goto out; @@ -7606,7 +7826,7 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, goto out; } - if (arvif->vdev_type != WMI_VDEV_TYPE_MONITOR && ar->monitor_vdev_created) + if (ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR && ar->monitor_vdev_created) ath12k_mac_monitor_start(ar); arvif->is_started = true; @@ -7615,6 +7835,7 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, out: mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return ret; } @@ -7625,11 +7846,15 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, struct ieee80211_bss_conf *link_conf, struct ieee80211_chanctx_conf *ctx) { + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; struct ath12k_base *ab; - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_vif *arvif; int ret; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; /* The vif is expected to be attached to an ar's VDEV. * We leave the vif/vdev in this function as is * and not delete the vdev symmetric to assign_vif_chanctx() @@ -7637,8 +7862,10 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, * remove_interface() or when there is a change in channel * that moves the vif to a new ar */ - if (!arvif->is_created) + if (!arvif->is_created) { + mutex_unlock(&ah->conf_mutex); return; + } ar = arvif->ar; ab = ar->ab; @@ -7651,18 +7878,19 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, WARN_ON(!arvif->is_started); - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { ret = ath12k_mac_monitor_stop(ar); if (ret) { mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return; } arvif->is_started = false; } - if (arvif->vdev_type != WMI_VDEV_TYPE_STA && - arvif->vdev_type != WMI_VDEV_TYPE_MONITOR) { + if (ahvif->vdev_type != WMI_VDEV_TYPE_STA && + ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR) { ath12k_bss_disassoc(ar, arvif); ret = ath12k_mac_vdev_stop(arvif); if (ret) @@ -7671,11 +7899,12 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, } arvif->is_started = false; - if (arvif->vdev_type != WMI_VDEV_TYPE_MONITOR && + if (ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR && ar->num_started_vdevs == 1 && ar->monitor_vdev_created) ath12k_mac_monitor_stop(ar); mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); } static int @@ -7684,17 +7913,19 @@ ath12k_mac_op_switch_vif_chanctx(struct ieee80211_hw *hw, int n_vifs, enum ieee80211_chanctx_switch_mode mode) { + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; ar = ath12k_get_ar_by_ctx(hw, vifs->old_ctx); if (!ar) return -EINVAL; - + mutex_lock(&ah->conf_mutex); mutex_lock(&ar->conf_mutex); /* Switching channels across radio is not allowed */ if (ar != ath12k_get_ar_by_ctx(hw, vifs->new_ctx)) { mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return -EINVAL; } @@ -7702,8 +7933,8 @@ ath12k_mac_op_switch_vif_chanctx(struct ieee80211_hw *hw, "mac chanctx switch n_vifs %d mode %d\n", n_vifs, mode); ath12k_mac_update_vif_chan(ar, vifs, n_vifs); - mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return 0; } @@ -7711,7 +7942,7 @@ ath12k_mac_op_switch_vif_chanctx(struct ieee80211_hw *hw, static int ath12k_set_vdev_param_to_all_vifs(struct ath12k *ar, int param, u32 value) { - struct ath12k_vif *arvif; + struct ath12k_link_vif *arvif; int ret = 0; mutex_lock(&ar->conf_mutex); @@ -7946,7 +8177,7 @@ ath12k_mac_get_single_legacy_rate(struct ath12k *ar, return 0; } -static int ath12k_mac_set_fixed_rate_params(struct ath12k_vif *arvif, +static int ath12k_mac_set_fixed_rate_params(struct ath12k_link_vif *arvif, u32 rate, u8 nss, u8 sgi, u8 ldpc) { struct ath12k *ar = arvif->ar; @@ -8025,7 +8256,7 @@ ath12k_mac_vht_mcs_range_present(struct ath12k *ar, static void ath12k_mac_set_bitrate_mask_iter(void *data, struct ieee80211_sta *sta) { - struct ath12k_vif *arvif = data; + struct ath12k_link_vif *arvif = data; struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); struct ath12k *ar = arvif->ar; @@ -8042,8 +8273,8 @@ static void ath12k_mac_set_bitrate_mask_iter(void *data, static void ath12k_mac_disable_peer_fixed_rate(void *data, struct ieee80211_sta *sta) { + struct ath12k_link_vif *arvif = data; struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); - struct ath12k_vif *arvif = data; struct ath12k *ar = arvif->ar; int ret; @@ -8065,9 +8296,11 @@ ath12k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, struct ieee80211_vif *vif, const struct cfg80211_bitrate_mask *mask) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_link_vif *arvif; struct cfg80211_chan_def def; - struct ath12k *ar = arvif->ar; + struct ath12k *ar; enum nl80211_band band; const u8 *ht_mcs_mask; const u16 *vht_mcs_mask; @@ -8079,8 +8312,13 @@ ath12k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, int ret; int num_rates; - if (ath12k_mac_vif_chan(vif, &def)) + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; + ar = arvif->ar; + if (ath12k_mac_vif_chan(vif, &def)) { + mutex_unlock(&ah->conf_mutex); return -EPERM; + } band = def.chan->band; ht_mcs_mask = mask->control[band].ht_mcs; @@ -8181,6 +8419,7 @@ ath12k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, mutex_unlock(&ar->conf_mutex); out: + mutex_unlock(&ah->conf_mutex); return ret; } @@ -8191,7 +8430,8 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw, struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k *ar; struct ath12k_base *ab; - struct ath12k_vif *arvif; + struct ath12k_vif *ahvif; + struct ath12k_link_vif *arvif; int recovery_count, i; if (reconfig_type != IEEE80211_RECONFIG_TYPE_RESTART) @@ -8232,11 +8472,12 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw, } list_for_each_entry(arvif, &ar->arvifs, list) { + ahvif = arvif->ahvif; ath12k_dbg(ab, ATH12K_DBG_BOOT, "reconfig cipher %d up %d vdev type %d\n", - arvif->key_cipher, + ahvif->key_cipher, arvif->is_up, - arvif->vdev_type); + ahvif->vdev_type); /* After trigger disconnect, then upper layer will * trigger connect again, then the PN number of @@ -8244,9 +8485,9 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw, * side, hence PN number mismatch will not happen. */ if (arvif->is_up && - arvif->vdev_type == WMI_VDEV_TYPE_STA && - arvif->vdev_subtype == WMI_VDEV_SUBTYPE_NONE) { - ieee80211_hw_restart_disconnect(arvif->vif); + ahvif->vdev_type == WMI_VDEV_TYPE_STA && + ahvif->vdev_subtype == WMI_VDEV_SUBTYPE_NONE) { + ieee80211_hw_restart_disconnect(ahvif->vif); ath12k_dbg(ab, ATH12K_DBG_BOOT, "restart disconnect\n"); @@ -8413,14 +8654,18 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, int duration, enum ieee80211_roc_type type) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k_wmi_scan_req_arg arg; + struct ath12k_link_vif *arvif; struct ath12k *ar, *prev_ar; u32 scan_time_msec; bool create = true; int ret; + mutex_lock(&ah->conf_mutex); + arvif = &ahvif->deflink; + if (ah->num_radio == 1) { WARN_ON(!arvif->is_created); ar = ath12k_ah_to_ar(ah, 0); @@ -8428,8 +8673,10 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, } ar = ath12k_mac_select_scan_device(hw, vif, chan->center_freq); - if (!ar) + if (!ar) { + mutex_unlock(&ah->conf_mutex); return -EINVAL; + } /* If the vif is already assigned to a specific vdev of an ar, * check whether its already started, vdev which is started @@ -8441,11 +8688,15 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, * always on the same band for the vif */ if (arvif->is_created) { - if (WARN_ON(!arvif->ar)) + if (WARN_ON(!arvif->ar)) { + mutex_unlock(&ah->conf_mutex); return -EINVAL; + } - if (ar != arvif->ar && arvif->is_started) + if (ar != arvif->ar && arvif->is_started) { + mutex_unlock(&ah->conf_mutex); return -EBUSY; + } if (ar != arvif->ar) { /* backup the previously used ar ptr, since the vdev delete @@ -8459,6 +8710,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, ath12k_warn(prev_ar->ab, "unable to delete scan vdev for roc: %d\n", ret); + mutex_unlock(&ah->conf_mutex); return ret; } } else { @@ -8473,6 +8725,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, if (ret) { ath12k_warn(ar->ab, "unable to create scan vdev for roc: %d\n", ret); + mutex_unlock(&ah->conf_mutex); return -EINVAL; } } @@ -8555,6 +8808,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, kfree(arg.chan_list); exit: mutex_unlock(&ar->conf_mutex); + mutex_unlock(&ah->conf_mutex); return ret; } @@ -9281,6 +9535,7 @@ static struct ath12k_hw *ath12k_mac_hw_allocate(struct ath12k_base *ab, ah->num_radio = num_pdev_map; mutex_init(&ah->hw_mutex); + mutex_init(&ah->conf_mutex); for (i = 0; i < num_pdev_map; i++) { ab = pdev_map[i].ab; diff --git a/drivers/net/wireless/ath/ath12k/mac.h b/drivers/net/wireless/ath/ath12k/mac.h index 69fd282b9dd3..ef54349cb159 100644 --- a/drivers/net/wireless/ath/ath12k/mac.h +++ b/drivers/net/wireless/ath/ath12k/mac.h @@ -40,6 +40,9 @@ struct ath12k_generic_iter { #define ATH12K_TX_POWER_MAX_VAL 70 #define ATH12K_TX_POWER_MIN_VAL 0 +#define ATH12K_DEFAULT_LINK_ID 0 +#define ATH12K_INVALID_LINK_ID 255 + enum ath12k_supported_bw { ATH12K_BW_20 = 0, ATH12K_BW_40 = 1, @@ -64,9 +67,9 @@ u8 ath12k_mac_hw_rate_to_idx(const struct ieee80211_supported_band *sband, void __ath12k_mac_scan_finish(struct ath12k *ar); void ath12k_mac_scan_finish(struct ath12k *ar); -struct ath12k_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id); -struct ath12k_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, - u32 vdev_id); +struct ath12k_link_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id); +struct ath12k_link_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, + u32 vdev_id); struct ath12k *ath12k_mac_get_ar_by_vdev_id(struct ath12k_base *ab, u32 vdev_id); struct ath12k *ath12k_mac_get_ar_by_pdev_id(struct ath12k_base *ab, u32 pdev_id); diff --git a/drivers/net/wireless/ath/ath12k/p2p.c b/drivers/net/wireless/ath/ath12k/p2p.c index 3a851ee15b2f..84cccf7d91e7 100644 --- a/drivers/net/wireless/ath/ath12k/p2p.c +++ b/drivers/net/wireless/ath/ath12k/p2p.c @@ -69,20 +69,20 @@ static size_t ath12k_p2p_noa_ie_len_compute(const struct ath12k_wmi_p2p_noa_info return len; } -static void ath12k_p2p_noa_ie_assign(struct ath12k_vif *arvif, void *ie, +static void ath12k_p2p_noa_ie_assign(struct ath12k_link_vif *arvif, void *ie, size_t len) { struct ath12k *ar = arvif->ar; lockdep_assert_held(&ar->data_lock); - kfree(arvif->u.ap.noa_data); + kfree(arvif->ahvif->u.ap.noa_data); - arvif->u.ap.noa_data = ie; - arvif->u.ap.noa_len = len; + arvif->ahvif->u.ap.noa_data = ie; + arvif->ahvif->u.ap.noa_len = len; } -static void __ath12k_p2p_noa_update(struct ath12k_vif *arvif, +static void __ath12k_p2p_noa_update(struct ath12k_link_vif *arvif, const struct ath12k_wmi_p2p_noa_info *noa) { struct ath12k *ar = arvif->ar; @@ -105,7 +105,7 @@ static void __ath12k_p2p_noa_update(struct ath12k_vif *arvif, ath12k_p2p_noa_ie_assign(arvif, ie, len); } -void ath12k_p2p_noa_update(struct ath12k_vif *arvif, +void ath12k_p2p_noa_update(struct ath12k_link_vif *arvif, const struct ath12k_wmi_p2p_noa_info *noa) { struct ath12k *ar = arvif->ar; @@ -118,9 +118,12 @@ void ath12k_p2p_noa_update(struct ath12k_vif *arvif, static void ath12k_p2p_noa_update_vdev_iter(void *data, u8 *mac, struct ieee80211_vif *vif) { - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_p2p_noa_arg *arg = data; + struct ath12k_link_vif *arvif; + WARN_ON(!rcu_read_lock_any_held()); + arvif = &ahvif->deflink; if (arvif->ar != arg->ar || arvif->vdev_id != arg->vdev_id) return; diff --git a/drivers/net/wireless/ath/ath12k/p2p.h b/drivers/net/wireless/ath/ath12k/p2p.h index b2eec51a9900..03ee877e6d6b 100644 --- a/drivers/net/wireless/ath/ath12k/p2p.h +++ b/drivers/net/wireless/ath/ath12k/p2p.h @@ -16,7 +16,7 @@ struct ath12k_p2p_noa_arg { const struct ath12k_wmi_p2p_noa_info *noa; }; -void ath12k_p2p_noa_update(struct ath12k_vif *arvif, +void ath12k_p2p_noa_update(struct ath12k_link_vif *arvif, const struct ath12k_wmi_p2p_noa_info *noa); void ath12k_p2p_noa_update_by_vdev_id(struct ath12k *ar, u32 vdev_id, const struct ath12k_wmi_p2p_noa_info *noa); diff --git a/drivers/net/wireless/ath/ath12k/peer.c b/drivers/net/wireless/ath/ath12k/peer.c index 19c0626fbff1..6481f100e6cc 100644 --- a/drivers/net/wireless/ath/ath12k/peer.c +++ b/drivers/net/wireless/ath/ath12k/peer.c @@ -1,7 +1,7 @@ // SPDX-License-Identifier: BSD-3-Clause-Clear /* * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved. - * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved. + * Copyright (c) 2021-2022, 2024 Qualcomm Innovation Center, Inc. All rights reserved. */ #include "core.h" @@ -261,10 +261,11 @@ static int ath12k_wait_for_peer_created(struct ath12k *ar, int vdev_id, const u8 return ath12k_wait_for_peer_common(ar->ab, vdev_id, addr, true); } -int ath12k_peer_create(struct ath12k *ar, struct ath12k_vif *arvif, +int ath12k_peer_create(struct ath12k *ar, struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_create_arg *arg) { + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ath12k_peer *peer; int ret; @@ -326,7 +327,7 @@ int ath12k_peer_create(struct ath12k *ar, struct ath12k_vif *arvif, peer->pdev_idx = ar->pdev_idx; peer->sta = sta; - if (arvif->vif->type == NL80211_IFTYPE_STATION) { + if (vif->type == NL80211_IFTYPE_STATION) { arvif->ast_hash = peer->ast_hash; arvif->ast_idx = peer->hw_peer_id; } diff --git a/drivers/net/wireless/ath/ath12k/peer.h b/drivers/net/wireless/ath/ath12k/peer.h index 7b3500b5c8c2..b955f0cdf598 100644 --- a/drivers/net/wireless/ath/ath12k/peer.h +++ b/drivers/net/wireless/ath/ath12k/peer.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: BSD-3-Clause-Clear */ /* * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved. - * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved. + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved. */ #ifndef ATH12K_PEER_H @@ -59,7 +59,7 @@ struct ath12k_peer *ath12k_peer_find_by_addr(struct ath12k_base *ab, struct ath12k_peer *ath12k_peer_find_by_id(struct ath12k_base *ab, int peer_id); void ath12k_peer_cleanup(struct ath12k *ar, u32 vdev_id); int ath12k_peer_delete(struct ath12k *ar, u32 vdev_id, u8 *addr); -int ath12k_peer_create(struct ath12k *ar, struct ath12k_vif *arvif, +int ath12k_peer_create(struct ath12k *ar, struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_create_arg *arg); int ath12k_wait_for_peer_delete_done(struct ath12k *ar, u32 vdev_id, diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c index d6e1d1398cdb..ef02c90f63b8 100644 --- a/drivers/net/wireless/ath/ath12k/wmi.c +++ b/drivers/net/wireless/ath/ath12k/wmi.c @@ -6683,7 +6683,8 @@ ath12k_wmi_process_csa_switch_count_event(struct ath12k_base *ab, const u32 *vdev_ids) { int i; - struct ath12k_vif *arvif; + struct ath12k_link_vif *arvif; + struct ath12k_vif *ahvif; /* Finish CSA once the switch count becomes NULL */ if (ev->current_switch_count) @@ -6698,9 +6699,10 @@ ath12k_wmi_process_csa_switch_count_event(struct ath12k_base *ab, vdev_ids[i]); continue; } + ahvif = arvif->ahvif; - if (arvif->is_up && arvif->vif->bss_conf.csa_active) - ieee80211_csa_finish(arvif->vif, 0); + if (arvif->is_up && ahvif->vif->bss_conf.csa_active) + ieee80211_csa_finish(ahvif->vif, 0); } rcu_read_unlock(); } @@ -7252,13 +7254,13 @@ ath12k_wmi_send_unit_test_cmd(struct ath12k *ar, int ath12k_wmi_simulate_radar(struct ath12k *ar) { - struct ath12k_vif *arvif; + struct ath12k_link_vif *arvif; u32 dfs_args[DFS_MAX_TEST_ARGS]; struct wmi_unit_test_cmd wmi_ut; bool arvif_found = false; list_for_each_entry(arvif, &ar->arvifs, list) { - if (arvif->is_started && arvif->vdev_type == WMI_VDEV_TYPE_AP) { + if (arvif->is_started && arvif->ahvif->vdev_type == WMI_VDEV_TYPE_AP) { arvif_found = true; break; } -- 2.34.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling 2024-06-17 13:16 ` [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling Rameshkumar Sundaram @ 2024-06-18 7:47 ` Baochen Qiang 2024-06-18 8:37 ` Kalle Valo 2024-06-20 16:52 ` Rameshkumar Sundaram 0 siblings, 2 replies; 11+ messages in thread From: Baochen Qiang @ 2024-06-18 7:47 UTC (permalink / raw) To: Rameshkumar Sundaram, ath12k; +Cc: linux-wireless, Sriram R On 6/17/2024 9:16 PM, Rameshkumar Sundaram wrote: > From: Sriram R <quic_srirrama@quicinc.com> > > To prepare the driver for MLO support, split the driver vif > data structure to scale for multiple links. This requires changing > the use of arvif to per link and not per hw which can now > comprise of multiple links. > Also since most configurations from mac80211 are done per link, do refactoring > of the driver functions to apply these configurations at link level. > > Split ath12k_vif which is the driver private of ieee80211_vif to store > link specific information as ath12k_link_vif. For default use cases > the ath12k vif will have a preallocated link vif called deflink which will > be used by non ML and the first link vif of ML vif. > > With MLO Support to be added, remaining link vifs will be allocated during > channel assignment where vdev create/start happens. These link vifs will be > freed during interface down. > > Current ath12k_vif(arvif) structure > > +---------------+ +---------------+ +---------------+ > | ieee80211_vif | | ieee80211_vif | | ieee80211_vif | > | private data | | private data | | private data | > | | | | | | > | ath12k_vif | | ath12k_vif | | ath12k_vif | > | (arvif) | | (arvif) | | (arvif) | > | | | | | | > | +----------+ | | +----------+ | | +----------+ | > | |*ar (2GHz)| | | |*ar (5GHz)| | | |*ar (2GHz)| | > | +----------+ | | +----------+ | | +----------+ | > | | | | | | > +---------------+ +---------------+ +---------------+ > > Proposed ath12k_vif(ahvif) containing ath12k_link_vif(s) (arvif) > (deflink is preallocated member which is always the first link if > ieee80211_vif is MLD and is the only link otherwise) > > +---------------------------------+ > | ieee80211_vif | > | private data | > | | > | ath12k_vif(ahvif) | > | | > | +-------------------------------+ > | |ath12k_link_vif deflink (arvif)| > | | +---------------+ | > | | | *ar(2GHz) | | > | +-------------------------------+ > | +-------------------------------+ > | | ath12k_link_vif *link (arvif)| > | | +---------------+ | > | | | *ar(5GHz) | | > | +-------------------------------+ > | +-------------------------------+ > | | ath12k_link_vif *link (arvif)| > | | +---------------+ | > | | | *ar(6GHz) | | > | +-------------------------------+ > | | > +---------------------------------+ > > To refactor existing ath12k_vif to make use of link vifs, following > changes are made, > > 1. ath12k_vif now called by variable name ahvif stores multiple > arvifs(ah12k_link_vif) and also has a back pointer to ieee80211_vif. > > 2. In this patch set, only deflink is used to be on par with the > existing code. When MLO support is added the link id will be used to > fetch the arvif. > > 3. For mac80211 ops which doesn't use specific link_id, the config or info > is common for the vif, hence apply the config to all link vifs. > The links_map in the ahvif, will be used to identify all the link vifs that > are setup. > > 4. Change ath12k_vif_to_arvif() as ath12k_vif_to_ahvif() to fetch the > hw level vif. The link vif can be fetched from ahvif->link[], or the > deflink can be accessed via ahvif->deflink. API to access link > vif(arvif) by passing link_id can be introduced with MLO Support. > > 5. The ieee80211_vif can be accessed from ahvif using ath12k_vif_to_vif() > > Locking: > Currently modifications to members of arvif and arsta are protected by ar->conf_mutex > and it stays as such. > Now with these hw level structure (ahvif) being introduced, any modifications > to its members and link objects (i.e., arvifs[] which are dynamically allocated) > needs to be protected for writing and ah->conf_mutex is used for the same. > Also, atomic contexts(say WMI events and certain mac_ops) that we currently have in driver > will not(shouldn't be allowed) do any modifications but can read them and > rcu_read_lock() is used for the same. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Signed-off-by: Sriram R <quic_srirrama@quicinc.com> > Co-developed-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> > Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/core.h | 69 ++- > drivers/net/wireless/ath/ath12k/dp.c | 21 +- > drivers/net/wireless/ath/ath12k/dp.h | 3 +- > drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +- > drivers/net/wireless/ath/ath12k/dp_rx.h | 2 +- > drivers/net/wireless/ath/ath12k/dp_tx.c | 9 +- > drivers/net/wireless/ath/ath12k/dp_tx.h | 2 +- > drivers/net/wireless/ath/ath12k/mac.c | 733 ++++++++++++++++-------- > drivers/net/wireless/ath/ath12k/mac.h | 9 +- > drivers/net/wireless/ath/ath12k/p2p.c | 17 +- > drivers/net/wireless/ath/ath12k/p2p.h | 2 +- > drivers/net/wireless/ath/ath12k/peer.c | 7 +- > drivers/net/wireless/ath/ath12k/peer.h | 4 +- > drivers/net/wireless/ath/ath12k/wmi.c | 12 +- > 14 files changed, 592 insertions(+), 300 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h > index b483899ca136..d47b6413aaad 100644 > --- a/drivers/net/wireless/ath/ath12k/core.h > +++ b/drivers/net/wireless/ath/ath12k/core.h > @@ -229,10 +229,8 @@ struct ath12k_vif_cache { > u32 bss_conf_changed; > }; > > -struct ath12k_vif { > +struct ath12k_link_vif { > u32 vdev_id; > - enum wmi_vdev_type vdev_type; > - enum wmi_vdev_subtype vdev_subtype; > u32 beacon_interval; > u32 dtim_period; > u16 ast_hash; > @@ -242,13 +240,38 @@ struct ath12k_vif { > u8 search_type; > > struct ath12k *ar; > - struct ieee80211_vif *vif; > > int bank_id; > u8 vdev_id_check_en; > > struct wmi_wmm_params_all_arg wmm_params; > struct list_head list; > + > + bool is_created; > + bool is_started; > + bool is_up; > + u8 bssid[ETH_ALEN]; > + struct cfg80211_bitrate_mask bitrate_mask; > + struct delayed_work connection_loss_work; > + int num_legacy_stations; > + int rtscts_prot_mode; > + int txpower; > + bool rsnie_present; > + bool wpaie_present; > + struct ieee80211_chanctx_conf chanctx; > + u8 vdev_stats_id; > + u32 punct_bitmap; > + u8 link_id; > + struct ath12k_vif *ahvif; > + struct ath12k_vif_cache *cache; > +}; > + > +struct ath12k_vif { > + enum wmi_vdev_type vdev_type; > + enum wmi_vdev_subtype vdev_subtype; > + struct ieee80211_vif *vif; > + struct ath12k_hw *ah; > + > union { > struct { > u32 uapsd; > @@ -266,31 +289,21 @@ struct ath12k_vif { > } ap; > } u; > > - bool is_created; > - bool is_started; > - bool is_up; > u32 aid; > - u8 bssid[ETH_ALEN]; > - struct cfg80211_bitrate_mask bitrate_mask; > - struct delayed_work connection_loss_work; > - int num_legacy_stations; > - int rtscts_prot_mode; > - int txpower; > - bool rsnie_present; > - bool wpaie_present; > - struct ieee80211_chanctx_conf chanctx; > u32 key_cipher; > u8 tx_encap_type; > - u8 vdev_stats_id; > - u32 punct_bitmap; > bool ps; > - struct ath12k_vif_cache *cache; > + > + struct ath12k_link_vif deflink; > + struct ath12k_link_vif __rcu *link[IEEE80211_MLD_MAX_NUM_LINKS]; > + /* indicates bitmap of link vif created in FW */ > + u16 links_map; > }; > > struct ath12k_vif_iter { > u32 vdev_id; > struct ath12k *ar; > - struct ath12k_vif *arvif; > + struct ath12k_link_vif *arvif; > }; > > #define HAL_AST_IDX_INVALID 0xFFFF > @@ -426,7 +439,7 @@ struct ath12k_wbm_tx_stats { > }; > > struct ath12k_sta { > - struct ath12k_vif *arvif; > + struct ath12k_link_vif *arvif; > > /* the following are protected by ar->data_lock */ > u32 changed; /* IEEE80211_RC_* */ > @@ -543,7 +556,7 @@ struct ath12k { > */ > struct mutex conf_mutex; > /* protects the radio specific data like debug stats, ppdu_stats_info stats, > - * vdev_stop_status info, scan data, ath12k_sta info, ath12k_vif info, > + * vdev_stop_status info, scan data, ath12k_sta info, ath12k_link_vif info, > * channel context data, survey info, test mode data. > */ > spinlock_t data_lock; > @@ -639,6 +652,11 @@ struct ath12k_hw { > enum ath12k_hw_state state; > bool regd_updated; > bool use_6ghz_regd; > + > + /* To synchronize concurrent access of ahvif->link[] > + * between mac80211 operations. > + */ > + struct mutex conf_mutex; > u8 num_radio; > > /* Keep last */ > @@ -995,7 +1013,7 @@ static inline struct ath12k_skb_rxcb *ATH12K_SKB_RXCB(struct sk_buff *skb) > return (struct ath12k_skb_rxcb *)skb->cb; > } > > -static inline struct ath12k_vif *ath12k_vif_to_arvif(struct ieee80211_vif *vif) > +static inline struct ath12k_vif *ath12k_vif_to_ahvif(struct ieee80211_vif *vif) > { > return (struct ath12k_vif *)vif->drv_priv; > } > @@ -1005,6 +1023,11 @@ static inline struct ath12k_sta *ath12k_sta_to_arsta(struct ieee80211_sta *sta) > return (struct ath12k_sta *)sta->drv_priv; > } > > +static inline struct ieee80211_vif *ath12k_vif_to_vif(struct ath12k_vif *ahvif) better naming as ath12k_ahvif_to_vif()? > +{ > + return container_of((void *)ahvif, struct ieee80211_vif, drv_priv); > +} > + > static inline struct ath12k *ath12k_ab_to_ar(struct ath12k_base *ab, > int mac_id) > { > diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c > index 61aa78d8bd8c..30aac0dd5a80 100644 > --- a/drivers/net/wireless/ath/ath12k/dp.c > +++ b/drivers/net/wireless/ath/ath12k/dp.c > @@ -327,20 +327,22 @@ int ath12k_dp_srng_setup(struct ath12k_base *ab, struct dp_srng *ring, > } > > static > -u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, struct ath12k_vif *arvif) > +u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, > + struct ath12k_link_vif *arvif) > { > u32 bank_config = 0; > + struct ath12k_vif *ahvif = arvif->ahvif; > > /* Only valid for raw frames with HW crypto enabled. > * With SW crypto, mac80211 sets key per packet > */ > - if (arvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && > + if (ahvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && > test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags)) > bank_config |= > - u32_encode_bits(ath12k_dp_tx_get_encrypt_type(arvif->key_cipher), > + u32_encode_bits(ath12k_dp_tx_get_encrypt_type(ahvif->key_cipher), > HAL_TX_BANK_CONFIG_ENCRYPT_TYPE); > > - bank_config |= u32_encode_bits(arvif->tx_encap_type, > + bank_config |= u32_encode_bits(ahvif->tx_encap_type, > HAL_TX_BANK_CONFIG_ENCAP_TYPE); > bank_config |= u32_encode_bits(0, HAL_TX_BANK_CONFIG_SRC_BUFFER_SWAP) | > u32_encode_bits(0, HAL_TX_BANK_CONFIG_LINK_META_SWAP) | > @@ -355,7 +357,7 @@ u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, struct ath12k_vif > HAL_TX_ADDRY_EN), > HAL_TX_BANK_CONFIG_ADDRY_EN); > > - bank_config |= u32_encode_bits(ieee80211_vif_is_mesh(arvif->vif) ? 3 : 0, > + bank_config |= u32_encode_bits(ieee80211_vif_is_mesh(ahvif->vif) ? 3 : 0, > HAL_TX_BANK_CONFIG_MESH_EN) | > u32_encode_bits(arvif->vdev_id_check_en, > HAL_TX_BANK_CONFIG_VDEV_ID_CHECK_EN); > @@ -365,7 +367,8 @@ u32 ath12k_dp_tx_get_vdev_bank_config(struct ath12k_base *ab, struct ath12k_vif > return bank_config; > } > > -static int ath12k_dp_tx_get_bank_profile(struct ath12k_base *ab, struct ath12k_vif *arvif, > +static int ath12k_dp_tx_get_bank_profile(struct ath12k_base *ab, > + struct ath12k_link_vif *arvif, > struct ath12k_dp *dp) > { > int bank_id = DP_INVALID_BANK_ID; > @@ -1099,9 +1102,9 @@ int ath12k_dp_htt_connect(struct ath12k_dp *dp) > return 0; > } > > -static void ath12k_dp_update_vdev_search(struct ath12k_vif *arvif) > +static void ath12k_dp_update_vdev_search(struct ath12k_link_vif *arvif) > { > - switch (arvif->vdev_type) { > + switch (arvif->ahvif->vdev_type) { > case WMI_VDEV_TYPE_STA: > /* TODO: Verify the search type and flags since ast hash > * is not part of peer mapv3 > @@ -1120,7 +1123,7 @@ static void ath12k_dp_update_vdev_search(struct ath12k_vif *arvif) > } > } > > -void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_vif *arvif) > +void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_link_vif *arvif) > { > struct ath12k_base *ab = ar->ab; > > diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h > index 742094545089..4161486e98ab 100644 > --- a/drivers/net/wireless/ath/ath12k/dp.h > +++ b/drivers/net/wireless/ath/ath12k/dp.h > @@ -16,6 +16,7 @@ struct ath12k_base; > struct ath12k_peer; > struct ath12k_dp; > struct ath12k_vif; > +struct ath12k_link_vif; > struct hal_tcl_status_ring; > struct ath12k_ext_irq_grp; > > @@ -1810,7 +1811,7 @@ int ath12k_dp_service_srng(struct ath12k_base *ab, > struct ath12k_ext_irq_grp *irq_grp, > int budget); > int ath12k_dp_htt_connect(struct ath12k_dp *dp); > -void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_vif *arvif); > +void ath12k_dp_vdev_tx_attach(struct ath12k *ar, struct ath12k_link_vif *arvif); > void ath12k_dp_free(struct ath12k_base *ab); > int ath12k_dp_alloc(struct ath12k_base *ab); > void ath12k_dp_cc_config(struct ath12k_base *ab); > diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c > index 54aea3c22311..781cb7af8cf0 100644 > --- a/drivers/net/wireless/ath/ath12k/dp_rx.c > +++ b/drivers/net/wireless/ath/ath12k/dp_rx.c > @@ -1090,7 +1090,7 @@ int ath12k_dp_rx_ampdu_stop(struct ath12k *ar, > return ret; > } > > -int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_vif *arvif, > +int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_link_vif *arvif, > const u8 *peer_addr, > enum set_key_cmd key_cmd, > struct ieee80211_key_conf *key) > diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.h b/drivers/net/wireless/ath/ath12k/dp_rx.h > index 2ff421160181..8c1bccc4f0f0 100644 > --- a/drivers/net/wireless/ath/ath12k/dp_rx.h > +++ b/drivers/net/wireless/ath/ath12k/dp_rx.h > @@ -88,7 +88,7 @@ int ath12k_dp_rx_ampdu_start(struct ath12k *ar, > struct ieee80211_ampdu_params *params); > int ath12k_dp_rx_ampdu_stop(struct ath12k *ar, > struct ieee80211_ampdu_params *params); > -int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_vif *arvif, > +int ath12k_dp_rx_peer_pn_replay_config(struct ath12k_link_vif *arvif, > const u8 *peer_addr, > enum set_key_cmd key_cmd, > struct ieee80211_key_conf *key); > diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c > index c4cfa7cf7cb9..fb5de5c2794d 100644 > --- a/drivers/net/wireless/ath/ath12k/dp_tx.c > +++ b/drivers/net/wireless/ath/ath12k/dp_tx.c > @@ -10,7 +10,7 @@ > #include "hw.h" > > static enum hal_tcl_encap_type > -ath12k_dp_tx_get_encap_type(struct ath12k_vif *arvif, struct sk_buff *skb) > +ath12k_dp_tx_get_encap_type(struct ath12k_link_vif *arvif, struct sk_buff *skb) > { > struct ieee80211_tx_info *tx_info = IEEE80211_SKB_CB(skb); > struct ath12k_base *ab = arvif->ar->ab; > @@ -162,7 +162,7 @@ static int ath12k_dp_prepare_htt_metadata(struct sk_buff *skb) > return 0; > } > > -int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, > +int ath12k_dp_tx(struct ath12k *ar, struct ath12k_link_vif *arvif, > struct sk_buff *skb) > { > struct ath12k_base *ab = ar->ab; > @@ -176,6 +176,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, > struct sk_buff *skb_ext_desc; > struct hal_srng *tcl_ring; > struct ieee80211_hdr *hdr = (void *)skb->data; > + struct ath12k_vif *ahvif = arvif->ahvif; > struct dp_tx_ring *tx_ring; > u8 pool_id; > u8 hal_ring_id; > @@ -219,7 +220,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, > ti.bank_id = arvif->bank_id; > ti.meta_data_flags = arvif->tcl_metadata; > > - if (arvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && > + if (ahvif->tx_encap_type == HAL_TCL_ENCAP_TYPE_RAW && > test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ar->ab->dev_flags)) { > if (skb_cb->flags & ATH12K_SKB_CIPHER_SET) { > ti.encrypt_type = > @@ -304,7 +305,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, > ti.desc_id = tx_desc->desc_id; > ti.data_len = skb->len; > skb_cb->paddr = ti.paddr; > - skb_cb->vif = arvif->vif; > + skb_cb->vif = ahvif->vif; > skb_cb->ar = ar; > > if (msdu_ext_desc) { > diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.h b/drivers/net/wireless/ath/ath12k/dp_tx.h > index 55ff8cc721e3..46dce23501f3 100644 > --- a/drivers/net/wireless/ath/ath12k/dp_tx.h > +++ b/drivers/net/wireless/ath/ath12k/dp_tx.h > @@ -16,7 +16,7 @@ struct ath12k_dp_htt_wbm_tx_status { > }; > > int ath12k_dp_tx_htt_h2t_ver_req_msg(struct ath12k_base *ab); > -int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif, > +int ath12k_dp_tx(struct ath12k *ar, struct ath12k_link_vif *arvif, > struct sk_buff *skb); > void ath12k_dp_tx_completion_handler(struct ath12k_base *ab, int ring_id); > > diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c > index 2259ce22cc8b..8bd8efcc1264 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.c > +++ b/drivers/net/wireless/ath/ath12k/mac.c > @@ -247,7 +247,7 @@ static const u32 ath12k_smps_map[] = { > }; > > static int ath12k_start_vdev_delay(struct ath12k *ar, > - struct ath12k_vif *arvif); > + struct ath12k_link_vif *arvif); > static void ath12k_mac_stop(struct ath12k *ar); > static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif); > static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif); > @@ -536,18 +536,22 @@ static void ath12k_get_arvif_iter(void *data, u8 *mac, > struct ieee80211_vif *vif) > { > struct ath12k_vif_iter *arvif_iter = data; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif = &ahvif->deflink; > > if (arvif->vdev_id == arvif_iter->vdev_id && > arvif->ar == arvif_iter->ar) > arvif_iter->arvif = arvif; > } > > -struct ath12k_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id) > +struct ath12k_link_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id) > { > struct ath12k_vif_iter arvif_iter = {}; > u32 flags; > > + /* To use the arvif returned, caller must have held rcu read lock. > + */ > + WARN_ON(!rcu_read_lock_any_held()); why rcu lock needed here? what needs protecting? > arvif_iter.vdev_id = vdev_id; > arvif_iter.ar = ar; > > @@ -564,12 +568,12 @@ struct ath12k_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id) > return arvif_iter.arvif; > } > > -struct ath12k_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, > - u32 vdev_id) > +struct ath12k_link_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, > + u32 vdev_id) > { > int i; > struct ath12k_pdev *pdev; > - struct ath12k_vif *arvif; > + struct ath12k_link_vif *arvif; > > for (i = 0; i < ab->num_radios; i++) { > pdev = rcu_dereference(ab->pdevs_active[i]); > @@ -655,7 +659,8 @@ static struct ath12k *ath12k_get_ar_by_ctx(struct ieee80211_hw *hw, > static struct ath12k *ath12k_get_ar_by_vif(struct ieee80211_hw *hw, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif = &ahvif->deflink; > struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > > /* If there is one pdev within ah, then we return > @@ -691,7 +696,7 @@ static void ath12k_pdev_caps_update(struct ath12k *ar) > static int ath12k_mac_txpower_recalc(struct ath12k *ar) > { > struct ath12k_pdev *pdev = ar->pdev; > - struct ath12k_vif *arvif; > + struct ath12k_link_vif *arvif; > int ret, txpower = -1; > u32 param; > > @@ -745,7 +750,7 @@ static int ath12k_mac_txpower_recalc(struct ath12k *ar) > return ret; > } > > -static int ath12k_recalc_rtscts_prot(struct ath12k_vif *arvif) > +static int ath12k_recalc_rtscts_prot(struct ath12k_link_vif *arvif) > { > struct ath12k *ar = arvif->ar; > u32 vdev_param, rts_cts; > @@ -784,7 +789,7 @@ static int ath12k_recalc_rtscts_prot(struct ath12k_vif *arvif) > return ret; > } > > -static int ath12k_mac_set_kickout(struct ath12k_vif *arvif) > +static int ath12k_mac_set_kickout(struct ath12k_link_vif *arvif) > { > struct ath12k *ar = arvif->ar; > u32 param; > @@ -1147,8 +1152,9 @@ static int ath12k_mac_monitor_stop(struct ath12k *ar) > return ret; > } > > -static int ath12k_mac_vdev_stop(struct ath12k_vif *arvif) > +static int ath12k_mac_vdev_stop(struct ath12k_link_vif *arvif) > { > + struct ath12k_vif *ahvif = arvif->ahvif; > struct ath12k *ar = arvif->ar; > int ret; > > @@ -1174,7 +1180,7 @@ static int ath12k_mac_vdev_stop(struct ath12k_vif *arvif) > > ar->num_started_vdevs--; > ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "vdev %pM stopped, vdev_id %d\n", > - arvif->vif->addr, arvif->vdev_id); > + ahvif->vif->addr, arvif->vdev_id); > > if (test_bit(ATH12K_CAC_RUNNING, &ar->dev_flags)) { > clear_bit(ATH12K_CAC_RUNNING, &ar->dev_flags); > @@ -1242,7 +1248,7 @@ static int ath12k_mac_op_config(struct ieee80211_hw *hw, u32 changed) > return ret; > } > > -static int ath12k_mac_setup_bcn_p2p_ie(struct ath12k_vif *arvif, > +static int ath12k_mac_setup_bcn_p2p_ie(struct ath12k_link_vif *arvif, > struct sk_buff *bcn) > { > struct ath12k *ar = arvif->ar; > @@ -1299,7 +1305,7 @@ static int ath12k_mac_remove_vendor_ie(struct sk_buff *skb, unsigned int oui, > return 0; > } > > -static void ath12k_mac_set_arvif_ies(struct ath12k_vif *arvif, struct sk_buff *bcn, > +static void ath12k_mac_set_arvif_ies(struct ath12k_link_vif *arvif, struct sk_buff *bcn, > u8 bssid_index, bool *nontx_profile_found) > { > struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)bcn->data; > @@ -1391,19 +1397,22 @@ static void ath12k_mac_set_arvif_ies(struct ath12k_vif *arvif, struct sk_buff *b > } > } > > -static int ath12k_mac_setup_bcn_tmpl_ema(struct ath12k_vif *arvif) > +static int ath12k_mac_setup_bcn_tmpl_ema(struct ath12k_link_vif *arvif) > { > - struct ieee80211_bss_conf *bss_conf = &arvif->vif->bss_conf; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_bss_conf *bss_conf = &ahvif->vif->bss_conf; > struct ath12k_wmi_bcn_tmpl_ema_arg ema_args; > struct ieee80211_ema_beacons *beacons; > - struct ath12k_vif *tx_arvif; > + struct ath12k_link_vif *tx_arvif; > bool nontx_profile_found = false; > + struct ath12k_vif *tx_ahvif; > int ret = 0; > u8 i; > > - tx_arvif = ath12k_vif_to_arvif(arvif->vif->mbssid_tx_vif); > + tx_ahvif = ath12k_vif_to_ahvif(ahvif->vif->mbssid_tx_vif); > + tx_arvif = &tx_ahvif->deflink; > beacons = ieee80211_beacon_get_template_ema_list(ath12k_ar_to_hw(tx_arvif->ar), > - tx_arvif->vif, 0); > + tx_ahvif->vif, 0); > if (!beacons || !beacons->cnt) { > ath12k_warn(arvif->ar->ab, > "failed to get ema beacon templates from mac80211\n"); > @@ -1441,22 +1450,25 @@ static int ath12k_mac_setup_bcn_tmpl_ema(struct ath12k_vif *arvif) > return ret; > } > > -static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) > +static int ath12k_mac_setup_bcn_tmpl(struct ath12k_link_vif *arvif) > { > - struct ath12k_vif *tx_arvif = arvif; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); > + struct ath12k_link_vif *tx_arvif = arvif; > struct ath12k *ar = arvif->ar; > struct ath12k_base *ab = ar->ab; > - struct ieee80211_vif *vif = arvif->vif; > struct ieee80211_mutable_offsets offs = {}; > + struct ath12k_vif *tx_ahvif = ahvif; > bool nontx_profile_found = false; > struct sk_buff *bcn; > int ret; > > - if (arvif->vdev_type != WMI_VDEV_TYPE_AP) > + if (ahvif->vdev_type != WMI_VDEV_TYPE_AP) > return 0; > > if (vif->mbssid_tx_vif) { > - tx_arvif = ath12k_vif_to_arvif(vif->mbssid_tx_vif); > + tx_ahvif = ath12k_vif_to_ahvif(vif->mbssid_tx_vif); > + tx_arvif = &tx_ahvif->deflink; > if (tx_arvif != arvif && arvif->is_up) > return 0; > > @@ -1464,7 +1476,7 @@ static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) > return ath12k_mac_setup_bcn_tmpl_ema(arvif); > } > > - bcn = ieee80211_beacon_get_template(ath12k_ar_to_hw(tx_arvif->ar), tx_arvif->vif, > + bcn = ieee80211_beacon_get_template(ath12k_ar_to_hw(tx_arvif->ar), tx_ahvif->vif, > &offs, 0); > if (!bcn) { > ath12k_warn(ab, "failed to get beacon template from mac80211\n"); > @@ -1475,14 +1487,14 @@ static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) > ath12k_mac_set_arvif_ies(arvif, bcn, 0, NULL); > } else { > ath12k_mac_set_arvif_ies(arvif, bcn, > - arvif->vif->bss_conf.bssid_index, > + ahvif->vif->bss_conf.bssid_index, > &nontx_profile_found); > if (!nontx_profile_found) > ath12k_warn(ab, > "nontransmitted profile not found in beacon template\n"); > } > > - if (arvif->vif->type == NL80211_IFTYPE_AP && arvif->vif->p2p) { > + if (ahvif->vif->type == NL80211_IFTYPE_AP && ahvif->vif->p2p) { > ret = ath12k_mac_setup_bcn_p2p_ie(arvif, bcn); > if (ret) { > ath12k_warn(ab, "failed to setup P2P GO bcn ie: %d\n", > @@ -1516,10 +1528,11 @@ static int ath12k_mac_setup_bcn_tmpl(struct ath12k_vif *arvif) > return ret; > } > > -static void ath12k_control_beaconing(struct ath12k_vif *arvif, > +static void ath12k_control_beaconing(struct ath12k_link_vif *arvif, > struct ieee80211_bss_conf *info) > { > struct ath12k_wmi_vdev_up_params params = {}; > + struct ath12k_vif *ahvif = arvif->ahvif; > struct ath12k *ar = arvif->ar; > int ret; > > @@ -1543,15 +1556,19 @@ static void ath12k_control_beaconing(struct ath12k_vif *arvif, > return; > } > > - arvif->aid = 0; > + ahvif->aid = 0; > > ether_addr_copy(arvif->bssid, info->bssid); > > params.vdev_id = arvif->vdev_id; > - params.aid = arvif->aid; > + params.aid = ahvif->aid; > params.bssid = arvif->bssid; > - if (arvif->vif->mbssid_tx_vif) { > - params.tx_bssid = ath12k_vif_to_arvif(arvif->vif->mbssid_tx_vif)->bssid; > + if (ahvif->vif->mbssid_tx_vif) { > + struct ath12k_vif *tx_ahvif = > + ath12k_vif_to_ahvif(ahvif->vif->mbssid_tx_vif); > + struct ath12k_link_vif *tx_arvif = &tx_ahvif->deflink; > + > + params.tx_bssid = tx_arvif->bssid; > params.nontx_profile_idx = info->bssid_index; > params.nontx_profile_cnt = 1 << info->bssid_indicator; > } > @@ -1572,7 +1589,8 @@ static void ath12k_mac_handle_beacon_iter(void *data, u8 *mac, > { > struct sk_buff *skb = data; > struct ieee80211_mgmt *mgmt = (void *)skb->data; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif = &ahvif->deflink; > > if (vif->type != NL80211_IFTYPE_STATION) > return; > @@ -1595,7 +1613,8 @@ static void ath12k_mac_handle_beacon_miss_iter(void *data, u8 *mac, > struct ieee80211_vif *vif) > { > u32 *vdev_id = data; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif = &ahvif->deflink; > struct ath12k *ar = arvif->ar; > struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); > > @@ -1626,9 +1645,9 @@ void ath12k_mac_handle_beacon_miss(struct ath12k *ar, u32 vdev_id) > > static void ath12k_mac_vif_sta_connection_loss_work(struct work_struct *work) > { > - struct ath12k_vif *arvif = container_of(work, struct ath12k_vif, > - connection_loss_work.work); > - struct ieee80211_vif *vif = arvif->vif; > + struct ath12k_link_vif *arvif = container_of(work, struct ath12k_link_vif, > + connection_loss_work.work); > + struct ieee80211_vif *vif = arvif->ahvif->vif; > > if (!arvif->is_up) > return; > @@ -1641,12 +1660,15 @@ static void ath12k_peer_assoc_h_basic(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); > + struct ath12k_link_vif *arvif; > u32 aid; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > if (vif->type == NL80211_IFTYPE_STATION) > aid = vif->cfg.aid; > else > @@ -1667,16 +1689,19 @@ static void ath12k_peer_assoc_h_crypto(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ieee80211_bss_conf *info = &vif->bss_conf; > + struct ath12k_link_vif *arvif; > struct cfg80211_chan_def def; > struct cfg80211_bss *bss; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); > const u8 *rsnie = NULL; > const u8 *wpaie = NULL; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) > return; > > @@ -1729,19 +1754,22 @@ static void ath12k_peer_assoc_h_rates(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct wmi_rate_set_arg *rateset = &arg->peer_legacy_rates; > struct cfg80211_chan_def def; > const struct ieee80211_supported_band *sband; > const struct ieee80211_rate *rates; > struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); > + struct ath12k_link_vif *arvif; > enum nl80211_band band; > u32 ratemask; > u8 rate; > int i; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) > return; > > @@ -1792,8 +1820,9 @@ static void ath12k_peer_assoc_h_ht(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > const struct ieee80211_sta_ht_cap *ht_cap = &sta->deflink.ht_cap; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_link_vif *arvif; > struct cfg80211_chan_def def; > enum nl80211_band band; > const u8 *ht_mcs_mask; > @@ -1801,8 +1830,10 @@ static void ath12k_peer_assoc_h_ht(struct ath12k *ar, > u8 max_nss; > u32 stbc; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) > return; > > @@ -1953,8 +1984,9 @@ static void ath12k_peer_assoc_h_vht(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > const struct ieee80211_sta_vht_cap *vht_cap = &sta->deflink.vht_cap; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_link_vif *arvif; > struct cfg80211_chan_def def; > enum nl80211_band band; > const u16 *vht_mcs_mask; > @@ -1963,6 +1995,9 @@ static void ath12k_peer_assoc_h_vht(struct ath12k *ar, > u8 max_nss, vht_mcs; > int i; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > + arvif = &ahvif->deflink; > + > if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) > return; > > @@ -2300,9 +2335,9 @@ static void ath12k_peer_assoc_h_qos(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > > - switch (arvif->vdev_type) { > + switch (ahvif->vdev_type) { > case WMI_VDEV_TYPE_AP: > if (sta->wme) { > /* TODO: Check WME vs QoS */ > @@ -2332,7 +2367,7 @@ static void ath12k_peer_assoc_h_qos(struct ath12k *ar, > } > > static int ath12k_peer_assoc_qos_ap(struct ath12k *ar, > - struct ath12k_vif *arvif, > + struct ath12k_link_vif *arvif, > struct ieee80211_sta *sta) > { > struct ath12k_wmi_ap_ps_arg arg; > @@ -2498,13 +2533,17 @@ static void ath12k_peer_assoc_h_phymode(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > struct cfg80211_chan_def def; > enum nl80211_band band; > const u8 *ht_mcs_mask; > const u16 *vht_mcs_mask; > enum wmi_phy_mode phymode = MODE_UNKNOWN; > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > + > + arvif = &ahvif->deflink; > if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) > return; > > @@ -2643,13 +2682,17 @@ static void ath12k_peer_assoc_h_eht(struct ath12k *ar, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_assoc_arg *arg) > { > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > const struct ieee80211_sta_eht_cap *eht_cap = &sta->deflink.eht_cap; > const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; > const struct ieee80211_eht_mcs_nss_supp_20mhz_only *bw_20; > const struct ieee80211_eht_mcs_nss_supp_bw *bw; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_link_vif *arvif; > u32 *rx_mcs, *tx_mcs; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > + > + arvif = &ahvif->deflink; > if (!sta->deflink.he_cap.has_he || !eht_cap->has_eht) > return; > > @@ -2749,7 +2792,7 @@ static void ath12k_peer_assoc_prepare(struct ath12k *ar, > /* TODO: amsdu_disable req? */ > } > > -static int ath12k_setup_peer_smps(struct ath12k *ar, struct ath12k_vif *arvif, > +static int ath12k_setup_peer_smps(struct ath12k *ar, struct ath12k_link_vif *arvif, > const u8 *addr, > const struct ieee80211_sta_ht_cap *ht_cap, > const struct ieee80211_he_6ghz_capa *he_6ghz_capa) > @@ -2766,10 +2809,11 @@ static int ath12k_setup_peer_smps(struct ath12k *ar, struct ath12k_vif *arvif, > } > > static void ath12k_bss_assoc(struct ath12k *ar, > - struct ath12k_vif *arvif, > + struct ath12k_link_vif *arvif, > struct ieee80211_bss_conf *bss_conf) > { > - struct ieee80211_vif *vif = arvif->vif; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); > struct ath12k_wmi_vdev_up_params params = {}; > struct ath12k_wmi_peer_assoc_arg peer_arg; > struct ieee80211_sta *ap_sta; > @@ -2780,7 +2824,7 @@ static void ath12k_bss_assoc(struct ath12k *ar, > lockdep_assert_held(&ar->conf_mutex); > > ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "mac vdev %i assoc bssid %pM aid %d\n", > - arvif->vdev_id, arvif->bssid, arvif->aid); > + arvif->vdev_id, arvif->bssid, ahvif->aid); > > rcu_read_lock(); > > @@ -2820,11 +2864,11 @@ static void ath12k_bss_assoc(struct ath12k *ar, > > WARN_ON(arvif->is_up); > > - arvif->aid = vif->cfg.aid; > + ahvif->aid = vif->cfg.aid; > ether_addr_copy(arvif->bssid, bss_conf->bssid); > > params.vdev_id = arvif->vdev_id; > - params.aid = arvif->aid; > + params.aid = ahvif->aid; > params.bssid = arvif->bssid; > ret = ath12k_wmi_vdev_up(ar, ¶ms); > if (ret) { > @@ -2865,7 +2909,7 @@ static void ath12k_bss_assoc(struct ath12k *ar, > } > > static void ath12k_bss_disassoc(struct ath12k *ar, > - struct ath12k_vif *arvif) > + struct ath12k_link_vif *arvif) > { > int ret; > > @@ -2913,17 +2957,20 @@ static void ath12k_recalculate_mgmt_rate(struct ath12k *ar, > struct ieee80211_vif *vif, > struct cfg80211_chan_def *def) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); > const struct ieee80211_supported_band *sband; > + struct ath12k_link_vif *arvif; > u8 basic_rate_idx; > int hw_rate_code; > u32 vdev_param; > u16 bitrate; > int ret; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > sband = hw->wiphy->bands[def->chan->band]; > basic_rate_idx = ffs(vif->bss_conf.basic_rates) - 1; > bitrate = sband->bitrates[basic_rate_idx].bitrate; > @@ -2947,9 +2994,10 @@ static void ath12k_recalculate_mgmt_rate(struct ath12k *ar, > ath12k_warn(ar->ab, "failed to set beacon tx rate %d\n", ret); > } > > -static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, > +static int ath12k_mac_fils_discovery(struct ath12k_link_vif *arvif, > struct ieee80211_bss_conf *info) > { > + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); > struct ath12k *ar = arvif->ar; > struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); > struct sk_buff *tmpl; > @@ -2960,7 +3008,7 @@ static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, > if (info->fils_discovery.max_interval) { > interval = info->fils_discovery.max_interval; > > - tmpl = ieee80211_get_fils_discovery_tmpl(hw, arvif->vif); > + tmpl = ieee80211_get_fils_discovery_tmpl(hw, vif); > if (tmpl) > ret = ath12k_wmi_fils_discovery_tmpl(ar, arvif->vdev_id, > tmpl); > @@ -2968,8 +3016,7 @@ static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, > unsol_bcast_probe_resp_enabled = 1; > interval = info->unsol_bcast_probe_resp_interval; > > - tmpl = ieee80211_get_unsol_bcast_probe_resp_tmpl(hw, > - arvif->vif); > + tmpl = ieee80211_get_unsol_bcast_probe_resp_tmpl(hw, vif); > if (tmpl) > ret = ath12k_wmi_probe_resp_tmpl(ar, arvif->vdev_id, > tmpl); > @@ -2994,10 +3041,10 @@ static int ath12k_mac_fils_discovery(struct ath12k_vif *arvif, > return ret; > } > > -static void ath12k_mac_vif_setup_ps(struct ath12k_vif *arvif) > +static void ath12k_mac_vif_setup_ps(struct ath12k_link_vif *arvif) > { > struct ath12k *ar = arvif->ar; > - struct ieee80211_vif *vif = arvif->vif; > + struct ieee80211_vif *vif = arvif->ahvif->vif; > struct ieee80211_conf *conf = &ath12k_ar_to_hw(ar)->conf; > enum wmi_sta_powersave_param param; > enum wmi_sta_ps_mode psmode; > @@ -3010,7 +3057,7 @@ static void ath12k_mac_vif_setup_ps(struct ath12k_vif *arvif) > if (vif->type != NL80211_IFTYPE_STATION) > return; > > - enable_ps = arvif->ps; > + enable_ps = arvif->ahvif->ps; > if (enable_ps) { > psmode = WMI_STA_PS_MODE_ENABLED; > param = WMI_STA_PS_PARAM_INACTIVITY_TIME; > @@ -3042,11 +3089,12 @@ static void ath12k_mac_vif_setup_ps(struct ath12k_vif *arvif) > } > > static void ath12k_mac_bss_info_changed(struct ath12k *ar, > - struct ath12k_vif *arvif, > + struct ath12k_link_vif *arvif, > struct ieee80211_bss_conf *info, > u64 changed) > { > - struct ieee80211_vif *vif = arvif->vif; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); > struct ieee80211_vif_cfg *vif_cfg = &vif->cfg; > struct cfg80211_chan_def def; > u32 param_id, param_value; > @@ -3116,10 +3164,10 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, > > if (changed & BSS_CHANGED_SSID && > vif->type == NL80211_IFTYPE_AP) { > - arvif->u.ap.ssid_len = vif->cfg.ssid_len; > + ahvif->u.ap.ssid_len = vif->cfg.ssid_len; > if (vif->cfg.ssid_len) > - memcpy(arvif->u.ap.ssid, vif->cfg.ssid, vif->cfg.ssid_len); > - arvif->u.ap.hidden_ssid = info->hidden_ssid; > + memcpy(ahvif->u.ap.ssid, vif->cfg.ssid, vif->cfg.ssid_len); > + ahvif->u.ap.hidden_ssid = info->hidden_ssid; > } > > if (changed & BSS_CHANGED_BSSID && !is_zero_ether_addr(info->bssid)) > @@ -3230,7 +3278,7 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, > } > > if (changed & BSS_CHANGED_MCAST_RATE && > - !ath12k_mac_vif_chan(arvif->vif, &def)) { > + !ath12k_mac_vif_chan(vif, &def)) { > band = def.chan->band; > mcast_rate = vif->bss_conf.mcast_rate[band]; > > @@ -3274,7 +3322,7 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, > } > > if (changed & BSS_CHANGED_BASIC_RATES && > - !ath12k_mac_vif_chan(arvif->vif, &def)) > + !ath12k_mac_vif_chan(vif, &def)) > ath12k_recalculate_mgmt_rate(ar, vif, &def); > > if (changed & BSS_CHANGED_TWT) { > @@ -3320,12 +3368,12 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, > > if (changed & BSS_CHANGED_PS && > ar->ab->hw_params->supports_sta_ps) { > - arvif->ps = vif_cfg->ps; > + ahvif->ps = vif_cfg->ps; > ath12k_mac_vif_setup_ps(arvif); > } > } > > -static struct ath12k_vif_cache *ath12k_arvif_get_cache(struct ath12k_vif *arvif) > +static struct ath12k_vif_cache *ath12k_arvif_get_cache(struct ath12k_link_vif *arvif) > { > if (!arvif->cache) > arvif->cache = kzalloc(sizeof(*arvif->cache), GFP_KERNEL); > @@ -3333,7 +3381,7 @@ static struct ath12k_vif_cache *ath12k_arvif_get_cache(struct ath12k_vif *arvif) > return arvif->cache; > } > > -static void ath12k_arvif_put_cache(struct ath12k_vif *arvif) > +static void ath12k_arvif_put_cache(struct ath12k_link_vif *arvif) > { > kfree(arvif->cache); > arvif->cache = NULL; > @@ -3344,10 +3392,17 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, > struct ieee80211_bss_conf *info, > u64 changed) > { > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_vif_cache *cache; > + struct ath12k_link_vif *arvif; > > + mutex_lock(&ah->conf_mutex); > + /* TODO use info->link_id and fetch corresponding ahvif->link[] > + * with MLO support. > + */ > + arvif = &ahvif->deflink; > ar = ath12k_get_ar_by_vif(hw, vif); > > /* if the vdev is not created on a certain radio, > @@ -3355,10 +3410,17 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, > */ > > if (!ar) { > + /* TODO Once link vif is fetched based on link id from > + * info, avoid using the deflink above and cache the link > + * configs in ahvif per link. > + */ > cache = ath12k_arvif_get_cache(arvif); > - if (!cache) > + if (!cache) { > + mutex_unlock(&ah->conf_mutex); > return; > + } > arvif->cache->bss_conf_changed |= changed; > + mutex_unlock(&ah->conf_mutex); > return; > } > > @@ -3367,6 +3429,7 @@ static void ath12k_mac_op_bss_info_changed(struct ieee80211_hw *hw, > ath12k_mac_bss_info_changed(ar, arvif, info, changed); > > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > } > > static struct ath12k* > @@ -3575,13 +3638,17 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, > { > struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar, *prev_ar; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > struct cfg80211_scan_request *req = &hw_req->req; > struct ath12k_wmi_scan_req_arg arg = {}; > int ret; > int i; > bool create = true; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > + > if (ah->num_radio == 1) { > WARN_ON(!arvif->is_created); > ar = ath12k_ah_to_ar(ah, 0); > @@ -3592,9 +3659,10 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, > * requested in the hw_req, select the corresponding radio > */ > ar = ath12k_mac_select_scan_device(hw, vif, hw_req->req.channels[0]->center_freq); > - if (!ar) > + if (!ar) { > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > - > + } > /* If the vif is already assigned to a specific vdev of an ar, > * check whether its already started, vdev which is started > * are not allowed to switch to a new radio. > @@ -3605,11 +3673,15 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, > * always on the same band for the vif > */ > if (arvif->is_created) { > - if (WARN_ON(!arvif->ar)) > + if (WARN_ON(!arvif->ar)) { > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > + } > > - if (ar != arvif->ar && arvif->is_started) > + if (ar != arvif->ar && arvif->is_started) { > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > + } > > if (ar != arvif->ar) { > /* backup the previously used ar ptr, since the vdev delete > @@ -3632,6 +3704,7 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, > mutex_unlock(&ar->conf_mutex); > if (ret) { > ath12k_warn(ar->ab, "unable to create scan vdev %d\n", ret); > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > } > } > @@ -3714,21 +3787,30 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, > kfree(arg.extraie.ptr); > > mutex_unlock(&ar->conf_mutex); > - > + mutex_unlock(&ah->conf_mutex); > return ret; > } > > static void ath12k_mac_op_cancel_hw_scan(struct ieee80211_hw *hw, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > + struct ath12k_link_vif *arvif; > struct ath12k *ar; > > - if (!arvif->is_created) > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > + > + if (!arvif->is_created) { > + mutex_unlock(&ah->conf_mutex); > return; > + } > > ar = arvif->ar; > > + mutex_unlock(&ah->conf_mutex); > + > mutex_lock(&ar->conf_mutex); > ath12k_scan_abort(ar); > mutex_unlock(&ar->conf_mutex); > @@ -3736,7 +3818,7 @@ static void ath12k_mac_op_cancel_hw_scan(struct ieee80211_hw *hw, > cancel_delayed_work_sync(&ar->scan.timeout); > } > > -static int ath12k_install_key(struct ath12k_vif *arvif, > +static int ath12k_install_key(struct ath12k_link_vif *arvif, > struct ieee80211_key_conf *key, > enum set_key_cmd cmd, > const u8 *macaddr, u32 flags) > @@ -3751,6 +3833,8 @@ static int ath12k_install_key(struct ath12k_vif *arvif, > .key_flags = flags, > .macaddr = macaddr, > }; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); > > lockdep_assert_held(&arvif->ar->conf_mutex); > > @@ -3803,13 +3887,13 @@ static int ath12k_install_key(struct ath12k_vif *arvif, > if (!wait_for_completion_timeout(&ar->install_key_done, 1 * HZ)) > return -ETIMEDOUT; > > - if (ether_addr_equal(macaddr, arvif->vif->addr)) > - arvif->key_cipher = key->cipher; > + if (ether_addr_equal(macaddr, vif->addr)) > + ahvif->key_cipher = key->cipher; > > return ar->install_key_status ? -EINVAL : 0; > } > > -static int ath12k_clear_peer_keys(struct ath12k_vif *arvif, > +static int ath12k_clear_peer_keys(struct ath12k_link_vif *arvif, > const u8 *addr) > { > struct ath12k *ar = arvif->ar; > @@ -3855,22 +3939,25 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, > struct ieee80211_vif *vif, struct ieee80211_sta *sta, > struct ieee80211_key_conf *key) > { > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_base *ab = ar->ab; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_link_vif *arvif; > struct ath12k_peer *peer; > struct ath12k_sta *arsta; > const u8 *peer_addr; > int ret = 0; > u32 flags = 0; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > if (test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags)) > return 1; > > if (sta) > peer_addr = sta->addr; > - else if (arvif->vdev_type == WMI_VDEV_TYPE_STA) > + else if (ahvif->vdev_type == WMI_VDEV_TYPE_STA) > peer_addr = vif->bss_conf.bssid; > else > peer_addr = vif->addr; > @@ -3966,41 +4053,60 @@ static int ath12k_mac_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, > struct ieee80211_vif *vif, struct ieee80211_sta *sta, > struct ieee80211_key_conf *key) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > + struct ath12k_link_vif *arvif; > struct ath12k_vif_cache *cache; > struct ath12k *ar; > int ret; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > /* BIP needs to be done in software */ > if (key->cipher == WLAN_CIPHER_SUITE_AES_CMAC || > key->cipher == WLAN_CIPHER_SUITE_BIP_GMAC_128 || > key->cipher == WLAN_CIPHER_SUITE_BIP_GMAC_256 || > - key->cipher == WLAN_CIPHER_SUITE_BIP_CMAC_256) > + key->cipher == WLAN_CIPHER_SUITE_BIP_CMAC_256) { > + mutex_unlock(&ah->conf_mutex); > return 1; > + } > > - if (key->keyidx > WMI_MAX_KEY_INDEX) > + if (key->keyidx > WMI_MAX_KEY_INDEX) { > + mutex_unlock(&ah->conf_mutex); > return -ENOSPC; > + } > > ar = ath12k_get_ar_by_vif(hw, vif); > if (!ar) { > /* ar is expected to be valid when sta ptr is available */ > if (sta) { > WARN_ON_ONCE(1); > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > } > > cache = ath12k_arvif_get_cache(arvif); > - if (!cache) > + if (!cache) { > + mutex_unlock(&ah->conf_mutex); > return -ENOSPC; > + } > cache->key_conf.cmd = cmd; > cache->key_conf.key = key; > cache->key_conf.changed = true; > + mutex_unlock(&ah->conf_mutex); > return 0; > } > > + /* Note: Currently only deflink of ahvif is used here, once MLO > + * support is added the allocated links (i.e ahvif->links[]) > + * should be use based on link id passed from mac80211 and such link > + * access needs to be protected with ah->conf_mutex. > + */ > + > mutex_lock(&ar->conf_mutex); > ret = ath12k_mac_set_key(ar, cmd, vif, sta, key); > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > return ret; > } > > @@ -4019,7 +4125,7 @@ ath12k_mac_bitrate_mask_num_vht_rates(struct ath12k *ar, > } > > static int > -ath12k_mac_set_peer_vht_fixed_rate(struct ath12k_vif *arvif, > +ath12k_mac_set_peer_vht_fixed_rate(struct ath12k_link_vif *arvif, > struct ieee80211_sta *sta, > const struct cfg80211_bitrate_mask *mask, > enum nl80211_band band) > @@ -4069,16 +4175,19 @@ static int ath12k_station_assoc(struct ath12k *ar, > struct ieee80211_sta *sta, > bool reassoc) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_wmi_peer_assoc_arg peer_arg; > int ret; > struct cfg80211_chan_def def; > enum nl80211_band band; > + struct ath12k_link_vif *arvif; > struct cfg80211_bitrate_mask *mask; > u8 num_vht_rates; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) > return -EPERM; > > @@ -4152,11 +4261,14 @@ static int ath12k_station_disassoc(struct ath12k *ar, > struct ieee80211_vif *vif, > struct ieee80211_sta *sta) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > int ret; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > if (!sta->wme) { > arvif->num_legacy_stations--; > ret = ath12k_recalc_rtscts_prot(arvif); > @@ -4176,8 +4288,8 @@ static int ath12k_station_disassoc(struct ath12k *ar, > static void ath12k_sta_rc_update_wk(struct work_struct *wk) > { > struct ath12k *ar; > - struct ath12k_vif *arvif; > struct ath12k_sta *arsta; > + struct ath12k_link_vif *arvif; > struct ieee80211_sta *sta; > struct cfg80211_chan_def def; > enum nl80211_band band; > @@ -4188,13 +4300,15 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) > const struct cfg80211_bitrate_mask *mask; > struct ath12k_wmi_peer_assoc_arg peer_arg; > enum wmi_phy_mode peer_phymode; > + struct ieee80211_vif *vif; > > arsta = container_of(wk, struct ath12k_sta, update_wk); > sta = container_of((void *)arsta, struct ieee80211_sta, drv_priv); > arvif = arsta->arvif; > + vif = ath12k_vif_to_vif(arvif->ahvif); > ar = arvif->ar; > > - if (WARN_ON(ath12k_mac_vif_chan(arvif->vif, &def))) > + if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) > return; > > band = def.chan->band; > @@ -4220,7 +4334,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) > ath12k_mac_max_vht_nss(vht_mcs_mask))); > > if (changed & IEEE80211_RC_BW_CHANGED) { > - ath12k_peer_assoc_h_phymode(ar, arvif->vif, sta, &peer_arg); > + ath12k_peer_assoc_h_phymode(ar, vif, sta, &peer_arg); > peer_phymode = peer_arg.peer_phymode; > > if (bw > bw_prev) { > @@ -4315,7 +4429,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) > * is provided in the new bitrate mask we set the > * other rates using peer_assoc command. > */ > - ath12k_peer_assoc_prepare(ar, arvif->vif, sta, > + ath12k_peer_assoc_prepare(ar, vif, sta, > &peer_arg, true); > > err = ath12k_wmi_send_peer_assoc_cmd(ar, &peer_arg); > @@ -4332,14 +4446,14 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) > mutex_unlock(&ar->conf_mutex); > } > > -static int ath12k_mac_inc_num_stations(struct ath12k_vif *arvif, > +static int ath12k_mac_inc_num_stations(struct ath12k_link_vif *arvif, > struct ieee80211_sta *sta) > { > struct ath12k *ar = arvif->ar; > > lockdep_assert_held(&ar->conf_mutex); > > - if (arvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) > + if (arvif->ahvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) > return 0; > > if (ar->num_stations >= ar->max_num_stations) > @@ -4350,14 +4464,14 @@ static int ath12k_mac_inc_num_stations(struct ath12k_vif *arvif, > return 0; > } > > -static void ath12k_mac_dec_num_stations(struct ath12k_vif *arvif, > +static void ath12k_mac_dec_num_stations(struct ath12k_link_vif *arvif, > struct ieee80211_sta *sta) > { > struct ath12k *ar = arvif->ar; > > lockdep_assert_held(&ar->conf_mutex); > > - if (arvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) > + if (arvif->ahvif->vdev_type == WMI_VDEV_TYPE_STA && !sta->tdls) > return; > > ar->num_stations--; > @@ -4368,20 +4482,22 @@ static int ath12k_mac_station_add(struct ath12k *ar, > struct ieee80211_sta *sta) > { > struct ath12k_base *ab = ar->ab; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); > struct ath12k_wmi_peer_create_arg peer_param; > + struct ath12k_link_vif *arvif; > int ret; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > ret = ath12k_mac_inc_num_stations(arvif, sta); > if (ret) { > ath12k_warn(ab, "refusing to associate station: too many connected already (%d)\n", > ar->max_num_stations); > goto exit; > } > - > arsta->rx_stats = kzalloc(sizeof(*arsta->rx_stats), GFP_KERNEL); > if (!arsta->rx_stats) { > ret = -ENOMEM; > @@ -4422,7 +4538,7 @@ static int ath12k_mac_station_add(struct ath12k *ar, > > if (ab->hw_params->vdev_start_delay && > !arvif->is_started && > - arvif->vdev_type != WMI_VDEV_TYPE_AP) { > + arvif->ahvif->vdev_type != WMI_VDEV_TYPE_AP) { > ret = ath12k_start_vdev_delay(ar, arvif); > if (ret) { > ath12k_warn(ab, "failed to delay vdev start: %d\n", ret); > @@ -4477,12 +4593,17 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, > enum ieee80211_sta_state old_state, > enum ieee80211_sta_state new_state) > { > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k *ar; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); > + struct ath12k_link_vif *arvif; > struct ath12k_peer *peer; > int ret = 0; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > + > /* cancel must be done outside the mutex to avoid deadlock */ > if ((old_state == IEEE80211_STA_NONE && > new_state == IEEE80211_STA_NOTEXIST)) > @@ -4491,9 +4612,9 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, > ar = ath12k_get_ar_by_vif(hw, vif); > if (!ar) { > WARN_ON_ONCE(1); > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > } > - > mutex_lock(&ar->conf_mutex); > > if (old_state == IEEE80211_STA_NOTEXIST && > @@ -4508,7 +4629,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, > sta->addr, arvif->vdev_id); > } else if ((old_state == IEEE80211_STA_NONE && > new_state == IEEE80211_STA_NOTEXIST)) { > - if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { > + if (ahvif->vdev_type == WMI_VDEV_TYPE_STA) { > ath12k_bss_disassoc(ar, arvif); > ret = ath12k_mac_vdev_stop(arvif); > if (ret) > @@ -4596,6 +4717,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, > } > > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > > return ret; > } > @@ -4606,20 +4728,28 @@ static int ath12k_mac_op_sta_set_txpwr(struct ieee80211_hw *hw, > { > struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > int ret; > s16 txpwr; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > + > if (sta->deflink.txpwr.type == NL80211_TX_POWER_AUTOMATIC) { > txpwr = 0; > } else { > txpwr = sta->deflink.txpwr.power; > - if (!txpwr) > + if (!txpwr) { > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > + } > } > > - if (txpwr > ATH12K_TX_POWER_MAX_VAL || txpwr < ATH12K_TX_POWER_MIN_VAL) > + if (txpwr > ATH12K_TX_POWER_MAX_VAL || txpwr < ATH12K_TX_POWER_MIN_VAL) { > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > + } > > ar = ath12k_ah_to_ar(ah, 0); > > @@ -4635,6 +4765,7 @@ static int ath12k_mac_op_sta_set_txpwr(struct ieee80211_hw *hw, > > out: > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > return ret; > } > > @@ -4645,7 +4776,8 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, > { > struct ath12k *ar; > struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > struct ath12k_peer *peer; > u32 bw, smps; > > @@ -4655,11 +4787,14 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, > return; > } > > + rcu_read_lock(); > + arvif = &ahvif->deflink; does ath12k_vif::deflink need rcu protect? note it is not declared as rcu*, and even mac80211 uses it without holding such lock. See ieee80211_mgd_auth() { struct ieee80211_link_data *link; ... if() ... else link = &sdata->deflink; ... } > spin_lock_bh(&ar->ab->base_lock); > > peer = ath12k_peer_find(ar->ab, arvif->vdev_id, sta->addr); > if (!peer) { > spin_unlock_bh(&ar->ab->base_lock); > + rcu_read_unlock(); > ath12k_warn(ar->ab, "mac sta rc update failed to find peer %pM on vdev %i\n", > sta->addr, arvif->vdev_id); > return; > @@ -4712,16 +4847,18 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, > spin_unlock_bh(&ar->data_lock); > > ieee80211_queue_work(hw, &arsta->update_wk); > + rcu_read_unlock(); > } > > -static int ath12k_conf_tx_uapsd(struct ath12k_vif *arvif, > +static int ath12k_conf_tx_uapsd(struct ath12k_link_vif *arvif, > u16 ac, bool enable) > { > struct ath12k *ar = arvif->ar; > + struct ath12k_vif *ahvif = arvif->ahvif; > u32 value; > int ret; > > - if (arvif->vdev_type != WMI_VDEV_TYPE_STA) > + if (ahvif->vdev_type != WMI_VDEV_TYPE_STA) > return 0; > > switch (ac) { > @@ -4744,19 +4881,19 @@ static int ath12k_conf_tx_uapsd(struct ath12k_vif *arvif, > } > > if (enable) > - arvif->u.sta.uapsd |= value; > + ahvif->u.sta.uapsd |= value; > else > - arvif->u.sta.uapsd &= ~value; > + ahvif->u.sta.uapsd &= ~value; > > ret = ath12k_wmi_set_sta_ps_param(ar, arvif->vdev_id, > WMI_STA_PS_PARAM_UAPSD, > - arvif->u.sta.uapsd); > + ahvif->u.sta.uapsd); > if (ret) { > ath12k_warn(ar->ab, "could not set uapsd params %d\n", ret); > goto exit; > } > > - if (arvif->u.sta.uapsd) > + if (ahvif->u.sta.uapsd) > value = WMI_STA_PS_RX_WAKE_POLICY_POLL_UAPSD; > else > value = WMI_STA_PS_RX_WAKE_POLICY_WAKE; > @@ -4771,7 +4908,7 @@ static int ath12k_conf_tx_uapsd(struct ath12k_vif *arvif, > return ret; > } > > -static int ath12k_mac_conf_tx(struct ath12k_vif *arvif, > +static int ath12k_mac_conf_tx(struct ath12k_link_vif *arvif, > unsigned int link_id, u16 ac, > const struct ieee80211_tx_queue_params *params) > { > @@ -4829,27 +4966,34 @@ static int ath12k_mac_op_conf_tx(struct ieee80211_hw *hw, > unsigned int link_id, u16 ac, > const struct ieee80211_tx_queue_params *params) > { > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > + struct ath12k_link_vif *arvif; > + struct ath12k_vif_cache *cache; > struct ath12k *ar; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > - struct ath12k_vif_cache *cache = arvif->cache; > int ret; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > ar = ath12k_get_ar_by_vif(hw, vif); > if (!ar) { > /* cache the info and apply after vdev is created */ > cache = ath12k_arvif_get_cache(arvif); > - if (!cache) > + if (!cache) { > + mutex_unlock(&ah->conf_mutex); > return -ENOSPC; > + } > cache->tx_conf.changed = true; > cache->tx_conf.ac = ac; > cache->tx_conf.tx_queue_params = *params; > + mutex_unlock(&ah->conf_mutex); > return 0; > } > > mutex_lock(&ar->conf_mutex); > ret = ath12k_mac_conf_tx(arvif, link_id, ac, params); > mutex_unlock(&ar->conf_mutex); > - > + mutex_unlock(&ah->conf_mutex); > return ret; > } > > @@ -4919,10 +5063,11 @@ ath12k_create_ht_cap(struct ath12k *ar, u32 ar_ht_cap, u32 rate_cap_rx_chainmask > return ht_cap; > } > > -static int ath12k_mac_set_txbf_conf(struct ath12k_vif *arvif) > +static int ath12k_mac_set_txbf_conf(struct ath12k_link_vif *arvif) > { > u32 value = 0; > struct ath12k *ar = arvif->ar; > + struct ath12k_vif *ahvif = arvif->ahvif; > int nsts; > int sound_dim; > u32 vht_cap = ar->pdev->cap.vht_cap; > @@ -4950,7 +5095,7 @@ static int ath12k_mac_set_txbf_conf(struct ath12k_vif *arvif) > value |= WMI_VDEV_PARAM_TXBF_SU_TX_BFER; > > if ((vht_cap & IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE) && > - arvif->vdev_type == WMI_VDEV_TYPE_AP) > + ahvif->vdev_type == WMI_VDEV_TYPE_AP) > value |= WMI_VDEV_PARAM_TXBF_MU_TX_BFER; > } > > @@ -4958,7 +5103,7 @@ static int ath12k_mac_set_txbf_conf(struct ath12k_vif *arvif) > value |= WMI_VDEV_PARAM_TXBF_SU_TX_BFEE; > > if ((vht_cap & IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE) && > - arvif->vdev_type == WMI_VDEV_TYPE_STA) > + ahvif->vdev_type == WMI_VDEV_TYPE_STA) > value |= WMI_VDEV_PARAM_TXBF_MU_TX_BFEE; > } > > @@ -5619,7 +5764,7 @@ static int ath12k_mac_vif_txmgmt_idr_remove(int buf_id, void *skb, void *ctx) > return 0; > } > > -static int ath12k_mac_mgmt_tx_wmi(struct ath12k *ar, struct ath12k_vif *arvif, > +static int ath12k_mac_mgmt_tx_wmi(struct ath12k *ar, struct ath12k_link_vif *arvif, > struct sk_buff *skb) > { > struct ath12k_base *ab = ar->ab; > @@ -5687,7 +5832,8 @@ static void ath12k_mgmt_over_wmi_tx_work(struct work_struct *work) > { > struct ath12k *ar = container_of(work, struct ath12k, wmi_mgmt_tx_work); > struct ath12k_skb_cb *skb_cb; > - struct ath12k_vif *arvif; > + struct ath12k_vif *ahvif; > + struct ath12k_link_vif *arvif; > struct sk_buff *skb; > int ret; > > @@ -5699,8 +5845,8 @@ static void ath12k_mgmt_over_wmi_tx_work(struct work_struct *work) > continue; > } > > - arvif = ath12k_vif_to_arvif(skb_cb->vif); > - > + ahvif = ath12k_vif_to_ahvif(skb_cb->vif); > + arvif = &ahvif->deflink; > if (ar->allocated_vdev_map & (1LL << arvif->vdev_id)) { > ret = ath12k_mac_mgmt_tx_wmi(ar, arvif, skb); > if (ret) { > @@ -5755,18 +5901,18 @@ static void ath12k_mac_add_p2p_noa_ie(struct ath12k *ar, > struct sk_buff *skb, > bool is_prb_rsp) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > > if (likely(!is_prb_rsp)) > return; > > spin_lock_bh(&ar->data_lock); > > - if (arvif->u.ap.noa_data && > - !pskb_expand_head(skb, 0, arvif->u.ap.noa_len, > + if (ahvif->u.ap.noa_data && > + !pskb_expand_head(skb, 0, ahvif->u.ap.noa_len, > GFP_ATOMIC)) > - skb_put_data(skb, arvif->u.ap.noa_data, > - arvif->u.ap.noa_len); > + skb_put_data(skb, ahvif->u.ap.noa_data, > + ahvif->u.ap.noa_len); > > spin_unlock_bh(&ar->data_lock); > } > @@ -5778,7 +5924,8 @@ static void ath12k_mac_op_tx(struct ieee80211_hw *hw, > struct ath12k_skb_cb *skb_cb = ATH12K_SKB_CB(skb); > struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb); > struct ieee80211_vif *vif = info->control.vif; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif = &ahvif->deflink; > struct ath12k *ar = arvif->ar; > struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)skb->data; > struct ieee80211_key_conf *key = info->control.hw_key; > @@ -6131,7 +6278,7 @@ static void ath12k_mac_op_stop(struct ieee80211_hw *hw) > } > > static u8 > -ath12k_mac_get_vdev_stats_id(struct ath12k_vif *arvif) > +ath12k_mac_get_vdev_stats_id(struct ath12k_link_vif *arvif) > { > struct ath12k_base *ab = arvif->ar->ab; > u8 vdev_stats_id = 0; > @@ -6153,19 +6300,22 @@ ath12k_mac_get_vdev_stats_id(struct ath12k_vif *arvif) > return vdev_stats_id; > } > > -static int ath12k_mac_setup_vdev_params_mbssid(struct ath12k_vif *arvif, > +static int ath12k_mac_setup_vdev_params_mbssid(struct ath12k_link_vif *arvif, > u32 *flags, u32 *tx_vdev_id) > { > - struct ieee80211_vif *tx_vif = arvif->vif->mbssid_tx_vif; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_vif *tx_vif = ahvif->vif->mbssid_tx_vif; > struct ath12k *ar = arvif->ar; > - struct ath12k_vif *tx_arvif; > + struct ath12k_link_vif *tx_arvif; > + struct ath12k_vif *tx_ahvif; > > if (!tx_vif) > return 0; > > - tx_arvif = ath12k_vif_to_arvif(tx_vif); > + tx_ahvif = ath12k_vif_to_ahvif(tx_vif); > + tx_arvif = &tx_ahvif->deflink; > > - if (arvif->vif->bss_conf.nontransmitted) { > + if (ahvif->vif->bss_conf.nontransmitted) { > if (ar->ah->hw->wiphy != ieee80211_vif_to_wdev(tx_vif)->wiphy) > return -EINVAL; > > @@ -6177,22 +6327,23 @@ static int ath12k_mac_setup_vdev_params_mbssid(struct ath12k_vif *arvif, > return -EINVAL; > } > > - if (arvif->vif->bss_conf.ema_ap) > + if (ahvif->vif->bss_conf.ema_ap) > *flags |= WMI_VDEV_MBSSID_FLAGS_EMA_MODE; > > return 0; > } > > -static int ath12k_mac_setup_vdev_create_arg(struct ath12k_vif *arvif, > +static int ath12k_mac_setup_vdev_create_arg(struct ath12k_link_vif *arvif, > struct ath12k_wmi_vdev_create_arg *arg) > { > struct ath12k *ar = arvif->ar; > struct ath12k_pdev *pdev = ar->pdev; > + struct ath12k_vif *ahvif = arvif->ahvif; > int ret; > > arg->if_id = arvif->vdev_id; > - arg->type = arvif->vdev_type; > - arg->subtype = arvif->vdev_subtype; > + arg->type = ahvif->vdev_type; > + arg->subtype = ahvif->vdev_subtype; > arg->pdev_id = pdev->pdev_id; > > arg->mbssid_flags = WMI_VDEV_MBSSID_FLAGS_NON_MBSSID_AP; > @@ -6259,14 +6410,15 @@ ath12k_mac_prepare_he_mode(struct ath12k_pdev *pdev, u32 viftype) > } > > static int ath12k_set_he_mu_sounding_mode(struct ath12k *ar, > - struct ath12k_vif *arvif) > + struct ath12k_link_vif *arvif) > { > u32 param_id, param_value; > struct ath12k_base *ab = ar->ab; > + struct ath12k_vif *ahvif = arvif->ahvif; > int ret; > > param_id = WMI_VDEV_PARAM_SET_HEMU_MODE; > - param_value = ath12k_mac_prepare_he_mode(ar->pdev, arvif->vif->type); > + param_value = ath12k_mac_prepare_he_mode(ar->pdev, ahvif->vif->type); > ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id, > param_id, param_value); > if (ret) { > @@ -6289,9 +6441,10 @@ static int ath12k_set_he_mu_sounding_mode(struct ath12k *ar, > return ret; > } > > -static void ath12k_mac_update_vif_offload(struct ath12k_vif *arvif) > +static void ath12k_mac_update_vif_offload(struct ath12k_link_vif *arvif) > { > - struct ieee80211_vif *vif = arvif->vif; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); > struct ath12k *ar = arvif->ar; > struct ath12k_base *ab = ar->ab; > u32 param_id, param_value; > @@ -6304,14 +6457,14 @@ static void ath12k_mac_update_vif_offload(struct ath12k_vif *arvif) > IEEE80211_OFFLOAD_DECAP_ENABLED); > > if (vif->offload_flags & IEEE80211_OFFLOAD_ENCAP_ENABLED) > - arvif->tx_encap_type = ATH12K_HW_TXRX_ETHERNET; > + ahvif->tx_encap_type = ATH12K_HW_TXRX_ETHERNET; > else if (test_bit(ATH12K_FLAG_RAW_MODE, &ab->dev_flags)) > - arvif->tx_encap_type = ATH12K_HW_TXRX_RAW; > + ahvif->tx_encap_type = ATH12K_HW_TXRX_RAW; > else > - arvif->tx_encap_type = ATH12K_HW_TXRX_NATIVE_WIFI; > + ahvif->tx_encap_type = ATH12K_HW_TXRX_NATIVE_WIFI; > > ret = ath12k_wmi_vdev_set_param_cmd(ar, arvif->vdev_id, > - param_id, arvif->tx_encap_type); > + param_id, ahvif->tx_encap_type); > if (ret) { > ath12k_warn(ab, "failed to set vdev %d tx encap mode: %d\n", > arvif->vdev_id, ret); > @@ -6338,57 +6491,60 @@ static void ath12k_mac_update_vif_offload(struct ath12k_vif *arvif) > static void ath12k_mac_op_update_vif_offload(struct ieee80211_hw *hw, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > > - ath12k_mac_update_vif_offload(arvif); > + ath12k_mac_update_vif_offload(&ahvif->deflink); > } > > -static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) > +int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) > { > struct ath12k_hw *ah = ar->ah; > struct ath12k_base *ab = ar->ab; > struct ieee80211_hw *hw = ah->hw; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_wmi_vdev_create_arg vdev_arg = {0}; > struct ath12k_wmi_peer_create_arg peer_param; > + struct ath12k_link_vif *arvif; > u32 param_id, param_value; > u16 nss; > int i; > int ret, vdev_id; > > + lockdep_assert_held(&ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > arvif->ar = ar; > vdev_id = __ffs64(ab->free_vdev_map); > arvif->vdev_id = vdev_id; > - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_NONE; > + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_NONE; > > switch (vif->type) { > case NL80211_IFTYPE_UNSPECIFIED: > case NL80211_IFTYPE_STATION: > - arvif->vdev_type = WMI_VDEV_TYPE_STA; > + ahvif->vdev_type = WMI_VDEV_TYPE_STA; > > if (vif->p2p) > - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_CLIENT; > + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_CLIENT; > > break; > case NL80211_IFTYPE_MESH_POINT: > - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_MESH_11S; > + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_MESH_11S; > fallthrough; > case NL80211_IFTYPE_AP: > - arvif->vdev_type = WMI_VDEV_TYPE_AP; > + ahvif->vdev_type = WMI_VDEV_TYPE_AP; > > if (vif->p2p) > - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_GO; > + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_GO; > > break; > case NL80211_IFTYPE_MONITOR: > - arvif->vdev_type = WMI_VDEV_TYPE_MONITOR; > + ahvif->vdev_type = WMI_VDEV_TYPE_MONITOR; > ar->monitor_vdev_id = vdev_id; > break; > case NL80211_IFTYPE_P2P_DEVICE: > - arvif->vdev_type = WMI_VDEV_TYPE_STA; > - arvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_DEVICE; > + ahvif->vdev_type = WMI_VDEV_TYPE_STA; > + ahvif->vdev_subtype = WMI_VDEV_SUBTYPE_P2P_DEVICE; > break; > default: > WARN_ON(1); > @@ -6396,7 +6552,7 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) > } > > ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "mac vdev create id %d type %d subtype %d map %llx\n", > - arvif->vdev_id, arvif->vdev_type, arvif->vdev_subtype, > + arvif->vdev_id, ahvif->vdev_type, ahvif->vdev_subtype, > ab->free_vdev_map); > > vif->cab_queue = arvif->vdev_id % (ATH12K_HW_MAX_QUEUES - 1); > @@ -6439,7 +6595,7 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) > goto err_vdev_del; > } > > - switch (arvif->vdev_type) { > + switch (ahvif->vdev_type) { > case WMI_VDEV_TYPE_AP: > peer_param.vdev_id = arvif->vdev_id; > peer_param.peer_addr = vif->addr; > @@ -6515,15 +6671,19 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) > } > > ath12k_dp_vdev_tx_attach(ar, arvif); > - > if (vif->type != NL80211_IFTYPE_MONITOR && ar->monitor_conf_enabled) > ath12k_mac_monitor_vdev_create(ar); > > arvif->ar = ar; > + /* TODO use appropriate link id once MLO support is added. > + */ > + arvif->link_id = ATH12K_DEFAULT_LINK_ID; > + rcu_assign_pointer(ahvif->link[arvif->link_id], arvif); > + ahvif->links_map = BIT(arvif->link_id); > return ret; > > err_peer_del: > - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { > + if (ahvif->vdev_type == WMI_VDEV_TYPE_AP) { > reinit_completion(&ar->peer_delete_done); > > ret = ath12k_wmi_send_peer_delete_cmd(ar, vif->addr, > @@ -6559,16 +6719,19 @@ static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) > return ret; > } > > -static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ieee80211_vif *vif) > +static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > - struct ath12k_vif_cache *cache = arvif->cache; > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_vif_cache *cache; > struct ath12k_base *ab = ar->ab; > - > + struct ath12k_link_vif *arvif; > int ret; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > > + arvif = &ahvif->deflink; > + cache = arvif->cache; > if (!cache) > return; > > @@ -6600,12 +6763,16 @@ static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, > struct ieee80211_vif *vif, > struct ieee80211_chanctx_conf *ctx) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > struct ath12k_hw *ah = hw->priv; > struct ath12k *ar, *prev_ar; > struct ath12k_base *ab; > int ret; > > + lockdep_assert_held(&ah->conf_mutex); > + arvif = &ahvif->deflink; > + > if (ah->num_radio == 1) > ar = ah->radio; > else if (ctx) > @@ -6687,12 +6854,18 @@ static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, > static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > int i; > > - memset(arvif, 0, sizeof(*arvif)); > + mutex_lock(&ah->conf_mutex); > + memset(ahvif, 0, sizeof(*ahvif)); > > - arvif->vif = vif; > + ahvif->ah = ah; > + ahvif->vif = vif; > + arvif = &ahvif->deflink; > + arvif->ahvif = ahvif; > > INIT_LIST_HEAD(&arvif->list); > INIT_DELAYED_WORK(&arvif->connection_loss_work, > @@ -6719,6 +6892,7 @@ static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw, > * vdev needs to be created > */ > ath12k_mac_assign_vif_to_vdev(hw, vif, NULL); > + mutex_unlock(&ah->conf_mutex); > return 0; > } > > @@ -6749,12 +6923,16 @@ static void ath12k_mac_vif_unref(struct ath12k_dp *dp, struct ieee80211_vif *vif > > static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_base *ab = ar->ab; > + struct ath12k_link_vif *arvif; > unsigned long time_left; > int ret; > > + lockdep_assert_held(&ahvif->ah->conf_mutex); > lockdep_assert_held(&ar->conf_mutex); > + > + arvif = &ahvif->deflink; > reinit_completion(&ar->vdev_delete_done); > > ret = ath12k_wmi_vdev_delete(ar, arvif->vdev_id); > @@ -6775,7 +6953,7 @@ static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) > ar->allocated_vdev_map &= ~(1LL << arvif->vdev_id); > ar->num_created_vdevs--; > > - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > ar->monitor_vdev_id = -1; > ar->monitor_vdev_created = false; > } else if (ar->monitor_vdev_created && !ar->monitor_started) { > @@ -6805,6 +6983,12 @@ static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) > /* TODO: recal traffic pause state based on the available vdevs */ > arvif->is_created = false; > arvif->ar = NULL; > + if (arvif->link_id < IEEE80211_MLD_MAX_NUM_LINKS) { > + rcu_assign_pointer(ahvif->link[arvif->link_id], NULL); > + synchronize_rcu(); > + ahvif->links_map &= ~(BIT(arvif->link_id)); > + arvif->link_id = ATH12K_INVALID_LINK_ID; > + } > > return ret; > } > @@ -6812,16 +6996,21 @@ static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) > static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > + struct ath12k_link_vif *arvif; > struct ath12k_base *ab; > struct ath12k *ar; > int ret; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > if (!arvif->is_created) { > /* if we cached some config but never received assign chanctx, > * free the allocated cache. > */ > ath12k_arvif_put_cache(arvif); > + mutex_unlock(&ah->conf_mutex); > return; > } > > @@ -6835,7 +7024,7 @@ static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw, > ath12k_dbg(ab, ATH12K_DBG_MAC, "mac remove interface (vdev %d)\n", > arvif->vdev_id); > > - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { > + if (ahvif->vdev_type == WMI_VDEV_TYPE_AP) { > ret = ath12k_peer_delete(ar, arvif->vdev_id, vif->addr); > if (ret) > ath12k_warn(ab, "failed to submit AP self-peer removal on vdev %d: %d\n", > @@ -6845,6 +7034,7 @@ static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw, > ath12k_mac_vdev_delete(ar, vif); > > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > } > > /* FIXME: Has to be verified. */ > @@ -6936,7 +7126,7 @@ static int ath12k_mac_op_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx > return ret; > } > > -static int ath12k_mac_ampdu_action(struct ath12k_vif *arvif, > +static int ath12k_mac_ampdu_action(struct ath12k_link_vif *arvif, > struct ieee80211_ampdu_params *params) > { > struct ath12k *ar = arvif->ar; > @@ -6972,7 +7162,8 @@ static int ath12k_mac_op_ampdu_action(struct ieee80211_hw *hw, > { > struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > int ret = -EINVAL; > > ar = ath12k_get_ar_by_vif(hw, vif); > @@ -6980,10 +7171,13 @@ static int ath12k_mac_op_ampdu_action(struct ieee80211_hw *hw, > return -EINVAL; > > ar = ath12k_ah_to_ar(ah, 0); > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > > mutex_lock(&ar->conf_mutex); > ret = ath12k_mac_ampdu_action(arvif, params); > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > > if (ret) > ath12k_warn(ar->ab, "pdev idx %d unable to perform ampdu action %d ret %d\n", > @@ -7114,7 +7308,7 @@ ath12k_mac_check_down_grade_phy_mode(struct ath12k *ar, > } > > static int > -ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, > +ath12k_mac_vdev_start_restart(struct ath12k_link_vif *arvif, > struct ieee80211_chanctx_conf *ctx, > bool restart) > { > @@ -7122,7 +7316,8 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, > struct ath12k_base *ab = ar->ab; > struct wmi_vdev_start_req_arg arg = {}; > const struct cfg80211_chan_def *chandef = &ctx->def; > - int he_support = arvif->vif->bss_conf.he_support; > + struct ath12k_vif *ahvif = arvif->ahvif; > + int he_support = ahvif->vif->bss_conf.he_support; > int ret; > > lockdep_assert_held(&ar->conf_mutex); > @@ -7141,7 +7336,7 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, > > arg.mode = ath12k_mac_check_down_grade_phy_mode(ar, arg.mode, > chandef->chan->band, > - arvif->vif->type); > + ahvif->vif->type); > arg.min_power = 0; > arg.max_power = chandef->chan->max_power * 2; > arg.max_reg_power = chandef->chan->max_reg_power * 2; > @@ -7161,10 +7356,10 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, > return ret; > } > > - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { > - arg.ssid = arvif->u.ap.ssid; > - arg.ssid_len = arvif->u.ap.ssid_len; > - arg.hidden_ssid = arvif->u.ap.hidden_ssid; > + if (ahvif->vdev_type == WMI_VDEV_TYPE_AP) { > + arg.ssid = ahvif->u.ap.ssid; > + arg.ssid_len = ahvif->u.ap.ssid_len; > + arg.hidden_ssid = ahvif->u.ap.hidden_ssid; > > /* For now allow DFS for AP mode */ > arg.chan_radar = !!(chandef->chan->flags & IEEE80211_CHAN_RADAR); > @@ -7211,7 +7406,7 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, > > ar->num_started_vdevs++; > ath12k_dbg(ab, ATH12K_DBG_MAC, "vdev %pM started, vdev_id %d\n", > - arvif->vif->addr, arvif->vdev_id); > + ahvif->vif->addr, arvif->vdev_id); > > /* Enable CAC Flag in the driver by checking the channel DFS cac time, > * i.e dfs_cac_ms value which will be valid only for radar channels > @@ -7220,7 +7415,7 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, > * during CAC. > */ > /* TODO: Set the flag for other interface types as required */ > - if (arvif->vdev_type == WMI_VDEV_TYPE_AP && > + if (arvif->ahvif->vdev_type == WMI_VDEV_TYPE_AP && > chandef->chan->dfs_cac_ms && > chandef->chan->dfs_state == NL80211_DFS_USABLE) { > set_bit(ATH12K_CAC_RUNNING, &ar->dev_flags); > @@ -7237,13 +7432,13 @@ ath12k_mac_vdev_start_restart(struct ath12k_vif *arvif, > return 0; > } > > -static int ath12k_mac_vdev_start(struct ath12k_vif *arvif, > +static int ath12k_mac_vdev_start(struct ath12k_link_vif *arvif, > struct ieee80211_chanctx_conf *ctx) > { > return ath12k_mac_vdev_start_restart(arvif, ctx, false); > } > > -static int ath12k_mac_vdev_restart(struct ath12k_vif *arvif, > +static int ath12k_mac_vdev_restart(struct ath12k_link_vif *arvif, > struct ieee80211_chanctx_conf *ctx) > { > return ath12k_mac_vdev_start_restart(arvif, ctx, true); > @@ -7261,8 +7456,12 @@ static void > ath12k_mac_change_chanctx_cnt_iter(void *data, u8 *mac, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_mac_change_chanctx_arg *arg = data; > + struct ath12k_link_vif *arvif; > + > + lockdep_assert_held(&ahvif->ah->conf_mutex); > + arvif = &ahvif->deflink; > > if (arvif->ar != arg->ar) > return; > @@ -7277,9 +7476,13 @@ static void > ath12k_mac_change_chanctx_fill_iter(void *data, u8 *mac, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_mac_change_chanctx_arg *arg = data; > struct ieee80211_chanctx_conf *ctx; > + struct ath12k_link_vif *arvif; > + > + lockdep_assert_held(&ahvif->ah->conf_mutex); > + arvif = &ahvif->deflink; > > if (arvif->ar != arg->ar) > return; > @@ -7323,13 +7526,13 @@ static u32 ath12k_mac_nlwidth_to_wmiwidth(enum nl80211_chan_width width) > } > > static int ath12k_mac_update_peer_puncturing_width(struct ath12k *ar, > - struct ath12k_vif *arvif, > + struct ath12k_link_vif *arvif, > struct cfg80211_chan_def def) > { > u32 param_id, param_value; > int ret; > > - if (arvif->vdev_type != WMI_VDEV_TYPE_STA) > + if (arvif->ahvif->vdev_type != WMI_VDEV_TYPE_STA) > return 0; > > param_id = WMI_PEER_CHWIDTH_PUNCTURE_20MHZ_BITMAP; > @@ -7355,8 +7558,9 @@ ath12k_mac_update_vif_chan(struct ath12k *ar, > { > struct ath12k_wmi_vdev_up_params params = {}; > struct ath12k_base *ab = ar->ab; > + struct ath12k_link_vif *arvif; > struct ieee80211_vif *vif; > - struct ath12k_vif *arvif; > + struct ath12k_vif *ahvif; > int ret; > int i; > bool monitor_vif = false; > @@ -7365,7 +7569,8 @@ ath12k_mac_update_vif_chan(struct ath12k *ar, > > for (i = 0; i < n_vifs; i++) { > vif = vifs[i].vif; > - arvif = ath12k_vif_to_arvif(vif); > + ahvif = ath12k_vif_to_ahvif(vif); > + arvif = &ahvif->deflink; > > if (vif->type == NL80211_IFTYPE_MONITOR) > monitor_vif = true; > @@ -7415,10 +7620,14 @@ ath12k_mac_update_vif_chan(struct ath12k *ar, > > memset(¶ms, 0, sizeof(params)); > params.vdev_id = arvif->vdev_id; > - params.aid = arvif->aid; > + params.aid = ahvif->aid; > params.bssid = arvif->bssid; > if (vif->mbssid_tx_vif) { > - params.tx_bssid = ath12k_vif_to_arvif(vif->mbssid_tx_vif)->bssid; > + struct ath12k_vif *ahvif = > + ath12k_vif_to_ahvif(vif->mbssid_tx_vif); > + struct ath12k_link_vif *arvif = &ahvif->deflink; > + > + params.tx_bssid = arvif->bssid; > params.nontx_profile_idx = vif->bss_conf.bssid_index; > params.nontx_profile_cnt = 1 << vif->bss_conf.bssid_indicator; > } > @@ -7481,12 +7690,16 @@ static void ath12k_mac_op_change_chanctx(struct ieee80211_hw *hw, > struct ieee80211_chanctx_conf *ctx, > u32 changed) > { > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > struct ath12k_base *ab; > > + mutex_lock(&ah->conf_mutex); > ar = ath12k_get_ar_by_ctx(hw, ctx); > - if (!ar) > + if (!ar) { > + mutex_unlock(&ah->conf_mutex); > return; > + } > > ab = ar->ab; > > @@ -7511,13 +7724,15 @@ static void ath12k_mac_op_change_chanctx(struct ieee80211_hw *hw, > > unlock: > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > } > > static int ath12k_start_vdev_delay(struct ath12k *ar, > - struct ath12k_vif *arvif) > + struct ath12k_link_vif *arvif) > { > struct ath12k_base *ab = ar->ab; > - struct ieee80211_vif *vif = arvif->vif; > + struct ath12k_vif *ahvif = arvif->ahvif; > + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); > int ret; > > if (WARN_ON(arvif->is_started)) > @@ -7531,7 +7746,7 @@ static int ath12k_start_vdev_delay(struct ath12k *ar, > return ret; > } > > - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > ret = ath12k_monitor_vdev_up(ar, arvif->vdev_id); > if (ret) { > ath12k_warn(ab, "failed put monitor up: %d\n", ret); > @@ -7551,17 +7766,22 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, > struct ieee80211_bss_conf *link_conf, > struct ieee80211_chanctx_conf *ctx) > { > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > struct ath12k_base *ab; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > int ret; > > /* For multi radio wiphy, the vdev was not created during add_interface > * create now since we have a channel ctx now to assign to a specific ar/fw > */ > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > ar = ath12k_mac_assign_vif_to_vdev(hw, vif, ctx); > if (!ar) { > WARN_ON(1); > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > } > > @@ -7577,8 +7797,8 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, > > /* for some targets bss peer must be created before vdev_start */ > if (ab->hw_params->vdev_start_delay && > - arvif->vdev_type != WMI_VDEV_TYPE_AP && > - arvif->vdev_type != WMI_VDEV_TYPE_MONITOR && > + ahvif->vdev_type != WMI_VDEV_TYPE_AP && > + ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR && > !ath12k_peer_exist_by_vdev_id(ab, arvif->vdev_id)) { > memcpy(&arvif->chanctx, ctx, sizeof(*ctx)); > ret = 0; > @@ -7590,7 +7810,7 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, > goto out; > } > > - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > ret = ath12k_mac_monitor_start(ar); > if (ret) > goto out; > @@ -7606,7 +7826,7 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, > goto out; > } > > - if (arvif->vdev_type != WMI_VDEV_TYPE_MONITOR && ar->monitor_vdev_created) > + if (ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR && ar->monitor_vdev_created) > ath12k_mac_monitor_start(ar); > > arvif->is_started = true; > @@ -7615,6 +7835,7 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, > > out: > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > > return ret; > } > @@ -7625,11 +7846,15 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, > struct ieee80211_bss_conf *link_conf, > struct ieee80211_chanctx_conf *ctx) > { > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > struct ath12k_base *ab; > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_link_vif *arvif; > int ret; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > /* The vif is expected to be attached to an ar's VDEV. > * We leave the vif/vdev in this function as is > * and not delete the vdev symmetric to assign_vif_chanctx() > @@ -7637,8 +7862,10 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, > * remove_interface() or when there is a change in channel > * that moves the vif to a new ar > */ > - if (!arvif->is_created) > + if (!arvif->is_created) { > + mutex_unlock(&ah->conf_mutex); > return; > + } > > ar = arvif->ar; > ab = ar->ab; > @@ -7651,18 +7878,19 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, > > WARN_ON(!arvif->is_started); > > - if (arvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > + if (ahvif->vdev_type == WMI_VDEV_TYPE_MONITOR) { > ret = ath12k_mac_monitor_stop(ar); > if (ret) { > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > return; > } > > arvif->is_started = false; > } > > - if (arvif->vdev_type != WMI_VDEV_TYPE_STA && > - arvif->vdev_type != WMI_VDEV_TYPE_MONITOR) { > + if (ahvif->vdev_type != WMI_VDEV_TYPE_STA && > + ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR) { > ath12k_bss_disassoc(ar, arvif); > ret = ath12k_mac_vdev_stop(arvif); > if (ret) > @@ -7671,11 +7899,12 @@ ath12k_mac_op_unassign_vif_chanctx(struct ieee80211_hw *hw, > } > arvif->is_started = false; > > - if (arvif->vdev_type != WMI_VDEV_TYPE_MONITOR && > + if (ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR && > ar->num_started_vdevs == 1 && ar->monitor_vdev_created) > ath12k_mac_monitor_stop(ar); > > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > } > > static int > @@ -7684,17 +7913,19 @@ ath12k_mac_op_switch_vif_chanctx(struct ieee80211_hw *hw, > int n_vifs, > enum ieee80211_chanctx_switch_mode mode) > { > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > > ar = ath12k_get_ar_by_ctx(hw, vifs->old_ctx); > if (!ar) > return -EINVAL; > - > + mutex_lock(&ah->conf_mutex); > mutex_lock(&ar->conf_mutex); > > /* Switching channels across radio is not allowed */ > if (ar != ath12k_get_ar_by_ctx(hw, vifs->new_ctx)) { > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > } > > @@ -7702,8 +7933,8 @@ ath12k_mac_op_switch_vif_chanctx(struct ieee80211_hw *hw, > "mac chanctx switch n_vifs %d mode %d\n", > n_vifs, mode); > ath12k_mac_update_vif_chan(ar, vifs, n_vifs); > - > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > > return 0; > } > @@ -7711,7 +7942,7 @@ ath12k_mac_op_switch_vif_chanctx(struct ieee80211_hw *hw, > static int > ath12k_set_vdev_param_to_all_vifs(struct ath12k *ar, int param, u32 value) > { > - struct ath12k_vif *arvif; > + struct ath12k_link_vif *arvif; > int ret = 0; > > mutex_lock(&ar->conf_mutex); > @@ -7946,7 +8177,7 @@ ath12k_mac_get_single_legacy_rate(struct ath12k *ar, > return 0; > } > > -static int ath12k_mac_set_fixed_rate_params(struct ath12k_vif *arvif, > +static int ath12k_mac_set_fixed_rate_params(struct ath12k_link_vif *arvif, > u32 rate, u8 nss, u8 sgi, u8 ldpc) > { > struct ath12k *ar = arvif->ar; > @@ -8025,7 +8256,7 @@ ath12k_mac_vht_mcs_range_present(struct ath12k *ar, > static void ath12k_mac_set_bitrate_mask_iter(void *data, > struct ieee80211_sta *sta) > { > - struct ath12k_vif *arvif = data; > + struct ath12k_link_vif *arvif = data; > struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); > struct ath12k *ar = arvif->ar; > > @@ -8042,8 +8273,8 @@ static void ath12k_mac_set_bitrate_mask_iter(void *data, > static void ath12k_mac_disable_peer_fixed_rate(void *data, > struct ieee80211_sta *sta) > { > + struct ath12k_link_vif *arvif = data; > struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); > - struct ath12k_vif *arvif = data; > struct ath12k *ar = arvif->ar; > int ret; > > @@ -8065,9 +8296,11 @@ ath12k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, > struct ieee80211_vif *vif, > const struct cfg80211_bitrate_mask *mask) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > + struct ath12k_link_vif *arvif; > struct cfg80211_chan_def def; > - struct ath12k *ar = arvif->ar; > + struct ath12k *ar; > enum nl80211_band band; > const u8 *ht_mcs_mask; > const u16 *vht_mcs_mask; > @@ -8079,8 +8312,13 @@ ath12k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, > int ret; > int num_rates; > > - if (ath12k_mac_vif_chan(vif, &def)) > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > + ar = arvif->ar; > + if (ath12k_mac_vif_chan(vif, &def)) { > + mutex_unlock(&ah->conf_mutex); > return -EPERM; > + } > > band = def.chan->band; > ht_mcs_mask = mask->control[band].ht_mcs; > @@ -8181,6 +8419,7 @@ ath12k_mac_op_set_bitrate_mask(struct ieee80211_hw *hw, > mutex_unlock(&ar->conf_mutex); > > out: > + mutex_unlock(&ah->conf_mutex); > return ret; > } > > @@ -8191,7 +8430,8 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw, > struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k *ar; > struct ath12k_base *ab; > - struct ath12k_vif *arvif; > + struct ath12k_vif *ahvif; > + struct ath12k_link_vif *arvif; > int recovery_count, i; > > if (reconfig_type != IEEE80211_RECONFIG_TYPE_RESTART) > @@ -8232,11 +8472,12 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw, > } > > list_for_each_entry(arvif, &ar->arvifs, list) { > + ahvif = arvif->ahvif; > ath12k_dbg(ab, ATH12K_DBG_BOOT, > "reconfig cipher %d up %d vdev type %d\n", > - arvif->key_cipher, > + ahvif->key_cipher, > arvif->is_up, > - arvif->vdev_type); > + ahvif->vdev_type); > > /* After trigger disconnect, then upper layer will > * trigger connect again, then the PN number of > @@ -8244,9 +8485,9 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw, > * side, hence PN number mismatch will not happen. > */ > if (arvif->is_up && > - arvif->vdev_type == WMI_VDEV_TYPE_STA && > - arvif->vdev_subtype == WMI_VDEV_SUBTYPE_NONE) { > - ieee80211_hw_restart_disconnect(arvif->vif); > + ahvif->vdev_type == WMI_VDEV_TYPE_STA && > + ahvif->vdev_subtype == WMI_VDEV_SUBTYPE_NONE) { > + ieee80211_hw_restart_disconnect(ahvif->vif); > > ath12k_dbg(ab, ATH12K_DBG_BOOT, > "restart disconnect\n"); > @@ -8413,14 +8654,18 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > int duration, > enum ieee80211_roc_type type) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_hw *ah = ath12k_hw_to_ah(hw); > struct ath12k_wmi_scan_req_arg arg; > + struct ath12k_link_vif *arvif; > struct ath12k *ar, *prev_ar; > u32 scan_time_msec; > bool create = true; > int ret; > > + mutex_lock(&ah->conf_mutex); > + arvif = &ahvif->deflink; > + > if (ah->num_radio == 1) { > WARN_ON(!arvif->is_created); > ar = ath12k_ah_to_ar(ah, 0); > @@ -8428,8 +8673,10 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > } > > ar = ath12k_mac_select_scan_device(hw, vif, chan->center_freq); > - if (!ar) > + if (!ar) { > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > + } > > /* If the vif is already assigned to a specific vdev of an ar, > * check whether its already started, vdev which is started > @@ -8441,11 +8688,15 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > * always on the same band for the vif > */ > if (arvif->is_created) { > - if (WARN_ON(!arvif->ar)) > + if (WARN_ON(!arvif->ar)) { > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > + } > > - if (ar != arvif->ar && arvif->is_started) > + if (ar != arvif->ar && arvif->is_started) { > + mutex_unlock(&ah->conf_mutex); > return -EBUSY; > + } > > if (ar != arvif->ar) { > /* backup the previously used ar ptr, since the vdev delete > @@ -8459,6 +8710,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > ath12k_warn(prev_ar->ab, > "unable to delete scan vdev for roc: %d\n", > ret); > + mutex_unlock(&ah->conf_mutex); > return ret; > } > } else { > @@ -8473,6 +8725,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > if (ret) { > ath12k_warn(ar->ab, "unable to create scan vdev for roc: %d\n", > ret); > + mutex_unlock(&ah->conf_mutex); > return -EINVAL; > } > } > @@ -8555,6 +8808,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, > kfree(arg.chan_list); > exit: > mutex_unlock(&ar->conf_mutex); > + mutex_unlock(&ah->conf_mutex); > > return ret; > } > @@ -9281,6 +9535,7 @@ static struct ath12k_hw *ath12k_mac_hw_allocate(struct ath12k_base *ab, > ah->num_radio = num_pdev_map; > > mutex_init(&ah->hw_mutex); > + mutex_init(&ah->conf_mutex); > > for (i = 0; i < num_pdev_map; i++) { > ab = pdev_map[i].ab; > diff --git a/drivers/net/wireless/ath/ath12k/mac.h b/drivers/net/wireless/ath/ath12k/mac.h > index 69fd282b9dd3..ef54349cb159 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.h > +++ b/drivers/net/wireless/ath/ath12k/mac.h > @@ -40,6 +40,9 @@ struct ath12k_generic_iter { > #define ATH12K_TX_POWER_MAX_VAL 70 > #define ATH12K_TX_POWER_MIN_VAL 0 > > +#define ATH12K_DEFAULT_LINK_ID 0 > +#define ATH12K_INVALID_LINK_ID 255 > + > enum ath12k_supported_bw { > ATH12K_BW_20 = 0, > ATH12K_BW_40 = 1, > @@ -64,9 +67,9 @@ u8 ath12k_mac_hw_rate_to_idx(const struct ieee80211_supported_band *sband, > void __ath12k_mac_scan_finish(struct ath12k *ar); > void ath12k_mac_scan_finish(struct ath12k *ar); > > -struct ath12k_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id); > -struct ath12k_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, > - u32 vdev_id); > +struct ath12k_link_vif *ath12k_mac_get_arvif(struct ath12k *ar, u32 vdev_id); > +struct ath12k_link_vif *ath12k_mac_get_arvif_by_vdev_id(struct ath12k_base *ab, > + u32 vdev_id); > struct ath12k *ath12k_mac_get_ar_by_vdev_id(struct ath12k_base *ab, u32 vdev_id); > struct ath12k *ath12k_mac_get_ar_by_pdev_id(struct ath12k_base *ab, u32 pdev_id); > > diff --git a/drivers/net/wireless/ath/ath12k/p2p.c b/drivers/net/wireless/ath/ath12k/p2p.c > index 3a851ee15b2f..84cccf7d91e7 100644 > --- a/drivers/net/wireless/ath/ath12k/p2p.c > +++ b/drivers/net/wireless/ath/ath12k/p2p.c > @@ -69,20 +69,20 @@ static size_t ath12k_p2p_noa_ie_len_compute(const struct ath12k_wmi_p2p_noa_info > return len; > } > > -static void ath12k_p2p_noa_ie_assign(struct ath12k_vif *arvif, void *ie, > +static void ath12k_p2p_noa_ie_assign(struct ath12k_link_vif *arvif, void *ie, > size_t len) > { > struct ath12k *ar = arvif->ar; > > lockdep_assert_held(&ar->data_lock); > > - kfree(arvif->u.ap.noa_data); > + kfree(arvif->ahvif->u.ap.noa_data); > > - arvif->u.ap.noa_data = ie; > - arvif->u.ap.noa_len = len; > + arvif->ahvif->u.ap.noa_data = ie; > + arvif->ahvif->u.ap.noa_len = len; > } > > -static void __ath12k_p2p_noa_update(struct ath12k_vif *arvif, > +static void __ath12k_p2p_noa_update(struct ath12k_link_vif *arvif, > const struct ath12k_wmi_p2p_noa_info *noa) > { > struct ath12k *ar = arvif->ar; > @@ -105,7 +105,7 @@ static void __ath12k_p2p_noa_update(struct ath12k_vif *arvif, > ath12k_p2p_noa_ie_assign(arvif, ie, len); > } > > -void ath12k_p2p_noa_update(struct ath12k_vif *arvif, > +void ath12k_p2p_noa_update(struct ath12k_link_vif *arvif, > const struct ath12k_wmi_p2p_noa_info *noa) > { > struct ath12k *ar = arvif->ar; > @@ -118,9 +118,12 @@ void ath12k_p2p_noa_update(struct ath12k_vif *arvif, > static void ath12k_p2p_noa_update_vdev_iter(void *data, u8 *mac, > struct ieee80211_vif *vif) > { > - struct ath12k_vif *arvif = ath12k_vif_to_arvif(vif); > + struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); > struct ath12k_p2p_noa_arg *arg = data; > + struct ath12k_link_vif *arvif; > > + WARN_ON(!rcu_read_lock_any_held()); > + arvif = &ahvif->deflink; same here. > if (arvif->ar != arg->ar || arvif->vdev_id != arg->vdev_id) > return; > > diff --git a/drivers/net/wireless/ath/ath12k/p2p.h b/drivers/net/wireless/ath/ath12k/p2p.h > index b2eec51a9900..03ee877e6d6b 100644 > --- a/drivers/net/wireless/ath/ath12k/p2p.h > +++ b/drivers/net/wireless/ath/ath12k/p2p.h > @@ -16,7 +16,7 @@ struct ath12k_p2p_noa_arg { > const struct ath12k_wmi_p2p_noa_info *noa; > }; > > -void ath12k_p2p_noa_update(struct ath12k_vif *arvif, > +void ath12k_p2p_noa_update(struct ath12k_link_vif *arvif, > const struct ath12k_wmi_p2p_noa_info *noa); > void ath12k_p2p_noa_update_by_vdev_id(struct ath12k *ar, u32 vdev_id, > const struct ath12k_wmi_p2p_noa_info *noa); > diff --git a/drivers/net/wireless/ath/ath12k/peer.c b/drivers/net/wireless/ath/ath12k/peer.c > index 19c0626fbff1..6481f100e6cc 100644 > --- a/drivers/net/wireless/ath/ath12k/peer.c > +++ b/drivers/net/wireless/ath/ath12k/peer.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: BSD-3-Clause-Clear > /* > * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved. > - * Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2021-2022, 2024 Qualcomm Innovation Center, Inc. All rights reserved. > */ > > #include "core.h" > @@ -261,10 +261,11 @@ static int ath12k_wait_for_peer_created(struct ath12k *ar, int vdev_id, const u8 > return ath12k_wait_for_peer_common(ar->ab, vdev_id, addr, true); > } > > -int ath12k_peer_create(struct ath12k *ar, struct ath12k_vif *arvif, > +int ath12k_peer_create(struct ath12k *ar, struct ath12k_link_vif *arvif, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_create_arg *arg) > { > + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); > struct ath12k_peer *peer; > int ret; > > @@ -326,7 +327,7 @@ int ath12k_peer_create(struct ath12k *ar, struct ath12k_vif *arvif, > peer->pdev_idx = ar->pdev_idx; > peer->sta = sta; > > - if (arvif->vif->type == NL80211_IFTYPE_STATION) { > + if (vif->type == NL80211_IFTYPE_STATION) { > arvif->ast_hash = peer->ast_hash; > arvif->ast_idx = peer->hw_peer_id; > } > diff --git a/drivers/net/wireless/ath/ath12k/peer.h b/drivers/net/wireless/ath/ath12k/peer.h > index 7b3500b5c8c2..b955f0cdf598 100644 > --- a/drivers/net/wireless/ath/ath12k/peer.h > +++ b/drivers/net/wireless/ath/ath12k/peer.h > @@ -1,7 +1,7 @@ > /* SPDX-License-Identifier: BSD-3-Clause-Clear */ > /* > * Copyright (c) 2018-2021 The Linux Foundation. All rights reserved. > - * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved. > + * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved. > */ > > #ifndef ATH12K_PEER_H > @@ -59,7 +59,7 @@ struct ath12k_peer *ath12k_peer_find_by_addr(struct ath12k_base *ab, > struct ath12k_peer *ath12k_peer_find_by_id(struct ath12k_base *ab, int peer_id); > void ath12k_peer_cleanup(struct ath12k *ar, u32 vdev_id); > int ath12k_peer_delete(struct ath12k *ar, u32 vdev_id, u8 *addr); > -int ath12k_peer_create(struct ath12k *ar, struct ath12k_vif *arvif, > +int ath12k_peer_create(struct ath12k *ar, struct ath12k_link_vif *arvif, > struct ieee80211_sta *sta, > struct ath12k_wmi_peer_create_arg *arg); > int ath12k_wait_for_peer_delete_done(struct ath12k *ar, u32 vdev_id, > diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c > index d6e1d1398cdb..ef02c90f63b8 100644 > --- a/drivers/net/wireless/ath/ath12k/wmi.c > +++ b/drivers/net/wireless/ath/ath12k/wmi.c > @@ -6683,7 +6683,8 @@ ath12k_wmi_process_csa_switch_count_event(struct ath12k_base *ab, > const u32 *vdev_ids) > { > int i; > - struct ath12k_vif *arvif; > + struct ath12k_link_vif *arvif; > + struct ath12k_vif *ahvif; > > /* Finish CSA once the switch count becomes NULL */ > if (ev->current_switch_count) > @@ -6698,9 +6699,10 @@ ath12k_wmi_process_csa_switch_count_event(struct ath12k_base *ab, > vdev_ids[i]); > continue; > } > + ahvif = arvif->ahvif; > > - if (arvif->is_up && arvif->vif->bss_conf.csa_active) > - ieee80211_csa_finish(arvif->vif, 0); > + if (arvif->is_up && ahvif->vif->bss_conf.csa_active) > + ieee80211_csa_finish(ahvif->vif, 0); > } > rcu_read_unlock(); > } > @@ -7252,13 +7254,13 @@ ath12k_wmi_send_unit_test_cmd(struct ath12k *ar, > > int ath12k_wmi_simulate_radar(struct ath12k *ar) > { > - struct ath12k_vif *arvif; > + struct ath12k_link_vif *arvif; > u32 dfs_args[DFS_MAX_TEST_ARGS]; > struct wmi_unit_test_cmd wmi_ut; > bool arvif_found = false; > > list_for_each_entry(arvif, &ar->arvifs, list) { > - if (arvif->is_started && arvif->vdev_type == WMI_VDEV_TYPE_AP) { > + if (arvif->is_started && arvif->ahvif->vdev_type == WMI_VDEV_TYPE_AP) { > arvif_found = true; > break; > } ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling 2024-06-18 7:47 ` Baochen Qiang @ 2024-06-18 8:37 ` Kalle Valo 2024-06-18 10:18 ` Baochen Qiang 2024-06-20 16:52 ` Rameshkumar Sundaram 1 sibling, 1 reply; 11+ messages in thread From: Kalle Valo @ 2024-06-18 8:37 UTC (permalink / raw) To: Baochen Qiang; +Cc: Rameshkumar Sundaram, ath12k, linux-wireless, Sriram R Baochen Qiang <quic_bqiang@quicinc.com> writes: >> +static inline struct ieee80211_vif *ath12k_vif_to_vif(struct ath12k_vif *ahvif) > > better naming as ath12k_ahvif_to_vif()? Thanks a lot for the review, I appreciate it. But please edit your quotes, having thousands of lines of quotes makes use of patchwork practically impossible: https://patchwork.kernel.org/project/linux-wireless/patch/20240617131650.3288118-2-quic_ramess@quicinc.com/ -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling 2024-06-18 8:37 ` Kalle Valo @ 2024-06-18 10:18 ` Baochen Qiang 0 siblings, 0 replies; 11+ messages in thread From: Baochen Qiang @ 2024-06-18 10:18 UTC (permalink / raw) To: Kalle Valo; +Cc: Rameshkumar Sundaram, ath12k, linux-wireless, Sriram R On 6/18/2024 4:37 PM, Kalle Valo wrote: > Baochen Qiang <quic_bqiang@quicinc.com> writes: > >>> +static inline struct ieee80211_vif *ath12k_vif_to_vif(struct ath12k_vif *ahvif) >> >> better naming as ath12k_ahvif_to_vif()? > > Thanks a lot for the review, I appreciate it. But please edit your > quotes, having thousands of lines of quotes makes use of patchwork > practically impossible: Didn't notice that, will do. > > https://patchwork.kernel.org/project/linux-wireless/patch/20240617131650.3288118-2-quic_ramess@quicinc.com/ > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling 2024-06-18 7:47 ` Baochen Qiang 2024-06-18 8:37 ` Kalle Valo @ 2024-06-20 16:52 ` Rameshkumar Sundaram 1 sibling, 0 replies; 11+ messages in thread From: Rameshkumar Sundaram @ 2024-06-20 16:52 UTC (permalink / raw) To: Baochen Qiang, ath12k; +Cc: linux-wireless, Sriram R On 6/18/2024 1:17 PM, Baochen Qiang wrote: > > > On 6/17/2024 9:16 PM, Rameshkumar Sundaram wrote: >> From: Sriram R <quic_srirrama@quicinc.com> >> >> To prepare the driver for MLO support, split the driver vif >> data structure to scale for multiple links. This requires changing >> the use of arvif to per link and not per hw which can now >> comprise of multiple links. >> Also since most configurations from mac80211 are done per link, do refactoring >> of the driver functions to apply these configurations at link level. >> >> Split ath12k_vif which is the driver private of ieee80211_vif to store >> link specific information as ath12k_link_vif. For default use cases >> the ath12k vif will have a preallocated link vif called deflink which will >> be used by non ML and the first link vif of ML vif. >> >> With MLO Support to be added, remaining link vifs will be allocated during >> channel assignment where vdev create/start happens. These link vifs will be >> freed during interface down. >> >> Current ath12k_vif(arvif) structure >> >> +---------------+ +---------------+ +---------------+ >> | ieee80211_vif | | ieee80211_vif | | ieee80211_vif | >> | private data | | private data | | private data | >> | | | | | | >> | ath12k_vif | | ath12k_vif | | ath12k_vif | >> | (arvif) | | (arvif) | | (arvif) | >> | | | | | | >> | +----------+ | | +----------+ | | +----------+ | >> | |*ar (2GHz)| | | |*ar (5GHz)| | | |*ar (2GHz)| | >> | +----------+ | | +----------+ | | +----------+ | >> | | | | | | >> +---------------+ +---------------+ +---------------+ >> >> Proposed ath12k_vif(ahvif) containing ath12k_link_vif(s) (arvif) >> (deflink is preallocated member which is always the first link if >> ieee80211_vif is MLD and is the only link otherwise) >> >> +---------------------------------+ >> | ieee80211_vif | >> | private data | >> | | >> | ath12k_vif(ahvif) | >> | | >> | +-------------------------------+ >> | |ath12k_link_vif deflink (arvif)| >> | | +---------------+ | >> | | | *ar(2GHz) | | >> | +-------------------------------+ >> | +-------------------------------+ >> | | ath12k_link_vif *link (arvif)| >> | | +---------------+ | >> | | | *ar(5GHz) | | >> | +-------------------------------+ >> | +-------------------------------+ >> | | ath12k_link_vif *link (arvif)| >> | | +---------------+ | >> | | | *ar(6GHz) | | >> | +-------------------------------+ >> | | >> +---------------------------------+ >> >> To refactor existing ath12k_vif to make use of link vifs, following >> changes are made, >> >> 1. ath12k_vif now called by variable name ahvif stores multiple >> arvifs(ah12k_link_vif) and also has a back pointer to ieee80211_vif. >> >> 2. In this patch set, only deflink is used to be on par with the >> existing code. When MLO support is added the link id will be used to >> fetch the arvif. >> >> 3. For mac80211 ops which doesn't use specific link_id, the config or info >> is common for the vif, hence apply the config to all link vifs. >> The links_map in the ahvif, will be used to identify all the link vifs that >> are setup. >> >> 4. Change ath12k_vif_to_arvif() as ath12k_vif_to_ahvif() to fetch the >> hw level vif. The link vif can be fetched from ahvif->link[], or the >> deflink can be accessed via ahvif->deflink. API to access link >> vif(arvif) by passing link_id can be introduced with MLO Support. >> >> 5. The ieee80211_vif can be accessed from ahvif using ath12k_vif_to_vif() >> >> Locking: >> Currently modifications to members of arvif and arsta are protected by ar->conf_mutex >> and it stays as such. >> Now with these hw level structure (ahvif) being introduced, any modifications >> to its members and link objects (i.e., arvifs[] which are dynamically allocated) >> needs to be protected for writing and ah->conf_mutex is used for the same. >> Also, atomic contexts(say WMI events and certain mac_ops) that we currently have in driver >> will not(shouldn't be allowed) do any modifications but can read them and >> rcu_read_lock() is used for the same. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >> >> Signed-off-by: Sriram R <quic_srirrama@quicinc.com> >> Co-developed-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> >> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> >> --- >> drivers/net/wireless/ath/ath12k/core.h | 69 ++- >> drivers/net/wireless/ath/ath12k/dp.c | 21 +- >> drivers/net/wireless/ath/ath12k/dp.h | 3 +- >> drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +- >> drivers/net/wireless/ath/ath12k/dp_rx.h | 2 +- >> drivers/net/wireless/ath/ath12k/dp_tx.c | 9 +- >> drivers/net/wireless/ath/ath12k/dp_tx.h | 2 +- >> drivers/net/wireless/ath/ath12k/mac.c | 733 ++++++++++++++++-------- >> drivers/net/wireless/ath/ath12k/mac.h | 9 +- >> drivers/net/wireless/ath/ath12k/p2p.c | 17 +- >> drivers/net/wireless/ath/ath12k/p2p.h | 2 +- >> drivers/net/wireless/ath/ath12k/peer.c | 7 +- >> drivers/net/wireless/ath/ath12k/peer.h | 4 +- >> drivers/net/wireless/ath/ath12k/wmi.c | 12 +- >> 14 files changed, 592 insertions(+), 300 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h >> index b483899ca136..d47b6413aaad 100644 >> --- a/drivers/net/wireless/ath/ath12k/core.h >> +++ b/drivers/net/wireless/ath/ath12k/core.h >> @@ -229,10 +229,8 @@ struct ath12k_vif_cache { >> u32 bss_conf_changed; >> }; >> >> -struct ath12k_vif { >> +struct ath12k_link_vif { >> u32 vdev_id; >> - enum wmi_vdev_type vdev_type; >> - enum wmi_vdev_subtype vdev_subtype; >> u32 beacon_interval; >> u32 dtim_period; >> u16 ast_hash; >> @@ -242,13 +240,38 @@ struct ath12k_vif { >> u8 search_type; >> >> struct ath12k *ar; >> - struct ieee80211_vif *vif; >> >> int bank_id; >> u8 vdev_id_check_en; >> >> struct wmi_wmm_params_all_arg wmm_params; >> struct list_head list; >> + >> + bool is_created; >> + bool is_started; >> + bool is_up; >> + u8 bssid[ETH_ALEN]; >> + struct cfg80211_bitrate_mask bitrate_mask; >> + struct delayed_work connection_loss_work; >> + int num_legacy_stations; >> + int rtscts_prot_mode; >> + int txpower; >> + bool rsnie_present; >> + bool wpaie_present; >> + struct ieee80211_chanctx_conf chanctx; >> + u8 vdev_stats_id; >> + u32 punct_bitmap; >> + u8 link_id; >> + struct ath12k_vif *ahvif; >> + struct ath12k_vif_cache *cache; >> +}; >> + >> +struct ath12k_vif { >> + enum wmi_vdev_type vdev_type; >> + enum wmi_vdev_subtype vdev_subtype; >> + struct ieee80211_vif *vif; >> + struct ath12k_hw *ah; >> + >> union { >> struct { >> u32 uapsd; >> @@ -266,31 +289,21 @@ struct ath12k_vif { >> } ap; >> } u; >> >> - bool is_created; >> - bool is_started; >> - bool is_up; >> u32 aid; >> - u8 bssid[ETH_ALEN]; >> - struct cfg80211_bitrate_mask bitrate_mask; >> - struct delayed_work connection_loss_work; >> - int num_legacy_stations; >> - int rtscts_prot_mode; >> - int txpower; >> - bool rsnie_present; >> - bool wpaie_present; >> - struct ieee80211_chanctx_conf chanctx; >> u32 key_cipher; >> u8 tx_encap_type; >> - u8 vdev_stats_id; >> - u32 punct_bitmap; >> bool ps; >> - struct ath12k_vif_cache *cache; >> + >> + struct ath12k_link_vif deflink; >> + struct ath12k_link_vif __rcu *link[IEEE80211_MLD_MAX_NUM_LINKS]; >> + /* indicates bitmap of link vif created in FW */ >> + u16 links_map; >> }; >> >> struct ath12k_vif_iter { >> u32 vdev_id; >> struct ath12k *ar; >> - struct ath12k_vif *arvif; >> + struct ath12k_link_vif *arvif; >> }; >> >> #define HAL_AST_IDX_INVALID 0xFFFF >> @@ -426,7 +439,7 @@ struct ath12k_wbm_tx_stats { >> }; >> >> struct ath12k_sta { >> - struct ath12k_vif *arvif; >> + struct ath12k_link_vif *arvif; >> >> /* the following are protected by ar->data_lock */ >> u32 changed; /* IEEE80211_RC_* */ >> @@ -543,7 +556,7 @@ struct ath12k { >> */ >> struct mutex conf_mutex; >> /* protects the radio specific data like debug stats, ppdu_stats_info stats, >> - * vdev_stop_status info, scan data, ath12k_sta info, ath12k_vif info, >> + * vdev_stop_status info, scan data, ath12k_sta info, ath12k_link_vif info, >> * channel context data, survey info, test mode data. >> */ >> spinlock_t data_lock; >> @@ -639,6 +652,11 @@ struct ath12k_hw { >> enum ath12k_hw_state state; >> bool regd_updated; >> bool use_6ghz_regd; >> + >> + /* To synchronize concurrent access of ahvif->link[] >> + * between mac80211 operations. >> + */ >> + struct mutex conf_mutex; >> u8 num_radio; >> >> /* Keep last */ >> @@ -995,7 +1013,7 @@ static inline struct ath12k_skb_rxcb *ATH12K_SKB_RXCB(struct sk_buff *skb) >> return (struct ath12k_skb_rxcb *)skb->cb; >> } >> >> -static inline struct ath12k_vif *ath12k_vif_to_arvif(struct ieee80211_vif *vif) >> +static inline struct ath12k_vif *ath12k_vif_to_ahvif(struct ieee80211_vif *vif) >> { >> return (struct ath12k_vif *)vif->drv_priv; >> } >> @@ -1005,6 +1023,11 @@ static inline struct ath12k_sta *ath12k_sta_to_arsta(struct ieee80211_sta *sta) >> return (struct ath12k_sta *)sta->drv_priv; >> } >> >> +static inline struct ieee80211_vif *ath12k_vif_to_vif(struct ath12k_vif *ahvif) > better naming as ath12k_ahvif_to_vif()? > Sure, make sense will change as suggested. >> +{ >> + return container_of((void *)ahvif, struct ieee80211_vif, drv_priv); >> +} >> + >> static inline struct ath12k *ath12k_ab_to_ar(struct ath12k_base *ab, >> int mac_id) >> { >> diff --git a/drivers/net/wireless/ath/ath12k/dp.c b/drivers/net/wireless/ath/ath12k/dp.c >> index 61aa78d8bd8c..30aac0dd5a80 100644 >> --- a/drivers/net/wireless/ath/ath12k/dp.c >> +++ b/drivers/net/wireless/ath/ath12k/dp.c >> @@ -327,20 +327,22 @@ int ath12k_dp_srng_setup(struct ath12k_base *ab, struct dp_srng *ring, >> } >> ... >> >> @@ -4655,11 +4787,14 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, >> return; >> } >> >> + rcu_read_lock(); >> + arvif = &ahvif->deflink; > does ath12k_vif::deflink need rcu protect? note it is not declared as rcu*, and even mac80211 uses it without holding such lock. See Not needed, but this is going to be link specific once MLO changes are in and ideally we should now be obtaining ahvif->link[0] (which is anyway deflink as of now) as a preperation for that. Will change this to use link[0]. > ieee80211_mgd_auth() { > struct ieee80211_link_data *link; > ... > if() > ... > else > link = &sdata->deflink; > > ... > } > >> spin_lock_bh(&ar->ab->base_lock); >> >> peer = ath12k_peer_find(ar->ab, arvif->vdev_id, sta->addr); >> if (!peer) { >> spin_unlock_bh(&ar->ab->base_lock); >> + rcu_read_unlock(); >> ath12k_warn(ar->ab, "mac sta rc update failed to find peer %pM on vdev %i\n", >> sta->addr, arvif->vdev_id); >> return; ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 2/3] wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif 2024-06-17 13:16 [PATCH v4 0/3] wifi: ath12k: prepare vif and sta datastructure Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling Rameshkumar Sundaram @ 2024-06-17 13:16 ` Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram 2 siblings, 0 replies; 11+ messages in thread From: Rameshkumar Sundaram @ 2024-06-17 13:16 UTC (permalink / raw) To: ath12k; +Cc: linux-wireless, Sriram R, Rameshkumar Sundaram, Jeff Johnson From: Sriram R <quic_srirrama@quicinc.com> Currently ieee80211_vif/ahvif is passed as argument for all vif related control path functions that are being called from mac80211 ops. With MLO support being added multiple link vifs can be part of an ieee80211_vif/ahvif and all these functions will need link id along with ieee80211_vif/ahvif to be passed to fetch the corresponding link vif (arvif) to which the control/config applies. Also all these functions need to validate the locking dependency before dereferencing and start using the link vifs. To avoid these redundant link dereferences and validations, limit ieee80211_vif/ahvif argument to mac80211 ops unless otherwise really required. Do link vif dereference and locking only in mac80211 ops. Replace vif arg with ath12k_link_vif and internally fetch ath12k_vif(ahvif) and vif(ieee80211_vif) if required on other functions. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: Sriram R <quic_srirrama@quicinc.com> Co-developed-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/net/wireless/ath/ath12k/mac.c | 200 ++++++++++---------------- 1 file changed, 74 insertions(+), 126 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 8bd8efcc1264..9d6e35991db6 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -249,8 +249,8 @@ static const u32 ath12k_smps_map[] = { static int ath12k_start_vdev_delay(struct ath12k *ar, struct ath12k_link_vif *arvif); static void ath12k_mac_stop(struct ath12k *ar); -static int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif); -static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif); +static int ath12k_mac_vdev_create(struct ath12k *ar, struct ath12k_link_vif *arvif); +static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ath12k_link_vif *arvif); static const char *ath12k_mac_phymode_str(enum wmi_phy_mode mode) { @@ -1656,19 +1656,16 @@ static void ath12k_mac_vif_sta_connection_loss_work(struct work_struct *work) } static void ath12k_peer_assoc_h_basic(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); - struct ath12k_link_vif *arvif; u32 aid; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; if (vif->type == NL80211_IFTYPE_STATION) aid = vif->cfg.aid; else @@ -1685,23 +1682,20 @@ static void ath12k_peer_assoc_h_basic(struct ath12k *ar, } static void ath12k_peer_assoc_h_crypto(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ieee80211_bss_conf *info = &vif->bss_conf; - struct ath12k_link_vif *arvif; struct cfg80211_chan_def def; struct cfg80211_bss *bss; struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); const u8 *rsnie = NULL; const u8 *wpaie = NULL; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -1750,26 +1744,23 @@ static void ath12k_peer_assoc_h_crypto(struct ath12k *ar, } static void ath12k_peer_assoc_h_rates(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct wmi_rate_set_arg *rateset = &arg->peer_legacy_rates; struct cfg80211_chan_def def; const struct ieee80211_supported_band *sband; const struct ieee80211_rate *rates; struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); - struct ath12k_link_vif *arvif; enum nl80211_band band; u32 ratemask; u8 rate; int i; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -1816,13 +1807,12 @@ ath12k_peer_assoc_h_vht_masked(const u16 *vht_mcs_mask) } static void ath12k_peer_assoc_h_ht(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); const struct ieee80211_sta_ht_cap *ht_cap = &sta->deflink.ht_cap; - struct ath12k_link_vif *arvif; struct cfg80211_chan_def def; enum nl80211_band band; const u8 *ht_mcs_mask; @@ -1830,10 +1820,8 @@ static void ath12k_peer_assoc_h_ht(struct ath12k *ar, u8 max_nss; u32 stbc; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -1980,13 +1968,12 @@ ath12k_peer_assoc_h_vht_limit(u16 tx_mcs_set, } static void ath12k_peer_assoc_h_vht(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); const struct ieee80211_sta_vht_cap *vht_cap = &sta->deflink.vht_cap; - struct ath12k_link_vif *arvif; struct cfg80211_chan_def def; enum nl80211_band band; const u16 *vht_mcs_mask; @@ -1995,9 +1982,6 @@ static void ath12k_peer_assoc_h_vht(struct ath12k *ar, u8 max_nss, vht_mcs; int i; - lockdep_assert_held(&ahvif->ah->conf_mutex); - arvif = &ahvif->deflink; - if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -2079,10 +2063,11 @@ static void ath12k_peer_assoc_h_vht(struct ath12k *ar, } static void ath12k_peer_assoc_h_he(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; int i; u8 ampdu_factor, rx_mcs_80, rx_mcs_160, max_nss; @@ -2233,11 +2218,12 @@ static void ath12k_peer_assoc_h_he(struct ath12k *ar, } static void ath12k_peer_assoc_h_he_6ghz(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct cfg80211_chan_def def; enum nl80211_band band; u8 ampdu_factor, mpdu_density; @@ -2331,13 +2317,11 @@ static void ath12k_peer_assoc_h_smps(struct ieee80211_sta *sta, } static void ath12k_peer_assoc_h_qos(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); - - switch (ahvif->vdev_type) { + switch (arvif->ahvif->vdev_type) { case WMI_VDEV_TYPE_AP: if (sta->wme) { /* TODO: Check WME vs QoS */ @@ -2529,7 +2513,7 @@ static enum wmi_phy_mode ath12k_mac_get_phymode_eht(struct ath12k *ar, } static void ath12k_peer_assoc_h_phymode(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { @@ -2538,12 +2522,8 @@ static void ath12k_peer_assoc_h_phymode(struct ath12k *ar, const u8 *ht_mcs_mask; const u16 *vht_mcs_mask; enum wmi_phy_mode phymode = MODE_UNKNOWN; - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); - struct ath12k_link_vif *arvif; - - lockdep_assert_held(&ahvif->ah->conf_mutex); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); - arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -2678,21 +2658,16 @@ static void ath12k_mac_set_eht_ppe_threshold(const u8 *ppe_thres, } static void ath12k_peer_assoc_h_eht(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); const struct ieee80211_sta_eht_cap *eht_cap = &sta->deflink.eht_cap; const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; const struct ieee80211_eht_mcs_nss_supp_20mhz_only *bw_20; const struct ieee80211_eht_mcs_nss_supp_bw *bw; - struct ath12k_link_vif *arvif; u32 *rx_mcs, *tx_mcs; - lockdep_assert_held(&ahvif->ah->conf_mutex); - - arvif = &ahvif->deflink; if (!sta->deflink.he_cap.has_he || !eht_cap->has_eht) return; @@ -2765,7 +2740,7 @@ static void ath12k_peer_assoc_h_eht(struct ath12k *ar, } static void ath12k_peer_assoc_prepare(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ath12k_wmi_peer_assoc_arg *arg, bool reassoc) @@ -2777,16 +2752,16 @@ static void ath12k_peer_assoc_prepare(struct ath12k *ar, reinit_completion(&ar->peer_assoc_done); arg->peer_new_assoc = !reassoc; - ath12k_peer_assoc_h_basic(ar, vif, sta, arg); - ath12k_peer_assoc_h_crypto(ar, vif, sta, arg); - ath12k_peer_assoc_h_rates(ar, vif, sta, arg); - ath12k_peer_assoc_h_ht(ar, vif, sta, arg); - ath12k_peer_assoc_h_vht(ar, vif, sta, arg); - ath12k_peer_assoc_h_he(ar, vif, sta, arg); - ath12k_peer_assoc_h_he_6ghz(ar, vif, sta, arg); - ath12k_peer_assoc_h_eht(ar, vif, sta, arg); - ath12k_peer_assoc_h_qos(ar, vif, sta, arg); - ath12k_peer_assoc_h_phymode(ar, vif, sta, arg); + ath12k_peer_assoc_h_basic(ar, arvif, sta, arg); + ath12k_peer_assoc_h_crypto(ar, arvif, sta, arg); + ath12k_peer_assoc_h_rates(ar, arvif, sta, arg); + ath12k_peer_assoc_h_ht(ar, arvif, sta, arg); + ath12k_peer_assoc_h_vht(ar, arvif, sta, arg); + ath12k_peer_assoc_h_he(ar, arvif, sta, arg); + ath12k_peer_assoc_h_he_6ghz(ar, arvif, sta, arg); + ath12k_peer_assoc_h_eht(ar, arvif, sta, arg); + ath12k_peer_assoc_h_qos(ar, arvif, sta, arg); + ath12k_peer_assoc_h_phymode(ar, arvif, sta, arg); ath12k_peer_assoc_h_smps(sta, arg); /* TODO: amsdu_disable req? */ @@ -2836,7 +2811,7 @@ static void ath12k_bss_assoc(struct ath12k *ar, return; } - ath12k_peer_assoc_prepare(ar, vif, ap_sta, &peer_arg, false); + ath12k_peer_assoc_prepare(ar, arvif, ap_sta, &peer_arg, false); rcu_read_unlock(); @@ -2954,23 +2929,20 @@ static u32 ath12k_mac_get_rate_hw_value(int bitrate) } static void ath12k_recalculate_mgmt_rate(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct cfg80211_chan_def *def) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); const struct ieee80211_supported_band *sband; - struct ath12k_link_vif *arvif; u8 basic_rate_idx; int hw_rate_code; u32 vdev_param; u16 bitrate; int ret; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; sband = hw->wiphy->bands[def->chan->band]; basic_rate_idx = ffs(vif->bss_conf.basic_rates) - 1; bitrate = sband->bitrates[basic_rate_idx].bitrate; @@ -3323,7 +3295,7 @@ static void ath12k_mac_bss_info_changed(struct ath12k *ar, if (changed & BSS_CHANGED_BASIC_RATES && !ath12k_mac_vif_chan(vif, &def)) - ath12k_recalculate_mgmt_rate(ar, vif, &def); + ath12k_recalculate_mgmt_rate(ar, arvif, &def); if (changed & BSS_CHANGED_TWT) { if (info->twt_requester || info->twt_responder) @@ -3689,7 +3661,7 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, */ prev_ar = arvif->ar; mutex_lock(&prev_ar->conf_mutex); - ret = ath12k_mac_vdev_delete(prev_ar, vif); + ret = ath12k_mac_vdev_delete(prev_ar, arvif); mutex_unlock(&prev_ar->conf_mutex); if (ret) ath12k_warn(prev_ar->ab, @@ -3700,7 +3672,7 @@ static int ath12k_mac_op_hw_scan(struct ieee80211_hw *hw, } if (create) { mutex_lock(&ar->conf_mutex); - ret = ath12k_mac_vdev_create(ar, vif); + ret = ath12k_mac_vdev_create(ar, arvif); mutex_unlock(&ar->conf_mutex); if (ret) { ath12k_warn(ar->ab, "unable to create scan vdev %d\n", ret); @@ -3936,22 +3908,20 @@ static int ath12k_clear_peer_keys(struct ath12k_link_vif *arvif, } static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, - struct ieee80211_vif *vif, struct ieee80211_sta *sta, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, struct ieee80211_key_conf *key) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); struct ath12k_base *ab = ar->ab; - struct ath12k_link_vif *arvif; struct ath12k_peer *peer; struct ath12k_sta *arsta; const u8 *peer_addr; int ret = 0; u32 flags = 0; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; if (test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags)) return 1; @@ -4104,7 +4074,7 @@ static int ath12k_mac_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, */ mutex_lock(&ar->conf_mutex); - ret = ath12k_mac_set_key(ar, cmd, vif, sta, key); + ret = ath12k_mac_set_key(ar, cmd, arvif, sta, key); mutex_unlock(&ar->conf_mutex); mutex_unlock(&ah->conf_mutex); return ret; @@ -4171,30 +4141,27 @@ ath12k_mac_set_peer_vht_fixed_rate(struct ath12k_link_vif *arvif, } static int ath12k_station_assoc(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, bool reassoc) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ath12k_wmi_peer_assoc_arg peer_arg; int ret; struct cfg80211_chan_def def; enum nl80211_band band; - struct ath12k_link_vif *arvif; struct cfg80211_bitrate_mask *mask; u8 num_vht_rates; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return -EPERM; band = def.chan->band; mask = &arvif->bitrate_mask; - ath12k_peer_assoc_prepare(ar, vif, sta, &peer_arg, reassoc); + ath12k_peer_assoc_prepare(ar, arvif, sta, &peer_arg, reassoc); ret = ath12k_wmi_send_peer_assoc_cmd(ar, &peer_arg); if (ret) { @@ -4258,17 +4225,13 @@ static int ath12k_station_assoc(struct ath12k *ar, } static int ath12k_station_disassoc(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); - struct ath12k_link_vif *arvif; int ret; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; if (!sta->wme) { arvif->num_legacy_stations--; ret = ath12k_recalc_rtscts_prot(arvif); @@ -4334,7 +4297,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) ath12k_mac_max_vht_nss(vht_mcs_mask))); if (changed & IEEE80211_RC_BW_CHANGED) { - ath12k_peer_assoc_h_phymode(ar, vif, sta, &peer_arg); + ath12k_peer_assoc_h_phymode(ar, arvif, sta, &peer_arg); peer_phymode = peer_arg.peer_phymode; if (bw > bw_prev) { @@ -4429,7 +4392,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) * is provided in the new bitrate mask we set the * other rates using peer_assoc command. */ - ath12k_peer_assoc_prepare(ar, vif, sta, + ath12k_peer_assoc_prepare(ar, arvif, sta, &peer_arg, true); err = ath12k_wmi_send_peer_assoc_cmd(ar, &peer_arg); @@ -4478,20 +4441,17 @@ static void ath12k_mac_dec_num_stations(struct ath12k_link_vif *arvif, } static int ath12k_mac_station_add(struct ath12k *ar, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_sta *sta) { struct ath12k_base *ab = ar->ab; - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); struct ath12k_wmi_peer_create_arg peer_param; - struct ath12k_link_vif *arvif; int ret; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; ret = ath12k_mac_inc_num_stations(arvif, sta); if (ret) { ath12k_warn(ab, "refusing to associate station: too many connected already (%d)\n", @@ -4623,7 +4583,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, arsta->arvif = arvif; INIT_WORK(&arsta->update_wk, ath12k_sta_rc_update_wk); - ret = ath12k_mac_station_add(ar, vif, sta); + ret = ath12k_mac_station_add(ar, arvif, sta); if (ret) ath12k_warn(ar->ab, "Failed to add station: %pM for VDEV: %d\n", sta->addr, arvif->vdev_id); @@ -4666,7 +4626,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, (vif->type == NL80211_IFTYPE_AP || vif->type == NL80211_IFTYPE_MESH_POINT || vif->type == NL80211_IFTYPE_ADHOC)) { - ret = ath12k_station_assoc(ar, vif, sta, false); + ret = ath12k_station_assoc(ar, arvif, sta, false); if (ret) ath12k_warn(ar->ab, "Failed to associate station: %pM\n", sta->addr); @@ -4710,7 +4670,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, (vif->type == NL80211_IFTYPE_AP || vif->type == NL80211_IFTYPE_MESH_POINT || vif->type == NL80211_IFTYPE_ADHOC)) { - ret = ath12k_station_disassoc(ar, vif, sta); + ret = ath12k_station_disassoc(ar, arvif, sta); if (ret) ath12k_warn(ar->ab, "Failed to disassociate station: %pM\n", sta->addr); @@ -6496,24 +6456,22 @@ static void ath12k_mac_op_update_vif_offload(struct ieee80211_hw *hw, ath12k_mac_update_vif_offload(&ahvif->deflink); } -int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) +int ath12k_mac_vdev_create(struct ath12k *ar, struct ath12k_link_vif *arvif) { struct ath12k_hw *ah = ar->ah; struct ath12k_base *ab = ar->ab; struct ieee80211_hw *hw = ah->hw; - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); struct ath12k_wmi_vdev_create_arg vdev_arg = {0}; struct ath12k_wmi_peer_create_arg peer_param; - struct ath12k_link_vif *arvif; u32 param_id, param_value; u16 nss; int i; int ret, vdev_id; - lockdep_assert_held(&ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; arvif->ar = ar; vdev_id = __ffs64(ab->free_vdev_map); arvif->vdev_id = vdev_id; @@ -6719,19 +6677,16 @@ int ath12k_mac_vdev_create(struct ath12k *ar, struct ieee80211_vif *vif) return ret; } -static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ieee80211_vif *vif) +static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ath12k_link_vif *arvif) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); - struct ath12k_vif_cache *cache; + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ath12k_vif_cache *cache = arvif->cache; struct ath12k_base *ab = ar->ab; - struct ath12k_link_vif *arvif; + int ret; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - arvif = &ahvif->deflink; - cache = arvif->cache; if (!cache) return; @@ -6750,7 +6705,7 @@ static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ieee80211_vif * } if (cache->key_conf.changed) { - ret = ath12k_mac_set_key(ar, cache->key_conf.cmd, vif, NULL, + ret = ath12k_mac_set_key(ar, cache->key_conf.cmd, arvif, NULL, cache->key_conf.key); if (ret) ath12k_warn(ab, "unable to apply set key param to vdev %d ret %d\n", @@ -6760,19 +6715,15 @@ static void ath12k_mac_vif_cache_flush(struct ath12k *ar, struct ieee80211_vif * } static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, - struct ieee80211_vif *vif, + struct ath12k_link_vif *arvif, struct ieee80211_chanctx_conf *ctx) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); - struct ath12k_link_vif *arvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); struct ath12k_hw *ah = hw->priv; struct ath12k *ar, *prev_ar; struct ath12k_base *ab; int ret; - lockdep_assert_held(&ah->conf_mutex); - arvif = &ahvif->deflink; - if (ah->num_radio == 1) ar = ah->radio; else if (ctx) @@ -6806,7 +6757,7 @@ static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, */ prev_ar = arvif->ar; mutex_lock(&prev_ar->conf_mutex); - ret = ath12k_mac_vdev_delete(prev_ar, vif); + ret = ath12k_mac_vdev_delete(prev_ar, arvif); if (ret) ath12k_warn(prev_ar->ab, "unable to delete vdev %d\n", @@ -6834,7 +6785,7 @@ static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, goto unlock; } - ret = ath12k_mac_vdev_create(ar, vif); + ret = ath12k_mac_vdev_create(ar, arvif); if (ret) { ath12k_warn(ab, "failed to create vdev %pM ret %d", vif->addr, ret); goto unlock; @@ -6845,7 +6796,7 @@ static struct ath12k *ath12k_mac_assign_vif_to_vdev(struct ieee80211_hw *hw, * add_interface(), Apply any parameters for the vdev which were received * after add_interface, corresponding to this vif. */ - ath12k_mac_vif_cache_flush(ar, vif); + ath12k_mac_vif_cache_flush(ar, arvif); unlock: mutex_unlock(&ar->conf_mutex); return arvif->ar; @@ -6891,7 +6842,7 @@ static int ath12k_mac_op_add_interface(struct ieee80211_hw *hw, * creation until channel_assign to determine the radio on which the * vdev needs to be created */ - ath12k_mac_assign_vif_to_vdev(hw, vif, NULL); + ath12k_mac_assign_vif_to_vdev(hw, arvif, NULL); mutex_unlock(&ah->conf_mutex); return 0; } @@ -6921,18 +6872,15 @@ static void ath12k_mac_vif_unref(struct ath12k_dp *dp, struct ieee80211_vif *vif } } -static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ieee80211_vif *vif) +static int ath12k_mac_vdev_delete(struct ath12k *ar, struct ath12k_link_vif *arvif) { - struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_vif *ahvif = arvif->ahvif; + struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); struct ath12k_base *ab = ar->ab; - struct ath12k_link_vif *arvif; unsigned long time_left; int ret; - lockdep_assert_held(&ahvif->ah->conf_mutex); lockdep_assert_held(&ar->conf_mutex); - - arvif = &ahvif->deflink; reinit_completion(&ar->vdev_delete_done); ret = ath12k_wmi_vdev_delete(ar, arvif->vdev_id); @@ -7031,7 +6979,7 @@ static void ath12k_mac_op_remove_interface(struct ieee80211_hw *hw, arvif->vdev_id, ret); } - ath12k_mac_vdev_delete(ar, vif); + ath12k_mac_vdev_delete(ar, arvif); mutex_unlock(&ar->conf_mutex); mutex_unlock(&ah->conf_mutex); @@ -7778,7 +7726,7 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, */ mutex_lock(&ah->conf_mutex); arvif = &ahvif->deflink; - ar = ath12k_mac_assign_vif_to_vdev(hw, vif, ctx); + ar = ath12k_mac_assign_vif_to_vdev(hw, arvif, ctx); if (!ar) { WARN_ON(1); mutex_unlock(&ah->conf_mutex); @@ -8704,7 +8652,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, */ prev_ar = arvif->ar; mutex_lock(&prev_ar->conf_mutex); - ret = ath12k_mac_vdev_delete(prev_ar, vif); + ret = ath12k_mac_vdev_delete(prev_ar, arvif); mutex_unlock(&prev_ar->conf_mutex); if (ret) { ath12k_warn(prev_ar->ab, @@ -8720,7 +8668,7 @@ static int ath12k_mac_op_remain_on_channel(struct ieee80211_hw *hw, if (create) { mutex_lock(&ar->conf_mutex); - ret = ath12k_mac_vdev_create(ar, vif); + ret = ath12k_mac_vdev_create(ar, arvif); mutex_unlock(&ar->conf_mutex); if (ret) { ath12k_warn(ar->ab, "unable to create scan vdev for roc: %d\n", -- 2.34.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling 2024-06-17 13:16 [PATCH v4 0/3] wifi: ath12k: prepare vif and sta datastructure Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 2/3] wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif Rameshkumar Sundaram @ 2024-06-17 13:16 ` Rameshkumar Sundaram 2024-06-18 10:19 ` Baochen Qiang 2024-06-18 10:23 ` Baochen Qiang 2 siblings, 2 replies; 11+ messages in thread From: Rameshkumar Sundaram @ 2024-06-17 13:16 UTC (permalink / raw) To: ath12k; +Cc: linux-wireless, Sriram R, Rameshkumar Sundaram, Jeff Johnson From: Sriram R <quic_srirrama@quicinc.com> To prepare the driver for MLO support, split the driver sta data structure to scale for multiple links. This requires changing the use of arsta to per link and not per hw which can now comprise of multiple links. Also since most configurations from mac80211 are done per link, do refactoring of the driver functions to apply these configurations at link level. Split ath12k_sta which is the driver private of ieee80211_sta to store link specific information as ath12k_link_sta. For default use cases the ath12k_sta will have a preallocated link sta called deflink which will be used by non ML STAs and the first link sta of ML STA. With MLO Support to be added, remaining link stas will allocated during state change where new STA is added. These link stas will be freed when STA is deleted. Current ath12k_sta(arsta) structure +-----------------+ +----------------+ | | | | | ieee80211_sta | | ieee80211_sta | | private data | | private data | | | | | | ath12k_sta | | ath12k_sta | | (arsta) | | (arsta) | |+---------------+| | +-------------+| || *arvif (link || | |*arvif (link || || vif of an ar || | | vif of an ar|| || say 5GHz) || | | say 6GHz) || |+---------------+| | +-------------+| +-----------------+ +----------------+ Proposed ath12k_sta(ahsta) containing ath12k_link_sta(s) (arsta) (deflink is preallocated member which is always the first link if ieee80211_sta is ML STA and is the only link sta otherwise) +---------------------------------------+ | ieee80211_sta | | private data | | | | ath12k_sta (ahsta) | | +-------------------------------------+ | | ath12k_link_sta deflink (arsta) | | | | | | *arvif (link vif of ar (5GHz)) | | +-------------------------------------+ | +-------------------------------------+ | | ath12k_link_sta *link (arsta) | | | | | | *arvif (link vif of ar (6GHz)) | | | | | +-------------------------------------+ | | +---------------------------------------+ To refactor existing ath12k_sta to make use of link stas, following changes are made, 1. Limit ieee80211_sta argument mac80211 ops unless otherwise really required. 2. ath12k_sta now called by variable name arsta stores multiple arstas(ah12k_link_sta) and also has a back pointer to ath12k_sta 3. Pass ath12k_link_sta to mac functions that passed ieee80211_sta arg and fetch ath12k_sta(ahsta) and sta(ieee80211_sta) internally. This is done to avoid passing link id in all the functions and performing validation across these functions. Rather the validation and sta to arsta conversion can be done only at the mac80211 ops. 4. In this patchset, only ahsta->deflink is used to be on par with the existing code. When MLO support is added the link id will be used to fetch the arsta. 5. Change ath12k_sta_to_arsta() to ath12k_vif_to_ahsta() to fetch the ML level sta. The link sta can be fetched from ahsta->link[], or the deflink can be accessed via ahsta->deflink. API to access link sta (arsta) by passing link_id can be introduced with MLO Support. 6. The ieee80211_sta can be accessed from ahsta using ath12k_sta_to_sta() Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Signed-off-by: Sriram R <quic_srirrama@quicinc.com> Co-developed-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> Signed-off-by: Rameshkumar Sundaram <quic_ramess@quicinc.com> Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- drivers/net/wireless/ath/ath12k/core.h | 24 ++- drivers/net/wireless/ath/ath12k/dp_mon.c | 14 +- drivers/net/wireless/ath/ath12k/dp_rx.c | 14 +- drivers/net/wireless/ath/ath12k/mac.c | 192 +++++++++++++++-------- 4 files changed, 166 insertions(+), 78 deletions(-) diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h index d47b6413aaad..c43e43982ca6 100644 --- a/drivers/net/wireless/ath/ath12k/core.h +++ b/drivers/net/wireless/ath/ath12k/core.h @@ -438,15 +438,15 @@ struct ath12k_wbm_tx_stats { u64 wbm_tx_comp_stats[HAL_WBM_REL_HTT_TX_COMP_STATUS_MAX]; }; -struct ath12k_sta { +struct ath12k_link_sta { struct ath12k_link_vif *arvif; + struct ath12k_sta *ahsta; /* the following are protected by ar->data_lock */ u32 changed; /* IEEE80211_RC_* */ u32 bw; u32 nss; u32 smps; - enum hal_pn_type pn_type; struct work_struct update_wk; struct rate_info txrate; @@ -454,11 +454,20 @@ struct ath12k_sta { u64 rx_duration; u64 tx_duration; u8 rssi_comb; + u8 link_id; struct ath12k_rx_peer_stats *rx_stats; struct ath12k_wbm_tx_stats *wbm_tx_stats; u32 bw_prev; }; +struct ath12k_sta { + enum hal_pn_type pn_type; + struct ath12k_link_sta deflink; + struct ath12k_link_sta __rcu *link[IEEE80211_MLD_MAX_NUM_LINKS]; + /* indicates bitmap of link sta created in FW */ + u16 links_map; +}; + #define ATH12K_MIN_5G_FREQ 4150 #define ATH12K_MIN_6G_FREQ 5925 #define ATH12K_MAX_6G_FREQ 7115 @@ -653,8 +662,8 @@ struct ath12k_hw { bool regd_updated; bool use_6ghz_regd; - /* To synchronize concurrent access of ahvif->link[] - * between mac80211 operations. + /* To synchronize concurrent access of ahvif->link[] and + * ahsta->link[] between mac80211 operations. */ struct mutex conf_mutex; u8 num_radio; @@ -1018,11 +1027,16 @@ static inline struct ath12k_vif *ath12k_vif_to_ahvif(struct ieee80211_vif *vif) return (struct ath12k_vif *)vif->drv_priv; } -static inline struct ath12k_sta *ath12k_sta_to_arsta(struct ieee80211_sta *sta) +static inline struct ath12k_sta *ath12k_sta_to_ahsta(struct ieee80211_sta *sta) { return (struct ath12k_sta *)sta->drv_priv; } +static inline struct ieee80211_sta *ath12k_sta_to_sta(struct ath12k_sta *ahsta) +{ + return container_of((void *)ahsta, struct ieee80211_sta, drv_priv); +} + static inline struct ieee80211_vif *ath12k_vif_to_vif(struct ath12k_vif *ahvif) { return container_of((void *)ahvif, struct ieee80211_vif, drv_priv); diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c index 5c6749bc4039..f688f4ad5168 100644 --- a/drivers/net/wireless/ath/ath12k/dp_mon.c +++ b/drivers/net/wireless/ath/ath12k/dp_mon.c @@ -2165,7 +2165,7 @@ ath12k_dp_mon_rx_update_peer_rate_table_stats(struct ath12k_rx_peer_stats *rx_st } static void ath12k_dp_mon_rx_update_peer_su_stats(struct ath12k *ar, - struct ath12k_sta *arsta, + struct ath12k_link_sta *arsta, struct hal_rx_mon_ppdu_info *ppdu_info) { struct ath12k_rx_peer_stats *rx_stats = arsta->rx_stats; @@ -2321,7 +2321,8 @@ ath12k_dp_mon_rx_update_user_stats(struct ath12k *ar, struct hal_rx_mon_ppdu_info *ppdu_info, u32 uid) { - struct ath12k_sta *arsta = NULL; + struct ath12k_sta *ahsta; + struct ath12k_link_sta *arsta; struct ath12k_rx_peer_stats *rx_stats = NULL; struct hal_rx_user_status *user_stats = &ppdu_info->userstats[uid]; struct ath12k_peer *peer; @@ -2338,7 +2339,8 @@ ath12k_dp_mon_rx_update_user_stats(struct ath12k *ar, return; } - arsta = ath12k_sta_to_arsta(peer->sta); + ahsta = ath12k_sta_to_ahsta(peer->sta); + arsta = &ahsta->deflink; rx_stats = arsta->rx_stats; if (!rx_stats) @@ -2445,7 +2447,8 @@ int ath12k_dp_mon_rx_process_stats(struct ath12k *ar, int mac_id, struct dp_srng *mon_dst_ring; struct hal_srng *srng; struct dp_rxdma_mon_ring *buf_ring; - struct ath12k_sta *arsta = NULL; + struct ath12k_sta *ahsta = NULL; + struct ath12k_link_sta *arsta; struct ath12k_peer *peer; u64 cookie; int num_buffs_reaped = 0, srng_id, buf_id; @@ -2514,7 +2517,8 @@ int ath12k_dp_mon_rx_process_stats(struct ath12k *ar, int mac_id, } if (ppdu_info->reception_type == HAL_RX_RECEPTION_TYPE_SU) { - arsta = ath12k_sta_to_arsta(peer->sta); + ahsta = ath12k_sta_to_ahsta(peer->sta); + arsta = &ahsta->deflink; ath12k_dp_mon_rx_update_peer_su_stats(ar, arsta, ppdu_info); } else if ((ppdu_info->fc_valid) && diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c index 781cb7af8cf0..ece4d9635c7d 100644 --- a/drivers/net/wireless/ath/ath12k/dp_rx.c +++ b/drivers/net/wireless/ath/ath12k/dp_rx.c @@ -1040,13 +1040,14 @@ int ath12k_dp_rx_ampdu_start(struct ath12k *ar, struct ieee80211_ampdu_params *params) { struct ath12k_base *ab = ar->ab; - struct ath12k_sta *arsta = ath12k_sta_to_arsta(params->sta); + struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(params->sta); + struct ath12k_link_sta *arsta = &ahsta->deflink; int vdev_id = arsta->arvif->vdev_id; int ret; ret = ath12k_dp_rx_peer_tid_setup(ar, params->sta->addr, vdev_id, params->tid, params->buf_size, - params->ssn, arsta->pn_type); + params->ssn, arsta->ahsta->pn_type); if (ret) ath12k_warn(ab, "failed to setup rx tid %d\n", ret); @@ -1058,7 +1059,8 @@ int ath12k_dp_rx_ampdu_stop(struct ath12k *ar, { struct ath12k_base *ab = ar->ab; struct ath12k_peer *peer; - struct ath12k_sta *arsta = ath12k_sta_to_arsta(params->sta); + struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(params->sta); + struct ath12k_link_sta *arsta = &ahsta->deflink; int vdev_id = arsta->arvif->vdev_id; bool active; int ret; @@ -1312,7 +1314,8 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar, struct ath12k_base *ab = ar->ab; struct ath12k_peer *peer; struct ieee80211_sta *sta; - struct ath12k_sta *arsta; + struct ath12k_sta *ahsta; + struct ath12k_link_sta *arsta; struct htt_ppdu_stats_user_rate *user_rate; struct ath12k_per_peer_tx_stats *peer_stats = &ar->peer_tx_stats; struct htt_ppdu_user_stats *usr_stats = &ppdu_stats->user_stats[user]; @@ -1393,7 +1396,8 @@ ath12k_update_per_peer_tx_stats(struct ath12k *ar, } sta = peer->sta; - arsta = ath12k_sta_to_arsta(sta); + ahsta = ath12k_sta_to_ahsta(sta); + arsta = &ahsta->deflink; memset(&arsta->txrate, 0, sizeof(arsta->txrate)); diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 9d6e35991db6..7fadfafbd6a6 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -1657,10 +1657,11 @@ static void ath12k_mac_vif_sta_connection_loss_work(struct work_struct *work) static void ath12k_peer_assoc_h_basic(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ieee80211_hw *hw = ath12k_ar_to_hw(ar); u32 aid; @@ -1683,10 +1684,11 @@ static void ath12k_peer_assoc_h_basic(struct ath12k *ar, static void ath12k_peer_assoc_h_crypto(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ieee80211_bss_conf *info = &vif->bss_conf; struct cfg80211_chan_def def; struct cfg80211_bss *bss; @@ -1745,10 +1747,11 @@ static void ath12k_peer_assoc_h_crypto(struct ath12k *ar, static void ath12k_peer_assoc_h_rates(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct wmi_rate_set_arg *rateset = &arg->peer_legacy_rates; struct cfg80211_chan_def def; const struct ieee80211_supported_band *sband; @@ -1808,10 +1811,11 @@ ath12k_peer_assoc_h_vht_masked(const u16 *vht_mcs_mask) static void ath12k_peer_assoc_h_ht(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); const struct ieee80211_sta_ht_cap *ht_cap = &sta->deflink.ht_cap; struct cfg80211_chan_def def; enum nl80211_band band; @@ -1969,10 +1973,11 @@ ath12k_peer_assoc_h_vht_limit(u16 tx_mcs_set, static void ath12k_peer_assoc_h_vht(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); const struct ieee80211_sta_vht_cap *vht_cap = &sta->deflink.vht_cap; struct cfg80211_chan_def def; enum nl80211_band band; @@ -2064,10 +2069,11 @@ static void ath12k_peer_assoc_h_vht(struct ath12k *ar, static void ath12k_peer_assoc_h_he(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; int i; u8 ampdu_factor, rx_mcs_80, rx_mcs_160, max_nss; @@ -2219,11 +2225,12 @@ static void ath12k_peer_assoc_h_he(struct ath12k *ar, static void ath12k_peer_assoc_h_he_6ghz(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { - const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); + const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; struct cfg80211_chan_def def; enum nl80211_band band; u8 ampdu_factor, mpdu_density; @@ -2291,9 +2298,10 @@ static int ath12k_get_smps_from_capa(const struct ieee80211_sta_ht_cap *ht_cap, return 0; } -static void ath12k_peer_assoc_h_smps(struct ieee80211_sta *sta, +static void ath12k_peer_assoc_h_smps(struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); const struct ieee80211_he_6ghz_capa *he_6ghz_capa = &sta->deflink.he_6ghz_capa; const struct ieee80211_sta_ht_cap *ht_cap = &sta->deflink.ht_cap; int smps; @@ -2318,9 +2326,11 @@ static void ath12k_peer_assoc_h_smps(struct ieee80211_sta *sta, static void ath12k_peer_assoc_h_qos(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); + switch (arvif->ahvif->vdev_type) { case WMI_VDEV_TYPE_AP: if (sta->wme) { @@ -2352,8 +2362,9 @@ static void ath12k_peer_assoc_h_qos(struct ath12k *ar, static int ath12k_peer_assoc_qos_ap(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta) + struct ath12k_link_sta *arsta) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ath12k_wmi_ap_ps_arg arg; u32 max_sp; u32 uapsd; @@ -2514,7 +2525,7 @@ static enum wmi_phy_mode ath12k_mac_get_phymode_eht(struct ath12k *ar, static void ath12k_peer_assoc_h_phymode(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { struct cfg80211_chan_def def; @@ -2523,6 +2534,7 @@ static void ath12k_peer_assoc_h_phymode(struct ath12k *ar, const u16 *vht_mcs_mask; enum wmi_phy_mode phymode = MODE_UNKNOWN; struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); if (WARN_ON(ath12k_mac_vif_chan(vif, &def))) return; @@ -2659,9 +2671,10 @@ static void ath12k_mac_set_eht_ppe_threshold(const u8 *ppe_thres, static void ath12k_peer_assoc_h_eht(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); const struct ieee80211_sta_eht_cap *eht_cap = &sta->deflink.eht_cap; const struct ieee80211_sta_he_cap *he_cap = &sta->deflink.he_cap; const struct ieee80211_eht_mcs_nss_supp_20mhz_only *bw_20; @@ -2741,7 +2754,7 @@ static void ath12k_peer_assoc_h_eht(struct ath12k *ar, static void ath12k_peer_assoc_prepare(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, struct ath12k_wmi_peer_assoc_arg *arg, bool reassoc) { @@ -2752,17 +2765,17 @@ static void ath12k_peer_assoc_prepare(struct ath12k *ar, reinit_completion(&ar->peer_assoc_done); arg->peer_new_assoc = !reassoc; - ath12k_peer_assoc_h_basic(ar, arvif, sta, arg); - ath12k_peer_assoc_h_crypto(ar, arvif, sta, arg); - ath12k_peer_assoc_h_rates(ar, arvif, sta, arg); - ath12k_peer_assoc_h_ht(ar, arvif, sta, arg); - ath12k_peer_assoc_h_vht(ar, arvif, sta, arg); - ath12k_peer_assoc_h_he(ar, arvif, sta, arg); - ath12k_peer_assoc_h_he_6ghz(ar, arvif, sta, arg); - ath12k_peer_assoc_h_eht(ar, arvif, sta, arg); - ath12k_peer_assoc_h_qos(ar, arvif, sta, arg); - ath12k_peer_assoc_h_phymode(ar, arvif, sta, arg); - ath12k_peer_assoc_h_smps(sta, arg); + ath12k_peer_assoc_h_basic(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_crypto(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_rates(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_ht(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_vht(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_he(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_he_6ghz(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_eht(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_qos(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_phymode(ar, arvif, arsta, arg); + ath12k_peer_assoc_h_smps(arsta, arg); /* TODO: amsdu_disable req? */ } @@ -2791,7 +2804,9 @@ static void ath12k_bss_assoc(struct ath12k *ar, struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); struct ath12k_wmi_vdev_up_params params = {}; struct ath12k_wmi_peer_assoc_arg peer_arg; + struct ath12k_link_sta *arsta; struct ieee80211_sta *ap_sta; + struct ath12k_sta *ahsta; struct ath12k_peer *peer; bool is_auth = false; int ret; @@ -2811,7 +2826,15 @@ static void ath12k_bss_assoc(struct ath12k *ar, return; } - ath12k_peer_assoc_prepare(ar, arvif, ap_sta, &peer_arg, false); + ahsta = ath12k_sta_to_ahsta(ap_sta); + arsta = &ahsta->deflink; + + if (WARN_ON(!arsta)) { + rcu_read_unlock(); + return; + } + + ath12k_peer_assoc_prepare(ar, arvif, arsta, &peer_arg, false); rcu_read_unlock(); @@ -3908,20 +3931,25 @@ static int ath12k_clear_peer_keys(struct ath12k_link_vif *arvif, } static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, - struct ath12k_link_vif *arvif, struct ieee80211_sta *sta, + struct ath12k_link_vif *arvif, + struct ath12k_link_sta *arsta, struct ieee80211_key_conf *key) { struct ath12k_vif *ahvif = arvif->ahvif; struct ieee80211_vif *vif = ath12k_vif_to_vif(ahvif); + struct ieee80211_sta *sta = NULL; struct ath12k_base *ab = ar->ab; struct ath12k_peer *peer; - struct ath12k_sta *arsta; + struct ath12k_sta *ahsta; const u8 *peer_addr; int ret = 0; u32 flags = 0; lockdep_assert_held(&ar->conf_mutex); + if (arsta) + sta = ath12k_sta_to_sta(arsta->ahsta); + if (test_bit(ATH12K_FLAG_HW_CRYPTO_DISABLED, &ab->dev_flags)) return 1; @@ -3994,7 +4022,7 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, ath12k_warn(ab, "peer %pM disappeared!\n", peer_addr); if (sta) { - arsta = ath12k_sta_to_arsta(sta); + ahsta = ath12k_sta_to_ahsta(sta); switch (key->cipher) { case WLAN_CIPHER_SUITE_TKIP: @@ -4003,12 +4031,12 @@ static int ath12k_mac_set_key(struct ath12k *ar, enum set_key_cmd cmd, case WLAN_CIPHER_SUITE_GCMP: case WLAN_CIPHER_SUITE_GCMP_256: if (cmd == SET_KEY) - arsta->pn_type = HAL_PN_TYPE_WPA; + ahsta->pn_type = HAL_PN_TYPE_WPA; else - arsta->pn_type = HAL_PN_TYPE_NONE; + ahsta->pn_type = HAL_PN_TYPE_NONE; break; default: - arsta->pn_type = HAL_PN_TYPE_NONE; + ahsta->pn_type = HAL_PN_TYPE_NONE; break; } } @@ -4026,7 +4054,9 @@ static int ath12k_mac_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k_link_vif *arvif; + struct ath12k_link_sta *arsta = NULL; struct ath12k_vif_cache *cache; + struct ath12k_sta *ahsta; struct ath12k *ar; int ret; @@ -4067,14 +4097,19 @@ static int ath12k_mac_op_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, return 0; } - /* Note: Currently only deflink of ahvif is used here, once MLO - * support is added the allocated links (i.e ahvif->links[]) + if (sta) { + ahsta = ath12k_sta_to_ahsta(sta); + arsta = &ahsta->deflink; + } + + /* Note: Currently only deflink of ahvif and ahsta are used here, + * once MLO support is added the allocated links (i.e ahvif->links[]) * should be use based on link id passed from mac80211 and such link * access needs to be protected with ah->conf_mutex. */ mutex_lock(&ar->conf_mutex); - ret = ath12k_mac_set_key(ar, cmd, arvif, sta, key); + ret = ath12k_mac_set_key(ar, cmd, arvif, arsta, key); mutex_unlock(&ar->conf_mutex); mutex_unlock(&ah->conf_mutex); return ret; @@ -4096,10 +4131,11 @@ ath12k_mac_bitrate_mask_num_vht_rates(struct ath12k *ar, static int ath12k_mac_set_peer_vht_fixed_rate(struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, const struct cfg80211_bitrate_mask *mask, enum nl80211_band band) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ath12k *ar = arvif->ar; u8 vht_rate, nss; u32 rate_code; @@ -4142,10 +4178,11 @@ ath12k_mac_set_peer_vht_fixed_rate(struct ath12k_link_vif *arvif, static int ath12k_station_assoc(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta, + struct ath12k_link_sta *arsta, bool reassoc) { struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ath12k_wmi_peer_assoc_arg peer_arg; int ret; struct cfg80211_chan_def def; @@ -4161,7 +4198,7 @@ static int ath12k_station_assoc(struct ath12k *ar, band = def.chan->band; mask = &arvif->bitrate_mask; - ath12k_peer_assoc_prepare(ar, arvif, sta, &peer_arg, reassoc); + ath12k_peer_assoc_prepare(ar, arvif, arsta, &peer_arg, reassoc); ret = ath12k_wmi_send_peer_assoc_cmd(ar, &peer_arg); if (ret) { @@ -4184,7 +4221,7 @@ static int ath12k_station_assoc(struct ath12k *ar, * Note that all other rates and NSS will be disabled for this peer. */ if (sta->deflink.vht_cap.vht_supported && num_vht_rates == 1) { - ret = ath12k_mac_set_peer_vht_fixed_rate(arvif, sta, mask, + ret = ath12k_mac_set_peer_vht_fixed_rate(arvif, arsta, mask, band); if (ret) return ret; @@ -4213,7 +4250,7 @@ static int ath12k_station_assoc(struct ath12k *ar, } if (sta->wme && sta->uapsd_queues) { - ret = ath12k_peer_assoc_qos_ap(ar, arvif, sta); + ret = ath12k_peer_assoc_qos_ap(ar, arvif, arsta); if (ret) { ath12k_warn(ar->ab, "failed to set qos params for STA %pM for vdev %i: %d\n", sta->addr, arvif->vdev_id, ret); @@ -4226,8 +4263,9 @@ static int ath12k_station_assoc(struct ath12k *ar, static int ath12k_station_disassoc(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta) + struct ath12k_link_sta *arsta) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); int ret; lockdep_assert_held(&ar->conf_mutex); @@ -4251,7 +4289,6 @@ static int ath12k_station_disassoc(struct ath12k *ar, static void ath12k_sta_rc_update_wk(struct work_struct *wk) { struct ath12k *ar; - struct ath12k_sta *arsta; struct ath12k_link_vif *arvif; struct ieee80211_sta *sta; struct cfg80211_chan_def def; @@ -4263,10 +4300,11 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) const struct cfg80211_bitrate_mask *mask; struct ath12k_wmi_peer_assoc_arg peer_arg; enum wmi_phy_mode peer_phymode; + struct ath12k_link_sta *arsta; struct ieee80211_vif *vif; - arsta = container_of(wk, struct ath12k_sta, update_wk); - sta = container_of((void *)arsta, struct ieee80211_sta, drv_priv); + arsta = container_of(wk, struct ath12k_link_sta, update_wk); + sta = ath12k_sta_to_sta(arsta->ahsta); arvif = arsta->arvif; vif = ath12k_vif_to_vif(arvif->ahvif); ar = arvif->ar; @@ -4297,7 +4335,7 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) ath12k_mac_max_vht_nss(vht_mcs_mask))); if (changed & IEEE80211_RC_BW_CHANGED) { - ath12k_peer_assoc_h_phymode(ar, arvif, sta, &peer_arg); + ath12k_peer_assoc_h_phymode(ar, arvif, arsta, &peer_arg); peer_phymode = peer_arg.peer_phymode; if (bw > bw_prev) { @@ -4385,14 +4423,14 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) * across HT/VHT and for multiple VHT MCS support. */ if (sta->deflink.vht_cap.vht_supported && num_vht_rates == 1) { - ath12k_mac_set_peer_vht_fixed_rate(arvif, sta, mask, + ath12k_mac_set_peer_vht_fixed_rate(arvif, arsta, mask, band); } else { /* If the peer is non-VHT or no fixed VHT rate * is provided in the new bitrate mask we set the * other rates using peer_assoc command. */ - ath12k_peer_assoc_prepare(ar, arvif, sta, + ath12k_peer_assoc_prepare(ar, arvif, arsta, &peer_arg, true); err = ath12k_wmi_send_peer_assoc_cmd(ar, &peer_arg); @@ -4410,8 +4448,9 @@ static void ath12k_sta_rc_update_wk(struct work_struct *wk) } static int ath12k_mac_inc_num_stations(struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta) + struct ath12k_link_sta *arsta) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ath12k *ar = arvif->ar; lockdep_assert_held(&ar->conf_mutex); @@ -4428,8 +4467,9 @@ static int ath12k_mac_inc_num_stations(struct ath12k_link_vif *arvif, } static void ath12k_mac_dec_num_stations(struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta) + struct ath12k_link_sta *arsta) { + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ath12k *ar = arvif->ar; lockdep_assert_held(&ar->conf_mutex); @@ -4442,17 +4482,17 @@ static void ath12k_mac_dec_num_stations(struct ath12k_link_vif *arvif, static int ath12k_mac_station_add(struct ath12k *ar, struct ath12k_link_vif *arvif, - struct ieee80211_sta *sta) + struct ath12k_link_sta *arsta) { struct ath12k_base *ab = ar->ab; struct ieee80211_vif *vif = ath12k_vif_to_vif(arvif->ahvif); - struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); + struct ieee80211_sta *sta = ath12k_sta_to_sta(arsta->ahsta); struct ath12k_wmi_peer_create_arg peer_param; int ret; lockdep_assert_held(&ar->conf_mutex); - ret = ath12k_mac_inc_num_stations(arvif, sta); + ret = ath12k_mac_inc_num_stations(arvif, arsta); if (ret) { ath12k_warn(ab, "refusing to associate station: too many connected already (%d)\n", ar->max_num_stations); @@ -4511,7 +4551,7 @@ static int ath12k_mac_station_add(struct ath12k *ar, free_peer: ath12k_peer_delete(ar, arvif->vdev_id, sta->addr); dec_num_station: - ath12k_mac_dec_num_stations(arvif, sta); + ath12k_mac_dec_num_stations(arvif, arsta); exit: return ret; } @@ -4555,14 +4595,16 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, { struct ath12k_hw *ah = ath12k_hw_to_ah(hw); struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(sta); struct ath12k *ar; - struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); struct ath12k_link_vif *arvif; + struct ath12k_link_sta *arsta; struct ath12k_peer *peer; int ret = 0; mutex_lock(&ah->conf_mutex); arvif = &ahvif->deflink; + arsta = &ahsta->deflink; /* cancel must be done outside the mutex to avoid deadlock */ if ((old_state == IEEE80211_STA_NONE && @@ -4580,10 +4622,15 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, if (old_state == IEEE80211_STA_NOTEXIST && new_state == IEEE80211_STA_NONE) { memset(arsta, 0, sizeof(*arsta)); + rcu_assign_pointer(ahsta->link[0], arsta); + /* TODO use appropriate link id once MLO support is added */ + arsta->link_id = ATH12K_DEFAULT_LINK_ID; + ahsta->links_map = BIT(arsta->link_id); + arsta->ahsta = ahsta; arsta->arvif = arvif; INIT_WORK(&arsta->update_wk, ath12k_sta_rc_update_wk); - ret = ath12k_mac_station_add(ar, arvif, sta); + ret = ath12k_mac_station_add(ar, arvif, arsta); if (ret) ath12k_warn(ar->ab, "Failed to add station: %pM for VDEV: %d\n", sta->addr, arvif->vdev_id); @@ -4606,7 +4653,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, ath12k_dbg(ar->ab, ATH12K_DBG_MAC, "Removed peer: %pM for VDEV: %d\n", sta->addr, arvif->vdev_id); - ath12k_mac_dec_num_stations(arvif, sta); + ath12k_mac_dec_num_stations(arvif, arsta); spin_lock_bh(&ar->ab->base_lock); peer = ath12k_peer_find(ar->ab, arvif->vdev_id, sta->addr); if (peer && peer->sta == sta) { @@ -4621,12 +4668,20 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, kfree(arsta->rx_stats); arsta->rx_stats = NULL; + + if (arsta->link_id < IEEE80211_MLD_MAX_NUM_LINKS) { + rcu_assign_pointer(ahsta->link[arsta->link_id], NULL); + synchronize_rcu(); + ahsta->links_map &= ~(BIT(arsta->link_id)); + arsta->link_id = ATH12K_INVALID_LINK_ID; + arsta->ahsta = NULL; + } } else if (old_state == IEEE80211_STA_AUTH && new_state == IEEE80211_STA_ASSOC && (vif->type == NL80211_IFTYPE_AP || vif->type == NL80211_IFTYPE_MESH_POINT || vif->type == NL80211_IFTYPE_ADHOC)) { - ret = ath12k_station_assoc(ar, arvif, sta, false); + ret = ath12k_station_assoc(ar, arvif, arsta, false); if (ret) ath12k_warn(ar->ab, "Failed to associate station: %pM\n", sta->addr); @@ -4670,7 +4725,7 @@ static int ath12k_mac_op_sta_state(struct ieee80211_hw *hw, (vif->type == NL80211_IFTYPE_AP || vif->type == NL80211_IFTYPE_MESH_POINT || vif->type == NL80211_IFTYPE_ADHOC)) { - ret = ath12k_station_disassoc(ar, arvif, sta); + ret = ath12k_station_disassoc(ar, arvif, arsta); if (ret) ath12k_warn(ar->ab, "Failed to disassociate station: %pM\n", sta->addr); @@ -4735,8 +4790,9 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, u32 changed) { struct ath12k *ar; - struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); + struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(sta); struct ath12k_vif *ahvif = ath12k_vif_to_ahvif(vif); + struct ath12k_link_sta *arsta; struct ath12k_link_vif *arvif; struct ath12k_peer *peer; u32 bw, smps; @@ -4748,6 +4804,7 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, } rcu_read_lock(); + arsta = &ahsta->deflink; arvif = &ahvif->deflink; spin_lock_bh(&ar->ab->base_lock); @@ -8205,7 +8262,8 @@ static void ath12k_mac_set_bitrate_mask_iter(void *data, struct ieee80211_sta *sta) { struct ath12k_link_vif *arvif = data; - struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); + struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(sta); + struct ath12k_link_sta *arsta = &ahsta->deflink; struct ath12k *ar = arvif->ar; if (arsta->arvif != arvif) @@ -8222,7 +8280,8 @@ static void ath12k_mac_disable_peer_fixed_rate(void *data, struct ieee80211_sta *sta) { struct ath12k_link_vif *arvif = data; - struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); + struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(sta); + struct ath12k_link_sta *arsta = &ahsta->deflink; struct ath12k *ar = arvif->ar; int ret; @@ -8544,16 +8603,22 @@ static void ath12k_mac_op_sta_statistics(struct ieee80211_hw *hw, struct ieee80211_sta *sta, struct station_info *sinfo) { - struct ath12k_sta *arsta = ath12k_sta_to_arsta(sta); + struct ath12k_hw *ah = ath12k_hw_to_ah(hw); + struct ath12k_sta *ahsta = ath12k_sta_to_ahsta(sta); + struct ath12k_link_sta *arsta; + mutex_lock(&ah->conf_mutex); + arsta = &ahsta->deflink; sinfo->rx_duration = arsta->rx_duration; sinfo->filled |= BIT_ULL(NL80211_STA_INFO_RX_DURATION); sinfo->tx_duration = arsta->tx_duration; sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_DURATION); - if (!arsta->txrate.legacy && !arsta->txrate.nss) + if (!arsta->txrate.legacy && !arsta->txrate.nss) { + mutex_unlock(&ah->conf_mutex); return; + } if (arsta->txrate.legacy) { sinfo->txrate.legacy = arsta->txrate.legacy; @@ -8571,6 +8636,7 @@ static void ath12k_mac_op_sta_statistics(struct ieee80211_hw *hw, /* TODO: Use real NF instead of default one. */ sinfo->signal = arsta->rssi_comb + ATH12K_DEFAULT_NOISE_FLOOR; sinfo->filled |= BIT_ULL(NL80211_STA_INFO_SIGNAL); + mutex_unlock(&ah->conf_mutex); } static int ath12k_mac_op_cancel_remain_on_channel(struct ieee80211_hw *hw, -- 2.34.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling 2024-06-17 13:16 ` [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram @ 2024-06-18 10:19 ` Baochen Qiang 2024-06-20 16:57 ` Rameshkumar Sundaram 2024-06-18 10:23 ` Baochen Qiang 1 sibling, 1 reply; 11+ messages in thread From: Baochen Qiang @ 2024-06-18 10:19 UTC (permalink / raw) To: Rameshkumar Sundaram, ath12k; +Cc: linux-wireless, Sriram R, Jeff Johnson On 6/17/2024 9:16 PM, Rameshkumar Sundaram wrote: > +static inline struct ieee80211_sta *ath12k_sta_to_sta(struct ath12k_sta *ahsta) > +{ > + return container_of((void *)ahsta, struct ieee80211_sta, drv_priv); > +} > + better naming as ath12k_ahsta_to_sta()? ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling 2024-06-18 10:19 ` Baochen Qiang @ 2024-06-20 16:57 ` Rameshkumar Sundaram 0 siblings, 0 replies; 11+ messages in thread From: Rameshkumar Sundaram @ 2024-06-20 16:57 UTC (permalink / raw) To: Baochen Qiang, ath12k; +Cc: linux-wireless, Sriram R, Jeff Johnson On 6/18/2024 3:49 PM, Baochen Qiang wrote: > > > On 6/17/2024 9:16 PM, Rameshkumar Sundaram wrote: >> +static inline struct ieee80211_sta *ath12k_sta_to_sta(struct ath12k_sta *ahsta) >> +{ >> + return container_of((void *)ahsta, struct ieee80211_sta, drv_priv); >> +} >> + > better naming as ath12k_ahsta_to_sta()? Sure, will change as suggested. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling 2024-06-17 13:16 ` [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram 2024-06-18 10:19 ` Baochen Qiang @ 2024-06-18 10:23 ` Baochen Qiang 1 sibling, 0 replies; 11+ messages in thread From: Baochen Qiang @ 2024-06-18 10:23 UTC (permalink / raw) To: Rameshkumar Sundaram, ath12k; +Cc: linux-wireless, Sriram R, Jeff Johnson On 6/17/2024 9:16 PM, Rameshkumar Sundaram wrote: > @@ -4748,6 +4804,7 @@ static void ath12k_mac_op_sta_rc_update(struct ieee80211_hw *hw, > } > > rcu_read_lock(); > + arsta = &ahsta->deflink; same as in patch [1/3], do we really need rcu to protect ath12k_sta::deflink? > arvif = &ahvif->deflink; > spin_lock_bh(&ar->ab->base_lock); ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2024-06-20 16:57 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-06-17 13:16 [PATCH v4 0/3] wifi: ath12k: prepare vif and sta datastructure Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 1/3] wifi: ath12k: prepare vif data structure for MLO handling Rameshkumar Sundaram 2024-06-18 7:47 ` Baochen Qiang 2024-06-18 8:37 ` Kalle Valo 2024-06-18 10:18 ` Baochen Qiang 2024-06-20 16:52 ` Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 2/3] wifi: ath12k: pass ath12k_link_vif instead of vif/ahvif Rameshkumar Sundaram 2024-06-17 13:16 ` [PATCH v4 3/3] wifi: ath12k: prepare sta data structure for MLO handling Rameshkumar Sundaram 2024-06-18 10:19 ` Baochen Qiang 2024-06-20 16:57 ` Rameshkumar Sundaram 2024-06-18 10:23 ` Baochen Qiang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox