* New binary rtw8852b_fw.bin not loading firmware not recognized @ 2023-03-16 22:47 rb 2023-03-17 0:35 ` Ping-Ke Shih 2023-03-17 5:53 ` Larry Finger 0 siblings, 2 replies; 7+ messages in thread From: rb @ 2023-03-16 22:47 UTC (permalink / raw) To: linux-wireless Briefly, I use rtw89_8852be in kernel driver HARDWARE: Network controller [0280]: Realtek Semiconductor Co., Ltd. Device [10ec:b852] Lenovo Ideapad 1i ISSUE: Newest version of binary firmware 2023_03_10, rtw89/rtw8852b_fw.bin, will not load/firmware not recognized on Linux Kernel 6.2.5 (and others): [] loading firmare: rwt89/rtw8852b_fw.bin [] rtw89_8852be 0000:03:00.0: no suitable firmware found [] rtw89_8852be 0000:03:00.0: failed to recognize firmware Issue persists regardless of which 6.2 series kernel is used. All previous rwt89/rtw8852b_fw.bin firmware from linux-firmware 2023_02_10 and earlier loads and works correctly. I did file a bug report with the details: https://bugzilla.kernel.org/show_bug.cgi?id=217207 Thank you, Rab B. rb0171610@gmail.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: New binary rtw8852b_fw.bin not loading firmware not recognized 2023-03-16 22:47 New binary rtw8852b_fw.bin not loading firmware not recognized rb @ 2023-03-17 0:35 ` Ping-Ke Shih 2023-03-17 5:12 ` Kalle Valo 2023-03-17 5:53 ` Larry Finger 1 sibling, 1 reply; 7+ messages in thread From: Ping-Ke Shih @ 2023-03-17 0:35 UTC (permalink / raw) To: rb, linux-wireless@vger.kernel.org > -----Original Message----- > From: rb <rb0171610@gmail.com> > Sent: Friday, March 17, 2023 6:48 AM > To: linux-wireless@vger.kernel.org > Subject: New binary rtw8852b_fw.bin not loading firmware not recognized > > Briefly, > > I use rtw89_8852be in kernel driver > > HARDWARE: > Network controller [0280]: Realtek Semiconductor Co., Ltd. Device [10ec:b852] > > Lenovo Ideapad 1i > > ISSUE: > Newest version of binary firmware 2023_03_10, > rtw89/rtw8852b_fw.bin, will not load/firmware not recognized on Linux Kernel 6.2.5 (and others): > > [] loading firmare: rwt89/rtw8852b_fw.bin > [] rtw89_8852be 0000:03:00.0: no suitable firmware found > [] rtw89_8852be 0000:03:00.0: failed to recognize firmware > > Issue persists regardless of which 6.2 series kernel is used. > > All previous rwt89/rtw8852b_fw.bin firmware from linux-firmware 2023_02_10 and earlier loads and works > correctly. > > I did file a bug report with the details: > > https://bugzilla.kernel.org/show_bug.cgi?id=217207 > The firmware format is changed, and wireless-next tree or upcoming 6.3 will support it. I will also post this information on the bug. Ping-Ke ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New binary rtw8852b_fw.bin not loading firmware not recognized 2023-03-17 0:35 ` Ping-Ke Shih @ 2023-03-17 5:12 ` Kalle Valo 2023-03-17 5:55 ` Larry Finger 2023-03-17 7:29 ` Ping-Ke Shih 0 siblings, 2 replies; 7+ messages in thread From: Kalle Valo @ 2023-03-17 5:12 UTC (permalink / raw) To: Ping-Ke Shih; +Cc: rb, linux-wireless@vger.kernel.org Ping-Ke Shih <pkshih@realtek.com> writes: >> -----Original Message----- >> From: rb <rb0171610@gmail.com> >> Sent: Friday, March 17, 2023 6:48 AM >> To: linux-wireless@vger.kernel.org >> Subject: New binary rtw8852b_fw.bin not loading firmware not recognized >> >> Briefly, >> >> I use rtw89_8852be in kernel driver >> >> HARDWARE: >> Network controller [0280]: Realtek Semiconductor Co., Ltd. Device [10ec:b852] >> >> Lenovo Ideapad 1i >> >> ISSUE: >> Newest version of binary firmware 2023_03_10, >> rtw89/rtw8852b_fw.bin, will not load/firmware not recognized on Linux Kernel 6.2.5 (and others): >> >> [] loading firmare: rwt89/rtw8852b_fw.bin >> [] rtw89_8852be 0000:03:00.0: no suitable firmware found >> [] rtw89_8852be 0000:03:00.0: failed to recognize firmware >> >> Issue persists regardless of which 6.2 series kernel is used. >> >> All previous rwt89/rtw8852b_fw.bin firmware from linux-firmware 2023_02_10 and earlier loads and works >> correctly. >> >> I did file a bug report with the details: >> >> https://bugzilla.kernel.org/show_bug.cgi?id=217207 >> > > The firmware format is changed, and wireless-next tree or upcoming 6.3 will > support it. I will also post this information on the bug. We cannot break user space like that, linux-firmware needs to be backwards compatible. In other words, anything you submit to linux-firmware needs to work with old kernels. Should this new firmware be reverted from linux-firmware? What about changes in the rtw89 driver? Do they still work with old firmware? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New binary rtw8852b_fw.bin not loading firmware not recognized 2023-03-17 5:12 ` Kalle Valo @ 2023-03-17 5:55 ` Larry Finger 2023-03-17 7:29 ` Ping-Ke Shih 1 sibling, 0 replies; 7+ messages in thread From: Larry Finger @ 2023-03-17 5:55 UTC (permalink / raw) To: Kalle Valo, Ping-Ke Shih; +Cc: rb, linux-wireless@vger.kernel.org On 3/17/23 00:12, Kalle Valo wrote: > Ping-Ke Shih <pkshih@realtek.com> writes: > >>> -----Original Message----- >>> From: rb <rb0171610@gmail.com> >>> Sent: Friday, March 17, 2023 6:48 AM >>> To: linux-wireless@vger.kernel.org >>> Subject: New binary rtw8852b_fw.bin not loading firmware not recognized >>> >>> Briefly, >>> >>> I use rtw89_8852be in kernel driver >>> >>> HARDWARE: >>> Network controller [0280]: Realtek Semiconductor Co., Ltd. Device [10ec:b852] >>> >>> Lenovo Ideapad 1i >>> >>> ISSUE: >>> Newest version of binary firmware 2023_03_10, >>> rtw89/rtw8852b_fw.bin, will not load/firmware not recognized on Linux Kernel 6.2.5 (and others): >>> >>> [] loading firmare: rwt89/rtw8852b_fw.bin >>> [] rtw89_8852be 0000:03:00.0: no suitable firmware found >>> [] rtw89_8852be 0000:03:00.0: failed to recognize firmware >>> >>> Issue persists regardless of which 6.2 series kernel is used. >>> >>> All previous rwt89/rtw8852b_fw.bin firmware from linux-firmware 2023_02_10 and earlier loads and works >>> correctly. >>> >>> I did file a bug report with the details: >>> >>> https://bugzilla.kernel.org/show_bug.cgi?id=217207 >>> >> >> The firmware format is changed, and wireless-next tree or upcoming 6.3 will >> support it. I will also post this information on the bug. > > We cannot break user space like that, linux-firmware needs to be > backwards compatible. In other words, anything you submit to > linux-firmware needs to work with old kernels. Should this new firmware > be reverted from linux-firmware? > > What about changes in the rtw89 driver? Do they still work with old > firmware? Kalle, This is an unfortunate situation that I did not learn about until this week. As you have seen, my download site has the old firmware. The latest driver will work with either version of the firmware. Larry ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New binary rtw8852b_fw.bin not loading firmware not recognized 2023-03-17 5:12 ` Kalle Valo 2023-03-17 5:55 ` Larry Finger @ 2023-03-17 7:29 ` Ping-Ke Shih 2023-03-17 8:57 ` Kalle Valo 1 sibling, 1 reply; 7+ messages in thread From: Ping-Ke Shih @ 2023-03-17 7:29 UTC (permalink / raw) To: kvalo@kernel.org; +Cc: linux-wireless@vger.kernel.org, rb0171610@gmail.com On Fri, 2023-03-17 at 07:12 +0200, Kalle Valo wrote: > Ping-Ke Shih <pkshih@realtek.com> writes: > > > > -----Original Message----- > > > From: rb <rb0171610@gmail.com> > > > Sent: Friday, March 17, 2023 6:48 AM > > > To: linux-wireless@vger.kernel.org > > > Subject: New binary rtw8852b_fw.bin not loading firmware not recognized > > > > > > Briefly, > > > > > > I use rtw89_8852be in kernel driver > > > > > > HARDWARE: > > > Network controller [0280]: Realtek Semiconductor Co., Ltd. Device [10ec:b852] > > > > > > Lenovo Ideapad 1i > > > > > > ISSUE: > > > Newest version of binary firmware 2023_03_10, > > > rtw89/rtw8852b_fw.bin, will not load/firmware not recognized on Linux Kernel 6.2.5 (and > > > others): > > > > > > [] loading firmare: rwt89/rtw8852b_fw.bin > > > [] rtw89_8852be 0000:03:00.0: no suitable firmware found > > > [] rtw89_8852be 0000:03:00.0: failed to recognize firmware > > > > > > Issue persists regardless of which 6.2 series kernel is used. > > > > > > All previous rwt89/rtw8852b_fw.bin firmware from linux-firmware 2023_02_10 and earlier loads > > > and works > > > correctly. > > > > > > I did file a bug report with the details: > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=217207 > > > > > > > The firmware format is changed, and wireless-next tree or upcoming 6.3 will > > support it. I will also post this information on the bug. > > We cannot break user space like that, linux-firmware needs to be > backwards compatible. In other words, anything you submit to > linux-firmware needs to work with old kernels. Should this new firmware > be reverted from linux-firmware? I think I should support two or more firmware with different name, like rwt89/rtw8852b_fw-2.bin, if format is changed. So, there will be two firmware existing in linux-firmware. Then, for old driver, it only supports rwt89/rtw8852b_fw.bin. For new driver, it will load rwt89/rtw8852b_fw-2.bin first, but if '-2' version doesn't present, it will try to load original version. I think it would work, but I want to confirm if this is acceptable rules for Linux. > > What about changes in the rtw89 driver? Do they still work with old > firmware? > New driver can work with old or new firmware. The only case that doesn't work is old driver + new firmware. Ping-Ke ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New binary rtw8852b_fw.bin not loading firmware not recognized 2023-03-17 7:29 ` Ping-Ke Shih @ 2023-03-17 8:57 ` Kalle Valo 0 siblings, 0 replies; 7+ messages in thread From: Kalle Valo @ 2023-03-17 8:57 UTC (permalink / raw) To: Ping-Ke Shih; +Cc: linux-wireless@vger.kernel.org, rb0171610@gmail.com Ping-Ke Shih <pkshih@realtek.com> writes: >> > > I did file a bug report with the details: >> > > >> > > https://bugzilla.kernel.org/show_bug.cgi?id=217207 >> > > >> > >> > The firmware format is changed, and wireless-next tree or upcoming 6.3 will >> > support it. I will also post this information on the bug. >> >> We cannot break user space like that, linux-firmware needs to be >> backwards compatible. In other words, anything you submit to >> linux-firmware needs to work with old kernels. Should this new firmware >> be reverted from linux-firmware? > > I think I should support two or more firmware with different name, like > rwt89/rtw8852b_fw-2.bin, if format is changed. So, there will be two > firmware existing in linux-firmware. > > Then, for old driver, it only supports rwt89/rtw8852b_fw.bin. For new driver, > it will load rwt89/rtw8852b_fw-2.bin first, but if '-2' version doesn't present, > it will try to load original version. > > I think it would work, but I want to confirm if this is acceptable rules > for Linux. Yes, this is the recommended way to handle backwards compatibility. ath10k (and soon ath11k) will do something similar, we have firmware-2.bin, firmware-3.bin and so on to avoid breaking older kernels whenever there are incompatible changes in firmware. Recently some guidelines were also written about this: https://www.kernel.org/doc/html/latest/driver-api/firmware/firmware-usage-guidelines.html >> What about changes in the rtw89 driver? Do they still work with old >> firmware? > > New driver can work with old or new firmware. The only case that doesn't > work is old driver + new firmware. Very good, thanks for confirming. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: New binary rtw8852b_fw.bin not loading firmware not recognized 2023-03-16 22:47 New binary rtw8852b_fw.bin not loading firmware not recognized rb 2023-03-17 0:35 ` Ping-Ke Shih @ 2023-03-17 5:53 ` Larry Finger 1 sibling, 0 replies; 7+ messages in thread From: Larry Finger @ 2023-03-17 5:53 UTC (permalink / raw) To: rb, linux-wireless On 3/16/23 17:47, rb wrote: > Briefly, > > I use rtw89_8852be in kernel driver > > HARDWARE: > Network controller [0280]: Realtek Semiconductor Co., Ltd. Device [10ec:b852] > > Lenovo Ideapad 1i > > ISSUE: > Newest version of binary firmware 2023_03_10, > rtw89/rtw8852b_fw.bin, will not load/firmware not recognized on Linux Kernel > 6.2.5 (and others): > > [] loading firmare: rwt89/rtw8852b_fw.bin > [] rtw89_8852be 0000:03:00.0: no suitable firmware found > [] rtw89_8852be 0000:03:00.0: failed to recognize firmware > > Issue persists regardless of which 6.2 series kernel is used. > > All previous rwt89/rtw8852b_fw.bin firmware from linux-firmware 2023_02_10 and > earlier loads and works correctly. > > I did file a bug report with the details: > > https://bugzilla.kernel.org/show_bug.cgi?id=217207 There are two workarounds. 1. Copy the 0.27.x firmware from my download site and install it using the following: wget lwfinger.com/download/rtw8852b_fw.bin sudo cp rtw8852b_fw.bin /lib/firmware/rtw89/. 2. Implement the driver found at https://github.com/lwfinger/rtw89.git. That version can handle version 0.27.x or 0.29.x of the firmware. Larry ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-17 8:59 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-16 22:47 New binary rtw8852b_fw.bin not loading firmware not recognized rb 2023-03-17 0:35 ` Ping-Ke Shih 2023-03-17 5:12 ` Kalle Valo 2023-03-17 5:55 ` Larry Finger 2023-03-17 7:29 ` Ping-Ke Shih 2023-03-17 8:57 ` Kalle Valo 2023-03-17 5:53 ` Larry Finger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox