[PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Ping-Ke Shih]

From: Chia-Yuan Li <leo.li@realtek.com>

The hardware command parser of txptctrl (TX protocol control) has overly
stringent timeout conditions, which results in false alarm. So disable it.

Signed-off-by: Chia-Yuan Li <leo.li@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/reg.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw89/reg.h b/drivers/net/wireless/realtek/rtw89/reg.h
index 72e448e91b6f..ccf74d9f9224 100644
--- a/drivers/net/wireless/realtek/rtw89/reg.h
+++ b/drivers/net/wireless/realtek/rtw89/reg.h
@@ -1891,7 +1891,6 @@
 				     B_AX_B0_IMR_ERR_USRCTL_NOINIT | \
 				     B_AX_B0_IMR_ERR_CMDPSR_1STCMDERR | \
 				     B_AX_B0_IMR_ERR_CMDPSR_CMDTYPE | \
-				     B_AX_B0_IMR_ERR_CMDPSR_FRZTO | \
 				     B_AX_B0_IMR_ERR_CMDPSR_TBLSZ | \
 				     B_AX_B0_IMR_ERR_MPDUINFO_RECFG | \
 				     B_AX_B0_IMR_ERR_MPDUIF_DATAERR | \
-- 
2.25.1

Re: [PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> writes:

> From: Chia-Yuan Li <leo.li@realtek.com>
>
> The hardware command parser of txptctrl (TX protocol control) has overly
> stringent timeout conditions, which results in false alarm. So disable it.
>
> Signed-off-by: Chia-Yuan Li <leo.li@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

I'm in the To field, do you maybe want me to take this to wireless tree?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Ping-Ke Shih]

On Thu, 2024-03-21 at 07:12 +0200, Kalle Valo wrote:
> 
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > From: Chia-Yuan Li <leo.li@realtek.com>
> > 
> > The hardware command parser of txptctrl (TX protocol control) has overly
> > stringent timeout conditions, which results in false alarm. So disable it.
> > 
> > Signed-off-by: Chia-Yuan Li <leo.li@realtek.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> I'm in the To field, do you maybe want me to take this to wireless tree?
> 

No, it should go via rtw.git. I just send this patch as usual. 
Should I change to wireless mailing list as To field and no need to add you
in neither To field nor Cc field in the future? 

Ping-Ke

Re: [PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> writes:

> On Thu, 2024-03-21 at 07:12 +0200, Kalle Valo wrote:
>> 
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>> 
>> > From: Chia-Yuan Li <leo.li@realtek.com>
>> > 
>> > The hardware command parser of txptctrl (TX protocol control) has overly
>> > stringent timeout conditions, which results in false alarm. So disable it.
>> > 
>> > Signed-off-by: Chia-Yuan Li <leo.li@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>> I'm in the To field, do you maybe want me to take this to wireless tree?
>> 
>
> No, it should go via rtw.git. I just send this patch as usual. 

Ok.

> Should I change to wireless mailing list as To field and no need to
> add you in neither To field nor Cc field in the future?

Yes, please drop me from To and Cc fields. And if there's an important
fix you want to go to wireless tree please label it as "[PATCH
wireless]" (or comment on the patch) and assign to me on patchwork.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Ping-Ke Shih]

On Thu, 2024-03-21 at 08:01 +0200, Kalle Valo wrote:
> 
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > Should I change to wireless mailing list as To field and no need to
> > add you in neither To field nor Cc field in the future?
> 
> Yes, please drop me from To and Cc fields. And if there's an important
> fix you want to go to wireless tree please label it as "[PATCH
> wireless]" (or comment on the patch) and assign to me on patchwork.
> 

Got it. But, still add you to To-field for pull-request, right?

Ping-Ke

Re: [PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Kalle Valo]

Ping-Ke Shih <pkshih@realtek.com> writes:

> On Thu, 2024-03-21 at 08:01 +0200, Kalle Valo wrote:
>> 
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>> 
>> > Should I change to wireless mailing list as To field and no need to
>> > add you in neither To field nor Cc field in the future?
>> 
>> Yes, please drop me from To and Cc fields. And if there's an important
>> fix you want to go to wireless tree please label it as "[PATCH
>> wireless]" (or comment on the patch) and assign to me on patchwork.
>
> Got it. But, still add you to To-field for pull-request, right?

Actually no need even for that. I take all patches and pull requests
from patchwork anyway :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Ping-Ke Shih]

On Thu, 2024-03-21 at 08:18 +0200, Kalle Valo wrote:
> 
> Actually no need even for that. I take all patches and pull requests
> from patchwork anyway :)
> 

Got it :)

Ping-Ke

Re: [PATCH] wifi: rtw89: disable txptctrl IMR to avoid flase alarm

[Ping-Ke Shih]

Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Chia-Yuan Li <leo.li@realtek.com>
> 
> The hardware command parser of txptctrl (TX protocol control) has overly
> stringent timeout conditions, which results in false alarm. So disable it.
> 
> Signed-off-by: Chia-Yuan Li <leo.li@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

209621a8f0cf wifi: rtw89: disable txptctrl IMR to avoid flase alarm

---
https://github.com/pkshih/rtw.git