* [RFC] rfkill: Add new ACPI device for Realtek serial BT
@ 2016-07-15 19:08 Larry Finger
2016-07-15 19:39 ` Marcel Holtmann
2016-07-18 7:18 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Larry Finger @ 2016-07-15 19:08 UTC (permalink / raw)
To: kvalo; +Cc: devel, linux-wireless, Larry Finger
The Realtek RTL8723BS chips, which are connected via SDIO, also contain
a serial Bluetooth device. In order for BT to work, the device must be
added to the acpi_device_id table.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
I have no idea if this device should be added here, or if the device could
be added to some structure supplied at device startup. If anyone has any
suggestions, please let me know.
Thanks,
Larry
---
net/rfkill/rfkill-gpio.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
index 76c01cb..50ca65e 100644
--- a/net/rfkill/rfkill-gpio.c
+++ b/net/rfkill/rfkill-gpio.c
@@ -163,6 +163,7 @@ static int rfkill_gpio_remove(struct platform_device *pdev)
static const struct acpi_device_id rfkill_acpi_match[] = {
{ "BCM4752", RFKILL_TYPE_GPS },
{ "LNV4752", RFKILL_TYPE_GPS },
+ { "OBDA8723", RFKILL_TYPE_BLUETOOTH },
{ },
};
MODULE_DEVICE_TABLE(acpi, rfkill_acpi_match);
--
2.6.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC] rfkill: Add new ACPI device for Realtek serial BT
2016-07-15 19:08 [RFC] rfkill: Add new ACPI device for Realtek serial BT Larry Finger
@ 2016-07-15 19:39 ` Marcel Holtmann
2016-07-18 7:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Marcel Holtmann @ 2016-07-15 19:39 UTC (permalink / raw)
To: Larry Finger; +Cc: Kalle Valo, devel, linux-wireless
Hi Larry,
> The Realtek RTL8723BS chips, which are connected via SDIO, also contain
> a serial Bluetooth device. In order for BT to work, the device must be
> added to the acpi_device_id table.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> I have no idea if this device should be added here, or if the device could
> be added to some structure supplied at device startup. If anyone has any
> suggestions, please let me know.
it should not be added here. Since most likely more is needed. For example within the hci_bcm.c and hci_intel.c drivers we handle the GPIO when attaching the UART to the Bluetooth subsystem. This means at minimum some sort of hci_rtl.c is needed. Can be for the beginning just an enhanced hci_h4.c.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC] rfkill: Add new ACPI device for Realtek serial BT
2016-07-15 19:08 [RFC] rfkill: Add new ACPI device for Realtek serial BT Larry Finger
2016-07-15 19:39 ` Marcel Holtmann
@ 2016-07-18 7:18 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2016-07-18 7:18 UTC (permalink / raw)
To: Larry Finger; +Cc: devel, linux-wireless
Larry Finger <Larry.Finger@lwfinger.net> writes:
> The Realtek RTL8723BS chips, which are connected via SDIO, also contain
> a serial Bluetooth device. In order for BT to work, the device must be
> added to the acpi_device_id table.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
>
> I have no idea if this device should be added here, or if the device could
> be added to some structure supplied at device startup. If anyone has any
> suggestions, please let me know.
>
> Thanks,
>
> Larry
> ---
> net/rfkill/rfkill-gpio.c | 1 +
> 1 file changed, 1 insertion(+)
BTW Johannes maintains rfkill, not me.
--
Kalle Valo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-18 7:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-15 19:08 [RFC] rfkill: Add new ACPI device for Realtek serial BT Larry Finger
2016-07-15 19:39 ` Marcel Holtmann
2016-07-18 7:18 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox