From: Kalle Valo <kvalo@kernel.org>
To: "A. Sverdlin" <alexander.sverdlin@siemens.com>
Cc: linux-wireless@vger.kernel.org,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
"Dmitry Antipov" <dmantipov@yandex.ru>,
stable@vger.kernel.org
Subject: Re: [PATCH] wifi: wfx: repair open network AP mode
Date: Fri, 23 Aug 2024 18:07:29 +0300 [thread overview]
Message-ID: <87o75juvke.fsf@kernel.org> (raw)
In-Reply-To: <20240823131521.3309073-1-alexander.sverdlin@siemens.com> (A. Sverdlin's message of "Fri, 23 Aug 2024 15:15:20 +0200")
"A. Sverdlin" <alexander.sverdlin@siemens.com> writes:
> From: Alexander Sverdlin <alexander.sverdlin@siemens.com>
>
> RSN IE missing in beacon is normal in open networks.
> Avoid returning -ENODEV in this case.
>
> Steps to reproduce:
>
> $ cat /etc/wpa_supplicant.conf
> network={
> ssid="testNet"
> mode=2
> key_mgmt=NONE
> }
>
> $ wpa_supplicant -iwlan0 -c /etc/wpa_supplicant.conf
> nl80211: Beacon set failed: -22 (Invalid argument)
> Failed to set beacon parameters
> Interface initialization failed
> wlan0: interface state UNINITIALIZED->DISABLED
> wlan0: AP-DISABLED
> wlan0: Unable to setup interface.
> Failed to initialize AP interface
>
> After the change:
>
> $ wpa_supplicant -iwlan0 -c /etc/wpa_supplicant.conf
> Successfully initialized wpa_supplicant
> wlan0: interface state UNINITIALIZED->ENABLED
> wlan0: AP-ENABLED
BTW excellent commit message, immediately obvious what was the problem
and how it was tested. I wish everyone would do the same.
> Cc: stable@vger.kernel.org
> Fixes: fe0a7776d4d1 ("wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap()")
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
I think this should go to wireless tree for v6.11, right?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html
next prev parent reply other threads:[~2024-08-23 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 13:15 [PATCH] wifi: wfx: repair open network AP mode A. Sverdlin
2024-08-23 13:42 ` Sverdlin, Alexander
2024-08-23 14:59 ` Kalle Valo
2024-08-23 15:07 ` Kalle Valo [this message]
2024-08-23 15:14 ` Sverdlin, Alexander
2024-08-26 15:12 ` Jérôme Pouiller
2024-08-26 15:42 ` Sverdlin, Alexander
2024-08-26 18:53 ` Jérôme Pouiller
2024-08-27 7:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o75juvke.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=alexander.sverdlin@siemens.com \
--cc=dmantipov@yandex.ru \
--cc=jerome.pouiller@silabs.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox