Re: [PATCH] wifi: wfx: repair open network AP mode

["Sverdlin, Alexander" <alexander.sverdlin@siemens.com>]

Hi!

On Fri, 2024-08-23 at 18:07 +0300, Kalle Valo wrote:
> > RSN IE missing in beacon is normal in open networks.
> > Avoid returning -ENODEV in this case.
> > 
> > Steps to reproduce:
> > 
> > $ cat /etc/wpa_supplicant.conf
> > network={
> >  	ssid="testNet"
> >  	mode=2
> >  	key_mgmt=NONE
> > }
> > 
> > $ wpa_supplicant -iwlan0 -c /etc/wpa_supplicant.conf
> > nl80211: Beacon set failed: -22 (Invalid argument)
> > Failed to set beacon parameters
> > Interface initialization failed
> > wlan0: interface state UNINITIALIZED->DISABLED
> > wlan0: AP-DISABLED
> > wlan0: Unable to setup interface.
> > Failed to initialize AP interface
> > 
> > After the change:
> > 
> > $ wpa_supplicant -iwlan0 -c /etc/wpa_supplicant.conf
> > Successfully initialized wpa_supplicant
> > wlan0: interface state UNINITIALIZED->ENABLED
> > wlan0: AP-ENABLED
> 
> BTW excellent commit message, immediately obvious what was the problem
> and how it was tested. I wish everyone would do the same.

Thanks!

> > Cc: stable@vger.kernel.org
> > Fixes: fe0a7776d4d1 ("wifi: wfx: fix possible NULL pointer dereference in wfx_set_mfp_ap()")
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@siemens.com>
> 
> I think this should go to wireless tree for v6.11, right?

Makes sense to me! Sorry, I've missed the proper tagging!
Whatever makes it into stable. I've already tested v6.1 and v6.8 where it applies
as-is.

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com