From: Kalle Valo <kvalo@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Antti Antinoja <antti@fennosys.fi>,
linux-wireless@vger.kernel.org, <amitkarwar@gmail.com>,
<nishants@marvell.com>, <gbhat@marvell.com>,
<huxinming820@gmail.com>
Subject: Re: mwifiex: exit on error - without calling rcu_read_unlock()
Date: Sun, 26 Jan 2020 17:04:04 +0200 [thread overview]
Message-ID: <87o8uqxnrv.fsf@tynnyri.adurom.net> (raw)
In-Reply-To: <87sgk2xq0v.fsf@tynnyri.adurom.net> (Kalle Valo's message of "Sun, 26 Jan 2020 16:15:28 +0200")
Kalle Valo <kvalo@codeaurora.org> writes:
> Antti Antinoja <antti@fennosys.fi> writes:
>
>> Please refer to:
>>
>> * https://grsecurity.net/the_life_of_a_bad_security_fix
>> *
>> https://github.com/torvalds/linux/commit/3d94a4a8373bf5f45cf5f939e88b8354dbf2311b#diff-c5e2f17b92b8e8f30306c5dd148d874f
>>
>> At quick glance it looks to me like the issue really is there: Not
>> calling rcu_read_unlock() before return on line 237.
>
> Ganapahti, can you send a fix this for this?
>
> Remember to add to the commit log:
>
> Fixes: 3d94a4a8373b ("mwifiex: fix possible heap overflow in mwifiex_process_country_ie()")
Oh, there was already a fix available:
https://patchwork.kernel.org/patch/11320227/
It just got piled up with all the patches.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-01-26 15:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 13:18 mwifiex: exit on error - without calling rcu_read_unlock() Antti Antinoja
2020-01-26 14:15 ` Kalle Valo
2020-01-26 15:04 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8uqxnrv.fsf@tynnyri.adurom.net \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=antti@fennosys.fi \
--cc=gbhat@marvell.com \
--cc=huxinming820@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=nishants@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox