* [PATCH] wl1251: correct definitions for 0th bit defines
@ 2009-08-17 15:18 Bob Copeland
2009-08-17 15:44 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Bob Copeland @ 2009-08-17 15:18 UTC (permalink / raw)
To: linville, Kalle Valo; +Cc: linux-wireless
ACX_SLV_SOFT_RESET_BIT and ACX_REG_EEPROM_START_BIT are both defined
as "1" in the vendor driver code, but they were defined to be BIT(1)
("2") here.
The SOFT_RESET typo ensures that wl1251_boot_soft_reset() doesn't;
as a result the device hangs when trying to reprogram the PLL
registers while running.
Signed-off-by: Bob Copeland <me@bobcopeland.com>
---
drivers/net/wireless/wl12xx/wl1251_reg.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1251_reg.h b/drivers/net/wireless/wl12xx/wl1251_reg.h
index 2de47cc..86a8666 100644
--- a/drivers/net/wireless/wl12xx/wl1251_reg.h
+++ b/drivers/net/wireless/wl12xx/wl1251_reg.h
@@ -309,8 +309,8 @@ enum wl12xx_acx_int_reg {
ACX_REG_TABLE_LEN
};
-#define ACX_SLV_SOFT_RESET_BIT BIT(1)
-#define ACX_REG_EEPROM_START_BIT BIT(1)
+#define ACX_SLV_SOFT_RESET_BIT BIT(0)
+#define ACX_REG_EEPROM_START_BIT BIT(0)
/* Command/Information Mailbox Pointers */
--
1.6.2.5
--
Bob Copeland %% www.bobcopeland.com
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] wl1251: correct definitions for 0th bit defines
2009-08-17 15:18 [PATCH] wl1251: correct definitions for 0th bit defines Bob Copeland
@ 2009-08-17 15:44 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2009-08-17 15:44 UTC (permalink / raw)
To: Bob Copeland; +Cc: linville, linux-wireless
Bob Copeland <me@bobcopeland.com> writes:
> ACX_SLV_SOFT_RESET_BIT and ACX_REG_EEPROM_START_BIT are both defined
> as "1" in the vendor driver code, but they were defined to be BIT(1)
> ("2") here.
>
> The SOFT_RESET typo ensures that wl1251_boot_soft_reset() doesn't;
> as a result the device hangs when trying to reprogram the PLL
> registers while running.
My bad, thanks for fixing this.
> Signed-off-by: Bob Copeland <me@bobcopeland.com>
Acked-by: Kalle Valo <kalle.valo@nokia.com>
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-08-17 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-08-17 15:18 [PATCH] wl1251: correct definitions for 0th bit defines Bob Copeland
2009-08-17 15:44 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox