Re: [PATCH wireless-next 7/7] wifi: mac80211_hwsim: add NAN Instant Communication support

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2026-10-01 at 16:33 +0300, Miri Korenblit wrote:

> @@ -263,15 +300,26 @@ void mac80211_hwsim_nan_rx(struct ieee80211_hw *hw,
>  		slot = hwsim_nan_slot_from_tsf(rx_status.mactime);
>  	}
>  
> +	/* (overly) simplify things, only track 2.4 GHz here */
> +	if (rx_status.freq != 2437)
> +		return;

comments should generally help ... I see it removed below but maybe make
it better while touching it :)


> +	scoped_guard(spinlock_bh, &data->nan.state_lock) {
> +		/*
> +		 * Fall back to the device default if user space did not
> +		 * configure it
> +		 */
> +		data->nan.discovery_beacon_interval =
> +			conf->discovery_beacon_interval ? : 100;

That seems like the totally wrong place - should probably make that
default in cfg80211? Or is there a reason to believe it would need to be
device-specific?

> -	data->nan.notify_dw = conf->enable_dw_notification;

Some of the refactoring in this commit is just confusing, like this just
disappearing. Please split the refactoring off first.

johannes