From: Johannes Berg <johannes@sipsolutions.net>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: linux-wireless@vger.kernel.org, Ilan Peer <ilan.peer@intel.com>
Subject: Re: [PATCH wireless-next 3/7] wifi: cfg80211: nan: check Rx registration for NAN beacons
Date: Fri, 02 Oct 2026 09:03:51 +0200 [thread overview]
Message-ID: <a130a88a3976e587450c730487be383f2448f80b.camel@sipsolutions.net> (raw)
In-Reply-To: <20261001162941.788c566446b6.I691a657e94dacc4e15d9a3b6d3fe95e5984ad999@changeid>
On Thu, 2026-10-01 at 16:33 +0300, Miri Korenblit wrote:
> From: Ilan Peer <ilan.peer@intel.com>
>
> Instant Communication requires user space to track the NAN beacons, so
> let it register for Rx of beacons on a NAN interface, but allow it
> only if the driver advertises Instant Communication support.
I think that commit message is misleading - this change doesn't let
userspace register for beacons, it only *doesn't* let it do that if IC
isn't supported.
But is that even useful? Even with the change you could still register
for beacons when IC isn't even turned on, so the check doesn't do much.
It seems to me a check at wiphy registration time that beacons were
allowed if NAN IC is supported would be clearer, and the opposite is
kind of pointless anyway since NAN IC doesn't need to be enabled, and
then you can probably register for beacons all you want without ever
getting them.
johannes
next prev parent reply other threads:[~2026-10-02 7:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 13:33 [PATCH wireless-next 0/7] wifi: cfg80211/mac80211: add NAN Instant Communication support Miri Korenblit
2026-10-01 13:33 ` [PATCH wireless-next 1/7] wifi: cfg80211: nan: add " Miri Korenblit
2026-10-01 13:33 ` [PATCH wireless-next 2/7] wifi: mac80211: nan: Update NAN configuration copy Miri Korenblit
2026-10-01 13:33 ` [PATCH wireless-next 3/7] wifi: cfg80211: nan: check Rx registration for NAN beacons Miri Korenblit
2026-10-02 7:03 ` Johannes Berg [this message]
2026-10-01 13:33 ` [PATCH wireless-next 4/7] wifi: mac80211: nan: allow " Miri Korenblit
2026-10-02 7:10 ` Johannes Berg
2026-10-04 12:40 ` Peer, Ilan
2026-10-01 13:33 ` [PATCH wireless-next 5/7] wifi: ieee80211: add NAN service ID list attribute definitions Miri Korenblit
2026-10-01 13:33 ` [PATCH wireless-next 6/7] wifi: mac80211_hwsim: nan: use ieee80211_is_nan_beacon() helper Miri Korenblit
2026-10-01 13:33 ` [PATCH wireless-next 7/7] wifi: mac80211_hwsim: add NAN Instant Communication support Miri Korenblit
2026-10-02 7:26 ` Johannes Berg
2026-10-04 13:12 ` Peer, Ilan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a130a88a3976e587450c730487be383f2448f80b.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ilan.peer@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox