From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Gabor Juhos <juhosg@openwrt.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"users@rt2x00.serialmonkey.com" <users@rt2x00.serialmonkey.com>,
Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines
Date: Sun, 2 Dec 2012 22:31:23 +0000 [thread overview]
Message-ID: <E88F907A-CE03-47C3-9615-AEBD93C8DC38@gmail.com> (raw)
In-Reply-To: <1354465442-1028-1-git-send-email-juhosg@openwrt.org>
Sent from my iPad
On 2 dec. 2012, at 16:24, Gabor Juhos <juhosg@openwrt.org> wrote:
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Ouch, that could have led to some nasty bugs. Thanks for spotting this and sending the patch.
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index 6d67c3e..1157b06 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
> */
> #define RFCSR3_K FIELD8(0x0f)
> /* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
> -#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
> -#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
> +#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
> +#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
>
> /*
> * FRCSR 5:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-12-02 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 16:24 [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines Gabor Juhos
2012-12-02 16:26 ` Ivo Van Doorn
2012-12-02 22:31 ` Gertjan van Wingerde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E88F907A-CE03-47C3-9615-AEBD93C8DC38@gmail.com \
--to=gwingerde@gmail.com \
--cc=juhosg@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=users@rt2x00.serialmonkey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox