* [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines
@ 2012-12-02 16:24 Gabor Juhos
2012-12-02 16:26 ` Ivo Van Doorn
2012-12-02 22:31 ` Gertjan van Wingerde
0 siblings, 2 replies; 3+ messages in thread
From: Gabor Juhos @ 2012-12-02 16:24 UTC (permalink / raw)
To: John W. Linville; +Cc: linux-wireless, users, Gabor Juhos
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
---
drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
index 6d67c3e..1157b06 100644
--- a/drivers/net/wireless/rt2x00/rt2800.h
+++ b/drivers/net/wireless/rt2x00/rt2800.h
@@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
*/
#define RFCSR3_K FIELD8(0x0f)
/* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
-#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
-#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
+#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
+#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
/*
* FRCSR 5:
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines
2012-12-02 16:24 [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines Gabor Juhos
@ 2012-12-02 16:26 ` Ivo Van Doorn
2012-12-02 22:31 ` Gertjan van Wingerde
1 sibling, 0 replies; 3+ messages in thread
From: Ivo Van Doorn @ 2012-12-02 16:26 UTC (permalink / raw)
To: Gabor Juhos; +Cc: John W. Linville, linux-wireless, rt2x00 Users List
On Sun, Dec 2, 2012 at 5:24 PM, Gabor Juhos <juhosg@openwrt.org> wrote:
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index 6d67c3e..1157b06 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
> */
> #define RFCSR3_K FIELD8(0x0f)
> /* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
> -#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
> -#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
> +#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
> +#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
>
> /*
> * FRCSR 5:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines
2012-12-02 16:24 [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines Gabor Juhos
2012-12-02 16:26 ` Ivo Van Doorn
@ 2012-12-02 22:31 ` Gertjan van Wingerde
1 sibling, 0 replies; 3+ messages in thread
From: Gertjan van Wingerde @ 2012-12-02 22:31 UTC (permalink / raw)
To: Gabor Juhos
Cc: John W. Linville, linux-wireless@vger.kernel.org,
users@rt2x00.serialmonkey.com, Gabor Juhos
Sent from my iPad
On 2 dec. 2012, at 16:24, Gabor Juhos <juhosg@openwrt.org> wrote:
> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Ouch, that could have led to some nasty bugs. Thanks for spotting this and sending the patch.
Acked-by: Gertjan van Wingerde <gwingerde@gmail.com>
> ---
> drivers/net/wireless/rt2x00/rt2800.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2800.h b/drivers/net/wireless/rt2x00/rt2800.h
> index 6d67c3e..1157b06 100644
> --- a/drivers/net/wireless/rt2x00/rt2800.h
> +++ b/drivers/net/wireless/rt2x00/rt2800.h
> @@ -1993,8 +1993,8 @@ struct mac_iveiv_entry {
> */
> #define RFCSR3_K FIELD8(0x0f)
> /* Bits [7-4] for RF3320 (RT3370/RT3390), on other chipsets reserved */
> -#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70);
> -#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80);
> +#define RFCSR3_PA1_BIAS_CCK FIELD8(0x70)
> +#define RFCSR3_PA2_CASCODE_BIAS_CCKK FIELD8(0x80)
>
> /*
> * FRCSR 5:
> --
> 1.7.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-02 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-02 16:24 [PATCH] rt2x00: rt2800lib: remove trailing semicolons from RFCSR3_* defines Gabor Juhos
2012-12-02 16:26 ` Ivo Van Doorn
2012-12-02 22:31 ` Gertjan van Wingerde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox